selftest: split a large system invocation line

Small cleanup for better code readability, no change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 10 05:19:26 CET 2018 on sn-devel-144

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 17247274b734acf51504b734063b60f25ba32a6c..f4ae0f3c02f44f0f03a9516d66acd7e26f87ad27 100755 (executable)
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -2468,7 +2468,9 @@ sub wait_for_start($$$$$)
            $cmd .= "cache del IDMAP/SID2XID/S-1-5-32-545";
            system($cmd);
 
-           $ret = system("SELFTEST_WINBINDD_SOCKET_DIR=" . $envvars->{SELFTEST_WINBINDD_SOCKET_DIR} . " " . Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545");
+           $cmd = "SELFTEST_WINBINDD_SOCKET_DIR='$envvars->{SELFTEST_WINBINDD_SOCKET_DIR}' ";
+           $cmd .= Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545";
+           $ret = system($cmd);
            if ($ret != 0) {
                print "Missing \"BUILTIN\\Users\", did net sam createbuiltingroup Users fail?\n";
                teardown_env($self, $envvars);