selftest: split a large system invocation line

Small cleanup for better code readability, no change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index df96fd18f5562cac3761d67592a06a42b2b6b5a3..73ac1c3a17e424a211fe83dacf76421d7780aa3e 100755 (executable)
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -2454,7 +2454,10 @@ sub wait_for_start($$$$$)
                }
        }
        if ($create_builtin_users eq "yes") {
-           $ret = system("SELFTEST_WINBINDD_SOCKET_DIR=" . $envvars->{SELFTEST_WINBINDD_SOCKET_DIR} . " " . Samba::bindir_path($self, "net") ." $envvars->{CONFIGURATION} sam createbuiltingroup Users");
+           $cmd = "SELFTEST_WINBINDD_SOCKET_DIR='$envvars->{SELFTEST_WINBINDD_SOCKET_DIR}' ";
+           $cmd .= Samba::bindir_path($self, "net") . " $envvars->{CONFIGURATION} ";
+           $cmd .= "sam createbuiltingroup Users";
+           $ret = system($cmd);
            if ($ret != 0) {
                print "Failed to create BUILTIN\\Users group\n";
                teardown_env($self, $envvars);