pdb: Fix CID 1427620 Resource leak
authorVolker Lendecke <vl@samba.org>
Wed, 17 Jan 2018 13:38:41 +0000 (14:38 +0100)
committerRalph Boehme <slow@samba.org>
Wed, 17 Jan 2018 18:24:11 +0000 (19:24 +0100)
It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/passdb/pdb_samba_dsdb.c

index b06267b..4e55a15 100644 (file)
@@ -3741,7 +3741,8 @@ static NTSTATUS pdb_samba_dsdb_enum_trusted_domains(struct pdb_methods *m,
                domains[di++] = d;
        }
 
-       talloc_realloc(domains, domains, struct pdb_trusted_domain *, di);
+       domains = talloc_realloc(domains, domains, struct pdb_trusted_domain *,
+                                di);
        *_domains = talloc_move(mem_ctx, &domains);
        *_num_domains = di;
        TALLOC_FREE(tmp_ctx);