ctdb-daemon: Revert "We can not assume that just because we could complete a TCP...
authorMartin Schwenke <martin@meltin.net>
Fri, 5 Apr 2019 05:17:35 +0000 (16:17 +1100)
committerAmitay Isaacs <amitay@samba.org>
Fri, 12 Apr 2019 07:11:30 +0000 (07:11 +0000)
commit38dc6d11a26c2e9a2cae7927321f2216ceb1c5ec
treed7e4abaef83ceade5150b3dc02cf85367efc02f8
parent10291d91f2a087ff959676f2e2a04b41ae5afd68
ctdb-daemon: Revert "We can not assume that just because we could complete a TCP handshake"

We also can not assume that nodes can be marked as connected via only
the keepalive mechanism.  Keepalives are not sent to disconnected
nodes so, in the absence of other packets (e.g. broadcasts), 2 nodes
may never become marked as connected to each other.

Revert to marking nodes as connected in the TCP transport code.  If a
connection is to a non(-operational) ctdbd then it will revert to
disconnected after a short while and may actually flap.  This should
be rare.

This reverts commit 66919db3d7ab1e091223faf515b183af8bfddc83.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13888

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tcp/tcp_connect.c