replmd: treat a zero GUID as not present in get_parsed_dns
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 2 Feb 2017 03:37:58 +0000 (16:37 +1300)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 Feb 2017 02:17:16 +0000 (03:17 +0100)
commit33a5b6a934ea5098cd84d3caaddc7658738c9d5e
treedc78113899553a6ac7a4038c9a7d1ac9fff9a18e
parent5fa1b5cc79d813435eefe912bd2530de70fa1baf
replmd: treat a zero GUID as not present in get_parsed_dns

This roughly follows the pattern in the 2009 commit
0d5d7f58473c989bff4 by the Andrews Tridgell and Bartlett, which dealt
with zero GUIDs in replmd_add_fix_la(). That function is about to use
get_parsed_dns() [see next commit], and the other users of
get_parsed_dns don't really want to see zero guids, so it is simpler
to test here.

This makes hitting the GUID_all_zero branch of parsed_dn_find() even
more unlikely.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/repl_meta_data.c