s3:utils: Allow to run smbpasswd as user
[metze/samba/wip.git] / source3 / utils / smbpasswd.c
index 8cca93f5defd0a2a8be3ed18f21f0e1e64b7f705..ae9862606f1884e747a89e1d4c5ba45440c32872 100644 (file)
  * this program; if not, see <http://www.gnu.org/licenses/>.  */
 
 #include "includes.h"
-
-extern bool AllowDebugChange;
+#include "system/passwd.h"
+#include "secrets.h"
+#include "../librpc/gen_ndr/samr.h"
+#include "../lib/util/util_pw.h"
+#include "passdb.h"
 
 /*
  * Next two lines needed for SunOS and don't
@@ -94,16 +97,15 @@ static int process_options(int argc, char **argv, int local_flags)
        while ((ch = getopt(argc, argv, "c:axdehminjr:sw:R:D:U:LW")) != EOF) {
                switch(ch) {
                case 'L':
-#if !defined(NSS_WRAPPER)
                        if (getuid() != 0) {
                                fprintf(stderr, "smbpasswd -L can only be used by root.\n");
                                exit(1);
                        }
-#endif
                        local_flags |= LOCAL_AM_ROOT;
                        break;
                case 'c':
                        configfile = optarg;
+                       set_dyn_CONFIGFILE(optarg);
                        break;
                case 'a':
                        local_flags |= LOCAL_ADD_USER;
@@ -133,6 +135,7 @@ static int process_options(int argc, char **argv, int local_flags)
                case 'n':
                        local_flags |= LOCAL_SET_NO_PASSWORD;
                        local_flags &= ~LOCAL_SET_PASSWORD;
+                       SAFE_FREE(new_passwd);
                        new_passwd = smb_xstrdup("NO PASSWORD");
                        break;
                case 'r':
@@ -149,10 +152,10 @@ static int process_options(int argc, char **argv, int local_flags)
                        fstrcpy(ldap_secret, optarg);
                        break;
                case 'R':
-                       lp_set_name_resolve_order(optarg);
+                       lp_set_cmdline("name resolve order", optarg);
                        break;
                case 'D':
-                       DEBUGLEVEL = atoi(optarg);
+                       lp_set_cmdline("log level", optarg);
                        break;
                case 'U': {
                        got_username = True;
@@ -192,7 +195,7 @@ static int process_options(int argc, char **argv, int local_flags)
                usage();
        }
 
-       if (!lp_load(configfile,True,False,False,True)) {
+       if (!lp_load_global(configfile)) {
                fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
                        configfile);
                exit(1);
@@ -212,11 +215,17 @@ static char *prompt_for_new_password(bool stdin_get)
        ZERO_ARRAY(new_pw);
 
        p = get_pass("New SMB password:", stdin_get);
+       if (p == NULL) {
+               return NULL;
+       }
 
        fstrcpy(new_pw, p);
        SAFE_FREE(p);
 
        p = get_pass("Retype new SMB password:", stdin_get);
+       if (p == NULL) {
+               return NULL;
+       }
 
        if (strcmp(p, new_pw)) {
                fprintf(stderr, "Mismatch - password unchanged.\n");
@@ -242,26 +251,29 @@ static NTSTATUS password_change(const char *remote_mach, char *username,
        char *msg_str = NULL;
 
        if (remote_mach != NULL) {
-               if (local_flags & (LOCAL_ADD_USER|LOCAL_DELETE_USER|LOCAL_DISABLE_USER|LOCAL_ENABLE_USER|
-                                                       LOCAL_TRUST_ACCOUNT|LOCAL_SET_NO_PASSWORD)) {
+               if (local_flags & (LOCAL_ADD_USER|LOCAL_DELETE_USER|
+                                  LOCAL_DISABLE_USER|LOCAL_ENABLE_USER|
+                                  LOCAL_TRUST_ACCOUNT|LOCAL_SET_NO_PASSWORD)) {
                        /* these things can't be done remotely yet */
+                       fprintf(stderr, "Invalid remote operation!\n");
                        return NT_STATUS_UNSUCCESSFUL;
                }
-               ret = remote_password_change(remote_mach, username, 
+               ret = remote_password_change(remote_mach, username,
                                             old_passwd, new_pw, &err_str);
-               if (err_str != NULL)
-                       fprintf(stderr, "%s", err_str);
-               SAFE_FREE(err_str);
-               return ret;
+       } else {
+               ret = local_password_change(username, local_flags, new_pw,
+                                           &err_str, &msg_str);
        }
 
-       ret = local_password_change(username, local_flags, new_pw, 
-                                    &err_str, &msg_str);
-
-       if(msg_str)
+       if (msg_str) {
                printf("%s", msg_str);
-       if(err_str)
+       }
+       if (err_str) {
                fprintf(stderr, "%s", err_str);
+       }
+       if (!NT_STATUS_IS_OK(ret) && !err_str) {
+               fprintf(stderr, "Failed to change password!\n");
+       }
 
        SAFE_FREE(msg_str);
        SAFE_FREE(err_str);
@@ -279,7 +291,7 @@ static bool store_ldap_admin_pw (char* pw)
        if (!secrets_init())
                return False;
 
-       return secrets_store_ldap_pw(lp_ldap_admin_dn(), pw);
+       return secrets_store_ldap_pw(lp_ldap_admin_dn(talloc_tos()), pw);
 }
 
 
@@ -294,7 +306,7 @@ static int process_root(int local_flags)
        char *old_passwd = NULL;
 
        if (local_flags & LOCAL_SET_LDAP_ADMIN_PW) {
-               char *ldap_admin_dn = lp_ldap_admin_dn();
+               char *ldap_admin_dn = lp_ldap_admin_dn(talloc_tos());
                if ( ! *ldap_admin_dn ) {
                        DEBUG(0,("ERROR: 'ldap admin dn' not defined! Please check your smb.conf\n"));
                        goto done;
@@ -303,6 +315,10 @@ static int process_root(int local_flags)
                printf("Setting stored password for \"%s\" in secrets.tdb\n", ldap_admin_dn);
                if ( ! *ldap_secret ) {
                        new_passwd = prompt_for_new_password(stdin_passwd_get);
+                       if (new_passwd == NULL) {
+                               fprintf(stderr, "Failed to read new password!\n");
+                               exit(1);
+                       }
                        fstrcpy(ldap_secret, new_passwd);
                }
                if (!store_ldap_admin_pw(ldap_secret)) {
@@ -337,7 +353,7 @@ static int process_root(int local_flags)
                load_interfaces();
        }
 
-       if (!user_name[0] && (pwd = getpwuid_alloc(talloc_autofree_context(), geteuid()))) {
+       if (!user_name[0] && (pwd = getpwuid_alloc(talloc_tos(), geteuid()))) {
                fstrcpy(user_name, pwd->pw_name);
                TALLOC_FREE(pwd);
        } 
@@ -363,7 +379,11 @@ static int process_root(int local_flags)
                if (local_flags & LOCAL_ADD_USER) {
                        SAFE_FREE(new_passwd);
                        new_passwd = smb_xstrdup(user_name);
-                       strlower_m(new_passwd);
+                       if (!strlower_m(new_passwd)) {
+                               fprintf(stderr, "strlower_m %s failed\n",
+                                       new_passwd);
+                               exit(1);
+                       }
                }
 
                /*
@@ -372,7 +392,7 @@ static int process_root(int local_flags)
                 */
 
                slprintf(buf, sizeof(buf)-1, "%s$", user_name);
-               fstrcpy(user_name, buf);
+               strlcpy(user_name, buf, sizeof(user_name));
        } else if (local_flags & LOCAL_INTERDOM_ACCOUNT) {
                static fstring buf;
 
@@ -389,12 +409,16 @@ static int process_root(int local_flags)
 
                /* prepare uppercased and '$' terminated username */
                slprintf(buf, sizeof(buf) - 1, "%s$", user_name);
-               fstrcpy(user_name, buf);
+               strlcpy(user_name, buf, sizeof(user_name));
 
        } else {
 
                if (remote_machine != NULL) {
                        old_passwd = get_pass("Old SMB password:",stdin_passwd_get);
+                       if(!old_passwd) {
+                               fprintf(stderr, "Unable to get old password.\n");
+                               exit(1);
+                       }
                }
 
                if (!(local_flags & LOCAL_SET_PASSWORD)) {
@@ -430,21 +454,8 @@ static int process_root(int local_flags)
                }
 
                if((local_flags & LOCAL_SET_PASSWORD) && (new_passwd == NULL)) {
-                       struct passwd *passwd;
-
-                       if (remote_machine == NULL) {
-                               passwd = getpwnam_alloc(NULL, user_name);
-
-                               if (!passwd) {
-                                       fprintf(stderr, "Cannot locate Unix account for "
-                                               "'%s'!\n", user_name);
-                                       exit(1);
-                               }
-                               TALLOC_FREE(passwd);
-                       }
 
                        new_passwd = prompt_for_new_password(stdin_passwd_get);
-
                        if(!new_passwd) {
                                fprintf(stderr, "Unable to get new password.\n");
                                exit(1);
@@ -455,7 +466,6 @@ static int process_root(int local_flags)
        if (!NT_STATUS_IS_OK(password_change(remote_machine, user_name,
                                             old_passwd, new_passwd,
                                             local_flags))) {
-               fprintf(stderr,"Failed to modify password entry for user %s\n", user_name);
                result = 1;
                goto done;
        } 
@@ -489,6 +499,7 @@ static int process_root(int local_flags)
        }
 
  done:
+       SAFE_FREE(old_passwd);
        SAFE_FREE(new_passwd);
        return result;
 }
@@ -511,7 +522,7 @@ static int process_nonroot(int local_flags)
        }
 
        if (!user_name[0]) {
-               pwd = getpwuid_alloc(talloc_autofree_context(), getuid());
+               pwd = getpwuid_alloc(talloc_tos(), getuid());
                if (pwd) {
                        fstrcpy(user_name,pwd->pw_name);
                        TALLOC_FREE(pwd);
@@ -535,6 +546,10 @@ static int process_nonroot(int local_flags)
 
        if (remote_machine != NULL) {
                old_pw = get_pass("Old SMB password:",stdin_passwd_get);
+               if (old_pw == NULL) {
+                       fprintf(stderr, "Unable to get old password.\n");
+                       exit(1);
+               }
        }
 
        if (!new_passwd) {
@@ -550,7 +565,6 @@ static int process_nonroot(int local_flags)
 
        if (!NT_STATUS_IS_OK(password_change(remote_machine, user_name, old_pw,
                                             new_pw, 0))) {
-               fprintf(stderr,"Failed to change password for %s\n", user_name);
                result = 1;
                goto done;
        }
@@ -572,11 +586,10 @@ static int process_nonroot(int local_flags)
 int main(int argc, char **argv)
 {      
        TALLOC_CTX *frame = talloc_stackframe();
+       struct messaging_context *msg_ctx = NULL;
        int local_flags = 0;
        int ret;
 
-       AllowDebugChange = False;
-
 #if defined(HAVE_SET_AUTH_PARAMETERS)
        set_auth_parameters(argc, argv);
 #endif /* HAVE_SET_AUTH_PARAMETERS */
@@ -585,11 +598,24 @@ int main(int argc, char **argv)
                local_flags = LOCAL_AM_ROOT;
        }
 
-       load_case_tables();
+       smb_init_locale();
 
        local_flags = process_options(argc, argv, local_flags);
 
-       setup_logging("smbpasswd", True);
+       setup_logging("smbpasswd", DEBUG_STDERR);
+
+       msg_ctx = server_messaging_context();
+       if (msg_ctx == NULL) {
+               if (geteuid() != 0) {
+                       DBG_NOTICE("Unable to initialize messaging context. "
+                                  "Must be root to do that.\n");
+               } else {
+                       fprintf(stderr,
+                               "smbpasswd is not able to initialize the "
+                               "messaging context!\n");
+                       return 1;
+               }
+       }
 
        /*
         * Set the machine NETBIOS name if not already
@@ -606,11 +632,16 @@ int main(int argc, char **argv)
        }
 
        if (local_flags & LOCAL_AM_ROOT) {
-               secrets_init();
-               return process_root(local_flags);
-       } 
+               bool ok;
 
-       ret = process_nonroot(local_flags);
+               ok = secrets_init();
+               if (!ok) {
+                       return 1;
+               }
+               ret = process_root(local_flags);
+       } else {
+               ret = process_nonroot(local_flags);
+       }
        TALLOC_FREE(frame);
        return ret;
 }