WRONG! pidl-wireshark: generate NDR64 enabled code for enums
[metze/samba/wip.git] / pidl / lib / Parse / Pidl / Wireshark / NDR.pm
index 8846b740ab745fc2922122456093690108a893d0..0c5340fb20e03b3a036d709206ebc0fd444d3fc9 100644 (file)
@@ -1,5 +1,5 @@
 ##################################################
-# Samba4 NDR parser generator for IDL structures
+# Wireshark NDR parser generator for IDL structures
 # Copyright tridge@samba.org 2000-2003
 # Copyright tpot@samba.org 2001,2005
 # Copyright jelmer@samba.org 2004-2007
@@ -166,13 +166,15 @@ sub Enum($$$$)
        $self->pidl_code("$dissectorname(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_, int hf_index _U_, guint32 *param _U_)");
        $self->pidl_code("{");
        $self->indent;
-       $self->pidl_code("g$e->{BASE_TYPE} parameter=0;");
+       my $type = $e->{BASE_TYPE};
+       $type = "uint1632" if ($e->{BASE_TYPE} eq "uint16");
+       $self->pidl_code("g${type} parameter=0;");
        $self->pidl_code("if(param){");
        $self->indent;
-       $self->pidl_code("parameter=(g$e->{BASE_TYPE})*param;");
+       $self->pidl_code("parameter=(g${type})*param;");
        $self->deindent;
        $self->pidl_code("}");
-       $self->pidl_code("offset = dissect_ndr_$e->{BASE_TYPE}(tvb, offset, pinfo, tree, drep, hf_index, &parameter);");
+       $self->pidl_code("offset = dissect_ndr_${type}(tvb, offset, pinfo, tree, drep, hf_index, &parameter);");
        $self->pidl_code("if(param){");
        $self->indent;
        $self->pidl_code("*param=(guint32)parameter;");
@@ -188,6 +190,13 @@ sub Enum($$$$)
        $self->register_type($name, "offset = $dissectorname(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);", "FT_UINT$enum_size", "BASE_DEC", "0", "VALS($valsstring)", $enum_size / 8);
 }
 
+sub Pipe($$$$)
+{
+       my ($self,$e,$name,$ifname) = @_;
+       error($e->{ORIGINAL}, "Pipe not yet supported");
+       return;
+}
+
 sub Bitmap($$$$)
 {
        my ($self,$e,$name,$ifname) = @_;
@@ -215,7 +224,7 @@ sub Bitmap($$$$)
 
        $self->pidl_code("if (parent_tree) {");
        $self->indent;
-       $self->pidl_code("item = proto_tree_add_item(parent_tree, hf_index, tvb, offset, $e->{ALIGN}, TRUE);");
+       $self->pidl_code("item = proto_tree_add_item(parent_tree, hf_index, tvb, offset, $e->{ALIGN}, DREP_ENC_INTEGER(drep));");
        $self->pidl_code("tree = proto_item_add_subtree(item,ett_$ifname\_$name);");
        $self->deindent;
        $self->pidl_code("}\n");
@@ -270,11 +279,9 @@ sub Bitmap($$$$)
        $self->register_type($name, "offset = $dissectorname(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);", "FT_UINT$size", "BASE_HEX", "0", "NULL", $size/8);
 }
 
-sub ElementLevel($$$$$$$)
+sub ElementLevel($$$$$$$$)
 {
-       my ($self,$e,$l,$hf,$myname,$pn,$ifname) = @_;
-
-       my $param = 0;
+       my ($self,$e,$l,$hf,$myname,$pn,$ifname,$param) = @_;
 
        if (defined($self->{conformance}->{dissectorparams}->{$myname})) {
                $param = $self->{conformance}->{dissectorparams}->{$myname}->{PARAM};
@@ -323,19 +330,30 @@ sub ElementLevel($$$$$$$)
                                $self->pidl_code("proto_item_append_text(tree, \": %s\", data);");
                        } elsif (property_matches($e, "flag", ".*LIBNDR_FLAG_STR_SIZE4.*")) {
                                $self->pidl_code("offset = dissect_ndr_vstring(tvb, offset, pinfo, tree, drep, $bs, $hf, FALSE, NULL);");
+                       } elsif (property_matches($e, "flag", ".*STR_NULLTERM.*")) {
+                               if ($bs == 2) {
+                                       $self->pidl_code("offset = dissect_null_term_wstring(tvb, offset, pinfo, tree, drep, $hf , 0);")
+                               } else {
+                                       $self->pidl_code("offset = dissect_null_term_string(tvb, offset, pinfo, tree, drep, $hf , 0);")
+                               }
                        } else {
                                warn("Unable to handle string with flags $e->{PROPERTIES}->{flag}");
                        }
+               } elsif ($l->{DATA_TYPE} eq "DATA_BLOB") {
+                       my $remain = 0;
+                       $remain = 1 if (property_matches($e->{ORIGINAL}, "flag", ".*LIBNDR_FLAG_REMAINING.*"));
+                       $self->pidl_code("offset = dissect_ndr_datablob(tvb, offset, pinfo, tree, drep, $hf, $remain);");
                } else {
                        my $call;
 
                        if ($self->{conformance}->{imports}->{$l->{DATA_TYPE}}) {
-                               $call = $self->{conformance}->{imports}->{$l->{DATA_TYPE}}->{DATA};     
+                               $call = $self->{conformance}->{imports}->{$l->{DATA_TYPE}}->{DATA};
                                $self->{conformance}->{imports}->{$l->{DATA_TYPE}}->{USED} = 1;
-                       } elsif (defined($self->{conformance}->{imports}->{"$pn.$e->{NAME}"})) {
-                               $call = $self->{conformance}->{imports}->{"$pn.$e->{NAME}"}->{DATA};
+
+                       } elsif (defined($self->{conformance}->{imports}->{"$pn.$e->{NAME}"})) {
+                               $call = $self->{conformance}->{imports}->{"$pn.$e->{NAME}"}->{DATA};
                                $self->{conformance}->{imports}->{"$pn.$e->{NAME}"}->{USED} = 1;
-                           
+
                        } elsif (defined($self->{conformance}->{types}->{$l->{DATA_TYPE}})) {
                                $call= $self->{conformance}->{types}->{$l->{DATA_TYPE}}->{DISSECTOR_NAME};
                                $self->{conformance}->{types}->{$l->{DATA_TYPE}}->{USED} = 1;
@@ -350,27 +368,74 @@ sub ElementLevel($$$$$$$)
                        $self->pidl_code($call);
                }
        } elsif ($_->{TYPE} eq "SUBCONTEXT") {
+               my $varswitch;
+               if (has_property($e, "switch_is")) {
+                       $varswitch = $e->{PROPERTIES}->{switch_is};
+               }
                my $num_bits = ($l->{HEADER_SIZE}*8);
+               my $hf2 = $self->register_hf_field($hf."_", "Subcontext length", "$ifname.$pn.$_->{NAME}subcontext", "FT_UINT$num_bits", "BASE_HEX", "NULL", 0, "");
+               $num_bits = 3264 if ($num_bits == 32);
+               $self->{hf_used}->{$hf2} = 1;
+               $self->pidl_code("dcerpc_info *di = (dcerpc_info*)pinfo->private_data;");
                $self->pidl_code("guint$num_bits size;");
-               $self->pidl_code("int start_offset = offset;");
+               $self->pidl_code("int conformant = di->conformant_run;");
                $self->pidl_code("tvbuff_t *subtvb;");
-               $self->pidl_code("offset = dissect_ndr_uint$num_bits(tvb, offset, pinfo, tree, drep, $hf, &size);");
-               $self->pidl_code("proto_tree_add_text(tree, tvb, start_offset, offset - start_offset + size, \"Subcontext size\");");
+               $self->pidl_code("");
+               # We need to be able to dissect the length of the context in every case
+               # and conformant run skips the dissections of scalars ...
+               $self->pidl_code("if (!conformant) {");
+               $self->indent;
+               $self->pidl_code("guint32 saved_flags = di->call_data->flags;");
+               $self->pidl_code("offset = dissect_ndr_uint$num_bits(tvb, offset, pinfo, tree, drep, $hf2, &size);");
+               # This is a subcontext, there is normally no such thing as
+               # 64 bit NDR is subcontext so we clear the flag so that we can
+               # continue to dissect handmarshalled stuff with pidl
+               $self->pidl_code("di->call_data->flags &= ~DCERPC_IS_NDR64;");
 
                $self->pidl_code("subtvb = tvb_new_subset(tvb, offset, size, -1);");
-               $self->pidl_code("$myname\_(subtvb, 0, pinfo, tree, drep);");
+               if ($param ne 0) {
+                       $self->pidl_code("$myname\_(subtvb, 0, pinfo, tree, drep, $param);");
+               } else {
+                       $self->pidl_code("$myname\_(subtvb, 0, pinfo, tree, drep);");
+               }
+               $self->pidl_code("offset += size;");
+               $self->pidl_code("di->call_data->flags = saved_flags;");
+               $self->deindent;
+               $self->pidl_code("}");
+       } elsif ($_->{TYPE} eq "PIPE") {
+               error($e->{ORIGINAL}, "Type PIPE not yet supported");
        } else {
                die("Unknown type `$_->{TYPE}'");
        }
 }
 
-sub Element($$$)
+sub Element($$$$$)
 {
-       my ($self,$e,$pn,$ifname) = @_;
+       my ($self,$e,$pn,$ifname,$isoruseswitch) = @_;
 
        my $dissectorname = "$ifname\_dissect\_element\_".StripPrefixes($pn, $self->{conformance}->{strip_prefixes})."\_".StripPrefixes($e->{NAME}, $self->{conformance}->{strip_prefixes});
 
-       my $call_code = "offset = $dissectorname(tvb, offset, pinfo, tree, drep);";
+       my ($call_code, $moreparam);
+       my $param = 0;
+       if (defined $isoruseswitch) {
+               my $type = $isoruseswitch->[0];
+               my $name = $isoruseswitch->[1];
+
+               my $switch_dt =  getType($type);
+               my $switch_type;
+               if ($switch_dt->{DATA}->{TYPE} eq "ENUM") {
+                       $switch_type = "g".Parse::Pidl::Typelist::enum_type_fn($switch_dt->{DATA});
+               } elsif ($switch_dt->{DATA}->{TYPE} eq "SCALAR") {
+                       $switch_type = "g$e->{SWITCH_TYPE}";
+               }
+               $moreparam = ", $switch_type *".$name;
+               $param = $name;
+               $call_code = "offset = $dissectorname(tvb, offset, pinfo, tree, drep, &$name);";
+       } else {
+               $moreparam = "";
+               $call_code = "offset = $dissectorname(tvb, offset, pinfo, tree, drep);";
+       }
+
 
        my $type = $self->find_type($e->{TYPE});
 
@@ -380,7 +445,7 @@ sub Element($$$)
                        MASK => 0,
                        VALSSTRING => "NULL",
                        FT_TYPE => "FT_NONE",
-                       BASE_TYPE => "BASE_HEX"
+                       BASE_TYPE => "BASE_NONE"
                };
        }
 
@@ -389,7 +454,7 @@ sub Element($$$)
                        MASK => 0,
                        VALSSTRING => "NULL",
                        FT_TYPE => "FT_STRING",
-                       BASE_TYPE => "BASE_DEC"
+                       BASE_TYPE => "BASE_NONE"
                };
        }
 
@@ -403,16 +468,24 @@ sub Element($$$)
 
        my $add = "";
 
+       my $oldparam = undef;
        foreach (@{$e->{LEVELS}}) {
+               if (defined $_->{SWITCH_IS}) {
+                       $oldparam = $param;
+                       $param = "*$param";
+               }
                next if ($_->{TYPE} eq "SWITCH");
-               $self->pidl_def("static int $dissectorname$add(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_);");
+               $self->pidl_def("static int $dissectorname$add(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_$moreparam);");
                $self->pidl_fn_start("$dissectorname$add");
                $self->pidl_code("static int");
-               $self->pidl_code("$dissectorname$add(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_)");
+               $self->pidl_code("$dissectorname$add(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *tree _U_, guint8 *drep _U_$moreparam)");
                $self->pidl_code("{");
                $self->indent;
 
-               $self->ElementLevel($e,$_,$hf,$dissectorname.$add,$pn,$ifname);
+               $self->ElementLevel($e,$_,$hf,$dissectorname.$add,$pn,$ifname,$param);
+               if (defined $oldparam) {
+                       $param = $oldparam;
+               }
 
                $self->pidl_code("");
                $self->pidl_code("return offset;");
@@ -433,7 +506,7 @@ sub Function($$$)
        my %dissectornames;
 
        foreach (@{$fn->{ELEMENTS}}) {
-           $dissectornames{$_->{NAME}} = $self->Element($_, $fn->{NAME}, $ifname) if not defined($dissectornames{$_->{NAME}});
+           $dissectornames{$_->{NAME}} = $self->Element($_, $fn->{NAME}, $ifname, undef) if not defined($dissectornames{$_->{NAME}});
        }
        
        my $fn_name = $_->{NAME};
@@ -473,12 +546,12 @@ sub Function($$$)
        if (not defined($fn->{RETURN_TYPE})) {
        } elsif ($fn->{RETURN_TYPE} eq "NTSTATUS") {
                $self->pidl_code("offset = dissect_ntstatus(tvb, offset, pinfo, tree, drep, hf\_$ifname\_status, &status);\n");
-               $self->pidl_code("if (status != 0 && check_col(pinfo->cinfo, COL_INFO))");
+               $self->pidl_code("if (status != 0)");
                $self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", Error: %s\", val_to_str(status, NT_errors, \"Unknown NT status 0x%08x\"));\n");
                $return_types{$ifname}->{"status"} = ["NTSTATUS", "NT Error"];
        } elsif ($fn->{RETURN_TYPE} eq "WERROR") {
                $self->pidl_code("offset = dissect_ndr_uint32(tvb, offset, pinfo, tree, drep, hf\_$ifname\_werror, &status);\n");
-               $self->pidl_code("if (status != 0 && check_col(pinfo->cinfo, COL_INFO))");
+               $self->pidl_code("if (status != 0)");
                $self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", Error: %s\", val_to_str(status, WERR_errors, \"Unknown DOS error 0x%08x\"));\n");
                
                $return_types{$ifname}->{"werror"} = ["WERROR", "Windows Error"];
@@ -488,12 +561,12 @@ sub Function($$$)
                        my $return_dissect = "dissect_ndr_" .Parse::Pidl::Typelist::enum_type_fn($type->{DATA});
 
                        $self->pidl_code("offset = $return_dissect(tvb, offset, pinfo, tree, drep, hf\_$ifname\_$fn->{RETURN_TYPE}_status, &status);");
-                       $self->pidl_code("if (status != 0 && check_col(pinfo->cinfo, COL_INFO))");
+                       $self->pidl_code("if (status != 0)");
                        $self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", Status: %s\", val_to_str(status, $ifname\_$fn->{RETURN_TYPE}\_vals, \"Unknown " . $fn->{RETURN_TYPE} . " error 0x%08x\"));\n");
                        $return_types{$ifname}->{$fn->{RETURN_TYPE}."_status"} = [$fn->{RETURN_TYPE}, $fn->{RETURN_TYPE}];
                } elsif ($type->{DATA}->{TYPE} eq "SCALAR") {
                        $self->pidl_code("offset = dissect_ndr_$fn->{RETURN_TYPE}(tvb, offset, pinfo, tree, drep, hf\_$ifname\_$fn->{RETURN_TYPE}_status, &status);");
-                       $self->pidl_code("if (status != 0 && check_col(pinfo->cinfo, COL_INFO))");
+                       $self->pidl_code("if (status != 0)");
                        $self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", Status: %d\", status);\n");
                        $return_types{$ifname}->{$fn->{RETURN_TYPE}."_status"} = [$fn->{RETURN_TYPE}, $fn->{RETURN_TYPE}];
                }
@@ -534,7 +607,40 @@ sub Struct($$$$)
        $self->register_ett("ett_$ifname\_$name");
 
        my $res = "";
-       ($res.="\t".$self->Element($_, $name, $ifname)."\n\n") foreach (@{$e->{ELEMENTS}});
+       my $varswitchs = {};
+       # will contain the switch var declaration;
+       my $vars = [];
+       foreach (@{$e->{ELEMENTS}}) {
+               if (has_property($_, "switch_is")) {
+                       $varswitchs->{$_->{PROPERTIES}->{switch_is}} = [];
+               }
+       }
+       foreach (@{$e->{ELEMENTS}}) {
+               my $switch_info = undef;
+
+               my $v = $_->{NAME};
+               if (scalar(grep {/$v/} keys(%$varswitchs)) == 1) {
+                       # This element is one of the switch attribute
+                       my $switch_dt =  getType($_->{TYPE});
+                       my $switch_type;
+                       if ($switch_dt->{DATA}->{TYPE} eq "ENUM") {
+                               $switch_type = "g".Parse::Pidl::Typelist::enum_type_fn($switch_dt->{DATA});
+                       } elsif ($switch_dt->{DATA}->{TYPE} eq "SCALAR") {
+                               $switch_type = "g$e->{SWITCH_TYPE}";
+                       }
+
+                       push @$vars, "$switch_type $v;";
+                       $switch_info = [ $_->{TYPE}, $v ];
+                       $varswitchs->{$v} = $switch_info;
+               }
+
+               if (has_property($_, "switch_is")) {
+                       my $varswitch = $_->{PROPERTIES}->{switch_is};
+                       $switch_info = $varswitchs->{$varswitch};
+               }
+
+               $res.="\t".$self->Element($_, $name, $ifname, $switch_info)."\n\n";
+       }
 
        $self->pidl_hdr("int $dissectorname(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_);");
 
@@ -543,12 +649,16 @@ sub Struct($$$$)
        $self->pidl_code("$dissectorname(tvbuff_t *tvb _U_, int offset _U_, packet_info *pinfo _U_, proto_tree *parent_tree _U_, guint8 *drep _U_, int hf_index _U_, guint32 param _U_)");
        $self->pidl_code("{");
        $self->indent;
+       $self->pidl_code($_) foreach (@$vars);
        $self->pidl_code("proto_item *item = NULL;");
        $self->pidl_code("proto_tree *tree = NULL;");
+       if ($e->{ALIGN} > 1) {
+               $self->pidl_code("dcerpc_info *di = (dcerpc_info *)pinfo->private_data;");
+       }
        $self->pidl_code("int old_offset;");
        $self->pidl_code("");
 
-       if ($e->{ALIGN} > 1) {
+       if ($e->{ALIGN} > 1 and not property_matches($e, "flag", ".*LIBNDR_FLAG_NOALIGN.*")) {
                $self->pidl_code("ALIGN_TO_$e->{ALIGN}_BYTES;");
        }
        $self->pidl_code("");
@@ -557,7 +667,7 @@ sub Struct($$$$)
        $self->pidl_code("");
        $self->pidl_code("if (parent_tree) {");
        $self->indent;
-       $self->pidl_code("item = proto_tree_add_item(parent_tree, hf_index, tvb, offset, -1, TRUE);");
+       $self->pidl_code("item = proto_tree_add_item(parent_tree, hf_index, tvb, offset, -1, ENC_NA);");
        $self->pidl_code("tree = proto_item_add_subtree(item, ett_$ifname\_$name);");
        $self->deindent;
        $self->pidl_code("}");
@@ -565,6 +675,15 @@ sub Struct($$$$)
        $self->pidl_code("\n$res");
 
        $self->pidl_code("proto_item_set_len(item, offset-old_offset);\n");
+       if ($e->{ALIGN} > 1) {
+               $self->pidl_code("");
+               $self->pidl_code("if (di->call_data->flags & DCERPC_IS_NDR64) {");
+               $self->indent;
+               $self->pidl_code("ALIGN_TO_$e->{ALIGN}_BYTES;");
+               $self->deindent;
+               $self->pidl_code("}");
+       }
+       $self->pidl_code("");
        $self->pidl_code("return offset;");
        $self->deindent;
        $self->pidl_code("}\n");
@@ -587,7 +706,7 @@ sub Union($$$$)
        foreach (@{$e->{ELEMENTS}}) {
                $res.="\n\t\t$_->{CASE}:\n";
                if ($_->{TYPE} ne "EMPTY") {
-                       $res.="\t\t\t".$self->Element($_, $name, $ifname)."\n";
+                       $res.="\t\t\t".$self->Element($_, $name, $ifname, undef)."\n";
                }
                $res.="\t\tbreak;\n";
        }
@@ -611,7 +730,11 @@ sub Union($$$$)
        $self->pidl_code("proto_item *item = NULL;");
        $self->pidl_code("proto_tree *tree = NULL;");
        $self->pidl_code("int old_offset;");
-       $self->pidl_code("$switch_type level;");
+       if (!defined $switch_type) {
+               $self->pidl_code("guint32 level = param;");
+       } else {
+               $self->pidl_code("$switch_type level;");
+       }
        $self->pidl_code("");
 
        $self->pidl_code("old_offset = offset;");
@@ -624,16 +747,20 @@ sub Union($$$$)
 
        $self->pidl_code("");
 
-       $self->pidl_code("offset = $switch_dissect(tvb, offset, pinfo, tree, drep, hf_index, &level);");
+       if (defined $switch_type) {
+               $self->pidl_code("offset = $switch_dissect(tvb, offset, pinfo, tree, drep, hf_index, &level);");
 
-       if ($e->{ALIGN} > 1) {
-               $self->pidl_code("ALIGN_TO_$e->{ALIGN}_BYTES;");
-               $self->pidl_code("");
+               if ($e->{ALIGN} > 1) {
+                       $self->pidl_code("ALIGN_TO_$e->{ALIGN}_BYTES;");
+                       $self->pidl_code("");
+               }
        }
 
 
        $self->pidl_code("switch(level) {$res\t}");
        $self->pidl_code("proto_item_set_len(item, offset-old_offset);\n");
+       $self->pidl_code("");
+
        $self->pidl_code("return offset;");
        $self->deindent;
        $self->pidl_code("}");
@@ -665,13 +792,13 @@ sub Type($$$$)
        my ($self, $e, $name, $ifname) = @_;
 
        $self->PrintIdl(DumpType($e->{ORIGINAL}));
-
        {
                ENUM => \&Enum,
                STRUCT => \&Struct,
                UNION => \&Union,
                BITMAP => \&Bitmap,
-               TYPEDEF => \&Typedef
+               TYPEDEF => \&Typedef,
+               PIPE    => \&Pipe
        }->{$e->{TYPE}}->($self, $e, $name, $ifname);
 }
 
@@ -756,8 +883,8 @@ sub ProcessImport
        my @imports = @_;
        foreach (@imports) {
                next if($_ eq "security");
-               s/\.idl\"$//;
                s/^\"//;
+               s/\.idl"?$//;
                $self->pidl_hdr("#include \"packet-dcerpc-$_\.h\"");
        }
        $self->pidl_hdr("");
@@ -797,7 +924,7 @@ sub ProcessInterface($$)
            . ", 0x" . substr($if_uuid, 35, 2) . " }");
            $self->pidl_def("};");
        
-           my $maj = $x->{VERSION};
+           my $maj = 0x0000FFFF & $x->{VERSION};
            $maj =~ s/\.(.*)$//g;
            $self->pidl_def("static guint16 ver_dcerpc_$x->{NAME} = $maj;");
            $self->pidl_def("");
@@ -806,7 +933,6 @@ sub ProcessInterface($$)
        $return_types{$x->{NAME}} = {};
 
        $self->Interface($x);
-
        $self->pidl_code("\n".DumpFunctionTable($x));
 
        foreach (keys %{$return_types{$x->{NAME}}}) {
@@ -865,6 +991,8 @@ sub Initialize($$)
                $self->register_type("int$bits", "offset = PIDL_dissect_uint$bits(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);", "FT_INT$bits", "BASE_DEC", 0, "NULL", $bytes);
        }
                
+       $self->register_type("uint3264", "offset = dissect_ndr_uint3264(tvb, offset, pinfo, tree, drep, \@HF\@, NULL);", "FT_UINT32", "BASE_DEC", 0, "NULL", 8);
+       $self->register_type("hyper", "offset = dissect_ndr_uint64(tvb, offset, pinfo, tree, drep, \@HF\@, NULL);", "FT_UINT64", "BASE_DEC", 0, "NULL", 8);
        $self->register_type("udlong", "offset = dissect_ndr_duint32(tvb, offset, pinfo, tree, drep, \@HF\@, NULL);", "FT_UINT64", "BASE_DEC", 0, "NULL", 4);
        $self->register_type("bool8", "offset = PIDL_dissect_uint8(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);","FT_INT8", "BASE_DEC", 0, "NULL", 1);
        $self->register_type("char", "offset = PIDL_dissect_uint8(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);","FT_INT8", "BASE_DEC", 0, "NULL", 1);
@@ -872,17 +1000,17 @@ sub Initialize($$)
        $self->register_type("dlong", "offset = dissect_ndr_duint32(tvb, offset, pinfo, tree, drep, \@HF\@, NULL);","FT_INT64", "BASE_DEC", 0, "NULL", 8);
        $self->register_type("GUID", "offset = dissect_ndr_uuid_t(tvb, offset, pinfo, tree, drep, \@HF\@, NULL);","FT_GUID", "BASE_NONE", 0, "NULL", 4);
        $self->register_type("policy_handle", "offset = PIDL_dissect_policy_hnd(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);","FT_BYTES", "BASE_NONE", 0, "NULL", 4);
-       $self->register_type("NTTIME", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);","FT_ABSOLUTE_TIME", "BASE_NONE", 0, "NULL", 4);
-       $self->register_type("NTTIME_hyper", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);","FT_ABSOLUTE_TIME", "BASE_NONE", 0, "NULL", 4);
-       $self->register_type("time_t", "offset = dissect_ndr_time_t(tvb, offset, pinfo,tree, drep, \@HF\@, NULL);","FT_ABSOLUTE_TIME", "BASE_DEC", 0, "NULL", 4);
-       $self->register_type("NTTIME_1sec", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);", "FT_ABSOLUTE_TIME", "BASE_NONE", 0, "NULL", 4);
+       $self->register_type("NTTIME", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);","FT_ABSOLUTE_TIME", "ABSOLUTE_TIME_LOCAL", 0, "NULL", 4);
+       $self->register_type("NTTIME_hyper", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);","FT_ABSOLUTE_TIME", "ABSOLUTE_TIME_LOCAL", 0, "NULL", 4);
+       $self->register_type("time_t", "offset = dissect_ndr_time_t(tvb, offset, pinfo,tree, drep, \@HF\@, NULL);","FT_ABSOLUTE_TIME", "ABSOLUTE_TIME_LOCAL", 0, "NULL", 4);
+       $self->register_type("NTTIME_1sec", "offset = dissect_ndr_nt_NTTIME(tvb, offset, pinfo, tree, drep, \@HF\@);", "FT_ABSOLUTE_TIME", "ABSOLUTE_TIME_LOCAL", 0, "NULL", 4);
        $self->register_type("SID", "
                dcerpc_info *di = (dcerpc_info *)pinfo->private_data;
 
                di->hf_index = \@HF\@;
 
                offset = dissect_ndr_nt_SID_with_options(tvb, offset, pinfo, tree, drep, param);
-       ","FT_STRING", "BASE_DEC", 0, "NULL", 4);
+       ","FT_STRING", "BASE_NONE", 0, "NULL", 4);
        $self->register_type("WERROR", 
                "offset = PIDL_dissect_uint32(tvb, offset, pinfo, tree, drep, \@HF\@, \@PARAM\@);","FT_UINT32", "BASE_DEC", 0, "VALS(WERR_errors)", 4);
        $self->register_type("NTSTATUS", 
@@ -895,7 +1023,7 @@ sub Initialize($$)
 sub Parse($$$$$)
 {
        my($self,$ndr,$idl_file,$h_filename,$cnf_file) = @_;
-       
+
        $self->Initialize($cnf_file);
 
        return (undef, undef) if defined($self->{conformance}->{noemit_dissector});
@@ -905,10 +1033,12 @@ sub Parse($$$$$)
        This filter was automatically generated
        from $idl_file and $cnf_file.
        
-       Pidl is a perl based IDL compiler for DCE/RPC idl files. 
+       Pidl is a perl based IDL compiler for DCE/RPC idl files.
        It is maintained by the Samba team, not the Wireshark team.
-       Instructions on how to download and install Pidl can be 
+       Instructions on how to download and install Pidl can be
        found at http://wiki.wireshark.org/Pidl
+
+       \$Id\$
 */
 
 ";
@@ -916,9 +1046,7 @@ sub Parse($$$$$)
        $self->pidl_hdr($notice);
 
        $self->{res}->{headers} = "\n";
-       $self->{res}->{headers} .= "#ifdef HAVE_CONFIG_H\n";
        $self->{res}->{headers} .= "#include \"config.h\"\n";
-       $self->{res}->{headers} .= "#endif\n\n";
 
        $self->{res}->{headers} .= "#ifdef _MSC_VER\n";
        $self->{res}->{headers} .= "#pragma warning(disable:4005)\n";
@@ -1040,6 +1168,23 @@ sub register_hf_field($$$$$$$$$)
        return $index;
 }
 
+sub change_hf_field_type($$$$)
+{
+       my ($self,$index,$ft_type,$base_type) = @_;
+       if (defined ($self->{conformance}->{hf_renames}->{$index})) {
+               print "Field $index has been renamed to ".$self->{conformance}->{hf_renames}->{$index}->{NEWNAME}." you can't change it's type";
+               return 0;
+       }
+
+       if (!defined ($self->{conformance}->{header_fields}->{$index})) {
+               print "Field $index doesn't exists";
+               return 0;
+       }
+       $self->{conformance}->{header_fields}->{$index}->{FT_TYPE} = $ft_type;
+       $self->{conformance}->{header_fields}->{$index}->{BASE_TYPE} = $base_type;
+       return 1;
+}
+
 sub DumpHfDeclaration($)
 {
        my ($self) = @_;
@@ -1055,6 +1200,20 @@ sub DumpHfDeclaration($)
        return "$res\n";
 }
 
+sub make_str_or_null($)
+{
+      my $str = shift;
+      if (substr($str, 0, 1) eq "\"") {
+              $str = substr($str, 1, length($str)-2);
+      }
+      $str =~ s/^\s*//;
+      $str =~ s/\s*$//;
+      if ($str eq "") {
+              return "NULL";
+      }
+      return make_str($str);
+}
+
 sub DumpHfList($)
 {
        my ($self) = @_;
@@ -1062,8 +1221,8 @@ sub DumpHfList($)
 
        foreach (values %{$self->{conformance}->{header_fields}}) 
        {
-               $res .= "\t{ &$_->{INDEX}, 
-         { ".make_str($_->{NAME}).", ".make_str($_->{FILTER}).", $_->{FT_TYPE}, $_->{BASE_TYPE}, $_->{VALSSTRING}, $_->{MASK}, ".make_str($_->{BLURB}).", HFILL }},
+               $res .= "\t{ &$_->{INDEX},
+         { ".make_str($_->{NAME}).", ".make_str($_->{FILTER}).", $_->{FT_TYPE}, $_->{BASE_TYPE}, $_->{VALSSTRING}, $_->{MASK}, ".make_str_or_null($_->{BLURB}).", HFILL }},
 ";
        }