pidl: remove 'pointer_default_top()' support
authorStefan Metzmacher <metze@samba.org>
Sat, 2 Feb 2008 09:18:33 +0000 (10:18 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 4 Feb 2008 17:37:09 +0000 (18:37 +0100)
metze

source/pidl/lib/Parse/Pidl/Compat.pm
source/pidl/lib/Parse/Pidl/NDR.pm
source/pidl/tests/ndr_compat.pl

index 7939bb2df2eb1df32f248a4f70e3ceb802a4644a..75190211441e5c0db0840baa1361a21c9b1b031e 100644 (file)
@@ -148,10 +148,6 @@ sub CheckInterface($)
 {
        my $if = shift;
 
-       if (has_property($if, "pointer_default_top") and 
-               $if->{PROPERTIES}->{pointer_default_top} ne "ref") {
-               warning($if, "pointer_default_top() is pidl-specific");
-       }
 }
 
 sub Check($)
index 98e8f183a2bd11ac5c2a5094ff7fcdf8f4aad653..fb1e65854cbbf6b091dc36bd6dc425964d84b955 100644 (file)
@@ -581,7 +581,7 @@ sub ParseFunction($$$)
        my $rettype = undef;
        my $thisopnum = undef;
 
-       CheckPointerTypes($d, $ndr->{PROPERTIES}->{pointer_default_top});
+       CheckPointerTypes($d, "ref");
 
        if (not defined($d->{PROPERTIES}{noopnum})) {
                $thisopnum = ${$opnum};
@@ -661,12 +661,6 @@ sub ParseInterface($)
                $idl->{PROPERTIES}->{pointer_default} = "unique";
        }
 
-       if (not has_property($idl, "pointer_default_top")) {
-               $idl->{PROPERTIES}->{pointer_default_top} = "ref";
-       } else {
-               warning($idl, "pointer_default_top() is a pidl extension and should not be used");
-       }
-
        foreach my $d (@{$idl->{DATA}}) {
                if ($d->{TYPE} eq "FUNCTION") {
                        push (@functions, ParseFunction($idl, $d, \$opnum));
@@ -824,7 +818,6 @@ my %property_list = (
        "uuid"                  => ["INTERFACE"],
        "endpoint"              => ["INTERFACE"],
        "pointer_default"       => ["INTERFACE"],
-       "pointer_default_top"   => ["INTERFACE"],
        "helper"                => ["INTERFACE"],
        "authservice"           => ["INTERFACE"],
 
index 735d929e279313931d0e2d223b85965355c0caf0..11b585c1184228fdad4d04bbb9590ba017e1ab40 100755 (executable)
@@ -19,9 +19,3 @@ sub parse_idl($)
 
 test_warnings("", sub {parse_idl("void x();"); });
 test_warnings("nofile:0: top-level [out] pointer `x' is not a [ref] pointer\n", sub {parse_idl("void x([out,unique] int *x);"); });
-
-test_warnings("nofile:0: pointer_default_top() is a pidl extension and should not be used\n", sub {
-       my $pidl = Parse::Pidl::IDL::parse_string("[pointer_default_top(unique)] interface echo { void x(); }; ", "nofile");
-       Parse::Pidl::NDR::Parse($pidl);
-});
-