heimdal: Use krb5_free_default_realm() for free()
authorSantosh Kumar Pradhan <spradhan@redhat.com>
Fri, 21 Feb 2014 04:18:31 +0000 (09:48 +0530)
committerNicolas Williams <nico@cryptonector.com>
Wed, 17 Jun 2015 22:41:26 +0000 (17:41 -0500)
The resource allocated by krb5_default_default_realm() should be
free()'d by krb5_free_default_realm() instead of plain free()
for better readability.

Signed-off-by: Santosh Kumar Pradhan <spradhan@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
lib/krb5/principal.c

index fca19d52bf564fccd77e2428a8236c427365ac0a..2ce5c7cc19a9b1ff16280cf115d682ceeea767f5 100644 (file)
@@ -360,7 +360,7 @@ exit:
        free(comp[--n]);
     }
     free(comp);
-    free(realm);
+    krb5_free_default_realm(context, realm);
     free(s);
     return ret;
 }
@@ -449,7 +449,7 @@ unparse_name_fixed(krb5_context context,
            return ret;
        if(strcmp(princ_realm(principal), r) != 0)
            short_form = 0;
-       free(r);
+       krb5_free_default_realm(context, r);
     }
     if(!short_form && !no_realm) {
        add_char(name, idx, len, '@');
@@ -747,7 +747,7 @@ krb5_make_principal(krb5_context context,
     ret = krb5_build_principal_va(context, principal, strlen(realm), realm, ap);
     va_end(ap);
     if(r)
-       free(r);
+       krb5_free_default_realm(context, r);
     return ret;
 }