pytest: s3_net_join: avoid name clash
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 19 Aug 2021 23:26:02 +0000 (11:26 +1200)
committerStefan Metzmacher <metze@samba.org>
Wed, 20 Oct 2021 12:02:33 +0000 (12:02 +0000)
The net_join test uses "NetJoinTest" (and doesn't properly clean up),
we must use a unique name for this test in s3_net_join.py.

[abartlet@samba.org The hilarious naming conventions come from a time when samba-tool
was known as "net" in the s4 branch]

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14869

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
python/samba/tests/s3_net_join.py

index dd691e4a116d588c5cbb8189180571c917803d16..cdb414c75dc4917e11a7c10540c75c5cd12b28f0 100644 (file)
@@ -49,7 +49,7 @@ class NetS3JoinTests(samba.tests.TestCaseInTempDir):
         super(NetS3JoinTests, self).tearDown()
 
     def test_net_join(self):
-        netbios_name = "NetJoinTest"
+        netbios_name = "S3NetJoinTest"
         machinepass  = "abcdefghij"
         creds = self.insta_creds(template=self.get_credentials(),
                                  kerberos_state=DONT_USE_KERBEROS)