waf: moved the -Wl,-no-undefined flags to source4 and ldb

moved it out of the general waf build as the s3 waf build cannot yet
handle linking with -Wl,-no-undefined

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Oct 25 01:12:15 UTC 2010 on sn-devel-104

diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index ea2ef0980687720e77117343ab1a6976d9c1bfa9..34acfdd1a9f597d9f0b423d361c7a53be5de617d 100644 (file)
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -577,8 +577,6 @@ def SAMBA_CONFIG_H(conf, path=None):
         # we add these here to ensure that -Wstrict-prototypes is not set during configure
         conf.ADD_CFLAGS('-Wall -g -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align -Wwrite-strings -Werror-implicit-function-declaration -Wformat=2 -Wno-format-y2k',
                         testflags=True)
-        conf.ADD_LDFLAGS('-Wl,-no-undefined', testflags=True)
-
 
     if Options.options.picky_developer:
         conf.ADD_CFLAGS('-Werror', testflags=True)

diff --git a/source4/lib/ldb/wscript b/source4/lib/ldb/wscript
index fe468102d95aa3c19766f1a6fec1f477b51d461d..502d49271355b2c8bb32ff0c6bf17537523a8f7d 100644 (file)
--- a/source4/lib/ldb/wscript
+++ b/source4/lib/ldb/wscript
@@ -60,6 +60,10 @@ def configure(conf):
 
     conf.DEFINE('HAVE_CONFIG_H', 1, add_to_cflags=True)
 
+    # we don't want any libraries or modules to rely on runtime
+    # resolution of symbols
+    conf.ADD_LDFLAGS('-Wl,-no-undefined', testflags=True)
+
     conf.SAMBA_CONFIG_H()
 
 def build(bld):

diff --git a/source4/wscript b/source4/wscript
index 10c53a3d21ebdbe5c4911d818467616dc14ed9d5..c419c16af2bf49282a39304e52b2bf3292728d33 100644 (file)
--- a/source4/wscript
+++ b/source4/wscript
@@ -116,6 +116,10 @@ def configure(conf):
     conf.RECURSE('../pidl')
     conf.RECURSE('selftest')
 
+    # we don't want any libraries or modules to rely on runtime
+    # resolution of symbols
+    conf.ADD_LDFLAGS('-Wl,-no-undefined', testflags=True)
+
     # we don't want PYTHONDIR in config.h, as otherwise changing
     # --prefix causes a complete rebuild
     del(conf.env.defines['PYTHONDIR'])