mount.cifs: don't leak passwords with verbose option
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:05:00 +0000 (07:05 -0400)
committerKarolin Seeger <kseeger@samba.org>
Mon, 28 Sep 2009 18:35:31 +0000 (20:35 +0200)
commit1c2a816df9fd9e3a3839a679a72b3041b0217dc3
treedc8bf898a71fa1e1252132e31f6946ac9d06d223
parent87fe29ca3239492126a99e1562db673ea7ca208b
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
Part 2/2 of a fix for CVE-2009-2948.
source/client/mount.cifs.c