ira/third_party.git
10 years agoRemove uid_wrapper related code.
Andreas Schneider [Wed, 3 Jul 2013 10:52:52 +0000 (12:52 +0200)]
Remove uid_wrapper related code.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agolib: Change uid_wrapper to preloadable version.
Andreas Schneider [Fri, 17 Jan 2014 13:43:01 +0000 (14:43 +0100)]
lib: Change uid_wrapper to preloadable version.

This imports version 1.0.1 of uid_wrapper.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoreplace: Add uid_wrapper_enabled().
Andreas Schneider [Fri, 17 Jan 2014 14:23:54 +0000 (15:23 +0100)]
replace: Add uid_wrapper_enabled().

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agolib-util: rename memdup to smb_memdup and fix all callers
Björn Baumbach [Mon, 14 Apr 2014 12:37:29 +0000 (14:37 +0200)]
lib-util: rename memdup to smb_memdup and fix all callers

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Volker Lendecke <vl@samba.org>
10 years agoauth: Remove plaintext OSF1 password support
Andrew Bartlett [Wed, 22 Jan 2014 02:40:19 +0000 (15:40 +1300)]
auth: Remove plaintext OSF1 password support

The WAF build does not have the code to detect getprpwnam on which
this is based, and so this is dead code.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
10 years agolibs: s3 and s4: make our dns lookup code signal-safe.
Jeremy Allison [Wed, 9 Apr 2014 22:27:45 +0000 (15:27 -0700)]
libs: s3 and s4: make our dns lookup code signal-safe.

Cope with -1,EINTR returns. Needed as this code can be
called from inside smbd.

Also fixes a bug in not checking the return from poll()
correctly.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 10 22:06:08 CEST 2014 on sn-devel-104

10 years agotdb: consolidate tdb allocation code - re-use dead records at hash top.
Michael Adam [Wed, 19 Mar 2014 12:38:17 +0000 (13:38 +0100)]
tdb: consolidate tdb allocation code - re-use dead records at hash top.

When in tdb_store we re-use a dead record reactivated from the
target hash chain itself, we currently leave it in its place in
the chain. When we re-use a dead record from a different chain or
from the freelist instead, we insert it at the beginning of the
target chain.

This patch changes the behaviour to always newly store a
record at the beginning of the hash chain. This removes
a special case and hence simplifies the allocation code.
On the other hand side, it introduces two additioal tdb_ofs_write
calls for the in-chain-case.

Note the subtelty of the patch that by moving the case of the candidate
record's chain as new case "i=0" into the for loop, we also reverse the
order of the two steps in the for-loop body (non blocking freelist alloc
and searching for dead record in a chain) in order to keep the overall
order of execution identical.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Apr  9 10:37:08 CEST 2014 on sn-devel-104

10 years agotalloc: Update flags in pytalloc-util pkgconfig file
Lukas Slebodnik [Fri, 4 Apr 2014 11:29:39 +0000 (13:29 +0200)]
talloc: Update flags in pytalloc-util pkgconfig file

After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is
used on install. But "-Wl," will be passed to linker and should not be among
CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place.
    @see commit 735c1cd2da15167748e92ba6de48fdb5169db587

Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr  4 23:50:25 CEST 2014 on sn-devel-104

10 years agotevent: Update flags in tevent pkgconfig file
Lukas Slebodnik [Fri, 4 Apr 2014 11:27:35 +0000 (13:27 +0200)]
tevent: Update flags in tevent pkgconfig file

After exapnding, @LIB_RPATH@ will be -Wl,-rpatch,/usr/local/lib if rpath is
used on install. But "-Wl," will be passed to linker and should not be among
CFLAGS. Other pkgconfig files have @LIB_RPATH@ in the right place.
    @see commit 735c1cd2da15167748e92ba6de48fdb5169db587

Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agolib/param: Add new parameter "old password allowed period"
Andrew Bartlett [Mon, 9 Dec 2013 01:23:49 +0000 (14:23 +1300)]
lib/param: Add new parameter "old password allowed period"

Change-Id: I46228b492ba71ba4f3fee380a1ccadb328e3ade1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoldb_ildap: Map some wrong username/password errors on to LDB_ERR_INVALID_CREDENTIALS
Andrew Bartlett [Mon, 25 Nov 2013 01:09:26 +0000 (14:09 +1300)]
ldb_ildap: Map some wrong username/password errors on to LDB_ERR_INVALID_CREDENTIALS

This is better than just LDB_ERR_OPERATIONS_ERROR for all errors.

Andrew Bartlett

Change-Id: Id832cf02fcd1dc0347d5ab9eb9a2db78fda39dc6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodlinklist: Fix a typo
Volker Lendecke [Wed, 2 Apr 2014 12:52:01 +0000 (14:52 +0200)]
dlinklist: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Apr  2 17:11:37 CEST 2014 on sn-devel-104

10 years agolib/socket_wrapper: explicitly use allow_warnings=True
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/socket_wrapper: explicitly use allow_warnings=True

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/zlib: explicitly use allow_warnings=True
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/zlib: explicitly use allow_warnings=True

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/popt: explicitly use allow_warnings=True
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/popt: explicitly use allow_warnings=True

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/ldb: explicitly use allow_warnings=True
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/ldb: explicitly use allow_warnings=True

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/ntdb: explicitly use allow_warnings=True for ntdb-test-helpers
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/ntdb: explicitly use allow_warnings=True for ntdb-test-helpers

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/ccan: explicitly use allow_warnings=True
Stefan Metzmacher [Wed, 26 Feb 2014 06:35:22 +0000 (07:35 +0100)]
lib/ccan: explicitly use allow_warnings=True

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/tevent/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/tevent/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/tdr/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/tdr/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/socket_wrapper/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/socket_wrapper/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/nss_wrapper/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/nss_wrapper/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/util/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/util/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/compression/tests: add missing #include "torture/local/proto.h"
Stefan Metzmacher [Thu, 27 Feb 2014 08:08:17 +0000 (09:08 +0100)]
lib/compression/tests: add missing #include "torture/local/proto.h"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/util: fix const warnings
Stefan Metzmacher [Wed, 26 Feb 2014 06:38:07 +0000 (07:38 +0100)]
lib/util: fix const warnings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/util: declare smb_panic_default() as _NORETURN_
Stefan Metzmacher [Wed, 26 Feb 2014 06:37:13 +0000 (07:37 +0100)]
lib/util: declare smb_panic_default() as _NORETURN_

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb/wscript: maintain a global list of unit tests
Stefan Metzmacher [Mon, 3 Feb 2014 09:40:45 +0000 (10:40 +0100)]
tdb/wscript: maintain a global list of unit tests

This makes sure a new test is also added to 'make test'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb/test: avoid const warnings by using 'discard_const_p(uint8_t,' instead of '(void *)'
Stefan Metzmacher [Mon, 3 Feb 2014 10:31:05 +0000 (11:31 +0100)]
tdb/test: avoid const warnings by using 'discard_const_p(uint8_t,' instead of '(void *)'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb/test: remove "\n" in diag() arguments
Stefan Metzmacher [Thu, 30 Jan 2014 12:20:33 +0000 (13:20 +0100)]
tdb/test: remove "\n" in diag() arguments

diag() already adds "\n".

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb/test: always call fflush() after [f]printf() in tap-interface.h
Stefan Metzmacher [Thu, 30 Jan 2014 12:01:08 +0000 (13:01 +0100)]
tdb/test: always call fflush() after [f]printf() in tap-interface.h

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb/tools: avoid const warnings in tdbdump.c
Stefan Metzmacher [Mon, 3 Feb 2014 10:30:12 +0000 (11:30 +0100)]
tdb/tools: avoid const warnings in tdbdump.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb: don't alter errno on success of tdb_open_ex()
Stefan Metzmacher [Thu, 30 Jan 2014 15:07:10 +0000 (16:07 +0100)]
tdb: don't alter errno on success of tdb_open_ex()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agolib/zlib: make use of conf.CHECK_BUNDLED_SYSTEM()
Stefan Metzmacher [Fri, 14 Mar 2014 09:34:00 +0000 (10:34 +0100)]
lib/zlib: make use of conf.CHECK_BUNDLED_SYSTEM()

This way --bundled-libraries=ALL will use the internal zlib version.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agotdb_wrap: Remove tdb_wrap_open_ again
Volker Lendecke [Wed, 26 Mar 2014 14:41:03 +0000 (14:41 +0000)]
tdb_wrap: Remove tdb_wrap_open_ again

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agodbwrap: Avoid passing lp_ctx to tdb_wrap_open in db_open_tdb
Volker Lendecke [Wed, 26 Mar 2014 14:26:24 +0000 (14:26 +0000)]
dbwrap: Avoid passing lp_ctx to tdb_wrap_open in db_open_tdb

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: Add lpcfg_tdb_flags()
Volker Lendecke [Wed, 26 Mar 2014 14:06:08 +0000 (14:06 +0000)]
param: Add lpcfg_tdb_flags()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: Add lpcfg_tdb_hash_size()
Volker Lendecke [Wed, 26 Mar 2014 14:04:41 +0000 (14:04 +0000)]
param: Add lpcfg_tdb_hash_size()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agolib: Add interim tdb_wrap_open_ without lp_ctx
Volker Lendecke [Wed, 26 Mar 2014 13:36:48 +0000 (13:36 +0000)]
lib: Add interim tdb_wrap_open_ without lp_ctx

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agolib: Pull up lp_ctx use one level
Volker Lendecke [Wed, 26 Mar 2014 13:32:16 +0000 (13:32 +0000)]
lib: Pull up lp_ctx use one level

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agolib/util: let is_ipaddress_v6() cope with "fe80::1234%3"
Stefan Metzmacher [Thu, 13 Feb 2014 18:51:30 +0000 (19:51 +0100)]
lib/util: let is_ipaddress_v6() cope with "fe80::1234%3"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
10 years agos3:param: move lp_ctdbd_socket() to ctdbd_conn.c
Stefan Metzmacher [Tue, 8 Oct 2013 11:33:49 +0000 (13:33 +0200)]
s3:param: move lp_ctdbd_socket() to ctdbd_conn.c

This allows us to use CTDB_PATH only in ctdbd_conn.c

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agotdb: change version to 1.2.13.
Michael Adam [Tue, 18 Mar 2014 12:05:42 +0000 (13:05 +0100)]
tdb: change version to 1.2.13.

* internal code cleanups
* always open internal TDBs with incompatible hash
* avoid reallocations in locking code
* systematize output format in tdbtool dump
* reduce freelist contention when allocating new records
  - try to find dead records also in other chains
  - don't do blocking locks on the freelist

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Mar 18 15:42:48 CET 2014 on sn-devel-104

10 years agotdb: Reduce freelist contention
Volker Lendecke [Tue, 18 Mar 2014 07:04:42 +0000 (08:04 +0100)]
tdb: Reduce freelist contention

In a metadata-intensive benchmark we have seen the locking.tdb freelist to be
one of the central contention points. This patch removes most of the contention
on the freelist. Ages ago we already reduced freelist contention by using the
even much older DEAD records: If TDB_VOLATILE is set, don't directly put
deleted records on the freelist, but just mark a few of them just as DEAD. The
next new record can them re-use that space without consulting the freelist.

This patch builds upon the DEAD records: If we need space and the freelist is
busy, instead of doing a blocking wait on the freelist, start looking into
other chains for DEAD records and steal them from there. This way every hash
chain becomes a small freelist. Just wander around the hash chains as long as
the freelist is still busy.

With this patch and the tdb mutex patch (following hopefully some time soon)
you can see a heavily busy clustered smbd run without locking.tdb futex
syscalls.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Make "tdb_purge_dead" internally public
Volker Lendecke [Tue, 18 Mar 2014 07:03:16 +0000 (08:03 +0100)]
tdb: Make "tdb_purge_dead" internally public

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Make "tdb_find_dead" internally public
Volker Lendecke [Tue, 18 Mar 2014 07:01:40 +0000 (08:01 +0100)]
tdb: Make "tdb_find_dead" internally public

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Add "last_ptr" to tdb_find_dead
Volker Lendecke [Tue, 18 Mar 2014 07:00:45 +0000 (08:00 +0100)]
tdb: Add "last_ptr" to tdb_find_dead

Will be used soon to unlink a dead record from a chain

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Move adding tailer space to tdb_find_dead
Volker Lendecke [Tue, 18 Mar 2014 06:52:59 +0000 (07:52 +0100)]
tdb: Move adding tailer space to tdb_find_dead

This aligns the tdb_find_dead API with the tdb_allocate API and thus makes it a
bit easier to understand, at least for me.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Do a best fit search for dead records
Volker Lendecke [Tue, 18 Mar 2014 06:46:38 +0000 (07:46 +0100)]
tdb: Do a best fit search for dead records

Hash chains are (or can be made) short enough that a full search for the
best-fitting dead record is feasible. The freelist can become much longer,
there we don't do the full search but accept records which are too large.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Don't purge records to a blocked freelist
Volker Lendecke [Mon, 17 Mar 2014 05:47:11 +0000 (06:47 +0100)]
tdb: Don't purge records to a blocked freelist

If the freelist is heavily contended, we should avoid accessing it

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: Fix a tdb corruption
Volker Lendecke [Sun, 16 Mar 2014 20:08:32 +0000 (20:08 +0000)]
tdb: Fix a tdb corruption

tdb_purge_dead can change the next pointer of "rec" if we purge the record
right behind the current record to be deleted. Just overwrite the magic,
not the whole record with stale data.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agolib/popt: Patch memory leak in popthelp.c
Jose A. Rivera [Mon, 3 Mar 2014 06:22:46 +0000 (11:52 +0530)]
lib/popt: Patch memory leak in popthelp.c

Memory created as "t" was not being free'd.

Change-Id: I5f6e20acc6c440a1cd9908aed7a90de2000f22f8
Coverity-Id: 240599
Coverity-Id: 240600
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
10 years agolib/popt: Small whitespace fix for readability.
Jose A. Rivera [Mon, 3 Mar 2014 06:19:55 +0000 (11:49 +0530)]
lib/popt: Small whitespace fix for readability.

Change-Id: Ib920f7e84c0247a8f09aa4c79c65b26afb78f234
Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
10 years agoparam: remove lp_dnsdomain from s3
Garming Sam [Fri, 24 Jan 2014 04:39:41 +0000 (17:39 +1300)]
param: remove lp_dnsdomain from s3

With the use of the shared globals structure, lp_dnsdomain is no longer used in the code and removing it would remove a notable special case

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: I59526c40c58e132a134d67fa7944dfeacd05f4c6
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
10 years agoparam: change s3_param.h from a generated file to a static one
Garming Sam [Fri, 24 Jan 2014 03:45:31 +0000 (16:45 +1300)]
param: change s3_param.h from a generated file to a static one

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: I131e37ec92f7a826caec382023915c5e4b4c52be
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
10 years agoparam: use loadparm_globals struct instead of lp function pointers in s3_helpers
Garming Sam [Fri, 24 Jan 2014 02:38:59 +0000 (15:38 +1300)]
param: use loadparm_globals struct instead of lp function pointers in s3_helpers

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: I4507cdbf111b7f9dca3ca18ee2bf242ffdfeb4e7
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
10 years agolib/param: rename lp_string to lpcfg_string
Garming Sam [Thu, 13 Feb 2014 21:23:36 +0000 (10:23 +1300)]
lib/param: rename lp_string to lpcfg_string

This avoids the confusion with lp_string in source3.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: Ic6df23b9e5986f7d1fd6253e30ebfdc1a3a45a41
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
10 years agolib/param: handle non-constant strings properly by passing in a memory context
Garming Sam [Thu, 16 Jan 2014 21:30:37 +0000 (10:30 +1300)]
lib/param: handle non-constant strings properly by passing in a memory context

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: Ic6bb1c709defd2b0f35fc7b877da0badca385776
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
10 years agobuild: find FILE_OFFSET_BITS via array
Gustavo Zacarias [Fri, 31 Jan 2014 09:53:44 +0000 (06:53 -0300)]
build: find FILE_OFFSET_BITS via array

This makes cross-compiling happy, use a trick similar to autoconf's
AC_CHECK_SIZEOF macro.
Basically we make an array:

static int array[1 - 2 * !(((long int)(sizeof(off_t))) < 8)];

This gives -1 multiplied by the negation of the condition
(sizeof(off_t) < 8) cast to a long int.
So if the condition is true it gives array[(-1 * 0)] (remember the
condition is cast and negated) thus passing a build test with a 0-sized
array.
If it's false it gives array[(-1 * 1)] thus failing with a
negative-sized array.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Feb 18 23:18:32 CET 2014 on sn-devel-104

10 years agotdb: always open internal databases with incompatible hash.
Michael Adam [Mon, 10 Feb 2014 15:23:48 +0000 (16:23 +0100)]
tdb: always open internal databases with incompatible hash.

This makes them more efficient due to better distribution
of keys across hash chains.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Feb 15 08:26:07 CET 2014 on sn-devel-104

10 years agotdb: in tdb_delete_hash, make lock/unlock bracket more obvious
Michael Adam [Thu, 13 Feb 2014 16:03:46 +0000 (17:03 +0100)]
tdb: in tdb_delete_hash, make lock/unlock bracket more obvious

by using the same variable as hash as in the lock.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Feb 15 03:21:07 CET 2014 on sn-devel-104

10 years agotdb: simplify tdb_delete_hash() a bit
Michael Adam [Thu, 13 Feb 2014 15:48:35 +0000 (16:48 +0100)]
tdb: simplify tdb_delete_hash() a bit

Make the lock/unlock bracket more obvious by extracting
locking (and finding) from the special cases to the top
of the function. This also lets us take lock and find
the record outside the special case branches (use dead
records or not).

There is a small semantic change implied:

In the dead records case, the record to delete is looked
up before the current dead records are potentially purged.
Hence, if the record to delete is not found, the dead
records are also not purge. This does not make a big
difference though, because purging is only delayed until
directly befor the next record to delete is in fact found.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agotdb: tdbtool: dump record magic with fixed number of 8 hex digits
Michael Adam [Wed, 12 Feb 2014 10:14:26 +0000 (11:14 +0100)]
tdb: tdbtool: dump record magic with fixed number of 8 hex digits

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agotdb: tdbtool: dump record hash with fixed number of 8 hex digits
Michael Adam [Wed, 12 Feb 2014 10:13:18 +0000 (11:13 +0100)]
tdb: tdbtool: dump record hash with fixed number of 8 hex digits

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agowaf:lib/replace fix iconv checks on HP/UX
Christian Ambach [Wed, 29 Jan 2014 19:48:38 +0000 (20:48 +0100)]
waf:lib/replace fix iconv checks on HP/UX

we need to copy away the list of LDFLAGS
to be tried before modifying it instead of
just creating a new reference and then continuing
with a modified list while it should have been
reset back to the original value

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9911

Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb 13 02:01:03 CET 2014 on sn-devel-104

10 years agoparam: Move LOADPARM_EXTRA_GLOBALS to lib/param/loadparm.h to be shared between loadparms
Garming Sam [Thu, 16 Jan 2014 00:44:22 +0000 (13:44 +1300)]
param: Move LOADPARM_EXTRA_GLOBALS to lib/param/loadparm.h to be shared between loadparms

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: move SMB2 defaults to lib/param and use in loadparm_init
Garming Sam [Thu, 16 Jan 2014 00:32:42 +0000 (13:32 +1300)]
param: move SMB2 defaults to lib/param and use in loadparm_init

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: remove special cases for tls files
Garming Sam [Thu, 16 Jan 2014 00:13:11 +0000 (13:13 +1300)]
param: remove special cases for tls files

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: use generate_param.py to generate s3_param.h
Garming Sam [Wed, 15 Jan 2014 04:52:41 +0000 (17:52 +1300)]
param: use generate_param.py to generate s3_param.h

Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: use generate_param.py to generate param_local.h
Garming Sam [Wed, 15 Jan 2014 04:45:46 +0000 (17:45 +1300)]
param: use generate_param.py to generate param_local.h

Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: use generate_param.py to generate param_global.h
Garming Sam [Wed, 15 Jan 2014 04:39:48 +0000 (17:39 +1300)]
param: use generate_param.py to generate param_global.h

Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: No longer have a special case for lp_configfile
Andrew Bartlett [Wed, 15 Jan 2014 04:29:57 +0000 (17:29 +1300)]
param: No longer have a special case for lp_configfile

This parameter is renamed because it does not normally return the current smb.conf file, but
instead returns the next one, as found in a config file = directive, to be loaded.

This avoids a conflict with the lpcfg_configfile from lib/param, which does refer to the
current smb.conf path.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: generate the param_functions.h containing the prototypes
Garming Sam [Wed, 15 Jan 2014 04:18:13 +0000 (17:18 +1300)]
lib/param: generate the param_functions.h containing the prototypes

Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: explicitly use mode=FUNCTIONS when running generate_param.py
Garming Sam [Wed, 15 Jan 2014 03:54:29 +0000 (16:54 +1300)]
lib/param: explicitly use mode=FUNCTIONS when running generate_param.py

Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Remove special handling for 'state dir' and 'cache dir'
Andrew Bartlett [Wed, 15 Jan 2014 02:59:54 +0000 (15:59 +1300)]
lib/param: Remove special handling for 'state dir' and 'cache dir'

The build system gives these two parameters different defaults
(compared with lock dir) in both the --enable-fhs and default mode, so
the logic to use lock dir no longer applies unless the build has been
very specially constructed.

Therefore, remove the special case handling and make these normal
parameters again.

Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Normalise "read raw" and "write raw" parameters
Andrew Bartlett [Wed, 15 Jan 2014 01:48:40 +0000 (14:48 +1300)]
lib/param: Normalise "read raw" and "write raw" parameters

They have been changed to function like normal parameters,
removing a special case in the loadparm system.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: auto generate param_functions.c at build time
Garming Sam [Tue, 14 Jan 2014 04:53:49 +0000 (17:53 +1300)]
param: auto generate param_functions.c at build time

generate_param.py reads the documentation to define which functions need to
be generated.

To add new parameters, edit the xml files in docs-xml/smbdotconf.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/ldb-samba: add more attributes with LDB_SYNTAX_SAMBA_GUID
Stefan Metzmacher [Wed, 29 Jan 2014 07:24:11 +0000 (08:24 +0100)]
lib/ldb-samba: add more attributes with LDB_SYNTAX_SAMBA_GUID

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
10 years agolib/param: Mark source code generators as group build_source
Andrew Bartlett [Mon, 3 Feb 2014 03:44:32 +0000 (16:44 +1300)]
lib/param: Mark source code generators as group build_source

Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Feb 10 05:56:58 CET 2014 on sn-devel-104

10 years agoparam: rename and move log level from LOADPARM_EXTRA_GLOBALS to param_functions.c
Garming Sam [Fri, 10 Jan 2014 02:06:41 +0000 (15:06 +1300)]
param: rename and move log level from LOADPARM_EXTRA_GLOBALS to param_functions.c

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agoparam: rename and move usershare template parameter from LOADPARM_EXTRA_GLOBALS to...
Garming Sam [Fri, 10 Jan 2014 01:34:43 +0000 (14:34 +1300)]
param: rename and move usershare template parameter from LOADPARM_EXTRA_GLOBALS to param_functions.c

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Kamen Mazdrashki <kamenim@samba.org>
10 years agoparam: rename lp function and variable from "nis_home_map" to "nis_homedir"
Garming Sam [Tue, 4 Feb 2014 02:09:04 +0000 (15:09 +1300)]
param: rename lp function and variable from "nis_home_map" to "nis_homedir"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Feb  8 03:31:34 CET 2014 on sn-devel-104

10 years agoparam: rename lp function and variable from "syncalways" to "sync_always"
Garming Sam [Tue, 4 Feb 2014 02:09:12 +0000 (15:09 +1300)]
param: rename lp function and variable from "syncalways" to "sync_always"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "minprintspace" to "min_print_space"
Garming Sam [Tue, 4 Feb 2014 02:09:12 +0000 (15:09 +1300)]
param: rename lp function and variable from "minprintspace" to "min_print_space"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "maxdisksize" to "max_disk_size"
Garming Sam [Tue, 4 Feb 2014 02:09:12 +0000 (15:09 +1300)]
param: rename lp function and variable from "maxdisksize" to "max_disk_size"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "writelist" to "write_list"
Garming Sam [Tue, 4 Feb 2014 02:09:11 +0000 (15:09 +1300)]
param: rename lp function and variable from "writelist" to "write_list"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "usernamelevel" to "username_level"
Garming Sam [Tue, 4 Feb 2014 02:09:11 +0000 (15:09 +1300)]
param: rename lp function and variable from "usernamelevel" to "username_level"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "rootdir" to "root_directory"
Garming Sam [Tue, 4 Feb 2014 02:09:11 +0000 (15:09 +1300)]
param: rename lp function and variable from "rootdir" to "root_directory"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "renameuser_script" to "rename_user_script"
Garming Sam [Tue, 4 Feb 2014 02:09:11 +0000 (15:09 +1300)]
param: rename lp function and variable from "renameuser_script" to "rename_user_script"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "readlist" to "read_list"
Garming Sam [Tue, 4 Feb 2014 02:09:10 +0000 (15:09 +1300)]
param: rename lp function and variable from "readlist" to "read_list"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "onlyuser" to "only_user"
Garming Sam [Tue, 4 Feb 2014 02:09:10 +0000 (15:09 +1300)]
param: rename lp function and variable from "onlyuser" to "only_user"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "inherit_perms" to "inherit_permissions"
Garming Sam [Tue, 4 Feb 2014 02:09:10 +0000 (15:09 +1300)]
param: rename lp function and variable from "inherit_perms" to "inherit_permissions"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "encrypted_passwords" to "encrypt_passwords"
Garming Sam [Tue, 4 Feb 2014 02:09:10 +0000 (15:09 +1300)]
param: rename lp function and variable from "encrypted_passwords" to "encrypt_passwords"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "srv_minprotocol" to "server_min_protocol"
Garming Sam [Tue, 4 Feb 2014 02:09:09 +0000 (15:09 +1300)]
param: rename lp function and variable from "srv_minprotocol" to "server_min_protocol"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "srv_maxprotocol" to "server_max_protocol"
Garming Sam [Tue, 4 Feb 2014 02:09:09 +0000 (15:09 +1300)]
param: rename lp function and variable from "srv_maxprotocol" to "server_max_protocol"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "maxmux" to "max_mux"
Garming Sam [Tue, 4 Feb 2014 02:09:09 +0000 (15:09 +1300)]
param: rename lp function and variable from "maxmux" to "max_mux"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "cli_minprotocol" to "client_min_protocol"
Garming Sam [Tue, 4 Feb 2014 02:09:08 +0000 (15:09 +1300)]
param: rename lp function and variable from "cli_minprotocol" to "client_min_protocol"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "cli_maxprotocol" to "client_max_protocol"
Garming Sam [Tue, 4 Feb 2014 02:09:08 +0000 (15:09 +1300)]
param: rename lp function and variable from "cli_maxprotocol" to "client_max_protocol"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "ms_add_printer_wizard" to "show_add_prin...
Garming Sam [Tue, 4 Feb 2014 02:09:08 +0000 (15:09 +1300)]
param: rename lp function and variable from "ms_add_printer_wizard" to "show_add_printer_wizard"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "queueresumecommand" to "queueresume_command"
Garming Sam [Tue, 4 Feb 2014 02:09:08 +0000 (15:09 +1300)]
param: rename lp function and variable from "queueresumecommand" to "queueresume_command"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agoparam: rename lp function and variable from "queuepausecommand" to "queuepause_command"
Garming Sam [Tue, 4 Feb 2014 02:09:07 +0000 (15:09 +1300)]
param: rename lp function and variable from "queuepausecommand" to "queuepause_command"

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>