Fix memleaks related to get_dirname
authorPeter Wu <peter@lekensteyn.nl>
Wed, 3 Feb 2016 17:28:46 +0000 (18:28 +0100)
committerAnders Broman <a.broman58@gmail.com>
Thu, 4 Feb 2016 04:57:30 +0000 (04:57 +0000)
commit8899e006aab3e0831214d187596eef450b5e21b7
tree83b3aebc1c31dcdbd89cb229202b186e6fc57356
parent36cf75efb15827c801c4e82c8ab3ed16f3e00749
Fix memleaks related to get_dirname

get_dirname may return NULL instead of the original string, so avoid
patterns like get_dirname(strdup(x)). Writing to
cf_path.toUtf8().data() is fine btw, toUtf8() returns new memory.

This fixes two memleak reported by LeakSanitizer via fileset_add_dir and
MainWindow::captureFileReadFinished (both via cf_callback_invoke).

Change-Id: I0f1528763e77e1f55b54b6674c890a9d02302ee8
Reviewed-on: https://code.wireshark.org/review/13691
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
fileset.c
ui/gtk/main.c
ui/qt/main_window.cpp
ui/qt/main_window_slots.cpp
wireshark-qt.cpp