git.samba.org / gd / wireshark / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 23b1100) | patch
GSM A-bis/OML: fix: do not use tvb_get_ntohl() to fetch IPv4 address
authorVadim Yanitskiy <axilirator@gmail.com>
Thu, 19 Dec 2019 05:09:07 +0000 (14:09 +0900)
committerAnders Broman <a.broman58@gmail.com>
Fri, 20 Dec 2019 05:21:37 +0000 (05:21 +0000)
commit88364fb2965e05c3eadb08a9b6a667c0a87313e3
tree791b98e9505c376e4b2e112df7e20a221696900ftree
parent23b11003bfdd756a376046b4c350069fbbc7e073commit | diff
GSM A-bis/OML: fix: do not use tvb_get_ntohl() to fetch IPv4 address

As per doc/README.dissector, the IPv4 addresses shall not be converted
to host byte order before being passed to proto_tree_add_ipv4(). Due
to this bug, the IPA Destination IP Address was displayed wrong.

Change-Id: I2dd96590bbd736a8bfe05502d6803813838c6c59
Bug: 16282
Reviewed-on: https://code.wireshark.org/review/35501
Reviewed-by: Anders Broman <a.broman58@gmail.com>
epan/dissectors/packet-gsm_abis_oml.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.