util_tdb: mark tdb_pack() and friends as deprecated

Following a discussion[1] with Volker, add a note to the tdb_unpack()
and tdb_pack[_append]() prototypes describing them as deprecated.

1. https://lists.samba.org/archive/samba-technical/2015-March/106548.html

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Mar 25 11:05:02 CET 2015 on sn-devel-104

diff --git a/source3/include/util_tdb.h b/source3/include/util_tdb.h
index 13bdeab3784eb1ba0305c7fc6696e11263c98ab1..80a8cac2ba92a2d6c4a8061c3837d1b44983e5c5 100644 (file)
--- a/source3/include/util_tdb.h
+++ b/source3/include/util_tdb.h
@@ -32,6 +32,10 @@ int tdb_trans_store(struct tdb_context *tdb, TDB_DATA key, TDB_DATA dbuf,
                    int flag);
 int tdb_trans_delete(struct tdb_context *tdb, TDB_DATA key);
 
+/*
+ * The tdb_unpack() and tdb_pack[_append]() helpers are deprecated. Consider
+ * using idl/ndr for marshalling of complex data types instead.
+ */
 int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...);
 size_t tdb_pack(uint8 *buf, int bufsize, const char *fmt, ...);
 bool tdb_pack_append(TALLOC_CTX *mem_ctx, uint8 **buf, size_t *len,