amitay/samba.git
9 years agos4-provision Add initial support for joining as a new subdomain
Andrew Bartlett [Wed, 24 Aug 2011 05:39:51 +0000 (15:39 +1000)]
s4-provision Add initial support for joining as a new subdomain

To do this we need to reorganise a lot of the provision code, so that
we can create the framework for the inbound replicaton of the config
and schema partitions and then add in the new subdomain locally.

Andrew Bartlett

9 years agoFix a typo. This is not an electromagnet pulse daemon I guess :-)
Volker Lendecke [Sun, 18 Sep 2011 21:19:41 +0000 (23:19 +0200)]
Fix a typo. This is not an electromagnet pulse daemon I guess :-)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Sep 19 01:25:23 CEST 2011 on sn-devel-104

9 years agos3: Add some const to create_local_private_krb5_conf_for_domain
Volker Lendecke [Sun, 18 Sep 2011 19:59:31 +0000 (21:59 +0200)]
s3: Add some const to create_local_private_krb5_conf_for_domain

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 23:31:28 CEST 2011 on sn-devel-104

9 years agos3: Add some const to print_kdc_line
Volker Lendecke [Sun, 18 Sep 2011 19:59:20 +0000 (21:59 +0200)]
s3: Add some const to print_kdc_line

9 years agos3:smb2cli: s/smb2cli_sesssetup/smb2cli_sesssetup_ntlmssp/
Stefan Metzmacher [Sun, 18 Sep 2011 18:09:48 +0000 (20:09 +0200)]
s3:smb2cli: s/smb2cli_sesssetup/smb2cli_sesssetup_ntlmssp/

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Sep 18 21:43:26 CEST 2011 on sn-devel-104

9 years agos3: Fix a c++ warning
Volker Lendecke [Sat, 17 Sep 2011 23:52:14 +0000 (01:52 +0200)]
s3: Fix a c++ warning

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 18:55:48 CEST 2011 on sn-devel-104

9 years agos3: Fix "ISO C90 forbids mixed declarations and code"
Volker Lendecke [Sat, 17 Sep 2011 23:50:37 +0000 (01:50 +0200)]
s3: Fix "ISO C90 forbids mixed declarations and code"

9 years agoswrap: Fix a c++ warning
Volker Lendecke [Sat, 17 Sep 2011 23:31:44 +0000 (01:31 +0200)]
swrap: Fix a c++ warning

9 years agos3: Fix two c++ warnings
Volker Lendecke [Sat, 17 Sep 2011 23:27:53 +0000 (01:27 +0200)]
s3: Fix two c++ warnings

9 years agopyldb: Drop unnecessary dependency on pytalloc-util.
Jelmer Vernooij [Sun, 18 Sep 2011 13:23:56 +0000 (15:23 +0200)]
pyldb: Drop unnecessary dependency on pytalloc-util.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Sep 18 17:23:40 CEST 2011 on sn-devel-104

9 years agos3:smb2cli: pass timeout to smb2cli_req_create/send()
Stefan Metzmacher [Sat, 17 Sep 2011 17:56:50 +0000 (19:56 +0200)]
s3:smb2cli: pass timeout to smb2cli_req_create/send()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Sep 18 07:04:05 CEST 2011 on sn-devel-104

9 years agos3:smb2cli: pass an array of expected status/body_size pairs to smb2cli_req_recv()
Stefan Metzmacher [Tue, 30 Aug 2011 22:40:06 +0000 (00:40 +0200)]
s3:smb2cli: pass an array of expected status/body_size pairs to smb2cli_req_recv()

This gives the caller more control and correctly reports unexpected
errors to the caller, instead of return NT_STATUS_INVALID_NETWOR_RESPONSE

metze

9 years agos3:smb2cli: only use tevent_req_defer_callback() if we have more than one smb2 response
Stefan Metzmacher [Wed, 7 Sep 2011 16:55:02 +0000 (18:55 +0200)]
s3:smb2cli: only use tevent_req_defer_callback() if we have more than one smb2 response

metze

9 years agos3:smb2cli: ignore async interim responses and store the async_id
Stefan Metzmacher [Sat, 17 Sep 2011 19:17:18 +0000 (21:17 +0200)]
s3:smb2cli: ignore async interim responses and store the async_id

metze

9 years agos3:smb2cli: check the response has the SMB2_HDR_FLAG_REDIRECT flag
Stefan Metzmacher [Sat, 17 Sep 2011 19:15:45 +0000 (21:15 +0200)]
s3:smb2cli: check the response has the SMB2_HDR_FLAG_REDIRECT flag

metze

9 years agos3:smb2cli: validate the opcode from the server is as expected
Stefan Metzmacher [Sat, 17 Sep 2011 19:13:58 +0000 (21:13 +0200)]
s3:smb2cli: validate the opcode from the server is as expected

metze

9 years agos3:smb2cli: initialize status if we got an unexpected response
Stefan Metzmacher [Sat, 17 Sep 2011 19:11:23 +0000 (21:11 +0200)]
s3:smb2cli: initialize status if we got an unexpected response

metze

9 years agos3:libsmb: return INTERNAL_ERROR if the request is in bad state when the caller ships it
Stefan Metzmacher [Sat, 17 Sep 2011 19:09:30 +0000 (21:09 +0200)]
s3:libsmb: return INTERNAL_ERROR if the request is in bad state when the caller ships it

metze

9 years agos3:libsmb: return if tevent_req_set_endtime() fails
Stefan Metzmacher [Sat, 17 Sep 2011 17:49:01 +0000 (19:49 +0200)]
s3:libsmb: return if tevent_req_set_endtime() fails

tevent_req_set_endtime() already calls tevent_req_nomem().

metze

9 years agos3:SMB2-BASIC: test smb2cli_flush()
Stefan Metzmacher [Sat, 17 Sep 2011 17:29:51 +0000 (19:29 +0200)]
s3:SMB2-BASIC: test smb2cli_flush()

metze

9 years agos3:smb2cli: SMB2_FLUSH responses have a body size of 4
Stefan Metzmacher [Sat, 17 Sep 2011 17:30:36 +0000 (19:30 +0200)]
s3:smb2cli: SMB2_FLUSH responses have a body size of 4

metze

9 years agos3: Trim a debug to 80 chars
Volker Lendecke [Sat, 17 Sep 2011 21:43:19 +0000 (23:43 +0200)]
s3: Trim a debug to 80 chars

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 01:15:02 CEST 2011 on sn-devel-104

9 years agos3: Fix a cut&paste error
Volker Lendecke [Sat, 17 Sep 2011 21:42:23 +0000 (23:42 +0200)]
s3: Fix a cut&paste error

9 years agos4:selftest: skip flakey samba4.drs.repl_schema.python for now
Stefan Metzmacher [Sat, 17 Sep 2011 05:06:26 +0000 (07:06 +0200)]
s4:selftest: skip flakey samba4.drs.repl_schema.python for now

UNEXPECTED(error): samba4.drs.repl_schema.python(vampire_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute
REASON: _StringException: _StringException: Content-Type: text/x-traceback;charset=utf8,language=python
traceback
49F
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/memdisk/autobuild/flakey/b12973/samba4/source4/torture/drs/python/repl_schema.py", line 179, in test_classWithCustomAttribute
    self._net_drs_replicate(DC=self.dnsname_dc2, fromDC=self.dnsname_dc1, nc_dn=self.schema_dn)
  File "/memdisk/autobuild/flakey/b12973/samba4/source4/torture/drs/python/drs_base.py", line 110, in _net_drs_replicate
    return self.check_output(cmd_line)
  File "bin/python/samba/tests/__init__.py", line 157, in check_output
    raise BlackboxProcessError(retcode, line, p.stdout.read(), p.stderr.read())
BlackboxProcessError: Command '/memdisk/autobuild/flakey/b12973/samba4/bin/samba-tool drs replicate -USAMBADOMAIN/Administrator%locDCpass1 --sync-forced LOCALVAMPIREDC.samba.example.com localdc.samba.example.com CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com'; exit status 255; stdout: ''; stderr: 'ERROR(runtime): DsReplicaSync failed - (-1073741807, 'NT_STATUS_END_OF_FILE')
'
0

As this is an error, we have to skip it instead of adding it to the knowfail file

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 17 08:43:31 CEST 2011 on sn-devel-104

9 years agos3: Fix bug 8455 -- Samba PDC is looking up only primary user group
Volker Lendecke [Fri, 16 Sep 2011 13:45:47 +0000 (15:45 +0200)]
s3: Fix bug 8455 -- Samba PDC is looking up only primary user group

group_sids_to_info3 does a sid_peek_check_rid on the domain sid before adding
the rids to the array. If the domain sid is 0x0, then the check will always
fail.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Sep 17 00:51:27 CEST 2011 on sn-devel-104

9 years agolibcli/smb: add SMB2_DIALECT_REVISION_222
Stefan Metzmacher [Fri, 16 Sep 2011 14:12:24 +0000 (16:12 +0200)]
libcli/smb: add SMB2_DIALECT_REVISION_222

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Sep 16 19:51:47 CEST 2011 on sn-devel-104

9 years agolibcli/smb: add PROTOCOL_SMB2_22
Stefan Metzmacher [Fri, 16 Sep 2011 14:11:47 +0000 (16:11 +0200)]
libcli/smb: add PROTOCOL_SMB2_22

metze

9 years agos3:libsmb: forward declaration for struct smb_trans_enc_state
Stefan Metzmacher [Thu, 15 Sep 2011 15:56:04 +0000 (17:56 +0200)]
s3:libsmb: forward declaration for struct smb_trans_enc_state

metze

9 years agos3-waf: finally make SO_PEERCRED configure check work with stricter CFLAGS.
Günther Deschner [Fri, 16 Sep 2011 10:35:58 +0000 (12:35 +0200)]
s3-waf: finally make SO_PEERCRED configure check work with stricter CFLAGS.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Sep 16 14:14:48 CEST 2011 on sn-devel-104

9 years agos3: Trim lines in nfs4_acls.c
Volker Lendecke [Thu, 15 Sep 2011 21:35:05 +0000 (23:35 +0200)]
s3: Trim lines in nfs4_acls.c

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Sep 16 01:39:36 CEST 2011 on sn-devel-104

9 years agos3: Fix some nonempty blank lines
Volker Lendecke [Thu, 15 Sep 2011 21:24:51 +0000 (23:24 +0200)]
s3: Fix some nonempty blank lines

9 years agos3: Make sharesec optionally use sddl
Volker Lendecke [Thu, 15 Sep 2011 17:27:07 +0000 (19:27 +0200)]
s3: Make sharesec optionally use sddl

9 years agos4:upgrade_from_s3 - old s3 versions < 3.4.x don't have a "state directory" param
Matthias Dieter Wallnöfer [Wed, 14 Sep 2011 08:12:30 +0000 (10:12 +0200)]
s4:upgrade_from_s3 - old s3 versions < 3.4.x don't have a "state directory" param

Hence the "lock directory" path has to be used instead.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Sep 16 00:07:30 CEST 2011 on sn-devel-104

9 years agotalloc: change version to 2.0.7 talloc-2.0.7
Stefan Metzmacher [Thu, 15 Sep 2011 15:05:11 +0000 (17:05 +0200)]
talloc: change version to 2.0.7

The version change is needed because the ABI file
of the pytalloc code was fixed.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 22:32:59 CEST 2011 on sn-devel-104

9 years agos3-waf: fix SO_PEERCRED configure check.
Günther Deschner [Thu, 15 Sep 2011 16:14:06 +0000 (18:14 +0200)]
s3-waf: fix SO_PEERCRED configure check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Sep 15 20:59:26 CEST 2011 on sn-devel-104

9 years agorpc_server: Improve debug message for sys_getpeereid().
Andreas Schneider [Thu, 15 Sep 2011 15:25:52 +0000 (17:25 +0200)]
rpc_server: Improve debug message for sys_getpeereid().

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Sep 15 19:23:43 CEST 2011 on sn-devel-104

9 years agos3:libsmb: remove unused cli_*encryption* functions
Stefan Metzmacher [Thu, 15 Sep 2011 14:05:45 +0000 (16:05 +0200)]
s3:libsmb: remove unused cli_*encryption* functions

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 17:52:00 CEST 2011 on sn-devel-104

9 years agos3:libsmb: s/cli_encryption_on/cli_state_encryption_on()
Stefan Metzmacher [Thu, 15 Sep 2011 14:15:18 +0000 (16:15 +0200)]
s3:libsmb: s/cli_encryption_on/cli_state_encryption_on()

metze

9 years agowaf: restore libsmbclient handling.
Günther Deschner [Thu, 15 Sep 2011 10:52:49 +0000 (12:52 +0200)]
waf: restore libsmbclient handling.

This is a temporary solution to get libsmbclient installed properly as a library
(including symlinks and proper symbols). I was not able to make the old internal
library name 'libsmb/smbclient' work together with "realname" and/or "link_name".
Maybe one of the waf gurus has more ideas here.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Sep 15 15:31:59 CEST 2011 on sn-devel-104

9 years agos3:libsmb: move cli->server{zone,time} to cli->conn.smb1.server.{time_zone,system_time}
Stefan Metzmacher [Tue, 13 Sep 2011 19:45:25 +0000 (21:45 +0200)]
s3:libsmb: move cli->server{zone,time} to cli->conn.smb1.server.{time_zone,system_time}

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 14:00:29 CEST 2011 on sn-devel-104

9 years agos3:libsmb: split cli->secblob into cli->conn.smb1.server.{guid,gss_blob,challenge...
Stefan Metzmacher [Tue, 13 Sep 2011 19:34:35 +0000 (21:34 +0200)]
s3:libsmb: split cli->secblob into cli->conn.smb1.server.{guid,gss_blob,challenge,workgroup}

metze

9 years agos3:auth_server: make use of cli_state_server_challenge()
Stefan Metzmacher [Tue, 13 Sep 2011 19:51:52 +0000 (21:51 +0200)]
s3:auth_server: make use of cli_state_server_challenge()

metze

9 years agos3:libsmb: make use of cli_state_server_gss_blob()
Stefan Metzmacher [Tue, 13 Sep 2011 19:17:02 +0000 (21:17 +0200)]
s3:libsmb: make use of cli_state_server_gss_blob()

metze

9 years agos3:libsmb: make use of cli_state_server_challenge()
Stefan Metzmacher [Tue, 13 Sep 2011 19:17:02 +0000 (21:17 +0200)]
s3:libsmb: make use of cli_state_server_challenge()

metze

9 years agos3:libsmb: add cli_state_server_challenge() and cli_state_server_gss_blob()
Stefan Metzmacher [Tue, 13 Sep 2011 18:41:09 +0000 (20:41 +0200)]
s3:libsmb: add cli_state_server_challenge() and cli_state_server_gss_blob()

metze

9 years agos3:libsmb: remove the guid from the cli->secblob in spnego mode
Stefan Metzmacher [Tue, 13 Sep 2011 19:14:05 +0000 (21:14 +0200)]
s3:libsmb: remove the guid from the cli->secblob in spnego mode

metze

9 years agos3:libsmb: make sure cli->secblob.length is 8 if we get a challenge
Stefan Metzmacher [Tue, 13 Sep 2011 19:13:21 +0000 (21:13 +0200)]
s3:libsmb: make sure cli->secblob.length is 8 if we get a challenge

metze

9 years agos3:libsmb: restructure cli_negprot_done() secblob handling a bit
Stefan Metzmacher [Tue, 13 Sep 2011 19:12:44 +0000 (21:12 +0200)]
s3:libsmb: restructure cli_negprot_done() secblob handling a bit

metze

9 years agos3:libsmb: move cli->sesskey to cli->conn.smb1.server.session_key
Stefan Metzmacher [Tue, 13 Sep 2011 16:45:36 +0000 (18:45 +0200)]
s3:libsmb: move cli->sesskey to cli->conn.smb1.server.session_key

metze

9 years agos3:libsmb: detect lock_read and write_unlock support
Stefan Metzmacher [Tue, 13 Sep 2011 16:09:42 +0000 (18:09 +0200)]
s3:libsmb: detect lock_read and write_unlock support

metze

9 years agos3:libsmb: move cli->*braw_supported to cli->conn.smb1.server.*braw
Stefan Metzmacher [Tue, 13 Sep 2011 16:07:58 +0000 (18:07 +0200)]
s3:libsmb: move cli->*braw_supported to cli->conn.smb1.server.*braw

This is currently unused, but we might use it in future.

metze

9 years agos3:libsmb: move cli->sec_mode to cli->conn.smb1.server.security_mode
Stefan Metzmacher [Tue, 13 Sep 2011 14:48:18 +0000 (16:48 +0200)]
s3:libsmb: move cli->sec_mode to cli->conn.smb1.server.security_mode

metze

9 years agos3:libsmb: move cli->max_mux to cli->conn.smb1.server.max_mux
Stefan Metzmacher [Tue, 13 Sep 2011 14:31:58 +0000 (16:31 +0200)]
s3:libsmb: move cli->max_mux to cli->conn.smb1.server.max_mux

metze

9 years agos3:libsmb: move cli->max_xmit to cli->conn.smb1.max_xmit
Stefan Metzmacher [Tue, 13 Sep 2011 13:00:59 +0000 (15:00 +0200)]
s3:libsmb: move cli->max_xmit to cli->conn.smb1.max_xmit

And keep cli->conn.smb1.client.max_xmit and
cli->conn.smb1.server.max_xmit.

metze

9 years agos3:libsmb: move cli->smb1.mid to cli->conn.smb1.mid
Stefan Metzmacher [Tue, 13 Sep 2011 13:07:29 +0000 (15:07 +0200)]
s3:libsmb: move cli->smb1.mid to cli->conn.smb1.mid

metze

9 years agos3:libsmb: move cli->capabilities to cli->conn.smb1.capabilities
Stefan Metzmacher [Tue, 13 Sep 2011 13:00:59 +0000 (15:00 +0200)]
s3:libsmb: move cli->capabilities to cli->conn.smb1.capabilities

And keep cli->conn.smb1.client.capabilities and
cli->conn.smb1.server_capabilities.

metze

9 years agos3:libsmb: move cli->protocol to cli->conn.protocol
Stefan Metzmacher [Tue, 13 Sep 2011 12:38:38 +0000 (14:38 +0200)]
s3:libsmb: move cli->protocol to cli->conn.protocol

metze

9 years agos3:libsmb: don't set cli->protocol in cli_state_create()
Stefan Metzmacher [Tue, 13 Sep 2011 12:37:29 +0000 (14:37 +0200)]
s3:libsmb: don't set cli->protocol in cli_state_create()

This is done in cli_negprot_done(), when we know the protocol.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 11:57:18 CEST 2011 on sn-devel-104

9 years agos3:libsmb: pass max_protocol to cli_negprot()
Stefan Metzmacher [Tue, 13 Sep 2011 12:33:31 +0000 (14:33 +0200)]
s3:libsmb: pass max_protocol to cli_negprot()

metze

9 years agos3:libsmb: add basic max_protocol support in cli_negprot()
Stefan Metzmacher [Tue, 13 Sep 2011 12:21:28 +0000 (14:21 +0200)]
s3:libsmb: add basic max_protocol support in cli_negprot()

metze

9 years agos3:libsmb: use local variables in cli_state_create()
Stefan Metzmacher [Thu, 8 Sep 2011 15:29:58 +0000 (17:29 +0200)]
s3:libsmb: use local variables in cli_state_create()

We don't need to keep use_spnego, use_level_II_oplocks, force_dos_errors
and force_ascii within struct cli_state.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 10:12:17 CEST 2011 on sn-devel-104

9 years agos3:libsmb: use CAP_EXTENDED_SECURITY instead of cli->use_spnego
Stefan Metzmacher [Thu, 8 Sep 2011 15:28:29 +0000 (17:28 +0200)]
s3:libsmb: use CAP_EXTENDED_SECURITY instead of cli->use_spnego

cli->capabilities contains the negotiated capabilities.

metze

9 years agos3:libsmb: make use of SMB_CAP_BOTH/CLIENT_MASK in cli_session_setup_capabilities()
Stefan Metzmacher [Thu, 8 Sep 2011 14:39:14 +0000 (16:39 +0200)]
s3:libsmb: make use of SMB_CAP_BOTH/CLIENT_MASK in cli_session_setup_capabilities()

This matches a w2k3 client.

metze

9 years agos3:libsmb: calculate the negotiated SMB1 capabilities in cli_negprot_done()
Stefan Metzmacher [Thu, 8 Sep 2011 14:14:51 +0000 (16:14 +0200)]
s3:libsmb: calculate the negotiated SMB1 capabilities in cli_negprot_done()

We calculate the negotiated capabilities based on the mask for:
 - client only flags
 - flags used in both directions
 - server only flags

metze

9 years agos3:include: add some masks for SMB1 CAP_* flags
Stefan Metzmacher [Thu, 8 Sep 2011 14:06:05 +0000 (16:06 +0200)]
s3:include: add some masks for SMB1 CAP_* flags

The flags are devided into 3 sections:
- client only flags
- flags used in both directions
- server only flags

metze

9 years agos3:libsmb: calculate all SMB1 capabilities we want to support for the connection
Stefan Metzmacher [Thu, 8 Sep 2011 14:09:35 +0000 (16:09 +0200)]
s3:libsmb: calculate all SMB1 capabilities we want to support for the connection

We should do this at startup in cli_state_create()
and later calculate the negotiated capabilities in
cli_negprot_done().

metze

9 years agos3:libsmb: no need to reset capabilities in cli_session_setup_lanman2()
Stefan Metzmacher [Thu, 8 Sep 2011 13:50:25 +0000 (15:50 +0200)]
s3:libsmb: no need to reset capabilities in cli_session_setup_lanman2()

This is only used cli->protocol < PROTOCOL_NT1, in which case
cli_negprot_done() has already reset cli->capabilities.

metze

9 years agos3:libsmb: make sure we always set cli->capabilities at the end of cli_negprot_done()
Stefan Metzmacher [Thu, 8 Sep 2011 13:41:29 +0000 (15:41 +0200)]
s3:libsmb: make sure we always set cli->capabilities at the end of cli_negprot_done()

If the server doesn't support PROTOCOL_NT1 we should reset the negotiated
capabilities to 0.

metze

9 years agoAdd a missing include file to two VFS modules
Richard Sharpe [Wed, 14 Sep 2011 23:23:36 +0000 (16:23 -0700)]
Add a missing include file to two VFS modules
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 15 02:56:36 CEST 2011 on sn-devel-104

9 years agoFinish commit 8745c70d by Michael Adam.
Jeremy Allison [Wed, 14 Sep 2011 21:07:29 +0000 (14:07 -0700)]
Finish commit 8745c70d by Michael Adam.

If you're going to move winbindd_cache.tdb to the state_path, do it *everywhere*.

Found by Ira Cooper <ira@wakeful.net>.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 15 00:43:04 CEST 2011 on sn-devel-104

9 years agos3:libsmb: remove unused cli->is_samba
Stefan Metzmacher [Mon, 12 Sep 2011 01:19:35 +0000 (03:19 +0200)]
s3:libsmb: remove unused cli->is_samba

s3:libsmb: remove unused cli->is_samba

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:libsmb: align chunk_size for cli_pull/push() to a page size of 1024 bytes
Stefan Metzmacher [Mon, 12 Sep 2011 00:48:25 +0000 (02:48 +0200)]
s3:libsmb: align chunk_size for cli_pull/push() to a page size of 1024 bytes

s3:libsmb: align chunk_size for cli_pull/push() to a page size of 1024 bytes

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:client.h: remove unused defines
Stefan Metzmacher [Tue, 13 Sep 2011 07:58:34 +0000 (09:58 +0200)]
s3:client.h: remove unused defines

s3:client.h: remove unused defines

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:libsmb: let cli_write_max_bufsize() return the max number of possible bytes
Stefan Metzmacher [Mon, 12 Sep 2011 00:45:22 +0000 (02:45 +0200)]
s3:libsmb: let cli_write_max_bufsize() return the max number of possible bytes

s3:libsmb: let cli_write_max_bufsize() return the max number of possible bytes

We now return what's possible on the wire.

Which is 0x1FFFF - data_offset if CAP_LARGE_WRITEX is given by
the server (without signing) or 0xFFFFFF - data_offset
if CIFS_UNIX_LARGE_READ_CAP is available (without signing/sealing).
Otherwise we return max_xmit - data_offset.

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:libsmb: let cli_read_max_bufsize() return the max number of possible bytes
Stefan Metzmacher [Mon, 12 Sep 2011 00:45:22 +0000 (02:45 +0200)]
s3:libsmb: let cli_read_max_bufsize() return the max number of possible bytes

s3:libsmb: let cli_read_max_bufsize() return the max number of possible bytes

We now return what's possible on the wire.

Which is 0xFFFF if CAP_LARGE_READX is given by the server
or 0xFFFFFF - data_offset if CIFS_UNIX_LARGE_READ_CAP
is available (without signing/sealing). Otherwise we return
max_xmit - data_offset.

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:smbd: SMB ReadX with size > 0xffff should only possible for samba clients.
Stefan Metzmacher [Sat, 10 Sep 2011 09:02:02 +0000 (11:02 +0200)]
s3:smbd: SMB ReadX with size > 0xffff should only possible for samba clients.

Windows 2008 R2 (and others) ignore the high bits for the read size.

Unless we're using the unix extentions and the client
uses CIFS_UNIX_LARGE_READ_CAP, we should also ignore
the high bits.

But we still need to support old "smbclient" binaries
and have to check if the client is "Samba".

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agos3:smbd: remember the client unix capabilities on the connection
Stefan Metzmacher [Mon, 12 Sep 2011 03:12:50 +0000 (05:12 +0200)]
s3:smbd: remember the client unix capabilities on the connection

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
9 years agoFix bug #8453 - smbclient segfaults when dialect option -m is used for legacy dialects
Jeremy Allison [Wed, 14 Sep 2011 18:59:22 +0000 (11:59 -0700)]
Fix bug #8453 - smbclient segfaults when dialect option -m is used for legacy dialects

Ensure we have valid pointers.

9 years agolibcli/auth: add some const to SMBNTencrypt_hash() and SMBNTencrypt()
Stefan Metzmacher [Wed, 14 Sep 2011 13:56:23 +0000 (15:56 +0200)]
libcli/auth: add some const to SMBNTencrypt_hash() and SMBNTencrypt()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 19:49:24 CEST 2011 on sn-devel-104

9 years agos4:wrepl_server: return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s4:wrepl_server: return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos4:libcli/wrepl: return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s4:libcli/wrepl: return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos4:lib/messaging: let irpc handles return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s4:lib/messaging: let irpc handles return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos4:librpc/rpc: return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s4:librpc/rpc: return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos3:winbindd: let wbint handles return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s3:winbindd: let wbint handles return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos3:rpc_server: let rpcint handles return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:57:37 +0000 (17:57 +0200)]
s3:rpc_server: let rpcint handles return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places.

metze

9 years agos3:rpc_client: return NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Wed, 14 Sep 2011 15:56:30 +0000 (17:56 +0200)]
s3:rpc_client: return NT_STATUS_CONNECTION_DISCONNECTED

We should return the same in all places
and don't mix NT_STATUS_INVALID_CONNECTION and NT_STATUS_CONNECTION_INVALID.

metze

9 years agos3:libsmb: return NT_STATUS_CONNECTION_DISCONNECTED instead of NT_STATUS_CONNECTION_I...
Stefan Metzmacher [Wed, 14 Sep 2011 15:54:48 +0000 (17:54 +0200)]
s3:libsmb: return NT_STATUS_CONNECTION_DISCONNECTED instead of NT_STATUS_CONNECTION_INVALID

We should return the same in all places.

metze

9 years agos3:torture/run_oplock4: don't set cli->use_level_II_oplocks
Stefan Metzmacher [Thu, 8 Sep 2011 15:24:02 +0000 (17:24 +0200)]
s3:torture/run_oplock4: don't set cli->use_level_II_oplocks

Doing this after the session setup is pointless,
as that's the only place where we tell the server we support
level II oplocks.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 17:23:46 CEST 2011 on sn-devel-104

9 years agos3:smb2_server: SMB2_OP_GETINFO doesn't require at least 1 dyn byte
Stefan Metzmacher [Wed, 14 Sep 2011 11:04:28 +0000 (13:04 +0200)]
s3:smb2_server: SMB2_OP_GETINFO doesn't require at least 1 dyn byte

metze

9 years agos3-libnet: add missing newlines in debug statement.
Günther Deschner [Wed, 14 Sep 2011 12:20:50 +0000 (14:20 +0200)]
s3-libnet: add missing newlines in debug statement.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Sep 14 15:52:10 CEST 2011 on sn-devel-104

9 years agos3:smbd: make use of better SMB signing negotiation
Stefan Metzmacher [Mon, 12 Sep 2011 07:19:06 +0000 (09:19 +0200)]
s3:smbd: make use of better SMB signing negotiation

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 09:41:02 CEST 2011 on sn-devel-104

9 years agos3:libsmb: make use of new advanded SMB signing
Stefan Metzmacher [Mon, 12 Sep 2011 07:16:27 +0000 (09:16 +0200)]
s3:libsmb: make use of new advanded SMB signing

metze

9 years agos3:smb_signing: add support for easier negotiation of SMB signing
Stefan Metzmacher [Mon, 12 Sep 2011 07:04:53 +0000 (09:04 +0200)]
s3:smb_signing: add support for easier negotiation of SMB signing

We don't make use of it yet, but it will follow.

metze

9 years agos3:smbd: echo FLAGS2_SMB_SECURITY_SIGNATURES* and the signature field in the reply
Stefan Metzmacher [Fri, 9 Sep 2011 20:44:44 +0000 (22:44 +0200)]
s3:smbd: echo FLAGS2_SMB_SECURITY_SIGNATURES* and the signature field in the reply

This matches what windows is doing.

metze

9 years agotdb2: remove bogus leftover .orig file.
Rusty Russell [Wed, 14 Sep 2011 02:28:20 +0000 (11:58 +0930)]
tdb2: remove bogus leftover .orig file.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Sep 14 06:06:41 CEST 2011 on sn-devel-104

9 years agoFix bug #8229 - git patch attached against 3.6.0-rc2 to fix 'widelinks' regression...
Jeremy Allison [Tue, 13 Sep 2011 23:42:09 +0000 (16:42 -0700)]
Fix bug #8229 - git patch attached against 3.6.0-rc2 to fix 'widelinks' regression intro'd in 3.2

Add "allow insecure widelinks" to re-enable the ability (requested
by some sites) to have "widelinks = yes" and "unix extensions = yes".

Based on an original patch by Linda Walsh <samba@tlinx.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 14 03:55:45 CEST 2011 on sn-devel-104

9 years agotdb_compat: change offset of CLEAR_IF_FIRST lock.
Rusty Russell [Tue, 13 Sep 2011 22:43:28 +0000 (08:13 +0930)]
tdb_compat: change offset of CLEAR_IF_FIRST lock.

This makes it match tdb1, which mean it will Just Work as TDB2 gets
tdb1 format support.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Sep 14 02:21:29 CEST 2011 on sn-devel-104

9 years agotdb_compat: support tdb_reopen/tdb_reopen_all for TDB2
Rusty Russell [Tue, 13 Sep 2011 22:43:28 +0000 (08:13 +0930)]
tdb_compat: support tdb_reopen/tdb_reopen_all for TDB2

This matters with the clear-if-first support: we need to re-establish
those locks at this point.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
9 years agoutil_tdb: return -1/0 from lock_with_timeout functions.
Rusty Russell [Tue, 13 Sep 2011 22:43:28 +0000 (08:13 +0930)]
util_tdb: return -1/0 from lock_with_timeout functions.

Keeps the tdb2 API change (which returns error codes, rather than -1)
localized.  The function returns -1 down the other path, so make it
consistent.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
9 years agodbwrap_tdb: handle tdb2 return values properly.
Rusty Russell [Tue, 13 Sep 2011 22:43:28 +0000 (08:13 +0930)]
dbwrap_tdb: handle tdb2 return values properly.

TDB2 versions of tdb_parse_record etc return an error code, not -1.
Turn those into -1/0 in dbwrap_tdb to insulate the rest of the code
from that change.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>