Volker Lendecke [Sun, 18 Jun 2006 07:54:06 +0000 (07:54 +0000)]
r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
(This used to be commit
def075baf873b24c522d09ddc0141d84431a1fae)
Volker Lendecke [Sat, 17 Jun 2006 07:43:56 +0000 (07:43 +0000)]
r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121
(This used to be commit
555984ea772730a5752905f1130e0bf6ec48207f)
Volker Lendecke [Sat, 17 Jun 2006 07:20:47 +0000 (07:20 +0000)]
r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
(This used to be commit
d3f5acb16e14ec394f1af41fa2f9e27fdca937db)
Jeremy Allison [Fri, 16 Jun 2006 23:26:48 +0000 (23:26 +0000)]
r16326: Klocwork #509. Always check return allocs.
Jeremy.
(This used to be commit
7e397b534a5ca5809facf5aa84acbfb0b8c9a5b4)
Jeremy Allison [Fri, 16 Jun 2006 23:21:36 +0000 (23:21 +0000)]
r16324: Klocwork #499. Allways check results from alloc.
Jeremy.
(This used to be commit
2b69d436da7b2902ea419f3bcc45c7b5a5c571fb)
Jeremy Allison [Fri, 16 Jun 2006 23:14:12 +0000 (23:14 +0000)]
r16322: Klocwork #481., Don't deref null on malloc fail.
Jeremy.
(This used to be commit
dd31f3fc0e044fdae139aefcb21773249c30eb74)
Jeremy Allison [Fri, 16 Jun 2006 23:07:42 +0000 (23:07 +0000)]
r16320: Ensure variable is not null before calling fclose.
Klocwork #412.
Jeremy.
(This used to be commit
fed55d653a73d09550a90a4904023580dd46ae76)
Jeremy Allison [Fri, 16 Jun 2006 23:04:13 +0000 (23:04 +0000)]
r16317: Klocwork #300. Check for error return on malloc.
Jeremy.
(This used to be commit
aa0d739834a286aeee88f76048dc347dd2852d09)
Jeremy Allison [Fri, 16 Jun 2006 22:44:28 +0000 (22:44 +0000)]
r16313: Not a problem - but ensure Klocwork is quiet (#872).
Jeremy.
(This used to be commit
22a345deed6caa5750e2bb233a20422ad7b90d94)
Jeremy Allison [Fri, 16 Jun 2006 22:40:07 +0000 (22:40 +0000)]
r16311: Check for NULL return. Klocwork #998.
Jeremy.
(This used to be commit
c430730f5a0dc00626b9b924e88adfb84cd48869)
Jeremy Allison [Fri, 16 Jun 2006 22:36:12 +0000 (22:36 +0000)]
r16309: Fix Klocwork #1596. Check for NULL on talloc.
Jeremy.
(This used to be commit
34b6b6723b1c87e19b0a51ef785a614d86bd5cef)
Jeremy Allison [Fri, 16 Jun 2006 22:29:53 +0000 (22:29 +0000)]
r16307: Make sure we know we must pass a valid pointer here.
Klocwork #1129.
Jeremy.
(This used to be commit
e8d86362ba8762a5e4180e7320f5ac8bb37c203d)
Jeremy Allison [Fri, 16 Jun 2006 22:25:17 +0000 (22:25 +0000)]
r16306: Error handling in this asn1 code *sucks*. Fix a generic
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
(This used to be commit
8ef11a7c6de74024b7d535d959db2d462662a86f)
Volker Lendecke [Fri, 16 Jun 2006 21:10:19 +0000 (21:10 +0000)]
r16301: Fix a memleak
(This used to be commit
21aaede518503e6722ba5ccfdb2c77007d12ddee)
Jeremy Allison [Fri, 16 Jun 2006 20:44:49 +0000 (20:44 +0000)]
r16299: Fix another "dereferencing type-punned pointer will break
strict-aliasing rules" gcc4 warning.
Jeremy.
(This used to be commit
ee77dde9b6375423f95f31455d06cef7303400be)
Jeremy Allison [Fri, 16 Jun 2006 18:50:01 +0000 (18:50 +0000)]
r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
(This used to be commit
db5b4e3f13bceeb2f078f412bdd4666516eedc5c)
Jeremy Allison [Fri, 16 Jun 2006 18:42:39 +0000 (18:42 +0000)]
r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break
strict-aliasing rules" warning.
Jeremy.
(This used to be commit
7ac5aee88cae3400fb6400b3628544da2e474560)
Lars Müller [Fri, 16 Jun 2006 14:34:36 +0000 (14:34 +0000)]
r16294: Fix syntax error.
Credits to Andreas Schwab from SUSE Linux for this fix.
(This used to be commit
da4c5c3b75e6fd4f9e661cbcbe7d38024a02d344)
Volker Lendecke [Fri, 16 Jun 2006 12:30:39 +0000 (12:30 +0000)]
r16290: Fix Coverity bugs 298 and 298
(This used to be commit
b96808bb623c01f2515fdbdede8b4e9edebff23b)
James Peach [Fri, 16 Jun 2006 04:44:59 +0000 (04:44 +0000)]
r16289: Fix smbclient test hang. This is caused by readline refusing to believe
the end of file it receives when reading from a pipe after we force
interactive mode.
(This used to be commit
3eee12645883df21efa5175b10854a965fc90422)
Jeremy Allison [Fri, 16 Jun 2006 02:23:02 +0000 (02:23 +0000)]
r16287: Use intptr_t to return an integer of an unknown type cast
to void *.
Jeremy.
(This used to be commit
e24361ecddef8a48a42a356775b93ce5c4027fae)
Jeremy Allison [Fri, 16 Jun 2006 02:01:29 +0000 (02:01 +0000)]
r16285: On a 64-bit box, size_t != uint32. Ensure we use
the right parameter type.
Jeremy.
(This used to be commit
938545f5352161b4fe195c2a826a26db5236f851)
Jeremy Allison [Fri, 16 Jun 2006 01:47:02 +0000 (01:47 +0000)]
r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
face01ef01e1a3c96eae17c56cadf01020d4cb46)
Jeremy Allison [Fri, 16 Jun 2006 01:35:08 +0000 (01:35 +0000)]
r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
c49ad9200bf3fdd8b9404d93182c2e04e662190a)
Jeremy Allison [Fri, 16 Jun 2006 01:33:13 +0000 (01:33 +0000)]
r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
45d5cad8c2438c032d9f11c62a50a04d0637bf6c)
Jeremy Allison [Fri, 16 Jun 2006 01:32:19 +0000 (01:32 +0000)]
r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
(This used to be commit
3a15fff21988b426a514ad28060eaf0ddc17ef6b)
Jeremy Allison [Fri, 16 Jun 2006 01:30:42 +0000 (01:30 +0000)]
r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
(This used to be commit
952547471f03bd2da1eda0247471b17aa1ff15de)
James Peach [Thu, 15 Jun 2006 23:51:20 +0000 (23:51 +0000)]
r16274: Fix the smbclient prompting behaviour for both systems that have
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.
Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit
848ac756f651a4be231e5635580c0fd5f3d3fa0e)
James Peach [Thu, 15 Jun 2006 23:47:41 +0000 (23:47 +0000)]
r16273: Add smbclient tests to verify that
in interactive mode, smbclient always prompts on stdout
in non-interactive mode, smbclient never prompts
(This used to be commit
dff1eba81ed4bdd6dbf2df6e7c28b0da74a39615)
Günther Deschner [Thu, 15 Jun 2006 21:59:25 +0000 (21:59 +0000)]
r16272: Fix memleak.
Guenther
(This used to be commit
afdb1189029e01a132f16fea48624126ec65cd77)
Jeremy Allison [Thu, 15 Jun 2006 21:46:15 +0000 (21:46 +0000)]
r16270: Fix Klocwork #706 - ensure sscanf has correct format
specifier.
Jeremy.
(This used to be commit
dc53d35b0a1491da94e231943a81547be4c75631)
Günther Deschner [Thu, 15 Jun 2006 21:45:10 +0000 (21:45 +0000)]
r16269: Fix the build.
Guenther
(This used to be commit
546710d58c07acdaa175caa48cec4d3f2bc657ad)
Günther Deschner [Thu, 15 Jun 2006 21:25:57 +0000 (21:25 +0000)]
r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.
I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.
Guenther
(This used to be commit
535d03cbe8b021e9aa6d74b62d81b867c494c957)
Jeremy Allison [Thu, 15 Jun 2006 21:03:40 +0000 (21:03 +0000)]
r16267: Fix Klocwork #401, #402 - ensure format specifier
limited. Fix memleak in printing gencache contents.
Jeremy.
(This used to be commit
81731e1f68cdf4af80733338238aeae0a7d108c0)
Günther Deschner [Thu, 15 Jun 2006 16:09:31 +0000 (16:09 +0000)]
r16261: Smaller fixes for net ads password.
Guenther
(This used to be commit
689ae22c80a890278610d9ada1eb4fa5e37bd5ce)
Gerald Carter [Thu, 15 Jun 2006 12:37:05 +0000 (12:37 +0000)]
r16255: Fix 'net ads join' when the workgroup is set incorrectly
in smb.conf. This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.
The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has. Thanks to Volker for the discussion.
(This used to be commit
95763b94f709fe1ad9e381dbc6b364c2f3759024)
Günther Deschner [Thu, 15 Jun 2006 11:58:13 +0000 (11:58 +0000)]
r16253: Fix another host/ UPN case in (the currently unused)
cli_rpc_pipe_open_krb5.
Guenther
(This used to be commit
fa19099112490daa085bb310f2f4ed877bb22b40)
Volker Lendecke [Thu, 15 Jun 2006 11:44:57 +0000 (11:44 +0000)]
r16252: Fix Klocwork ID 1119, 1121.
Volker
(This used to be commit
678bbcf06109b276d3e4514c3788a9fb31348de0)
Volker Lendecke [Thu, 15 Jun 2006 11:24:01 +0000 (11:24 +0000)]
r16251: for i in `seq 1 1000`
do
echo "I will always compile before commit :-)"
done
Also fix Klokwork ID 806.
Volker
(This used to be commit
4974c598c00abc20cfb73eee12a7c49c279e0f54)
Volker Lendecke [Thu, 15 Jun 2006 11:17:57 +0000 (11:17 +0000)]
r16250: Fix Klokwork IDs 148, 151, 152, 154.
Volker
(This used to be commit
d7a75ee94db009085165c062f73b68162a8b6da8)
Volker Lendecke [Thu, 15 Jun 2006 10:48:53 +0000 (10:48 +0000)]
r16249: Fix Klokwork ID 130
(This used to be commit
09586824f6568fb3305e3e59ba6bc8f5f632fb56)
Volker Lendecke [Thu, 15 Jun 2006 10:12:29 +0000 (10:12 +0000)]
r16248: Fix Coverity ID 297
(This used to be commit
e56e3c19e1244e2b7409d57a030ca8b7ec446932)
Volker Lendecke [Thu, 15 Jun 2006 10:06:09 +0000 (10:06 +0000)]
r16247: Fix Coverity ID 296
(This used to be commit
b82c95cb438b57bb8910e26657f8ffb590fe02df)
Jeremy Allison [Thu, 15 Jun 2006 05:32:21 +0000 (05:32 +0000)]
r16245: Cope with string being zero len. Klocwork bug #410.
Jeremy.
(This used to be commit
afe2d4c49333309b940cec8408ccd37ed3747cb7)
Jeremy Allison [Thu, 15 Jun 2006 05:20:21 +0000 (05:20 +0000)]
r16243: Fix Klocwork bugs #581 and #706, ensure we check
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit
66275bd3bc56e67759dbabe77cb2ba019c6f4887)
Jeremy Allison [Thu, 15 Jun 2006 01:54:09 +0000 (01:54 +0000)]
r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit
a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
Jeremy Allison [Wed, 14 Jun 2006 21:36:49 +0000 (21:36 +0000)]
r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit
6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
Günther Deschner [Wed, 14 Jun 2006 14:43:15 +0000 (14:43 +0000)]
r16222: Fix DEBUG statements.
Guenther
(This used to be commit
5ecfaf7d505e6acc23a06dd64d00f5e6fb8efe6f)
Günther Deschner [Wed, 14 Jun 2006 14:38:59 +0000 (14:38 +0000)]
r16221: No need for friednly error messages at log level 10.
Guenther
(This used to be commit
58a7c0900325065cc969eb4f2f4c85d41e27bc89)
Gerald Carter [Wed, 14 Jun 2006 12:00:53 +0000 (12:00 +0000)]
r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.
(This used to be commit
6c1f1c091f5e87bf9464fe8ad7eb2cb683819a62)
Jeremy Allison [Wed, 14 Jun 2006 02:06:28 +0000 (02:06 +0000)]
r16216: Add debug messages to make it possible to try and
debug why a job pause or resume command is not being
done.
Jeremy.
(This used to be commit
e6aacb1426bd04c4006f7be66228f9f8d9a7065d)
Jeremy Allison [Wed, 14 Jun 2006 00:37:52 +0000 (00:37 +0000)]
r16213: Fix Klocwork #852. iface_n_ip can potentially
return NULL. Ensure we don't deref.
Jeremy.
(This used to be commit
c2f0ea2ff2f6ad925cee9c85110c6ad828ffb7a9)
Jeremy Allison [Tue, 13 Jun 2006 21:21:44 +0000 (21:21 +0000)]
r16209: Klocwork bug #66, ensure no null deref.
Jeremy.
(This used to be commit
79e693798cf322071ea64a4014a01ad9eaba73e8)
Jeremy Allison [Tue, 13 Jun 2006 21:01:08 +0000 (21:01 +0000)]
r16207: Ensure we don't allocate an OID string unless
we know we don't have an error. Klocwork #6.
Jeremy.
(This used to be commit
2c1a2d7b40e7ef353461f97f5c69c2079b5670ab)
Gerald Carter [Tue, 13 Jun 2006 20:29:00 +0000 (20:29 +0000)]
r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that
(This used to be commit
304b7913cd25a024269fecdd541af06836816f68)
Gerald Carter [Tue, 13 Jun 2006 20:02:50 +0000 (20:02 +0000)]
r16205: Fix 'make install' when srcdir != builddir
(This used to be commit
44d4bab991d5fc88005a542d2490ae3254a0f5b5)
Volker Lendecke [Tue, 13 Jun 2006 19:56:26 +0000 (19:56 +0000)]
r16204: Fix Klocwork # 14
localtime() can return NULL.
Volker
(This used to be commit
07c5dcb8633e6fadb596dc5a22d8d31b2e16a3ef)
Volker Lendecke [Tue, 13 Jun 2006 19:40:28 +0000 (19:40 +0000)]
r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
Found by Klocwork, ID 653.
Volker
(This used to be commit
4cb8cf221f986b15de3ac608b173310c14248533)
Jeremy Allison [Tue, 13 Jun 2006 18:15:03 +0000 (18:15 +0000)]
r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
(This used to be commit
319f80bbf0455cfaf80eab51313a56db4ed04ac5)
Volker Lendecke [Tue, 13 Jun 2006 18:09:37 +0000 (18:09 +0000)]
r16201: Fix Klocwork 439
(This used to be commit
b369d0891afe8b777b837eaac317131232568ca7)
Jeremy Allison [Tue, 13 Jun 2006 18:09:04 +0000 (18:09 +0000)]
r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
(This used to be commit
98751e8190317416de56b4a19a489c5f4b7d6bc9)
Volker Lendecke [Tue, 13 Jun 2006 18:06:12 +0000 (18:06 +0000)]
r16198: Fix Klocwork 1023
(This used to be commit
3a7d01afbebe5c4c36935b6128998e1327c8f856)
Volker Lendecke [Tue, 13 Jun 2006 18:01:58 +0000 (18:01 +0000)]
r16197: Fix Klocwork id 1338
(This used to be commit
963ae5bd144b90e71331a88029698a1a6dc52190)
Volker Lendecke [Tue, 13 Jun 2006 17:55:39 +0000 (17:55 +0000)]
r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.
Volker
(This used to be commit
b5602cc4f1d77ed48ddca0f7f42b28706160c923)
Gerald Carter [Tue, 13 Jun 2006 15:57:00 +0000 (15:57 +0000)]
r16195: starting development for 3.0.24pre1
(This used to be commit
1b64f9a48bbb5a88c2029585e208865b41f2f423)
Gerald Carter [Tue, 13 Jun 2006 15:49:22 +0000 (15:49 +0000)]
r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 perl module (caused by upgarde in smbldap-tools)
(This used to be commit
abca3b12e78814a395b806a9969a8f12b3230dfd)
Günther Deschner [Tue, 13 Jun 2006 14:39:52 +0000 (14:39 +0000)]
r16192: Fix timeformats in the winbind response struct.
(pam_winbind users were forced to change a password inappropriately)
Guenther
(This used to be commit
65643d31725a4e3fe157d66e9ecad03a65a484e2)
Günther Deschner [Tue, 13 Jun 2006 13:41:04 +0000 (13:41 +0000)]
r16190: Fix more memleaks.
Guenther
(This used to be commit
dfebcc8e19bee06b7c03f88845314e9cfd6f398a)
Günther Deschner [Tue, 13 Jun 2006 11:37:51 +0000 (11:37 +0000)]
r16187: Fix memleak.
Guenther
(This used to be commit
e7d2b84aba2f2f5d844ba6a5fdcce35c3750d0b2)
Volker Lendecke [Mon, 12 Jun 2006 18:32:25 +0000 (18:32 +0000)]
r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
Volker
(This used to be commit
7674a4f8361d3f3b649245118b82d8a074a2760e)
Jeremy Allison [Mon, 12 Jun 2006 15:42:43 +0000 (15:42 +0000)]
r16155: Janitor for jelmer.
Fix typo in DEBUG()
Jeremy.
(This used to be commit
da768bf9c2761884cc97f690133d6897ed353e15)
Günther Deschner [Mon, 12 Jun 2006 13:59:22 +0000 (13:59 +0000)]
r16154: Fix winbind function table typo.
Guenther
(This used to be commit
aeff1f0c47992ce3941e27e63f9b1516c4918963)
Volker Lendecke [Mon, 12 Jun 2006 12:45:06 +0000 (12:45 +0000)]
r16153: Fix possible NULL dereference found by Klocwork # 252
(This used to be commit
128260527b90d77ca3dfc900e012018ef00ba9e0)
Volker Lendecke [Mon, 12 Jun 2006 11:03:49 +0000 (11:03 +0000)]
r16150: Fix possible NULL dereference found by Klocwork ID # 17
(This used to be commit
3159bd3a4e3ad70c60fea4cacc892be9f1d71ab9)
Volker Lendecke [Sun, 11 Jun 2006 16:13:41 +0000 (16:13 +0000)]
r16141: Dummy commit to make the build farm re-test against Samba4 16140
(This used to be commit
a1fcacf75683e4c08236bb4cc4164678ea1a1ce4)
Alexander Bokovoy [Sat, 10 Jun 2006 15:18:46 +0000 (15:18 +0000)]
r16138: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit
a18af427d7ea7b5a04d7006d10299d9e43317ae4)
Alexander Bokovoy [Sat, 10 Jun 2006 15:16:01 +0000 (15:16 +0000)]
r16136: By default, rootsbindir relies on SBINDIR so import it here
(This used to be commit
5ffb424641bfc71ce396800a6e426015b11fd6ba)
Gerald Carter [Fri, 9 Jun 2006 22:06:01 +0000 (22:06 +0000)]
r16131: fix RedHat 9 spec files
(This used to be commit
1ffb0f06adeb1658fa1f5eed747841c6ff1e5665)
Gerald Carter [Fri, 9 Jun 2006 21:57:42 +0000 (21:57 +0000)]
r16130: fix a shell portability issue for Solaris sh in installman.sh
(This used to be commit
9be3e07884e7f8121bc64766e7d036495cd94a15)
Jeremy Allison [Fri, 9 Jun 2006 17:19:59 +0000 (17:19 +0000)]
r16126: Janitor for Volker..... This looks correct to me.
Jeremy.
Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.
Volker.
(This used to be commit
ee1b9207d3119c2b3e7c1c4e59250dbd323eae6a)
Günther Deschner [Fri, 9 Jun 2006 13:04:47 +0000 (13:04 +0000)]
r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.
When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.
Guenther
(This used to be commit
e018ea3d1d70e68e6802843f88b3245dc09244c9)
Günther Deschner [Fri, 9 Jun 2006 12:55:07 +0000 (12:55 +0000)]
r16121: Fix a eDir related memory leak.
Guenther
(This used to be commit
322f1664df553d95fcdfc24f19bd7f34ce9b834b)
Günther Deschner [Fri, 9 Jun 2006 11:02:52 +0000 (11:02 +0000)]
r16117: Make winbindd work again in security=ads.
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.
Guenther
(This used to be commit
f6516a799aec2db819f79b9a1e641637422a9b4c)
James Peach [Fri, 9 Jun 2006 10:50:45 +0000 (10:50 +0000)]
r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we never
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
(This used to be commit
60b5f9618b77afb397f96c1ff406c8cd3a4648f3)
Günther Deschner [Fri, 9 Jun 2006 10:50:28 +0000 (10:50 +0000)]
r16115: Make "net ads changetrustpw" work again.
(adapt to the new UPN/SPN scheme).
Guenther
(This used to be commit
8fc70d0df0c93c29b49f924bac9ff5d9857cfd9d)
Günther Deschner [Fri, 9 Jun 2006 10:33:29 +0000 (10:33 +0000)]
r16114: Make winbindd's group enumeration (set|get|endgrent) work again (when
enabled).
Do not bail out when a group just has 0 members.
Jeremy, please check, this has been removed with r13915.
Guenther
(This used to be commit
3a738a855d335e44e167351e6396bf3fe81a03af)
Jeremy Allison [Fri, 9 Jun 2006 01:36:58 +0000 (01:36 +0000)]
r16112: Added Volker's fix for extra odd byte at the end
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
(This used to be commit
6cd1cb5c9deba2aa0d7a3251c8142834cbaba6d1)
James Peach [Fri, 9 Jun 2006 01:02:54 +0000 (01:02 +0000)]
r16111: Patch from Björn JACKE <samba@j3e.de>.
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
(This used to be commit
fc6ed6a1aa2225ccde04c4ecaf0777dc0de4f1cb)
Paul Green [Thu, 8 Jun 2006 18:41:15 +0000 (18:41 +0000)]
r16103: Properly rebuild timelimit on systems with executable extensions.
Paul
(This used to be commit
f5be3e12e2dc42a2092b71c9e4cab6f5d0ef8860)
Günther Deschner [Wed, 7 Jun 2006 13:06:49 +0000 (13:06 +0000)]
r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).
Guenther
(This used to be commit
8759a00fedfe5d8d789c8b707c924d8116da1102)
Gerald Carter [Wed, 7 Jun 2006 12:35:16 +0000 (12:35 +0000)]
r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
(This used to be commit
f3bd1c8c7de93917787e7341f759699c8399f006)
Gerald Carter [Wed, 7 Jun 2006 12:01:54 +0000 (12:01 +0000)]
r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
(This used to be commit
b01f289f1a788fe8f62a213b67a73a9bfee01bb1)
Jeremy Allison [Wed, 7 Jun 2006 04:45:50 +0000 (04:45 +0000)]
r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
(This used to be commit
5cd234a1fff1e9d025eea6600649e56c997eafc2)
Volker Lendecke [Tue, 6 Jun 2006 20:34:26 +0000 (20:34 +0000)]
r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.
Tom, waiting for more bug reports from you ;-))
Thanks for insisting!
Volker
(This used to be commit
bc78cca290559c5ca7623b9f6d9933e32668b9c4)
Volker Lendecke [Tue, 6 Jun 2006 20:18:11 +0000 (20:18 +0000)]
r16064: Bug fix for another one Tom Bork has reported:
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.
Thanks a lot!
People out there listening, please test current code, this release is
**BIG**
:-)
Volker
(This used to be commit
8f9ba5f96c9b506623ef97b7ed3d84f39d914a3c)
Volker Lendecke [Tue, 6 Jun 2006 14:18:12 +0000 (14:18 +0000)]
r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.
Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.
Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...
Thanks to Tom Bork for finding this one.
Volker
(This used to be commit
5a37aba10551456042266443cc0a92f28f8c3d0d)
James Peach [Tue, 6 Jun 2006 07:43:17 +0000 (07:43 +0000)]
r16057: Coalesce the DMAPI configure tests into a single macro. Add
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
(This used to be commit
aafd4db457ce8a60c628d54a3ace3b97c8885dca)
Jeremy Allison [Tue, 6 Jun 2006 00:34:26 +0000 (00:34 +0000)]
r16054: Janitor for Volker ? Volker - some reason you didn't
fix this in 3.0 ?
Jeremy.
We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...
One thing the samba3 join test found.
Volker
(This used to be commit
e5b7acc9b5cb6e8cf3d03c9d392fad06e0d282d9)
Jim McDonough [Mon, 5 Jun 2006 16:59:10 +0000 (16:59 +0000)]
r16047: Remove unnecessary line, as this value is set in either branch of the
'if' below. Spotted by Aleksey Fedoseev.
(This used to be commit
00eb42791abf3e34dc42a2067f07b8549ea31abb)
Volker Lendecke [Mon, 5 Jun 2006 13:00:24 +0000 (13:00 +0000)]
r16046: Hmmm. I don't fully understand popt, but this is necessary for smbclient to
show a prompt again :-)
James, could you check that this is ok? I think this was part of your Revision
15848.
Thanks,
Volker
(This used to be commit
91534146b4718206f0e2a7f456154a0497277dfd)