amitay/samba.git
11 years agos3:registry: rename reg_util.{c,h} to reg_util_internal.{c,h}
Michael Adam [Mon, 24 May 2010 22:04:13 +0000 (00:04 +0200)]
s3:registry: rename reg_util.{c,h} to reg_util_internal.{c,h}

11 years agos3:registry: move prototype registry_create_admin_token() to new header reg_util_token.h
Michael Adam [Mon, 24 May 2010 21:37:09 +0000 (23:37 +0200)]
s3:registry: move prototype registry_create_admin_token() to new header reg_util_token.h

and use it only where necessary.

11 years agos3:registry: move registry_create_admin_token() to new reg_util_token.c
Michael Adam [Mon, 24 May 2010 21:27:57 +0000 (23:27 +0200)]
s3:registry: move registry_create_admin_token() to new reg_util_token.c

11 years agos3:registry: extract reg_eventlog prototypes to header of their own
Michael Adam [Mon, 24 May 2010 21:06:27 +0000 (23:06 +0200)]
s3:registry: extract reg_eventlog prototypes to header of their own

and use them only where needed.

11 years agos3:registry: extract reg_perfcount prototypes into header of their own.
Michael Adam [Mon, 24 May 2010 20:59:04 +0000 (22:59 +0200)]
s3:registry: extract reg_perfcount prototypes into header of their own.

And use them only when necessary.

11 years agos3:registry: extraxt the reg_dispatcher prototypes into their own header.
Michael Adam [Mon, 24 May 2010 20:49:42 +0000 (22:49 +0200)]
s3:registry: extraxt the reg_dispatcher prototypes into their own header.

And use them only where needed.

11 years agos3:registry: extract the reg_backend_db prototypes into their own header.
Michael Adam [Mon, 24 May 2010 20:42:00 +0000 (22:42 +0200)]
s3:registry: extract the reg_backend_db prototypes into their own header.

And use them only where needed.

11 years agos3:registry: adapt callers of regval_ctr_addvalue to uint8 * instead of char *
Michael Adam [Mon, 24 May 2010 20:19:17 +0000 (22:19 +0200)]
s3:registry: adapt callers of regval_ctr_addvalue to uint8 * instead of char *

11 years agos3:registry: fix regval_ctr_addvalue() to take data as uint8 *, not char *.
Michael Adam [Mon, 24 May 2010 13:15:33 +0000 (15:15 +0200)]
s3:registry: fix regval_ctr_addvalue() to take data as uint8 *, not char *.

11 years agos3:registry: fix data_p arg of regval_compose to be uint8 * instead of char *
Michael Adam [Mon, 24 May 2010 13:00:29 +0000 (15:00 +0200)]
s3:registry: fix data_p arg of regval_compose to be uint8 * instead of char *

11 years agos3:registry: extract the reg_util prototypes into their own header.
Michael Adam [Sun, 23 May 2010 14:11:13 +0000 (16:11 +0200)]
s3:registry: extract the reg_util prototypes into their own header.

And use them only where needed.

11 years agos3:registry: remove superfluous comments from registry.h
Michael Adam [Sun, 23 May 2010 14:00:35 +0000 (16:00 +0200)]
s3:registry: remove superfluous comments from registry.h

11 years agos3:registry: extract the reg_util_legacy prototypes into their own header.
Michael Adam [Sun, 23 May 2010 13:57:27 +0000 (15:57 +0200)]
s3:registry: extract the reg_util_legacy prototypes into their own header.

And use them only where necessary.

11 years agos3:registry: extract the reg_cachehook prototypes into their own header.
Michael Adam [Sun, 23 May 2010 13:25:00 +0000 (15:25 +0200)]
s3:registry: extract the reg_cachehook prototypes into their own header.

And use them only where necessary.

11 years agos3:registry: protect registry.h from multiple inclusion
Michael Adam [Sun, 23 May 2010 11:32:08 +0000 (13:32 +0200)]
s3:registry: protect registry.h from multiple inclusion

11 years agos3:registry: add C to reg_cachehook, confessing considerable changes in 2008
Michael Adam [Sun, 23 May 2010 11:28:05 +0000 (13:28 +0200)]
s3:registry: add C to reg_cachehook, confessing considerable changes in 2008

11 years agos3:fix configure after change "add Werror_FLAGS for IBM's xlc"
Michael Adam [Tue, 25 May 2010 07:49:04 +0000 (09:49 +0200)]
s3:fix configure after change "add Werror_FLAGS for IBM's xlc"

For me, 24b3725407f1a67e13a7646d2e3f26ed1e4735ff broke configure.
The fix in f634450b67d2a084c41a63c0e94eb47adb90e101 is not complete yet.
After staring at the change a bit, tt seems to me that the
code inserted was just misplaced by one line.

Michael

11 years agos3: fix the configure run
Björn Jacke [Tue, 25 May 2010 07:43:57 +0000 (09:43 +0200)]
s3: fix the configure run

11 years agos3:configure: turn "error warnings" into errors
Björn Jacke [Mon, 24 May 2010 21:34:00 +0000 (23:34 +0200)]
s3:configure: turn "error warnings" into errors

By default "Missing argument(s)" is just an "error warning" for xlc :-)
The change to turn "error warnings" into errors should fix bug #7427.

11 years agos3:configure: add Werror_FLAGS for IBM's xlc
Björn Jacke [Mon, 24 May 2010 21:28:44 +0000 (23:28 +0200)]
s3:configure: add Werror_FLAGS for IBM's xlc

11 years agos4:dsdb_enum_group_mem - use "unsigned" counters
Matthias Dieter Wallnöfer [Mon, 24 May 2010 20:01:36 +0000 (22:01 +0200)]
s4:dsdb_enum_group_mem - use "unsigned" counters

"size_t" counters aren't really needed here (we don't check data lengths).
And we save the result in a certain "num_sids" variable which is of type
"unsigned".

11 years agos4:dsdb_lookup_rids - "unsigned" counters fit better than "signed" in this case
Matthias Dieter Wallnöfer [Mon, 24 May 2010 20:00:54 +0000 (22:00 +0200)]
s4:dsdb_lookup_rids - "unsigned" counters fit better than "signed" in this case

11 years agos4:dsdb_add_user - check the "cn"/"account_name" length (should be >= 1)
Matthias Dieter Wallnöfer [Mon, 24 May 2010 19:53:34 +0000 (21:53 +0200)]
s4:dsdb_add_user - check the "cn"/"account_name" length (should be >= 1)

This needed by the "cn_name_len"-1 accesses.

And use a "size_t"-typed variable for storing it (length specificators should
always be stored using "size_t" variables).

11 years agoAdd in support for the NTLMSSP version reply.
Jeremy Allison [Mon, 24 May 2010 18:03:42 +0000 (11:03 -0700)]
Add in support for the NTLMSSP version reply.

Jeremy.

11 years agofix a typo
Volker Lendecke [Sun, 23 May 2010 13:39:29 +0000 (15:39 +0200)]
fix a typo

11 years agoldb-waf: Install manual pages for ldb in standalone build, install
Jelmer Vernooij [Mon, 24 May 2010 15:25:34 +0000 (17:25 +0200)]
ldb-waf: Install manual pages for ldb in standalone build, install
python module.

11 years agos4:winbind Give more detail on the parameters when reporting idmap failure
Andrew Bartlett [Mon, 24 May 2010 05:03:17 +0000 (15:03 +1000)]
s4:winbind Give more detail on the parameters when reporting idmap failure

11 years agos4:winbind Change idmap API to match that used by the source3/ idmap subsystem
Andrew Bartlett [Mon, 24 May 2010 04:58:07 +0000 (14:58 +1000)]
s4:winbind Change idmap API to match that used by the source3/ idmap subsystem

This makes it much easier to write an idmap module that bridges the gap.

We should finish the change to the new API, but for the moment this
choke point works for the conversion.

Andrew Bartlett

11 years agos4:winbind Change include guard so as not to conflict with idmap.h in source3
Andrew Bartlett [Mon, 24 May 2010 01:21:29 +0000 (11:21 +1000)]
s4:winbind Change include guard so as not to conflict with idmap.h in source3

11 years agos4:winbind Fix up includes after seperation of idmap.idl from winbind.idl
Andrew Bartlett [Mon, 24 May 2010 00:52:18 +0000 (10:52 +1000)]
s4:winbind Fix up includes after seperation of idmap.idl from winbind.idl

11 years agos4:idmap Adjust code to new idmap structure names and layout.
Andrew Bartlett [Mon, 24 May 2010 00:16:34 +0000 (10:16 +1000)]
s4:idmap Adjust code to new idmap structure names and layout.

Andrew Bartlett

11 years agos4:idmap Seperate idmap structures from winbind.idl and match to source3/ idmap
Andrew Bartlett [Mon, 24 May 2010 00:15:04 +0000 (10:15 +1000)]
s4:idmap Seperate idmap structures from winbind.idl and match to source3/ idmap

These structures now match those in use in the source3 code.  I'm not
sure if this is the better API or not, but it is far, far safer to
remove a pointer than to add one.

Andrew Bartlett

11 years agos4:samr Push most of samr_LookupRids into a helper function
Andrew Bartlett [Sun, 23 May 2010 14:57:32 +0000 (00:57 +1000)]
s4:samr Push most of samr_LookupRids into a helper function

This is a rewrite of the lookup_rids code, using a query based on the
extended DN for a clearer interface.

By splitting this out, the logic is able to be shared, rather than
copied, into a passdb wrapper.

Andrew Bartlett

11 years agos4:samr Push most of samr_QueryGroupMember into a helper function
Andrew Bartlett [Thu, 20 May 2010 22:42:21 +0000 (08:42 +1000)]
s4:samr Push most of samr_QueryGroupMember into a helper function

This is a rewrite of the group membership lookup code, using the
stored extended DNs to avoid doing the lookup into each member to find
the SID

By splitting this out, the logic is able to be shared, rather than
copied, into a passdb wrapper.

Andrew Bartlett

11 years agos4:samr Move most of samr_CreateDomAlias into a helper function
Andrew Bartlett [Thu, 20 May 2010 22:21:37 +0000 (08:21 +1000)]
s4:samr Move most of samr_CreateDomAlias into a helper function

This allows this logic to be shared, rather than copied, into a passdb
wrapper.

Andrew Bartlett

11 years agos4:samr Split most of samr_CreateDomainGroup into a helper function
Andrew Bartlett [Thu, 20 May 2010 22:17:44 +0000 (08:17 +1000)]
s4:samr Split most of samr_CreateDomainGroup into a helper function

This allows this logic to be shared, rather than copied, into a passdb
wrapper.

Andrew Bartlett

11 years agos4:samr Split the guts of samr_CreateUser2 into a helper function
Andrew Bartlett [Thu, 20 May 2010 22:14:53 +0000 (08:14 +1000)]
s4:samr Split the guts of samr_CreateUser2 into a helper function

This allows this logic to be shared, rather than copied, into a passdb
wrapper.

Andrew Bartlett

11 years agos4:dsdb Allow a NULL search expression in dsdb_search()
Andrew Bartlett [Thu, 20 May 2010 22:11:13 +0000 (08:11 +1000)]
s4:dsdb Allow a NULL search expression in dsdb_search()

The NULL search expression expands to (objectClass=*), but %s expands
NULL to (NULL) which doesn't parse...

Andrew Bartlett

11 years agos4:ntvfs rename notify.idl to s4_notify.idl until we can merge this IDL
Andrew Bartlett [Tue, 18 May 2010 10:34:20 +0000 (20:34 +1000)]
s4:ntvfs rename notify.idl to s4_notify.idl until we can merge this IDL

This IDL is almost common, but the source3 version has a
hand-marshalled server_id.  The s3compat build has problems with two
different idl files of the same name.

Andrew Bartlett

11 years agos4:LogonGetDomainInfo - allow to set DNS hostname for the first time
Matthias Dieter Wallnöfer [Mon, 24 May 2010 10:42:32 +0000 (12:42 +0200)]
s4:LogonGetDomainInfo - allow to set DNS hostname for the first time

Otherwise it obviously can never be set.

11 years agos4:"rdn_name" LDB module - fix the creation of the RDN attribute (try to normalise it)
Matthias Dieter Wallnöfer [Mon, 24 May 2010 09:06:29 +0000 (11:06 +0200)]
s4:"rdn_name" LDB module - fix the creation of the RDN attribute (try to normalise it)

And return always the correct error codes on the failed add operations (should
anyway be ERR_OPERATIONS_ERROR - therefore no behaviour change).

11 years agos4:setup/*.ldif - remove unneeded "cn" attributes
Matthias Dieter Wallnöfer [Mon, 24 May 2010 08:38:16 +0000 (10:38 +0200)]
s4:setup/*.ldif - remove unneeded "cn" attributes

Should be generated automatically

11 years agos3: major overhaul of compiler and linker flags for HP-UX builds
Björn Jacke [Wed, 12 May 2010 16:17:30 +0000 (18:17 +0200)]
s3: major overhaul of compiler and linker flags for HP-UX builds

this will fix a number of things like shared library builds. That in turn will
probably trigger some other build bugs...

11 years agos3:Makefile: set PIE flags also for nss_winbind
Björn Jacke [Mon, 24 May 2010 11:41:12 +0000 (13:41 +0200)]
s3:Makefile: set PIE flags also for nss_winbind

11 years agos3:build: remove CFLAGS from LDSHFLAGS, SHLD has them already
Björn Jacke [Wed, 12 May 2010 17:05:37 +0000 (19:05 +0200)]
s3:build: remove CFLAGS from LDSHFLAGS, SHLD has them already

11 years agos3:Makefile: position independency is also needed for shared libs
Björn Jacke [Mon, 24 May 2010 10:21:40 +0000 (12:21 +0200)]
s3:Makefile: position independency is also needed for shared libs

11 years agos3:build: don't use pieflags twice - ldflags already have them
Björn Jacke [Sat, 22 May 2010 14:48:16 +0000 (16:48 +0200)]
s3:build: don't use pieflags twice - ldflags already have them

11 years agos3: Fix a typo found by ITPFS oota <t-oota@dh.jp.nec.com>
Volker Lendecke [Mon, 24 May 2010 09:23:42 +0000 (11:23 +0200)]
s3: Fix a typo found by ITPFS oota <t-oota@dh.jp.nec.com>

Thanks!

11 years agosolve the error "ldb.inst.h does not exist"
Thomas Nagy [Sun, 23 May 2010 19:31:53 +0000 (21:31 +0200)]
solve the error "ldb.inst.h does not exist"

The error happens when headermap.txt is not available

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agobuild: get the SONAME right for installed libraries
Andrew Tridgell [Sun, 23 May 2010 15:55:48 +0000 (17:55 +0200)]
build: get the SONAME right for installed libraries

11 years agoSubstitute the pidl files without using 'headermap.txt'
Thomas Nagy [Sat, 22 May 2010 12:35:50 +0000 (14:35 +0200)]
Substitute the pidl files without using 'headermap.txt'

The headers generated by pidl contain references to bin/default. Those paths
may be replaced automatically.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agos3: Another non-gnumake fix
Volker Lendecke [Sun, 23 May 2010 09:44:30 +0000 (11:44 +0200)]
s3: Another non-gnumake fix

AC_OUTPUT_COMMANDS must be called before AC_OUTPUT and
$MAKEFILE is not defined in ./config.status

11 years agos3: Factor out compiler-independent defines
Volker Lendecke [Sat, 22 May 2010 22:16:52 +0000 (00:16 +0200)]
s3: Factor out compiler-independent defines

11 years agos3: Next step to fix the build on OpenSolaris
Volker Lendecke [Sat, 22 May 2010 22:00:41 +0000 (00:00 +0200)]
s3: Next step to fix the build on OpenSolaris

11 years agos3: Attempt to fix the non-gnumake build
Volker Lendecke [Sat, 22 May 2010 17:29:13 +0000 (19:29 +0200)]
s3: Attempt to fix the non-gnumake build

Björn, please check!

11 years agotorture: fix typos
Simo Sorce [Sat, 22 May 2010 16:40:13 +0000 (12:40 -0400)]
torture: fix typos

11 years agos3: Remove unreachable code
Volker Lendecke [Sat, 22 May 2010 11:08:06 +0000 (13:08 +0200)]
s3: Remove unreachable code

11 years agos4:ldb_controls: make it possible to pass arbitrary control via the command line
Stefan Metzmacher [Fri, 21 May 2010 11:29:14 +0000 (13:29 +0200)]
s4:ldb_controls: make it possible to pass arbitrary control via the command line

--controls=local_oid:1.3.6.1.4.1.7165.4.3.7:1

To specify the DSDB_CONTROL_PASSWORD_HASH_VALUES_OID control as critical.

metze

11 years agoIf using fake oplocks, use the correct SMB2 type code for "no oplock".
Jeremy Allison [Sat, 22 May 2010 06:59:54 +0000 (23:59 -0700)]
If using fake oplocks, use the correct SMB2 type code for "no oplock".

Jeremy.

11 years agos4:libnet: use the new generated config from the provision for the self_join
Stefan Metzmacher [Fri, 21 May 2010 15:33:05 +0000 (17:33 +0200)]
s4:libnet: use the new generated config from the provision for the self_join

This fixes net vampire with the --target-dir option.

metze

11 years agoDon't forget brackets around bitwise tests.
Jeremy Allison [Sat, 22 May 2010 00:12:40 +0000 (17:12 -0700)]
Don't forget brackets around bitwise tests.

Jeremy.

11 years agoMake DFS work over SMB2.
Jeremy Allison [Fri, 21 May 2010 23:56:10 +0000 (16:56 -0700)]
Make DFS work over SMB2.

Jeremy.

11 years agos4:torture/rap/rap.c - quiet discard const warning
Matthias Dieter Wallnöfer [Fri, 21 May 2010 21:23:58 +0000 (23:23 +0200)]
s4:torture/rap/rap.c - quiet discard const warning

11 years agos4:torture/raw/open.c - remove unused variables and fix error handling
Matthias Dieter Wallnöfer [Fri, 21 May 2010 21:19:23 +0000 (23:19 +0200)]
s4:torture/raw/open.c - remove unused variables and fix error handling

11 years agos4:ntvfs/ipc/vfs_ipc.c - add more "const" in order to fix warnings
Matthias Dieter Wallnöfer [Fri, 21 May 2010 21:16:43 +0000 (23:16 +0200)]
s4:ntvfs/ipc/vfs_ipc.c - add more "const" in order to fix warnings

11 years agos4:ntvfs/posix/pvfs_wait.c - fix a "calculated value unused" warning
Matthias Dieter Wallnöfer [Fri, 21 May 2010 21:14:19 +0000 (23:14 +0200)]
s4:ntvfs/posix/pvfs_wait.c - fix a "calculated value unused" warning

The calculated value is "req" (!= NULL) if "talloc_reference" did work correctly
or it is NULL if we ran out of memory.

11 years agoFix bug #7448 - smbd crash when sambaLMPassword and sambaNTPassword entries missing...
Roel van Meer [Fri, 21 May 2010 21:17:17 +0000 (14:17 -0700)]
Fix bug #7448 - smbd crash when sambaLMPassword and sambaNTPassword entries missing from ldap.

Protect SMBsesskeygen_ntv1() from a NULL pointer.

11 years agoMake krb5 over SMB2 identical to the way we handle it in SMB1.
Jeremy Allison [Fri, 21 May 2010 19:08:18 +0000 (12:08 -0700)]
Make krb5 over SMB2 identical to the way we handle it in SMB1.

Jeremy.

11 years agoDoh! If you're going to give advice in "useage", make sure it's correct.
Jeremy Allison [Fri, 21 May 2010 18:40:54 +0000 (11:40 -0700)]
Doh! If you're going to give advice in "useage", make sure it's correct.

Jeremy.

11 years agoAdd comments to usage error message for -k to make it obvious what this needs.
Jeremy Allison [Fri, 21 May 2010 17:35:22 +0000 (10:35 -0700)]
Add comments to usage error message for -k to make it obvious what this needs.

Jeremy.

11 years agoSet SMB2 max read/write/trans sizes to Win7 compatible - 1Mb.
Jeremy Allison [Fri, 21 May 2010 17:32:46 +0000 (10:32 -0700)]
Set SMB2 max read/write/trans sizes to Win7 compatible - 1Mb.

Jeremy.

11 years agos3: added support for fake oplocks in SMB2.
Ira Cooper [Thu, 20 May 2010 15:13:37 +0000 (11:13 -0400)]
s3: added support for fake oplocks in SMB2.

11 years agos4-smbtorture: Fix NetUserPasswordSet2 RAP tests.
Günther Deschner [Fri, 21 May 2010 16:05:48 +0000 (18:05 +0200)]
s4-smbtorture: Fix NetUserPasswordSet2 RAP tests.

Guenther

11 years agos4-smbtorture: fix smbcli_rap_netuserpasswordset2().
Günther Deschner [Fri, 21 May 2010 16:05:10 +0000 (18:05 +0200)]
s4-smbtorture: fix smbcli_rap_netuserpasswordset2().

Guenther

11 years agorap: fix rap_NetUserPasswordSet2 IDL.
Günther Deschner [Fri, 21 May 2010 16:02:45 +0000 (18:02 +0200)]
rap: fix rap_NetUserPasswordSet2 IDL.

Guenther

11 years agos3-net: fix net_ads_gpo() for non-ads case.
Günther Deschner [Fri, 21 May 2010 16:06:51 +0000 (18:06 +0200)]
s3-net: fix net_ads_gpo() for non-ads case.

Guenther

11 years agos4-drsuapi: Sort ATTID definitions by ATTID value
Kamen Mazdrashki [Fri, 21 May 2010 02:36:35 +0000 (05:36 +0300)]
s4-drsuapi: Sort ATTID definitions by ATTID value

11 years agos4/drsuapi: Yet another set of predefined ATTIDs
Kamen Mazdrashki [Fri, 21 May 2010 02:27:04 +0000 (05:27 +0300)]
s4/drsuapi: Yet another set of predefined ATTIDs

11 years agos4-torture: Improved the winreg symlink test.
Andreas Schneider [Thu, 20 May 2010 12:00:57 +0000 (14:00 +0200)]
s4-torture: Improved the winreg symlink test.

This test is still disabled as we don't know how to remove a symbolic
link. It looks like there only DeleteKey functions which can work on a
handle are able to delete a symbolic link.

Pair-Programmed-With: Michael Adam <obnox@samba.org>

11 years agos4-torture: Disable the security descriptor tests.
Andreas Schneider [Fri, 21 May 2010 10:49:23 +0000 (12:49 +0200)]
s4-torture: Disable the security descriptor tests.

11 years agos4-torture: Try to fix the winreg tests.
Andreas Schneider [Fri, 21 May 2010 10:42:55 +0000 (12:42 +0200)]
s4-torture: Try to fix the winreg tests.

11 years agos4:ldb: add --controls support to ldbedit
Stefan Metzmacher [Fri, 21 May 2010 09:30:20 +0000 (11:30 +0200)]
s4:ldb: add --controls support to ldbedit

metze

11 years agowafsamba: Disable the abi checks when gdb is not available
Thomas Nagy [Fri, 21 May 2010 10:48:11 +0000 (12:48 +0200)]
wafsamba: Disable the abi checks when gdb is not available

Try to find gdb during the configuration, if gdb is missing, disable
the abi checks.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:libcli/ldap Update headermap.txt (autotools build) and wscript_build for libcli_ldap.h
Andrew Bartlett [Fri, 21 May 2010 10:07:18 +0000 (20:07 +1000)]
s4:libcli/ldap Update headermap.txt (autotools build) and wscript_build for libcli_ldap.h

It took a little while to find where to update this...

Andrew Bartlett

11 years agos4:torture:winreg: improve error messages in test_HKLM_wellknown
Michael Adam [Fri, 21 May 2010 08:56:37 +0000 (10:56 +0200)]
s4:torture:winreg: improve error messages in test_HKLM_wellknown

11 years agos4:torture:winreg: improve error messages in test_QueryValue_full
Michael Adam [Fri, 21 May 2010 08:53:35 +0000 (10:53 +0200)]
s4:torture:winreg: improve error messages in test_QueryValue_full

So that one has a chance to tell what part of the test failed. And why.

11 years agos3:dom_sid Global replace of DOM_SID with struct dom_sid
Andrew Bartlett [Fri, 21 May 2010 01:25:01 +0000 (11:25 +1000)]
s3:dom_sid Global replace of DOM_SID with struct dom_sid

This matches the structure that new code is being written to,
and removes one more of the old-style named structures, and
the need to know that is is just an alias for struct dom_sid.

Andrew Bartlett

Signed-off-by: Günther Deschner <gd@samba.org>
11 years agos3:passdb Remove use of uint8 uint16 and uint32 in favour of C99 types
Andrew Bartlett [Fri, 21 May 2010 00:38:04 +0000 (10:38 +1000)]
s3:passdb Remove use of uint8 uint16 and uint32 in favour of C99 types

Signed-off-by: Günther Deschner <gd@samba.org>
11 years agos4:libcli/ldap Rename ldap.h to libcli_ldap.h
Andrew Bartlett [Fri, 21 May 2010 07:39:15 +0000 (17:39 +1000)]
s4:libcli/ldap Rename ldap.h to libcli_ldap.h

It is a problem if a samba header is called ldap.h if we also want
to use OpenLDAP's ldap.h

Andrew Bartlett

11 years agos4:auth Remove un-needed headers.
Andrew Bartlett [Fri, 21 May 2010 06:38:44 +0000 (16:38 +1000)]
s4:auth Remove un-needed headers.

11 years agos4:auth Fix previous commit - segfault in determinging a user's groups
Andrew Bartlett [Fri, 21 May 2010 06:01:34 +0000 (16:01 +1000)]
s4:auth Fix previous commit - segfault in determinging a user's groups

The previous commit didn't include these vital fixes.

Andrew Bartlett

11 years agoRevert "Make -k a simple non-bool option."
Andrew Bartlett [Fri, 21 May 2010 05:04:36 +0000 (15:04 +1000)]
Revert "Make -k a simple non-bool option."

This reverts commit 2bbf055dbb15ea99b80ae66adc906ad5494a3999.

This change broke 'make test', because the current syntax is deliberate
and an integral part of how Samba4 uses Kerberos.

If a change like this is to be implemented, then careful review of all
our test scripts must be taken first, and then new options such as
--dont-use-kerberos, --may-use-kerberos and --must-use-kerberos
should be added.

Andrew Bartlett

11 years agos4:auth Error out when a memberOf DN does not have a SID
Andrew Bartlett [Fri, 21 May 2010 05:02:22 +0000 (15:02 +1000)]
s4:auth Error out when a memberOf DN does not have a SID

We previously segfaulted if this was not the case.

Andrew Bartlett

11 years agos4-smbtorture: add kernel_mode_registry_path().
Günther Deschner [Thu, 20 May 2010 23:25:16 +0000 (01:25 +0200)]
s4-smbtorture: add kernel_mode_registry_path().

Guenther

11 years agos4-smbtorture: Fix volatile test in RPC-WINREG.
Günther Deschner [Thu, 20 May 2010 22:28:36 +0000 (00:28 +0200)]
s4-smbtorture: Fix volatile test in RPC-WINREG.

Guenther

11 years agos3: registry: add tests with empty valuename
Gregor Beck [Wed, 19 May 2010 09:37:23 +0000 (11:37 +0200)]
s3: registry: add tests with empty valuename

Signed-off-by: Michael Adam <obnox@samba.org>
11 years agos3: registry: let test_setvalue use getvalueraw instead of enumerate
Gregor Beck [Wed, 19 May 2010 10:20:10 +0000 (12:20 +0200)]
s3: registry: let test_setvalue use getvalueraw instead of enumerate

simplifies code, prerequisite to handle empty valuenames

Signed-off-by: Michael Adam <obnox@samba.org>
11 years agos3: registry: fix query empty valuenames
Gregor Beck [Wed, 19 May 2010 09:16:54 +0000 (11:16 +0200)]
s3: registry: fix query empty valuenames

Remove a check introduced with commit 80c2446321c519797a57b8006942a983f8481d79
wich causes queries for values with empty name to fail. Empty valuenames are
used for the so called default value of a key.

Signed-off-by: Michael Adam <obnox@samba.org>
11 years agos3-waf: Actually make --with/--without-swat work
Kai Blin [Thu, 20 May 2010 21:05:21 +0000 (23:05 +0200)]
s3-waf: Actually make --with/--without-swat work

11 years agos3-waf: Really disable winbindd build when --without-winbind is specified
Kai Blin [Thu, 20 May 2010 20:58:59 +0000 (22:58 +0200)]
s3-waf: Really disable winbindd build when --without-winbind is specified