Günther Deschner [Thu, 5 Aug 2010 13:03:00 +0000 (15:03 +0200)]
s3: remove global include of samr.h
Guenther
Günther Deschner [Wed, 4 Aug 2010 10:01:50 +0000 (12:01 +0200)]
s3-build: no need to include privileges.h twice.
Guenther
Günther Deschner [Mon, 2 Aug 2010 22:03:03 +0000 (00:03 +0200)]
s3-net: only include netapi header when needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:21:09 +0000 (23:21 +0200)]
s3-libsmb: include nbt.h in namequery_dc code.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:18:53 +0000 (23:18 +0200)]
s3-libnet: include netlogon.h in libnet samsync header.
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:25:35 +0000 (15:25 +0200)]
s3-smbtorture: include svcctl.h
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:17:25 +0000 (23:17 +0200)]
s3-services: include svcctl.h where needed.
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:02:09 +0000 (15:02 +0200)]
s3-build: remove global include of krb5pac.h.
Put in samr and netlogon, as they were pulled in via krb5pac.h.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:12:16 +0000 (23:12 +0200)]
s3-krb5: include krb5pac.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:54:29 +0000 (22:54 +0200)]
s3-rap: include svcctl.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:52:00 +0000 (22:52 +0200)]
s3-passdb: include samr.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:23:12 +0000 (23:23 +0200)]
s3-param: include svcctl headers in loadparm.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:48:16 +0000 (22:48 +0200)]
s3-nmbd: include svcctl.h where needed.
Guenther
Volker Lendecke [Mon, 19 Jul 2010 19:00:41 +0000 (21:00 +0200)]
s3: Remove some explicit calls to procid_self()
Volker Lendecke [Mon, 19 Jul 2010 19:04:04 +0000 (21:04 +0200)]
s3: Remove some explicit calls to procid_self()
Andreas Schneider [Fri, 6 Aug 2010 11:49:37 +0000 (13:49 +0200)]
s3-spoolss: Make sure we convert a 4 byte value to uint32_t.
Andreas Schneider [Fri, 6 Aug 2010 11:49:01 +0000 (13:49 +0200)]
s3-spoolss: Fixed setting driver version correctly.
We are in a loop here, so setting tmp to 0 at the beginning of each
iteration sets info8->version to 0 if we enumerate over another value.
Stefan Metzmacher [Thu, 5 Aug 2010 08:04:57 +0000 (10:04 +0200)]
pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size < r.in.size.
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Fri, 6 Aug 2010 10:32:30 +0000 (12:32 +0200)]
s3: fail db_open_ctdb if ctdb is not around
Andrew Tridgell [Fri, 6 Aug 2010 03:06:42 +0000 (13:06 +1000)]
s3-printing: cope with missing printers in print migration
The printers database may be completely missing in a new install, and
we may have SECDESC entries for printers that have been removed. Don't
consider these fatal errors in the migration.
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Fri, 6 Aug 2010 06:14:11 +0000 (16:14 +1000)]
s4:ntlmssp Adjust Samba4 ntlmssp code to look more like the code in Samba3.
This does not change behaviour, and some of the whitespace isn't ideal, but
at the moment making this code more similar, even in cosmetics, will assist
later merge efforts.
Andrew Bartlett
Andreas Schneider [Thu, 5 Aug 2010 14:05:31 +0000 (16:05 +0200)]
s3-torture: Improve the winreg deletekey torture comments.
Andreas Schneider [Thu, 5 Aug 2010 13:35:52 +0000 (15:35 +0200)]
s3-torture: Correctly cleanup the winreg volatile key test.
Günther please check!
Andreas Schneider [Thu, 5 Aug 2010 13:24:20 +0000 (15:24 +0200)]
s4-torture: Fixed the winreg EnumValue test against Windows.
Günther please check!
Volker Lendecke [Thu, 5 Aug 2010 12:05:58 +0000 (14:05 +0200)]
s3: Remove some direct cli->inbuf references in interpret_long_filename
Volker Lendecke [Thu, 5 Aug 2010 12:02:56 +0000 (14:02 +0200)]
s3: Remove a pointless wrapper function
Volker Lendecke [Thu, 5 Aug 2010 11:45:59 +0000 (13:45 +0200)]
s3: Explicitly pass flags2 to clistr_pull_talloc
Required to eventually make cli_list async
Volker Lendecke [Thu, 5 Aug 2010 11:11:14 +0000 (13:11 +0200)]
s3: Remove some pointless wrapper functions
Volker Lendecke [Thu, 5 Aug 2010 11:06:11 +0000 (13:06 +0200)]
s3: Remove some pointless wrapper functions
Volker Lendecke [Thu, 5 Aug 2010 10:48:52 +0000 (12:48 +0200)]
s3: Save the received trans2 from the inbuf in cli_trans
Volker Lendecke [Thu, 5 Aug 2010 10:45:20 +0000 (12:45 +0200)]
s3: Fix a crash in masktest
Andreas Schneider [Thu, 5 Aug 2010 09:36:37 +0000 (11:36 +0200)]
s3-spoolss: Use the correct value for the data length.
Andreas Schneider [Thu, 5 Aug 2010 08:49:53 +0000 (10:49 +0200)]
s3-popt: Only include popt-common.h when needed.
Günther Deschner [Thu, 5 Aug 2010 00:25:37 +0000 (02:25 +0200)]
s3-secrets: only include secrets.h when needed.
Guenther
Andrew Tridgell [Tue, 11 May 2010 05:35:43 +0000 (07:35 +0200)]
s4-dns: ndr_dnsp helper functions
these handle the dnsp_name type
Andrew Tridgell [Thu, 5 Aug 2010 05:25:38 +0000 (15:25 +1000)]
s4-dns: fix dnsp for old build
Andrew Tridgell [Tue, 11 May 2010 05:09:46 +0000 (07:09 +0200)]
s4-dns: expanded the DNSP code to handle more record type
Andrew Tridgell [Tue, 11 May 2010 05:09:05 +0000 (07:09 +0200)]
pidl: added a new type dnsp_name
This is a name type used in DNS where each DNS component maps to a
length byte followed by the string
We want these to map to a char *, which is why we need to do this in
PIDL
Andrew Tridgell [Thu, 5 Aug 2010 05:22:49 +0000 (15:22 +1000)]
s4-ldb: added ldif handler for the dnsRecord attribute
Andrew Tridgell [Thu, 5 Aug 2010 05:20:13 +0000 (15:20 +1000)]
dns: first version of dsnRecord parser
Günther Deschner [Thu, 1 Jul 2010 22:32:52 +0000 (00:32 +0200)]
s3: avoid global include of ads.h.
Guenther
Günther Deschner [Wed, 4 Aug 2010 14:49:43 +0000 (16:49 +0200)]
s3-libnet_join: add ads.h as helper header to IDL.
Guenther
Günther Deschner [Wed, 4 Aug 2010 13:31:08 +0000 (15:31 +0200)]
s3-printing: move AD related printing components to an own file.
Guenther
Volker Lendecke [Mon, 2 Aug 2010 17:22:22 +0000 (19:22 +0200)]
s3: Convert cli_list() to return NTSTATUS
If needed, the callback functions can count themselves
Volker Lendecke [Mon, 2 Aug 2010 13:25:45 +0000 (15:25 +0200)]
s3: Use data_blob_null
Matthias Dieter Wallnöfer [Wed, 4 Aug 2010 17:43:59 +0000 (19:43 +0200)]
s4:LDB modules - remove the "kludge_acl" module code
Obviously this has been forgotten by Nadya.
Günther Deschner [Wed, 4 Aug 2010 12:55:10 +0000 (14:55 +0200)]
s3-waf: fix the build.
Guenther
Nadezhda Ivanova [Wed, 4 Aug 2010 12:22:17 +0000 (15:22 +0300)]
s4-dsdb: Removed kludge_acl as it is no longer necessary
Moved the access check on extended operations to acl module and removed kludge_acl
Christian Ambach [Wed, 21 Apr 2010 13:10:39 +0000 (15:10 +0200)]
small optimizations for shadowcopy2 module
- remove a compiler warning
- replace strlen usage
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Christian Ambach [Wed, 14 Apr 2010 08:05:56 +0000 (10:05 +0200)]
fix snapshot content display with hide unreadable
With the hide unreadable option set, snapshots are be displayed
as empty with shadow_copy2 and a NFSv4 ACL module.
To prevent multiple conversions of the paths when the acl call
does a VFS_STAT (as the nfs4acl code does), a check was added
to convert_shadow2_name() so it will not touch paths any more
that look like they have already been converted.
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Thu, 12 Nov 2009 11:30:58 +0000 (12:30 +0100)]
s3: Fix shadow copies after the change for in-path @GMT-
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Mon, 9 Nov 2009 10:06:30 +0000 (11:06 +0100)]
s3: Fix in-path shadowcopy2 module
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
olivier [Mon, 2 Aug 2010 22:20:11 +0000 (00:20 +0200)]
make scannedonly notify the scanner if no .scanned: file was found during rename
Günther Deschner [Tue, 3 Aug 2010 13:55:20 +0000 (15:55 +0200)]
s3-dcerpc: fix some uninitialized variables build warnings.
Guenther
Günther Deschner [Tue, 3 Aug 2010 13:13:57 +0000 (15:13 +0200)]
s3-spoolss: fix type-punned pointer build warning.
Guenther
Günther Deschner [Tue, 3 Aug 2010 12:51:27 +0000 (14:51 +0200)]
s3-spoolss: fix uninitialized variable build warning.
Andreas, please check.
Guenther
Günther Deschner [Tue, 3 Aug 2010 11:18:01 +0000 (13:18 +0200)]
s3-printing: make sure to set NTSTATUS code before checking it.
Andreas, please check.
Guenther
Anatoliy Atanasov [Mon, 2 Aug 2010 13:47:38 +0000 (16:47 +0300)]
s4/vampire: update dNSHostName for the Server object
Kamen Mazdrashki [Tue, 3 Aug 2010 01:26:57 +0000 (04:26 +0300)]
s4-schema: More verbose error log when subClassOf is not found in schema
Error message show failing classSchema object
but not the specific value for the failure,
which makes diagnostics by log files really hard.
Kamen Mazdrashki [Tue, 3 Aug 2010 01:14:45 +0000 (04:14 +0300)]
s4: fix comment typos
Günther Deschner [Mon, 2 Aug 2010 22:12:27 +0000 (00:12 +0200)]
s3-spoolss: remove duplicate (and incorrect) header.
Guenther
Andreas Schneider [Mon, 2 Aug 2010 16:32:40 +0000 (18:32 +0200)]
idl: Fixed a possible crash bug.
Stefan Metzmacher [Mon, 2 Aug 2010 08:21:36 +0000 (10:21 +0200)]
s4:librpc/rpc: avoid using DCERPC_NDR_REF_ALLOC for epm_Map()
metze
Stefan Metzmacher [Mon, 2 Aug 2010 07:53:27 +0000 (09:53 +0200)]
s4:torture/libnet: avoid dereferencing dcerpc_binding_handle internals
metze
Andreas Schneider [Mon, 2 Aug 2010 11:49:59 +0000 (13:49 +0200)]
s3-spoolss: Fixed a segfault if a value has no data.
Andreas Schneider [Mon, 2 Aug 2010 11:21:47 +0000 (13:21 +0200)]
s3-spoolss: Move some debug message to a higher level.
Andreas Schneider [Mon, 2 Aug 2010 10:38:57 +0000 (12:38 +0200)]
s3-spoolss: Fixed some C++ build warnings.
Andreas Schneider [Mon, 2 Aug 2010 10:09:03 +0000 (12:09 +0200)]
s3-spoolss: Use a stackframe to allocat memory.
This is faster and should be more secure to use if something goes wrong.
Günther Deschner [Mon, 2 Aug 2010 14:08:30 +0000 (16:08 +0200)]
s4-smbtorture: remove another old and now invalid s3 special case during spoolss testing.
Guenther
Günther Deschner [Mon, 2 Aug 2010 13:52:09 +0000 (15:52 +0200)]
spoolss: fix potential crash bug in spoolss_PrinterEnumValues push path.
Guenther
Günther Deschner [Mon, 2 Aug 2010 13:31:10 +0000 (15:31 +0200)]
s3-spoolss: remove unused MAX_OPEN_PRINTER_EXS define.
Guenther
Günther Deschner [Sun, 1 Aug 2010 13:34:52 +0000 (15:34 +0200)]
s3-build: fix some c++ build warnings.
Guenther
Volker Lendecke [Mon, 2 Aug 2010 09:03:13 +0000 (11:03 +0200)]
s3: Use cups-config --libs
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 20:12:04 +0000 (22:12 +0200)]
s4:ldap.py - remove superflous spaces
Sorry, forgot to delete them in the last commit
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 19:12:50 +0000 (21:12 +0200)]
s4:ldap.py - additional "instanceType" checks
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 15:34:43 +0000 (17:34 +0200)]
s4:instancetype LDB module - add checks requested by MS-ADTS 3.1.1.5.2.2
We've to test for the WRITE flag if we are performing an NC add. And if it
isn't an NC add then only the WRITE or no flag is allowed.
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 15:36:11 +0000 (17:36 +0200)]
s4:objectclass LDB module - consider the "instanceType" when adding NCs
This is requested by MS-ADTS 3.1.1.5.2.2 (NC add operation).
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 15:02:45 +0000 (17:02 +0200)]
s4:descriptor LDB module - remove the "forest DN" check
Also here we have to work with the default base DN.
After some reading I've discovered that this isn't really true. The forest
partition does exist on one or more DCs and is there the same as the default
base DN (which is already checked by the module).
And if we have other DCs which contain child domains then they never contain
data of the forest domain beside the schema and the configuration partition
(which are checked anyway) since a DC can always contain only one domain!
Link: http://www.informit.com/articles/article.aspx?p=26896&seqNum=5
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 15:02:45 +0000 (17:02 +0200)]
s4:acl LDB module - remove the "forest DN" check
After some reading I've discovered that this isn't really true. The forest
partition does exist on one or more DCs and is there the same as the default
base DN (which is already checked by the module).
And if we have other DCs which contain child domains then they never contain
data of the forest domain beside the schema and the configuration partition
(which are checked anyway) since a DC can always contain only one domain!
Link: http://www.informit.com/articles/article.aspx?p=26896&seqNum=5
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 14:39:45 +0000 (16:39 +0200)]
s4:acl LDB module - remove unused call "is_root_base_dn"
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 15:44:50 +0000 (17:44 +0200)]
s4:urgent_replication.py test - adapt the test for the harder delete restrictions
Otherwise we are not able to delete the "test crossRef" object which points
to the default NC anymore.
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 11:09:46 +0000 (13:09 +0200)]
s4:ldap.py - perform tests on the additional delete constraint checks
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 10:50:56 +0000 (12:50 +0200)]
s4:objectclass LDB module - implement additional delete constraint checks
MS-ADTS 3.1.1.5.5.3
Volker Lendecke [Sun, 1 Aug 2010 18:15:57 +0000 (20:15 +0200)]
s3: Fix an uninitialized variable
Volker Lendecke [Sun, 1 Aug 2010 18:15:39 +0000 (20:15 +0200)]
s3: Fix a C++ warning
Volker Lendecke [Mon, 19 Jul 2010 19:00:31 +0000 (21:00 +0200)]
s3: Fix some nonempty blank lines
Volker Lendecke [Sun, 1 Aug 2010 17:55:06 +0000 (19:55 +0200)]
s3: Fix an uninitialized variable
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 09:26:08 +0000 (11:26 +0200)]
s4:ldap.py - add a test for "CN=System" object rename behaviour
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 09:06:18 +0000 (11:06 +0200)]
s4:subtree_rename LDB module - rename "check_system_flags" into "check_constraints" and perform more checks
Always considering MS-ADTS 3.1.1.5.4.1.2.
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 09:05:26 +0000 (11:05 +0200)]
s4:subtree_rename LDB module - introduce out of memory checks
Matthias Dieter Wallnöfer [Sun, 1 Aug 2010 09:32:14 +0000 (11:32 +0200)]
s4:dsdb/samdb/ldb_modules/util.c - remove unused variables
Stefan Metzmacher [Sun, 1 Aug 2010 09:18:05 +0000 (11:18 +0200)]
s4:torture/rpc/winreg: fix "strict aliasing" compiler warnings
metze
Stefan Metzmacher [Sun, 1 Aug 2010 09:17:14 +0000 (11:17 +0200)]
s4:torture/rpc/winreg: fix the build with non gcc compilers (e.g. on solaris)
metze
Matthias Dieter Wallnöfer [Fri, 9 Jul 2010 17:22:01 +0000 (19:22 +0200)]
s4:ldap.py - performs some "systemFlags" testing
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 18:07:09 +0000 (20:07 +0200)]
s4:subtree_rename LDB module - introduce the "systemFlags" protection rules
This is done in a dedicated call "check_system_flags".
Matthias Dieter Wallnöfer [Thu, 8 Jul 2010 19:05:33 +0000 (21:05 +0200)]
s4:dsdb/pydsdb.c - import "systemFlags" into Python
Needed by ldap.py tests
Matthias Dieter Wallnöfer [Sat, 31 Jul 2010 19:26:38 +0000 (21:26 +0200)]
s4:subtree_rename LDB module - "subren_ctx_init" - fix the "out of memory" return
Matthias Dieter Wallnöfer [Sat, 31 Jul 2010 18:59:02 +0000 (20:59 +0200)]
s4:torture/winreg.c - fix warnings of Solaris 10 cc through the appropriate casts
Matthias Dieter Wallnöfer [Sat, 31 Jul 2010 18:58:47 +0000 (20:58 +0200)]
s4:torture/winreg.c - remove unreachable code
Matthias Dieter Wallnöfer [Sat, 31 Jul 2010 18:57:18 +0000 (20:57 +0200)]
s4:torture/winreg.c - add a FIXME comment on a codepart which isn't standard C-compatible
It seems to be GCC specific since it doesn't compile on Solaris 10 cc:
http://build.samba.org/?function=View+Build;host=sunX;tree=samba_4_0_waf;compiler=cc