amitay/samba.git
14 years agos4-dsdb: use GUID_from_ndr_blob() to create dsdb_get_extended_dn_guid()
Andrew Tridgell [Thu, 10 Dec 2009 00:23:20 +0000 (11:23 +1100)]
s4-dsdb: use GUID_from_ndr_blob() to create dsdb_get_extended_dn_guid()

14 years agolibrpc: split out a separate GUID_from_ndr_blob() function
Andrew Tridgell [Thu, 10 Dec 2009 00:22:20 +0000 (11:22 +1100)]
librpc: split out a separate GUID_from_ndr_blob() function

This will simplify many of the places that deal with NDR formatted
GUIDs

14 years agos4-smbtorture: enhance spoolss_EnumPrinterKey torture test.
Günther Deschner [Wed, 9 Dec 2009 14:31:51 +0000 (15:31 +0100)]
s4-smbtorture: enhance spoolss_EnumPrinterKey torture test.

This demonstrates that s3 still does not have that call implemented correctly.

Guenther

14 years agos3: check for PAM_RADIO_TYPE.
Bo Yang [Thu, 10 Dec 2009 11:29:24 +0000 (19:29 +0800)]
s3: check for PAM_RADIO_TYPE.

Signed-off-by: Bo Yang <boyang@samba.org>
14 years agos3: Fix build on non-linux platform.
Bo Yang [Thu, 10 Dec 2009 09:20:03 +0000 (17:20 +0800)]
s3: Fix build on non-linux platform.

Signed-off-by: Bo Yang <boyang@samba.org>
14 years agoWHATSNEW4: Samba 3.0 is not up-to-date.
Karolin Seeger [Wed, 9 Dec 2009 08:15:39 +0000 (09:15 +0100)]
WHATSNEW4: Samba 3.0 is not up-to-date.

Karolin

14 years agos4-dsdb: added dsdb_functional_level() helper function
Andrew Tridgell [Wed, 9 Dec 2009 04:18:37 +0000 (15:18 +1100)]
s4-dsdb: added dsdb_functional_level() helper function

14 years agos4-drs: ensure we fill in ncRoot_dn in getncchanges
Andrew Tridgell [Wed, 9 Dec 2009 03:39:05 +0000 (14:39 +1100)]
s4-drs: ensure we fill in ncRoot_dn in getncchanges

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agos4-drs: use parentGUID attribute in getncchanges
Andrew Tridgell [Wed, 9 Dec 2009 03:38:25 +0000 (14:38 +1100)]
s4-drs: use parentGUID attribute in getncchanges

Now that parentGUID is reliable again, use it instead
of building our own

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agos4-ldb: fixed nested searches inside ldb modules
Andrew Tridgell [Wed, 9 Dec 2009 03:37:26 +0000 (14:37 +1100)]
s4-ldb: fixed nested searches inside ldb modules

We need to keep a search count in ltdb to allow for nesting
of searches inside a module

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agos4-ldb: added a missing ltdb_unlock_read()
Andrew Tridgell [Wed, 9 Dec 2009 03:36:50 +0000 (14:36 +1100)]
s4-ldb: added a missing ltdb_unlock_read()

14 years agos4-dsdb: use dsdb_module_search_dn in repl_meta_data
Andrew Tridgell [Wed, 9 Dec 2009 03:35:46 +0000 (14:35 +1100)]
s4-dsdb: use dsdb_module_search_dn in repl_meta_data

This allows us to search below the current module. That
will be important when we start using the results of this
search to get the linked attributes meta data right

14 years agos4-dsdb: fixed steal of parentGUID for empty msg
Andrew Tridgell [Wed, 9 Dec 2009 03:34:13 +0000 (14:34 +1100)]
s4-dsdb: fixed steal of parentGUID for empty msg

msg->elements could be NULL before we add parentGUID

14 years agos3: Give the user a chance to change password when password will expire soon.
Bo Yang [Thu, 10 Dec 2009 06:30:13 +0000 (14:30 +0800)]
s3: Give the user a chance to change password when password will expire soon.

Signed-off-by: Bo Yang <boyang@samba.org>
14 years agos3: keep subsecond times on cross-filesystem moves and don't follow links
Björn Jacke [Wed, 9 Dec 2009 01:06:17 +0000 (02:06 +0100)]
s3: keep subsecond times on cross-filesystem moves and don't follow links

14 years agos3:configure: check for lutimes, futimes and futimens
Björn Jacke [Wed, 9 Dec 2009 01:04:23 +0000 (02:04 +0100)]
s3:configure: check for lutimes, futimes and futimens

14 years agoMerge commit 'origin/master' into abartlet-devel
Andrew Bartlett [Wed, 9 Dec 2009 00:53:45 +0000 (11:53 +1100)]
Merge commit 'origin/master' into abartlet-devel

14 years agos4: On the way to alpha11
Andrew Bartlett [Wed, 9 Dec 2009 00:52:41 +0000 (11:52 +1100)]
s4: On the way to alpha11

14 years agos3:doc: make dos filetimes description less contradictory
Björn Jacke [Tue, 8 Dec 2009 20:32:51 +0000 (21:32 +0100)]
s3:doc: make dos filetimes description less contradictory

14 years agos3: make sys_posix_fallocate more generic
Björn Jacke [Tue, 8 Dec 2009 20:13:19 +0000 (21:13 +0100)]
s3: make sys_posix_fallocate more generic

this is in preparation for other preallocation methods to be introduced.

14 years agos3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code.
Günther Deschner [Tue, 8 Dec 2009 13:46:10 +0000 (14:46 +0100)]
s3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code.

Guenther

14 years agospoolss: add more spoolss architectures to IDL.
Günther Deschner [Tue, 1 Dec 2009 23:59:21 +0000 (00:59 +0100)]
spoolss: add more spoolss architectures to IDL.

Guenther

14 years agoThis is alpha10 release-4-0-0alpha10 samba-4.0.0alpha10
Andrew Bartlett [Tue, 8 Dec 2009 03:12:19 +0000 (14:12 +1100)]
This is alpha10

14 years agoA WHATSNEW for alpha10
Andrew Bartlett [Tue, 8 Dec 2009 03:11:45 +0000 (14:11 +1100)]
A WHATSNEW for alpha10

14 years agos4:selftest: skip SMB2-ACLS for now
Stefan Metzmacher [Tue, 8 Dec 2009 11:53:51 +0000 (12:53 +0100)]
s4:selftest: skip SMB2-ACLS for now

metze

14 years agos4:selftest: run RAW-STREAMS again
Stefan Metzmacher [Tue, 8 Dec 2009 10:52:25 +0000 (11:52 +0100)]
s4:selftest: run RAW-STREAMS again

metze

14 years agoRAW-STREAMS: convert failing tests to torture api
Stefan Metzmacher [Tue, 8 Dec 2009 10:47:06 +0000 (11:47 +0100)]
RAW-STREAMS: convert failing tests to torture api

This is needed as we want to mark failing tests as
known failures.

metze

14 years agospoolss: fix spoolss_DriverInfo8 IDL.
Günther Deschner [Mon, 7 Dec 2009 17:55:08 +0000 (18:55 +0100)]
spoolss: fix spoolss_DriverInfo8 IDL.

found by RPC-SPOOLSS torture teset.

Guenther

14 years agos4-smbtorture: make level 8 the reference for PrinterDriverEnum test.
Günther Deschner [Mon, 7 Dec 2009 18:26:45 +0000 (19:26 +0100)]
s4-smbtorture: make level 8 the reference for PrinterDriverEnum test.

Guenther

14 years agos3-spoolss: cleanup _spoolss_EnumPrinterDrivers().
Günther Deschner [Mon, 7 Dec 2009 15:19:26 +0000 (16:19 +0100)]
s3-spoolss: cleanup _spoolss_EnumPrinterDrivers().

Guenther

14 years agos3-spoolss: remove unused architecture from fill_printer_driver_info1().
Günther Deschner [Mon, 7 Dec 2009 15:18:55 +0000 (16:18 +0100)]
s3-spoolss: remove unused architecture from fill_printer_driver_info1().

Guenther

14 years agos3-spoolss: remove ridiculous amount of duplicate driver code.
Günther Deschner [Thu, 3 Dec 2009 18:42:22 +0000 (19:42 +0100)]
s3-spoolss: remove ridiculous amount of duplicate driver code.

Guenther

14 years agos3-spoolss: fully support level 8 drivers.
Günther Deschner [Thu, 3 Dec 2009 18:11:53 +0000 (19:11 +0100)]
s3-spoolss: fully support level 8 drivers.

Guenther

14 years agos3-spoolss: use driver level info8 everywhere in spoolss server internally.
Günther Deschner [Fri, 27 Nov 2009 00:49:08 +0000 (01:49 +0100)]
s3-spoolss: use driver level info8 everywhere in spoolss server internally.

Guenther

14 years agos4-smbtorture: fill in COMPARE_STRING_ARRAY macro in spoolss driver test.
Günther Deschner [Tue, 8 Dec 2009 09:21:28 +0000 (10:21 +0100)]
s4-smbtorture: fill in COMPARE_STRING_ARRAY macro in spoolss driver test.

Guenther

14 years agos3: allocate only "new" space, not "old" sparse space in the posix_fallocate path
Björn Jacke [Tue, 8 Dec 2009 09:30:03 +0000 (10:30 +0100)]
s3: allocate only "new" space, not "old" sparse space in the posix_fallocate path

this makes the posix_fallocate path work analogous to the manual allocate path.

14 years agos4:selftest: use ${selftest_prefix} instead of hardcoded st/
Stefan Metzmacher [Tue, 8 Dec 2009 08:19:35 +0000 (09:19 +0100)]
s4:selftest: use ${selftest_prefix} instead of hardcoded st/

metze

14 years agopackaging(RHEL-CTDB): clean some commented out lines from the files sections
Michael Adam [Mon, 7 Dec 2009 13:27:28 +0000 (14:27 +0100)]
packaging(RHEL-CTDB): clean some commented out lines from the files sections

Michael

14 years agopackaging(RHEL-CTDB): explicitly list library versions in samba-winbind-32bit
Michael Adam [Mon, 7 Dec 2009 13:26:03 +0000 (14:26 +0100)]
packaging(RHEL-CTDB): explicitly list library versions in samba-winbind-32bit

Michael

14 years agopackaging(RHEL-CTDB): explicitly list library versions in samba-common
Michael Adam [Mon, 7 Dec 2009 13:25:32 +0000 (14:25 +0100)]
packaging(RHEL-CTDB): explicitly list library versions in samba-common

Michael

14 years agopackaging(RHEL-CTDB): explicitly list all packaged idmap/nss-info/charset modules
Michael Adam [Mon, 7 Dec 2009 13:20:24 +0000 (14:20 +0100)]
packaging(RHEL-CTDB): explicitly list all packaged idmap/nss-info/charset modules

in the samba-common package.
This is to  better be able to catch regressions or
build problems.

Michael

14 years agopackaging(RHEL-CTDB): explicitly list all the vfs modules in the main package
Michael Adam [Mon, 7 Dec 2009 13:16:15 +0000 (14:16 +0100)]
packaging(RHEL-CTDB): explicitly list all the vfs modules in the main package

Instead of the wildcard list, to better control regressions or
build problems.

Michael

14 years agopackaging(RHEL-CTDB): add some checks to test the built smbd
Michael Adam [Mon, 7 Dec 2009 13:12:05 +0000 (14:12 +0100)]
packaging(RHEL-CTDB): add some checks to test the built smbd

Test whether some required features have been built into smbd.
Can be extended...

Michael

14 years agopackaging(RHEL-CTDB): make everything instead of all in the build stage
Michael Adam [Mon, 7 Dec 2009 13:11:32 +0000 (14:11 +0100)]
packaging(RHEL-CTDB): make everything instead of all in the build stage

Michael

14 years agos4-selftest: show the test summary at the end of 'make test' in the build farm
Andrew Tridgell [Tue, 8 Dec 2009 04:58:45 +0000 (15:58 +1100)]
s4-selftest: show the test summary at the end of 'make test' in the build farm

This should make it easier to see what tests are failing with what
parameters

14 years agos4-heimdal: fixed a use-after-free heimdal bug
Andrew Tridgell [Tue, 8 Dec 2009 04:15:41 +0000 (15:15 +1100)]
s4-heimdal: fixed a use-after-free heimdal bug

This caused samba4kinit to segfault on some systems

14 years agos4-drs: use -r to ldbdel in unvampire devel script
Andrew Tridgell [Tue, 8 Dec 2009 03:42:08 +0000 (14:42 +1100)]
s4-drs: use -r to ldbdel in unvampire devel script

This ensures we delete any nTDSConnection objects

14 years agos4-ldb: fixed ldbdel with -r (recursive deletion)
Andrew Tridgell [Tue, 8 Dec 2009 03:40:20 +0000 (14:40 +1100)]
s4-ldb: fixed ldbdel with -r (recursive deletion)

We need to delete the deepest DNs first

14 years agos4:build Bump ldb and tdb required versions.
Andrew Bartlett [Mon, 7 Dec 2009 23:27:30 +0000 (10:27 +1100)]
s4:build Bump ldb and tdb required versions.

Hopefully this will ensure we don't get an older version from the system.

14 years agos4 torture: Cleanup RAW-ACLS a bit
Tim Prouty [Tue, 8 Dec 2009 01:19:30 +0000 (17:19 -0800)]
s4 torture: Cleanup RAW-ACLS a bit

Don't check SEC_DESC_DACL_AUTO_INHERITED right now
Disable RAW-ACLS-INHERITFLAGS for the short term
Update samba4's knownfail accordingly

14 years agos4-selftest: don't consider spoolss failures to be an error in s4
Andrew Tridgell [Tue, 8 Dec 2009 01:37:17 +0000 (12:37 +1100)]
s4-selftest: don't consider spoolss failures to be an error in s4

14 years agos4/smbstreams: Fix memory use after free.
Kamen Mazdrashki [Sat, 5 Dec 2009 23:59:42 +0000 (01:59 +0200)]
s4/smbstreams: Fix memory use after free.

The bug is that sometimes 'streams' is parent for 'new_name'.
With this said, 'new_name' must be dupped before 'streams'
pointer is freed.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agokrb5: Fix leaked hx509_context pointer
Kamen Mazdrashki [Sun, 6 Dec 2009 02:05:45 +0000 (04:05 +0200)]
krb5: Fix leaked hx509_context pointer

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agotdr-test: Fix 'push_charset' test
Kamen Mazdrashki [Sun, 6 Dec 2009 01:18:11 +0000 (03:18 +0200)]
tdr-test: Fix 'push_charset' test

4 bytes of 'bloe' string are pushed, so we should
check only for the first 4 caracters

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agotalloc: Fix write behind memory block
Kamen Mazdrashki [Sat, 5 Dec 2009 19:44:15 +0000 (21:44 +0200)]
talloc: Fix write behind memory block

If ALWASY_REALLOC is defined and we are to 'shrink' memory block,
memcpy() will write outside memory just allocated.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agos4 quicktest: exclude raw-streams from quicktest until bug is fixed
Tim Prouty [Fri, 4 Dec 2009 21:02:51 +0000 (13:02 -0800)]
s4 quicktest: exclude raw-streams from quicktest until bug is fixed

14 years agos4 torture: Add a new torture:hide_on_access_denied parameter
Tim Prouty [Sat, 5 Dec 2009 00:07:35 +0000 (16:07 -0800)]
s4 torture: Add a new torture:hide_on_access_denied parameter

It appears some newer versions of windows return
NT_STATUS_OBJECT_NAME_NOT_FOUND on a createfile when access is denied
rather than NT_STATUS_ACCESS_DENIED.  I'm not sure how this translates
to directory enumeration yet, but for now make this a parameter that
can be checked in the various torture tests.

This also gets RAW-ACLS and SMB2-CREATE passing against win7.

14 years agos4 torture: win 7 doesn't like the sequential_only flag for directories
Tim Prouty [Thu, 6 Aug 2009 21:31:01 +0000 (14:31 -0700)]
s4 torture: win 7 doesn't like the sequential_only flag for directories

Remove it for now

14 years agos4 torture: Port RAW-ACLS tests to SMB2
Zack Kirsch [Sat, 4 Jul 2009 23:16:23 +0000 (16:16 -0700)]
s4 torture: Port RAW-ACLS tests to SMB2

- The smblsa calls had to be commented out for now and should be fixed
  later, but they aren't crucial to the test.
- The first two tests from RAW-ACLS were already ported to
  torture_smb2_setinfo() and test_create_acl(). Modifications were
  made similar to the RAW-ACLS changes.
- test_sd_get_set() was ported, but does not pass against XP or Vista;
  it is not added to the SMB2-ACLS test suite.
- printf -> torture_comment / torture_warning / torture_result

14 years agos4 torure: Add SMB2 utility functions
Zack Kirsch [Wed, 1 Jul 2009 20:30:12 +0000 (13:30 -0700)]
s4 torure: Add SMB2 utility functions

- Add a torture_setup_dir() equivalent in SMB2, called smb2_util_setup_dir().
- Add verify_sd() and verify_attrib() helper functions for SMB2.

14 years agos4 torture: RAW-ACL Improvements
Zack Kirsch [Thu, 2 Jul 2009 21:08:41 +0000 (14:08 -0700)]
s4 torture: RAW-ACL Improvements

- Change RAW-ACLS test suite so each test can be run individually.
- Add verify_sd() and verify_attrib() helper functions.
- Change test_nttrans_create() to work for both files and directories.
- Fix a segfault in test_inheritance() when the test errors out early.
- test_sd_get_set() does not pass against XP or Vista, so it is no longer added
  to the RAW-ACLS test suite.
- Minor fixes to test_inheritance().
- New INHERITFLAGS test, which tests the auto inheritance flags a bit more.
- printf -> torture_comment / torture_warning / torture_result

14 years agos4 torture: Convert RAW-STREAMS to a set of test suites rather than a monolithic...
Tim Prouty [Fri, 4 Dec 2009 21:04:12 +0000 (13:04 -0800)]
s4 torture: Convert RAW-STREAMS to a set of test suites rather than a monolithic test

14 years agos4 torture: Update RAW-RENAME to pass against win7
Tim Prouty [Tue, 27 Oct 2009 00:16:37 +0000 (17:16 -0700)]
s4 torture: Update RAW-RENAME to pass against win7

14 years agos4 torture: Add a new RAW-STREAMS test to simulate the summary tab
Tim Prouty [Tue, 27 Oct 2009 00:17:45 +0000 (17:17 -0700)]
s4 torture: Add a new RAW-STREAMS test to simulate the summary tab

14 years agos4 torture: Fix the streams create disposition tests to actually return an error...
Tim Prouty [Wed, 21 Oct 2009 23:51:17 +0000 (16:51 -0700)]
s4 torture: Fix the streams create disposition tests to actually return an error on failure

14 years agos4/torture: add test for zero byte read contention with byte range locks
Steven Danneman [Fri, 4 Dec 2009 02:50:33 +0000 (18:50 -0800)]
s4/torture: add test for zero byte read contention with byte range locks

14 years agos4/libcli: add define for exclusive lock mode
Steven Danneman [Fri, 4 Dec 2009 02:32:56 +0000 (18:32 -0800)]
s4/libcli: add define for exclusive lock mode

14 years agos4/torture: fix >80 column spacing issues
Steven Danneman [Fri, 4 Dec 2009 03:32:53 +0000 (19:32 -0800)]
s4/torture: fix >80 column spacing issues

14 years agos4/torture: add delete-on-close test for directories
Aravind Srinivasan [Tue, 17 Nov 2009 20:28:34 +0000 (12:28 -0800)]
s4/torture: add delete-on-close test for directories

This test opens a directory with delete on close, opens it again,
and checks to make sure that the second open returned with
NT_STATUS_DELETE_PENDING.

14 years agoparent_sd can never be null in this function, so don't
Jeremy Allison [Mon, 7 Dec 2009 22:41:09 +0000 (14:41 -0800)]
parent_sd can never be null in this function, so don't
check for it.

Jeremy.

14 years agoHopefullt final fix for 6802 - acl_xattr.c module: A created folder does not properly...
Jeremy Allison [Mon, 7 Dec 2009 22:36:12 +0000 (14:36 -0800)]
Hopefullt final fix for 6802 - acl_xattr.c module: A created folder does not properly inherit permissions from parent and 6938 - No hook exists to check creation rights when using acl_xattr module

Volker was right (dammit :-). It's much easier to catch
this case in the create_file() vfs call instead of trying
to do everything inside open() and mkdir(). Hook all these
functions to gain the desired effect.
Jeremy.

14 years agos3: let gencache_init() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:46:34 +0000 (16:46 +0100)]
s3: let gencache_init() use tdb_check()

If the check fails we try to clear the tdb and start
with an empty cache.

metze

14 years agos3: let netsamlogon_cache_init() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:34:08 +0000 (16:34 +0100)]
s3: let netsamlogon_cache_init() use tdb_check()

If the check fails we try to unlink the old file and
start with an empty cache.

metze

14 years agos3: let tdb_validate_child() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:32:42 +0000 (16:32 +0100)]
s3: let tdb_validate_child() use tdb_check()

metze

14 years agos3: require tdb 1.1.7 with tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:59:39 +0000 (16:59 +0100)]
s3: require tdb 1.1.7 with tdb_check()

metze

14 years agos3:docs: Document "directory name cache size".
Karolin Seeger [Mon, 7 Dec 2009 15:28:30 +0000 (16:28 +0100)]
s3:docs: Document "directory name cache size".

Karolin

14 years agos3: de-deprecate "write cache size" to prevent its removal without a proper alternative
Volker Lendecke [Mon, 7 Dec 2009 15:24:08 +0000 (16:24 +0100)]
s3: de-deprecate "write cache size" to prevent its removal without a proper alternative

14 years agoFix release script with newer versins of git
Simo Sorce [Mon, 7 Dec 2009 14:25:03 +0000 (09:25 -0500)]
Fix release script with newer versins of git

14 years agos4-smbtorture: disable some spoolss printerdata tests which s3 does not pass at the...
Günther Deschner [Mon, 7 Dec 2009 13:38:24 +0000 (14:38 +0100)]
s4-smbtorture: disable some spoolss printerdata tests which s3 does not pass at the moment.

Guenther

14 years agos3: fix net and rpcclient after setprinterdataex changes.
Günther Deschner [Mon, 7 Dec 2009 10:54:26 +0000 (11:54 +0100)]
s3: fix net and rpcclient after setprinterdataex changes.

Guenther

14 years agos4-smbtorture: fix RPC-SPOOLSS after _spoolss_SetPrinterDataEx IDL change.
Günther Deschner [Fri, 4 Dec 2009 23:58:45 +0000 (00:58 +0100)]
s4-smbtorture: fix RPC-SPOOLSS after _spoolss_SetPrinterDataEx IDL change.

Guenther

14 years agos3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.
Günther Deschner [Mon, 7 Dec 2009 10:28:56 +0000 (11:28 +0100)]
s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.

Guenther

14 years agos3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:56:55 +0000 (00:56 +0100)]
s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.

Guenther

14 years agos3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:52:28 +0000 (00:52 +0100)]
s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.

Guenther

14 years agospoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:50:18 +0000 (00:50 +0100)]
spoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.

Guenther

14 years agos3-spoolss: a default printer should have at least a "PrintDriverData" key.
Günther Deschner [Fri, 4 Dec 2009 16:22:25 +0000 (17:22 +0100)]
s3-spoolss: a default printer should have at least a "PrintDriverData" key.

Guenther

14 years agos3-winreg: fill in some inline comments.
Günther Deschner [Fri, 4 Dec 2009 12:33:49 +0000 (13:33 +0100)]
s3-winreg: fill in some inline comments.

Guenther

14 years agos3-winreg: remove trailing whitespace.
Günther Deschner [Fri, 4 Dec 2009 12:29:08 +0000 (13:29 +0100)]
s3-winreg: remove trailing whitespace.

Guenther

14 years agos3:auth: Fix typo in debug message.
Karolin Seeger [Mon, 7 Dec 2009 13:38:18 +0000 (14:38 +0100)]
s3:auth: Fix typo in debug message.

Karolin

14 years agoexamples: Fix the build of the example VFS modules.
Karolin Seeger [Mon, 7 Dec 2009 09:15:49 +0000 (10:15 +0100)]
examples: Fix the build of the example VFS modules.

Karolin

14 years agos4:dsdb Use ldb_match_msg_objectclass in operational.c
Andrew Bartlett [Mon, 7 Dec 2009 04:28:51 +0000 (15:28 +1100)]
s4:dsdb Use ldb_match_msg_objectclass in operational.c

This avoids not only a possibly non-portable compiler expression, but
also the need to look up the schema each time.

Andrew Bartlett

14 years agos4:ldb Add a function to match a message against an objectClass
Andrew Bartlett [Mon, 7 Dec 2009 04:27:43 +0000 (15:27 +1100)]
s4:ldb Add a function to match a message against an objectClass

(as objectClass will always be a case insensitive ascii string, we can
make a much simpler match function here than for the general case).

Andrew Bartlett

14 years agos4:ldap.py Improve testsuite for primaryGroupToken behaviour
Andrew Bartlett [Mon, 7 Dec 2009 01:44:07 +0000 (12:44 +1100)]
s4:ldap.py Improve testsuite for primaryGroupToken behaviour

This tries to show that the domain object should not have a
primaryGroupToken, for example.  (This passes against the old and new
code, as the failure case requires an object with an objectSid, and
exactly one group in it's subtree.  Sadly I don't know of a valid structure
that I can construct to test this).

Andrew Bartlett

14 years agos4:dsdb Make primaryGroupToken calculation more efficient and correct
Andrew Bartlett [Mon, 7 Dec 2009 01:41:43 +0000 (12:41 +1100)]
s4:dsdb Make primaryGroupToken calculation more efficient and correct

The original code here would do a subtree search under each object,
attempting to determine if it was a group.  This was incorrect, and
inefficient - we just need to ask for the objectClass attribute, and
check that value before returning the group's RID.

(Much of this patch reworks operational.c to allow a search for 2
attributes for this calculation).

Andrew Bartlett

14 years agos4:dsdb Make parentGUID handler use dsdb_module_search_dn()
Andrew Bartlett [Thu, 3 Dec 2009 23:15:15 +0000 (10:15 +1100)]
s4:dsdb Make parentGUID handler use dsdb_module_search_dn()

This avoids doing a new search from the top of the module stack.

This also removes the helper function dsdb_find_parentguid_by_dn()
which is now unused.

Andrew Bartlett

14 years agos4:build torturedir and -DTORTUREDIR is unused
Andrew Bartlett [Thu, 3 Dec 2009 20:29:29 +0000 (07:29 +1100)]
s4:build torturedir and -DTORTUREDIR is unused

(And made building RPMs much more difficult for JHT)

14 years agos4:dsdb Hide the LM password by default too
Andrew Bartlett [Tue, 1 Dec 2009 21:53:32 +0000 (08:53 +1100)]
s4:dsdb Hide the LM password by default too

14 years agostreamline some log levels for invalid servicenames
Christian Ambach [Wed, 2 Dec 2009 19:06:37 +0000 (20:06 +0100)]
streamline some log levels for invalid servicenames

I don't think we need to log the fact that a user gave a wrong sharename in Explorer with the highest log level.
The level of this was not very consistent:
service.c: DEBUG(3,("find_service() failed to find service %s\n", service));
service.c: DEBUG(0,("%s (%s) couldn't find service %s\n",
smb2_tcon.c: DEBUG(1,("smbd_smb2_tree_connect: couldn't find service %s\n",

This changes the last two to 3 as the first one.

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
14 years agos3: Fix a const discard warning
Volker Lendecke [Sun, 6 Dec 2009 11:50:51 +0000 (12:50 +0100)]
s3: Fix a const discard warning

14 years agos3: talloc_array_length deals file with a NULL argument
Volker Lendecke [Sun, 6 Dec 2009 11:50:25 +0000 (12:50 +0100)]
s3: talloc_array_length deals file with a NULL argument