ldb:ldb_autotransaction_request - error string shouldn't be set here
authorMatthias Dieter Wallnöfer <mdw@samba.org>
Wed, 21 Sep 2011 09:45:32 +0000 (11:45 +0200)
committerAndrew Tridgell <tridge@samba.org>
Tue, 11 Oct 2011 08:15:18 +0000 (10:15 +0200)
A generic error string should be set independently of the access
mechanism to an LDB operation. Hence it should be handled in "ldb_wait"
and "ldb_request"

Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 11 10:15:18 CEST 2011 on sn-devel-104

lib/ldb/common/ldb.c

index 4a0d8043cc2c09e9bb901b21ff1aaef15f0d1d66..cd6172a1e851cfd3bdb2c0664b06da4184a62a87 100644 (file)
@@ -564,11 +564,6 @@ static int ldb_autotransaction_request(struct ldb_context *ldb,
        }
        ldb_transaction_cancel(ldb);
 
-       if (ldb->err_string == NULL) {
-               /* no error string was setup by the backend */
-               ldb_asprintf_errstring(ldb, "%s (%d)", ldb_strerror(ret), ret);
-       }
-
        return ret;
 }