s3:auth:check_sam_security: null out sampass after it has been stolen.
authorMichael Adam <obnox@samba.org>
Wed, 6 Jan 2010 11:32:51 +0000 (12:32 +0100)
committerMichael Adam <obnox@samba.org>
Thu, 7 Jan 2010 10:07:56 +0000 (11:07 +0100)
So that a later talloc_free would not harm. I could have used
talloc_move instead of talloc steal in make_server_info_sam(),
but this would have required a change of the signature.

Michael

source3/auth/auth_sam.c

index add74f611a5674673ec9543811362afa464c9a79..3573de13758deefe0160c8a714764e6ec0b55498 100644 (file)
@@ -402,6 +402,7 @@ static NTSTATUS check_sam_security(const struct auth_context *auth_context,
        become_root();
        nt_status = make_server_info_sam(server_info, sampass);
        unbecome_root();
        become_root();
        nt_status = make_server_info_sam(server_info, sampass);
        unbecome_root();
+       sampass = NULL;
 
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0,("check_sam_security: make_server_info_sam() failed with '%s'\n", nt_errstr(nt_status)));
 
        if (!NT_STATUS_IS_OK(nt_status)) {
                DEBUG(0,("check_sam_security: make_server_info_sam() failed with '%s'\n", nt_errstr(nt_status)));