s3-spoolss: Use tmp_ctx in winreg_printer_update_changeid_internal.
authorAndreas Schneider <asn@samba.org>
Mon, 25 Jul 2011 19:06:34 +0000 (21:06 +0200)
committerAndreas Schneider <asn@samba.org>
Wed, 27 Jul 2011 06:49:59 +0000 (08:49 +0200)
source3/rpc_server/spoolss/srv_spoolss_util.c

index 5fa1af5b3cf9b0786bbea5351c913aefd9250e2a..1833d5dc4c8be0778e2534402e2077abaf6a1d51 100644 (file)
@@ -98,12 +98,25 @@ WERROR winreg_printer_update_changeid_internal(TALLOC_CTX *mem_ctx,
 {
        WERROR result;
        struct dcerpc_binding_handle *b;
+       TALLOC_CTX *tmp_ctx;
 
-       result = winreg_printer_binding_handle(mem_ctx, session_info, msg_ctx, &b);
-       W_ERROR_NOT_OK_RETURN(result);
+       tmp_ctx = talloc_stackframe();
+       if (tmp_ctx == NULL) {
+               return WERR_NOMEM;
+       }
+
+       result = winreg_printer_binding_handle(tmp_ctx, session_info, msg_ctx, &b);
+       if (!W_ERROR_IS_OK(result)) {
+               talloc_free(tmp_ctx);
+               return result;
+       }
+
+       result = winreg_printer_update_changeid(mem_ctx,
+                                               b,
+                                               printer);
 
-       return winreg_printer_update_changeid(mem_ctx, b,
-                                             printer);
+       talloc_free(tmp_ctx);
+       return result;
 }
 
 WERROR winreg_printer_get_changeid_internal(TALLOC_CTX *mem_ctx,