Remove an invalid discard_const_p() - it masks an actual
authorJelmer Vernooij <jelmer@samba.org>
Mon, 9 Feb 2009 17:39:27 +0000 (18:39 +0100)
committerJelmer Vernooij <jelmer@samba.org>
Mon, 9 Feb 2009 17:39:27 +0000 (18:39 +0100)
bug in pidl where pidl uses "const" in a struct where there should not be
const.

There is only a single place in the Samba codebase where this triggers a
warning.

pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm

index b35762f025a7e281e88620796d49179d6c90f428..84752dac0de0371bae870ae74a6588183cd231f5 100644 (file)
@@ -2173,7 +2173,7 @@ sub ParseFunctionPull($$)
                        if (grep(/in/, @{$e->{DIRECTION}})) {
                                $self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, ($size) * sizeof(*r->in.$e->{NAME}));");
                        } else {
                        if (grep(/in/, @{$e->{DIRECTION}})) {
                                $self->pidl("memcpy(r->out.$e->{NAME}, r->in.$e->{NAME}, ($size) * sizeof(*r->in.$e->{NAME}));");
                        } else {
-                               $self->pidl("memset(discard_const_p(struct $fn->{NAME} *, r->out.$e->{NAME}), 0, ($size) * sizeof(*r->out.$e->{NAME}));");
+                               $self->pidl("memset(r->out.$e->{NAME}, 0, ($size) * sizeof(*r->out.$e->{NAME}));");
                        }
                } else {
                        $self->pidl("NDR_PULL_ALLOC($ndr, r->out.$e->{NAME});");
                        }
                } else {
                        $self->pidl("NDR_PULL_ALLOC($ndr, r->out.$e->{NAME});");