s3:idmap_tdb2: remove the undocumented option of the silly name "tdb:idmap2.tdb"

In ancient times, when ctdb had not support for persistent databases and
tdb2 was introduced as a two-layer solution and it was more important than
today to be able to change the location of the permanent database file
because it had to reside on shared storage.

But these were times when idmap_tdb2 was not even officially released.
Nowadays, with ctdb handling the persistent idmap2.tdb database, the path
is stripped anyways, so this undocumented option has become unnecessary
and is hence removed.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jul 27 05:37:57 CEST 2011 on sn-devel-104

diff --git a/source3/winbindd/idmap_tdb2.c b/source3/winbindd/idmap_tdb2.c
index 723afbc01ff16688b180afd20d7ac7212a4b06b1..112978bdc3e176d3731761a40684cecdb0570216 100644 (file)
--- a/source3/winbindd/idmap_tdb2.c
+++ b/source3/winbindd/idmap_tdb2.c
@@ -108,11 +108,7 @@ static NTSTATUS idmap_tdb2_open_db(struct idmap_domain *dom)
                return NT_STATUS_OK;
        }
 
-       db_path = lp_parm_talloc_string(-1, "tdb", "idmap2.tdb", NULL);
-       if (db_path == NULL) {
-               /* fall back to the private directory */
-               db_path = talloc_asprintf(NULL, "%s/idmap2.tdb", lp_private_dir());
-       }
+       db_path = talloc_asprintf(NULL, "%s/idmap2.tdb", lp_private_dir());
        NT_STATUS_HAVE_NO_MEMORY(db_path);
 
        /* Open idmap repository */