Remove unnecessary code

SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure
(This used to be commit 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7)

diff --git a/source3/lib/util_str.c b/source3/lib/util_str.c
index 1f3aab3bce9bbb1b39cdde9d6fc025439b1b63a3..6458ae3e05d0e6cf7a1f6fa0863b0cdbb527a663 100644 (file)
--- a/source3/lib/util_str.c
+++ b/source3/lib/util_str.c
@@ -411,13 +411,8 @@ char *strupper_static(const char *s)
 {
        static char *str = NULL;
 
-       if (str) {
-               SAFE_FREE(str);
-       }
+       SAFE_FREE(str);
        str = SMB_STRDUP(s);
-       if (!str) {
-               return CONST_DISCARD(char *,s);
-       }
        strupper_m(str);
        return str;
 }