Merge branch 'master' of ssh://git.samba.org/data/git/samba
[amitay/samba.git] / source4 / libnet / libnet_samsync_ldb.c
index e707d69cb851f41f3038c39c28f49fc66e22f8d2..e24c54a8c2cef695f22ca26644807344bde02f9a 100644 (file)
@@ -9,7 +9,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 
 #include "includes.h"
 #include "libnet/libnet.h"
-#include "libcli/ldap/ldap.h"
+#include "libcli/ldap/ldap_ndr.h"
 #include "dsdb/samdb/samdb.h"
 #include "auth/auth.h"
+#include "../lib/util/util_ldb.h"
+#include "librpc/gen_ndr/ndr_misc.h"
+#include "ldb_wrap.h"
+#include "libcli/security/security.h"
+#include "librpc/rpc/dcerpc.h"
+#include "param/param.h"
 
 struct samsync_ldb_secret {
        struct samsync_ldb_secret *prev, *next;
@@ -43,8 +48,11 @@ struct samsync_ldb_trusted_domain {
 };
 
 struct samsync_ldb_state {
+       /* Values from the LSA lookup */
+       const struct libnet_SamSync_state *samsync_state;
+
        struct dom_sid *dom_sid[3];
-       struct ldb_context *sam_ldb;
+       struct ldb_context *sam_ldb, *remote_ldb;
        struct ldb_dn *base_dn[3];
        struct samsync_ldb_secret *secrets;
        struct samsync_ldb_trusted_domain *trusted_domains;
@@ -72,7 +80,7 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, 
                                                "Failed to find DN for "
                                                "ForeignSecurityPrincipal container under %s",
-                                               ldb_dn_linearize(mem_ctx, state->base_dn[SAM_DATABASE_DOMAIN]));
+                                               ldb_dn_get_linearized(state->base_dn[SAM_DATABASE_DOMAIN]));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        
@@ -82,9 +90,9 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
        }
 
        /* add core elements to the ldb_message for the alias */
-       msg->dn = ldb_dn_build_child(mem_ctx, "CN", sidstr, basedn);
-       if (msg->dn == NULL)
-               return NT_STATUS_NO_MEMORY;
+       msg->dn = basedn;
+       if ( ! ldb_dn_add_child_fmt(msg->dn, "CN=%s", sidstr))
+               return NT_STATUS_UNSUCCESSFUL;
        
        samdb_msg_add_string(state->sam_ldb, mem_ctx, msg,
                             "objectClass",
@@ -93,11 +101,11 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
        *fsp_dn = msg->dn;
 
        /* create the alias */
-       ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+       ret = ldb_add(state->sam_ldb, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to create foreignSecurityPrincipal "
                                                "record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -106,7 +114,6 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
                                          struct samsync_ldb_state *state,
-                                         struct creds_CredentialState *creds,
                                          enum netr_SamDatabaseID database,
                                          struct netr_DELTA_ENUM *delta,
                                          char **error_string) 
@@ -116,12 +123,20 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
        struct ldb_message *msg;
        int ret;
        
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
        if (database == SAM_DATABASE_DOMAIN) {
+               struct ldb_dn *partitions_basedn;
                const char *domain_attrs[] =  {"nETBIOSName", "nCName", NULL};
                struct ldb_message **msgs_domain;
                int ret_domain;
 
-               ret_domain = gendb_search(state->sam_ldb, mem_ctx, NULL, &msgs_domain, domain_attrs,
+               partitions_basedn = samdb_partitions_dn(state->sam_ldb, mem_ctx);
+
+               ret_domain = gendb_search(state->sam_ldb, mem_ctx, partitions_basedn, &msgs_domain, domain_attrs,
                                          "(&(&(nETBIOSName=%s)(objectclass=crossRef))(ncName=*))", 
                                          domain_name);
                if (ret_domain == -1) {
@@ -135,35 +150,55 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
                        return NT_STATUS_NO_SUCH_DOMAIN;                
                }
 
-               state->base_dn[database] = samdb_result_dn(state, msgs_domain[0], "nCName", NULL);
+               state->base_dn[database] = samdb_result_dn(state->sam_ldb, state, msgs_domain[0], "nCName", NULL);
 
-               state->dom_sid[database] = samdb_search_dom_sid(state->sam_ldb, state,
-                                                               state->base_dn[database], 
-                                                               "objectSid", NULL);
+               if (state->dom_sid[database]) {
+                       /* Update the domain sid with the incoming
+                        * domain (found on LSA pipe, database sid may
+                        * be random) */
+                       samdb_msg_add_dom_sid(state->sam_ldb, mem_ctx, 
+                                             msg, "objectSid", state->dom_sid[database]);
+               } else {
+                       /* Well, we will have to use the one from the database */
+                       state->dom_sid[database] = samdb_search_dom_sid(state->sam_ldb, state,
+                                                                       state->base_dn[database], 
+                                                                       "objectSid", NULL);
+               }
+
+               if (state->samsync_state->domain_guid) {
+                       enum ndr_err_code ndr_err;
+                       struct ldb_val v;
+                       ndr_err = ndr_push_struct_blob(&v, msg, NULL, 
+                                                      state->samsync_state->domain_guid,
+                                                        (ndr_push_flags_fn_t)ndr_push_GUID);
+                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                               *error_string = talloc_asprintf(mem_ctx, "ndr_push of domain GUID failed!");
+                               return ndr_map_error2ntstatus(ndr_err);
+                       }
+                       
+                       ldb_msg_add_value(msg, "objectGUID", &v, NULL);
+               }
        } else if (database == SAM_DATABASE_BUILTIN) {
                /* work out the builtin_dn - useful for so many calls its worth
                   fetching here */
                const char *dnstring = samdb_search_string(state->sam_ldb, mem_ctx, NULL,
                                                           "distinguishedName", "objectClass=builtinDomain");
-               state->base_dn[database] = ldb_dn_explode(state, dnstring);
-               state->dom_sid[database] = dom_sid_parse_talloc(state, SID_BUILTIN);
+               state->base_dn[database] = ldb_dn_new(state, state->sam_ldb, dnstring);
+               if ( ! ldb_dn_validate(state->base_dn[database])) {
+                       return NT_STATUS_INTERNAL_ERROR;
+               }
        } else {
                /* PRIVs DB */
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       msg = ldb_msg_new(mem_ctx);
-       if (msg == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
        msg->dn = talloc_reference(mem_ctx, state->base_dn[database]);
        if (!msg->dn) {
                return NT_STATUS_NO_MEMORY;
        }
 
        samdb_msg_add_string(state->sam_ldb, mem_ctx, 
-                            msg, "oEMInformation", domain->comment.string);
+                            msg, "oEMInformation", domain->oem_information.string);
 
        samdb_msg_add_int64(state->sam_ldb, mem_ctx, 
                            msg, "forceLogoff", domain->force_logoff_time);
@@ -199,7 +234,6 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                                        struct samsync_ldb_state *state,
-                                       struct creds_CredentialState *creds,
                                        enum netr_SamDatabaseID database,
                                        struct netr_DELTA_ENUM *delta,
                                        char **error_string) 
@@ -209,39 +243,77 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
        const char *container, *obj_class;
        char *cn_name;
        int cn_name_len;
-
+       const struct dom_sid *user_sid;
        struct ldb_message *msg;
        struct ldb_message **msgs;
-       int ret;
+       struct ldb_message **remote_msgs = NULL;
+       int ret, i;
        uint32_t acb;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
+       /* we may change this to a global search, then fill in only the things not in ldap later */
+       const char *remote_attrs[] = { "userPrincipalName", "servicePrincipalName", 
+                                      "msDS-KeyVersionNumber", "objectGUID", NULL};
+
+       user_sid = dom_sid_add_rid(mem_ctx, state->dom_sid[database], rid);
+       if (!user_sid) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        msg = ldb_msg_new(mem_ctx);
        if (msg == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
+       msg->dn = NULL;
        /* search for the user, by rid */
        ret = gendb_search(state->sam_ldb, mem_ctx, state->base_dn[database],
                           &msgs, attrs, "(&(objectClass=user)(objectSid=%s))", 
-                          ldap_encode_ndr_dom_sid(mem_ctx, dom_sid_add_rid(mem_ctx, state->dom_sid[database], rid))); 
+                          ldap_encode_ndr_dom_sid(mem_ctx, user_sid));
 
        if (ret == -1) {
+               *error_string = talloc_asprintf(mem_ctx, "LDB for user %s failed: %s", 
+                                               dom_sid_string(mem_ctx, user_sid),
+                                               ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
-               *error_string = talloc_asprintf(mem_ctx, "More than one user with SID: %s", 
-                                               dom_sid_string(mem_ctx, 
-                                                              dom_sid_add_rid(mem_ctx, 
-                                                                              state->dom_sid[database], 
-                                                                              rid)));
+               *error_string = talloc_asprintf(mem_ctx, "More than one user with SID: %s in local LDB", 
+                                               dom_sid_string(mem_ctx, user_sid));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else {
-               msg->dn = talloc_steal(msg, msgs[0]->dn);
+               msg->dn = msgs[0]->dn;
+               talloc_steal(msg, msgs[0]->dn);
        }
 
+       /* and do the same on the remote database */
+       if (state->remote_ldb) {
+               ret = gendb_search(state->remote_ldb, mem_ctx, state->base_dn[database],
+                                  &remote_msgs, remote_attrs, "(&(objectClass=user)(objectSid=%s))", 
+                                  ldap_encode_ndr_dom_sid(mem_ctx, user_sid));
+               
+               if (ret == -1) {
+                       *error_string = talloc_asprintf(mem_ctx, "remote LDAP for user %s failed: %s", 
+                                                       dom_sid_string(mem_ctx, user_sid),
+                                                       ldb_errstring(state->remote_ldb));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               } else if (ret == 0) {
+                       *error_string = talloc_asprintf(mem_ctx, "User exists in samsync but not in remote LDAP domain! (base: %s, SID: %s)", 
+                                                       ldb_dn_get_linearized(state->base_dn[database]),
+                                                       dom_sid_string(mem_ctx, user_sid));
+                       return NT_STATUS_NO_SUCH_USER;
+               } else if (ret > 1) {
+                       *error_string = talloc_asprintf(mem_ctx, "More than one user in remote LDAP domain with SID: %s", 
+                                                       dom_sid_string(mem_ctx, user_sid));
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                       
+                       /* Try to put things in the same location as the remote server */
+               } else if (add) {
+                       msg->dn = remote_msgs[0]->dn;
+                       talloc_steal(msg, remote_msgs[0]->dn);
+               }
+       }
 
        cn_name   = talloc_strdup(mem_ctx, user->account_name.string);
        NT_STATUS_HAVE_NO_MEMORY(cn_name);
@@ -290,27 +362,33 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY; 
        } 
        
-       /* Passwords.  Ensure there is no plaintext stored against
-        * this entry, as we only have hashes */
-       samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                            "sambaPassword"); 
+       if (!add) {
+               /* Passwords.  Ensure there is no plaintext stored against
+                * this entry, as we only have hashes */
+               samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
+                                    "userPassword"); 
+       }
        if (user->lm_password_present) {
                samdb_msg_add_hash(state->sam_ldb, mem_ctx, msg,  
-                                  "lmPwdHash", &user->lmpassword);
-       } else {
+                                  "dBCSPwd", &user->lmpassword);
+       } else if (!add) {
                samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                                    "lmPwdHash"); 
+                                    "dBCSPwd"); 
        }
        if (user->nt_password_present) {
                samdb_msg_add_hash(state->sam_ldb, mem_ctx, msg,  
-                                  "ntPwdHash", &user->ntpassword);
-       } else {
+                                  "unicodePwd", &user->ntpassword);
+       } else if (!add) {
                samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                                    "ntPwdHash"); 
+                                    "unicodePwd"); 
        }
            
        ADD_OR_DEL(string, "comment", comment.string);
-       ADD_OR_DEL(string, "userParameters", parameters.string);
+
+       if (samdb_msg_add_parameters(state->sam_ldb, mem_ctx, msg, "userParameters", &user->parameters) != 0) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
        ADD_OR_DEL(uint, "countryCode", country_code);
        ADD_OR_DEL(uint, "codePage", code_page);
 
@@ -318,6 +396,16 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
 
 #undef ADD_OR_DEL
 
+       for (i=0; remote_attrs[i]; i++) {
+               struct ldb_message_element *el = ldb_msg_find_element(remote_msgs[0], remote_attrs[i]);
+               if (!el) {
+                       samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
+                                            remote_attrs[i]); 
+               } else {
+                       ldb_msg_add(msg, el, LDB_FLAG_MOD_REPLACE);
+               }
+       }
+
        acb = user->acct_flags;
        if (acb & (ACB_WSTRUST)) {
                cn_name[cn_name_len - 1] = '\0';
@@ -338,23 +426,41 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
        if (add) {
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
-               msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                               "CN=%s, CN=%s", cn_name, container);
                if (!msg->dn) {
-                       return NT_STATUS_NO_MEMORY;             
+                       msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+                       ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
+                       if (!msg->dn) {
+                               return NT_STATUS_NO_MEMORY;             
+                       }
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
-                       *error_string = talloc_asprintf(mem_ctx, "Failed to create user record %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn));
-                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                       struct ldb_dn *first_try_dn = msg->dn;
+                       /* Try again with the default DN */
+                       if (!remote_msgs) {
+                               *error_string = talloc_asprintf(mem_ctx, "Failed to create user record.  Tried %s: %s",
+                                                               ldb_dn_get_linearized(first_try_dn),
+                                                               ldb_errstring(state->sam_ldb));
+                               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                       } else {
+                               msg->dn = talloc_steal(msg, remote_msgs[0]->dn);
+                               ret = ldb_add(state->sam_ldb, msg);
+                               if (ret != 0) {
+                                       *error_string = talloc_asprintf(mem_ctx, "Failed to create user record.  Tried both %s and %s: %s",
+                                                                       ldb_dn_get_linearized(first_try_dn),
+                                                                       ldb_dn_get_linearized(msg->dn),
+                                                                       ldb_errstring(state->sam_ldb));
+                                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                               }
+                       }
                }
        } else {
                ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
                if (ret != 0) {
-                       *error_string = talloc_asprintf(mem_ctx, "Failed to modify user record %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn));
+                       *error_string = talloc_asprintf(mem_ctx, "Failed to modify user record %s: %s",
+                                                       ldb_dn_get_linearized(msg->dn),
+                                                       ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
        }
@@ -364,7 +470,6 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_delete_user(TALLOC_CTX *mem_ctx,
                                        struct samsync_ldb_state *state,
-                                       struct creds_CredentialState *creds,
                                        enum netr_SamDatabaseID database,
                                        struct netr_DELTA_ENUM *delta,
                                        char **error_string) 
@@ -393,10 +498,10 @@ static NTSTATUS samsync_ldb_delete_user(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete user record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -406,7 +511,6 @@ static NTSTATUS samsync_ldb_delete_user(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
                                         struct samsync_ldb_state *state,
-                                        struct creds_CredentialState *creds,
                                         enum netr_SamDatabaseID database,
                                         struct netr_DELTA_ENUM *delta,
                                         char **error_string) 
@@ -419,7 +523,7 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
        struct ldb_message *msg;
        struct ldb_message **msgs;
        int ret;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
 
        msg = ldb_msg_new(mem_ctx);
@@ -436,7 +540,7 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, "gendb_search failed: %s", ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
                *error_string = talloc_asprintf(mem_ctx, "More than one group/alias with SID: %s", 
                                                dom_sid_string(mem_ctx, 
@@ -477,16 +581,16 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
        if (add) {
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
-               msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                               "CN=%s, CN=%s", cn_name, container);
+               msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+               ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
                if (!msg->dn) {
                        return NT_STATUS_NO_MEMORY;             
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to create group record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -494,7 +598,7 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
                ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -505,7 +609,6 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_delete_group(TALLOC_CTX *mem_ctx,
                                         struct samsync_ldb_state *state,
-                                        struct creds_CredentialState *creds,
                                         enum netr_SamDatabaseID database,
                                         struct netr_DELTA_ENUM *delta,
                                         char **error_string) 
@@ -534,10 +637,10 @@ static NTSTATUS samsync_ldb_delete_group(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -547,7 +650,6 @@ static NTSTATUS samsync_ldb_delete_group(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_group_member(TALLOC_CTX *mem_ctx,
                                                struct samsync_ldb_state *state,
-                                               struct creds_CredentialState *creds,
                                                enum netr_SamDatabaseID database,
                                                struct netr_DELTA_ENUM *delta,
                                                char **error_string) 
@@ -602,7 +704,7 @@ static NTSTATUS samsync_ldb_handle_group_member(TALLOC_CTX *mem_ctx,
                } else if (ret > 1) {
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                } else {
-                       samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_linearize(mem_ctx, msgs[0]->dn));
+                       samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_alloc_linearized(mem_ctx, msgs[0]->dn));
                }
                
                talloc_free(msgs);
@@ -611,7 +713,7 @@ static NTSTATUS samsync_ldb_handle_group_member(TALLOC_CTX *mem_ctx,
        ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -621,7 +723,6 @@ static NTSTATUS samsync_ldb_handle_group_member(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
                                         struct samsync_ldb_state *state,
-                                        struct creds_CredentialState *creds,
                                         enum netr_SamDatabaseID database,
                                         struct netr_DELTA_ENUM *delta,
                                         char **error_string) 
@@ -634,7 +735,7 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
        struct ldb_message *msg;
        struct ldb_message **msgs;
        int ret;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
 
        msg = ldb_msg_new(mem_ctx);
@@ -651,7 +752,7 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, "gendb_search failed: %s", ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
                *error_string = talloc_asprintf(mem_ctx, "More than one group/alias with SID: %s", 
                                                dom_sid_string(mem_ctx, 
@@ -694,16 +795,16 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
        if (add) {
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
-               msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                               "CN=%s, CN=%s", cn_name, container);
+               msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+               ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
                if (!msg->dn) {
                        return NT_STATUS_NO_MEMORY;             
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to create alias record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -711,7 +812,7 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
                ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to modify alias record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -722,7 +823,6 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_delete_alias(TALLOC_CTX *mem_ctx,
                                         struct samsync_ldb_state *state,
-                                        struct creds_CredentialState *creds,
                                         enum netr_SamDatabaseID database,
                                         struct netr_DELTA_ENUM *delta,
                                         char **error_string) 
@@ -746,10 +846,10 @@ static NTSTATUS samsync_ldb_delete_alias(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete alias record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -759,7 +859,6 @@ static NTSTATUS samsync_ldb_delete_alias(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_alias_member(TALLOC_CTX *mem_ctx,
                                                struct samsync_ldb_state *state,
-                                               struct creds_CredentialState *creds,
                                                enum netr_SamDatabaseID database,
                                                struct netr_DELTA_ENUM *delta,
                                                char **error_string) 
@@ -824,7 +923,7 @@ static NTSTATUS samsync_ldb_handle_alias_member(TALLOC_CTX *mem_ctx,
                } else {
                        alias_member_dn = msgs[0]->dn;
                }
-               samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_linearize(mem_ctx, alias_member_dn));
+               samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_alloc_linearized(mem_ctx, alias_member_dn));
        
                talloc_free(msgs);
        }
@@ -832,7 +931,7 @@ static NTSTATUS samsync_ldb_handle_alias_member(TALLOC_CTX *mem_ctx,
        ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -842,7 +941,6 @@ static NTSTATUS samsync_ldb_handle_alias_member(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_handle_account(TALLOC_CTX *mem_ctx,
                                           struct samsync_ldb_state *state,
-                                          struct creds_CredentialState *creds,
                                           enum netr_SamDatabaseID database,
                                           struct netr_DELTA_ENUM *delta,
                                           char **error_string) 
@@ -897,7 +995,7 @@ static NTSTATUS samsync_ldb_handle_account(TALLOC_CTX *mem_ctx,
        ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify privilege record %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn));
+                                               ldb_dn_get_linearized(msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -906,7 +1004,6 @@ static NTSTATUS samsync_ldb_handle_account(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS samsync_ldb_delete_account(TALLOC_CTX *mem_ctx,
                                           struct samsync_ldb_state *state,
-                                          struct creds_CredentialState *creds,
                                           enum netr_SamDatabaseID database,
                                           struct netr_DELTA_ENUM *delta,
                                           char **error_string) 
@@ -947,7 +1044,7 @@ static NTSTATUS samsync_ldb_delete_account(TALLOC_CTX *mem_ctx,
        ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify privilege record %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn));
+                                               ldb_dn_get_linearized(msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -955,14 +1052,13 @@ static NTSTATUS samsync_ldb_delete_account(TALLOC_CTX *mem_ctx,
 }
 
 static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,             
-                                     void *private,                    
-                                     struct creds_CredentialState *creds,
+                                     void *private_data,
                                      enum netr_SamDatabaseID database,
                                      struct netr_DELTA_ENUM *delta,
                                      char **error_string)
 {
        NTSTATUS nt_status = NT_STATUS_OK;
-       struct samsync_ldb_state *state = private;
+       struct samsync_ldb_state *state = talloc_get_type(private_data, struct samsync_ldb_state);
 
        *error_string = NULL;
        switch (delta->delta_type) {
@@ -970,7 +1066,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_domain(mem_ctx, 
                                                      state,
-                                                     creds,
                                                      database,
                                                      delta,
                                                      error_string);
@@ -980,7 +1075,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_user(mem_ctx, 
                                                    state,
-                                                   creds,
                                                    database,
                                                    delta,
                                                    error_string);
@@ -990,7 +1084,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_delete_user(mem_ctx, 
                                                    state,
-                                                   creds,
                                                    database,
                                                    delta,
                                                    error_string);
@@ -1000,7 +1093,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_group(mem_ctx, 
                                                     state,
-                                                    creds,
                                                     database,
                                                     delta,
                                                     error_string);
@@ -1010,7 +1102,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_delete_group(mem_ctx, 
                                                     state,
-                                                    creds,
                                                     database,
                                                     delta,
                                                     error_string);
@@ -1020,7 +1111,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_group_member(mem_ctx, 
                                                            state,
-                                                           creds,
                                                            database,
                                                            delta,
                                                            error_string);
@@ -1030,7 +1120,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_alias(mem_ctx, 
                                                     state,
-                                                    creds,
                                                     database,
                                                     delta,
                                                     error_string);
@@ -1040,7 +1129,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_delete_alias(mem_ctx, 
                                                     state,
-                                                    creds,
                                                     database,
                                                     delta,
                                                     error_string);
@@ -1050,7 +1138,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_alias_member(mem_ctx, 
                                                            state,
-                                                           creds,
                                                            database,
                                                            delta,
                                                            error_string);
@@ -1060,7 +1147,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_handle_account(mem_ctx, 
                                                       state,
-                                                      creds,
                                                       database,
                                                       delta,
                                                       error_string);
@@ -1070,7 +1156,6 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        {
                nt_status = samsync_ldb_delete_account(mem_ctx, 
                                                       state,
-                                                      creds,
                                                       database,
                                                       delta,
                                                       error_string);
@@ -1086,6 +1171,48 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
        return nt_status;
 }
 
+static NTSTATUS libnet_samsync_ldb_init(TALLOC_CTX *mem_ctx,           
+                                       void *private_data,
+                                       struct libnet_SamSync_state *samsync_state,
+                                       char **error_string)
+{
+       struct samsync_ldb_state *state = talloc_get_type(private_data, struct samsync_ldb_state);
+       const char *server = dcerpc_server_name(samsync_state->netlogon_pipe);
+       char *ldap_url;
+
+       state->samsync_state = samsync_state;
+
+       ZERO_STRUCT(state->dom_sid);
+       if (state->samsync_state->domain_sid) {
+               state->dom_sid[SAM_DATABASE_DOMAIN] = dom_sid_dup(state, state->samsync_state->domain_sid);
+       }
+
+       state->dom_sid[SAM_DATABASE_BUILTIN] = dom_sid_parse_talloc(state, SID_BUILTIN);
+
+       if (state->samsync_state->realm) {
+               if (!server || !*server) {
+                       /* huh?  how do we not have a server name?  */
+                       *error_string = talloc_strdup(mem_ctx, "No DCE/RPC server name available.  How did we connect?");
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+               ldap_url = talloc_asprintf(state, "ldap://%s", server);
+               
+               state->remote_ldb = ldb_wrap_connect(mem_ctx, 
+                                                    state->samsync_state->machine_net_ctx->event_ctx,
+                                                    state->samsync_state->machine_net_ctx->lp_ctx, 
+                                                    ldap_url, 
+                                                    NULL, state->samsync_state->machine_net_ctx->cred,
+                                                    0, NULL);
+               if (!state->remote_ldb) {
+                       *error_string = talloc_asprintf(mem_ctx, "Failed to connect to remote LDAP server at %s (used to extract additional data in SamSync replication)", ldap_url);
+                       return NT_STATUS_NO_LOGON_SERVERS;
+               }
+       } else {
+               state->remote_ldb = NULL;
+       }
+       return NT_STATUS_OK;
+}
+
 NTSTATUS libnet_samsync_ldb(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, struct libnet_samsync_ldb *r)
 {
        NTSTATUS nt_status;
@@ -1099,15 +1226,21 @@ NTSTATUS libnet_samsync_ldb(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, str
        state->secrets         = NULL;
        state->trusted_domains = NULL;
 
-       state->sam_ldb         = samdb_connect(state, system_session(state));
+       state->sam_ldb         = samdb_connect(mem_ctx, 
+                                              ctx->event_ctx,
+                                              ctx->lp_ctx, 
+                                              r->in.session_info);
 
        r2.out.error_string    = NULL;
        r2.in.binding_string   = r->in.binding_string;
+       r2.in.rid_crypt        = true;
+       r2.in.init_fn          = libnet_samsync_ldb_init;
        r2.in.delta_fn         = libnet_samsync_ldb_fn;
        r2.in.fn_ctx           = state;
        r2.in.machine_account  = NULL; /* TODO:  Create a machine account, fill this in, and the delete it */
        nt_status              = libnet_SamSync_netlogon(ctx, state, &r2);
        r->out.error_string    = r2.out.error_string;
+       talloc_steal(mem_ctx, r->out.error_string);
 
        if (!NT_STATUS_IS_OK(nt_status)) {
                talloc_free(state);