gensec: Remove mem_ctx from calls that do not return memory
[amitay/samba.git] / source4 / auth / gensec / spnego.c
index bf991616bd06eeccf77e9ae671eb296079f3b15d..c48e87e8b5866063f775b1da79caef00718e54e7 100644 (file)
 */
 
 #include "includes.h"
-#include "auth/gensec/spnego.h"
+#include "../libcli/auth/spnego.h"
 #include "librpc/gen_ndr/ndr_dcerpc.h"
 #include "auth/credentials/credentials.h"
 #include "auth/gensec/gensec.h"
 #include "auth/gensec/gensec_proto.h"
+#include "auth/gensec/gensec_toplevel_proto.h"
+#include "param/param.h"
+
+_PUBLIC_ NTSTATUS gensec_spnego_init(void);
 
 enum spnego_state_position {
        SPNEGO_SERVER_START,
@@ -92,7 +96,6 @@ static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_securi
   wrappers for the spnego_*() functions
 */
 static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_security, 
-                                           TALLOC_CTX *mem_ctx, 
                                            uint8_t *data, size_t length, 
                                            const uint8_t *whole_pdu, size_t pdu_length, 
                                            const DATA_BLOB *sig)
@@ -105,14 +108,12 @@ static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_secur
        }
        
        return gensec_unseal_packet(spnego_state->sub_sec_security, 
-                                   mem_ctx, 
                                    data, length, 
                                    whole_pdu, pdu_length,
                                    sig); 
 }
 
 static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_security, 
-                                          TALLOC_CTX *mem_ctx, 
                                           const uint8_t *data, size_t length, 
                                           const uint8_t *whole_pdu, size_t pdu_length, 
                                           const DATA_BLOB *sig)
@@ -125,7 +126,6 @@ static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_securi
        }
        
        return gensec_check_packet(spnego_state->sub_sec_security, 
-                                  mem_ctx, 
                                   data, length, 
                                   whole_pdu, pdu_length,
                                   sig);
@@ -336,6 +336,11 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
        for (i=0; all_ops[i]; i++) {
                bool is_spnego;
                NTSTATUS nt_status;
+
+               if (gensec_security != NULL && 
+                               !gensec_security_ops_enabled(all_ops[i], gensec_security))
+                   continue;
+
                if (!all_ops[i]->oid) {
                        continue;
                }
@@ -414,9 +419,9 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
        }
 
        if (spnego_state->state_position == SPNEGO_SERVER_START) {
-               for (i=0; all_sec && all_sec[i].op; i++) {
-                       /* optomisitic token */
-                       if (strcmp(all_sec[i].oid, mechType[0]) == 0) {
+               uint32_t j;
+               for (j=0; mechType && mechType[j]; j++) {
+                       for (i=0; all_sec && all_sec[i].op; i++) {
                                nt_status = gensec_subcontext_start(spnego_state,
                                                                    gensec_security,
                                                                    &spnego_state->sub_sec_security);
@@ -431,7 +436,15 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                        spnego_state->sub_sec_security = NULL;
                                        break;
                                }
-                               
+
+                               if (j > 0) {
+                                       /* no optimistic token */
+                                       spnego_state->neg_oid = all_sec[i].oid;
+                                       *unwrapped_out = data_blob_null;
+                                       nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
+                                       break;
+                               }
+
                                nt_status = gensec_update(spnego_state->sub_sec_security,
                                                          out_mem_ctx, 
                                                          unwrapped_in,
@@ -450,10 +463,18 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                spnego_state->neg_oid = all_sec[i].oid;
                                break;
                        }
+                       if (spnego_state->sub_sec_security) {
+                               break;
+                       }
+               }
+
+               if (!spnego_state->sub_sec_security) {
+                       DEBUG(1, ("SPNEGO: Could not find a suitable mechtype in NEG_TOKEN_INIT\n"));
+                       return NT_STATUS_INVALID_PARAMETER;
                }
        }
        
-       /* Having tried any optomisitc token from the client (if we
+       /* Having tried any optimistic token from the client (if we
         * were the server), if we didn't get anywhere, walk our list
         * in our preference order */
        
@@ -489,6 +510,8 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                         * of this mech */
                        if (spnego_state->state_position != SPNEGO_SERVER_START) {
                                if (NT_STATUS_EQUAL(nt_status, NT_STATUS_INVALID_PARAMETER) || 
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_NO_LOGON_SERVERS) ||
+                                   NT_STATUS_EQUAL(nt_status, NT_STATUS_TIME_DIFFERENCE_AT_DC) ||
                                    NT_STATUS_EQUAL(nt_status, NT_STATUS_CANT_ACCESS_DOMAIN_INFO)) {
                                        /* Pretend we never started it (lets the first run find some incompatible demand) */
                                        
@@ -560,7 +583,6 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
        const char **mechTypes = NULL;
        DATA_BLOB unwrapped_out = data_blob(NULL, 0);
        const struct gensec_security_ops_wrapper *all_sec;
-       const char *principal = NULL;
 
        mechTypes = gensec_security_oids(gensec_security, 
                                         out_mem_ctx, GENSEC_OID_SPNEGO);
@@ -623,18 +645,12 @@ static NTSTATUS gensec_spnego_create_negTokenInit(struct gensec_security *gensec
 
                /* List the remaining mechs as options */
                spnego_out.negTokenInit.mechTypes = send_mech_types;
-               spnego_out.negTokenInit.reqFlags = 0;
+               spnego_out.negTokenInit.reqFlags = null_data_blob;
+               spnego_out.negTokenInit.reqFlagsPadding = 0;
                
                if (spnego_state->state_position == SPNEGO_SERVER_START) {
-                       /* server credentials */
-                       struct cli_credentials *creds = gensec_get_credentials(gensec_security);
-                       if (creds) {
-                               principal = cli_credentials_get_principal(creds, out_mem_ctx);
-                       }
-               }
-               if (principal) {
                        spnego_out.negTokenInit.mechListMIC
-                               = data_blob_string_const(principal);
+                               = data_blob_string_const(ADS_IGNORE_PRINCIPAL);
                } else {
                        spnego_out.negTokenInit.mechListMIC = null_data_blob;
                }
@@ -818,9 +834,12 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return NT_STATUS_INVALID_PARAMETER;
                }
 
-               if (spnego.negTokenInit.targetPrincipal) {
+               if (spnego.negTokenInit.targetPrincipal
+                   && strcmp(spnego.negTokenInit.targetPrincipal, ADS_IGNORE_PRINCIPAL) != 0) {
                        DEBUG(5, ("Server claims it's principal name is %s\n", spnego.negTokenInit.targetPrincipal));
-                       gensec_set_target_principal(gensec_security, spnego.negTokenInit.targetPrincipal);
+                       if (lpcfg_client_use_spnego_principal(gensec_security->settings->lp_ctx)) {
+                               gensec_set_target_principal(gensec_security, spnego.negTokenInit.targetPrincipal);
+                       }
                }
 
                nt_status = gensec_spnego_parse_negTokenInit(gensec_security,
@@ -839,7 +858,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                /* compose reply */
                spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
                spnego_out.negTokenInit.mechTypes = my_mechs;
-               spnego_out.negTokenInit.reqFlags = 0;
+               spnego_out.negTokenInit.reqFlags = null_data_blob;
+               spnego_out.negTokenInit.reqFlagsPadding = 0;
                spnego_out.negTokenInit.mechListMIC = null_data_blob;
                spnego_out.negTokenInit.mechToken = unwrapped_out;
                
@@ -898,7 +918,6 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (NT_STATUS_IS_OK(nt_status) && spnego.negTokenTarg.mechListMIC.length > 0) {
                        new_spnego = true;
                        nt_status = gensec_check_packet(spnego_state->sub_sec_security,
-                                                       out_mem_ctx,
                                                        spnego_state->mech_types.data,
                                                        spnego_state->mech_types.length,
                                                        spnego_state->mech_types.data,
@@ -969,8 +988,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                    spnego.negTokenTarg.supportedMech &&
                    strcmp(spnego.negTokenTarg.supportedMech, spnego_state->neg_oid) != 0) {
                        DEBUG(3,("GENSEC SPNEGO: client preferred mech (%s) not accepted, server wants: %s\n",
-                                gensec_get_name_by_oid(spnego.negTokenTarg.supportedMech), 
-                                gensec_get_name_by_oid(spnego_state->neg_oid)));
+                                gensec_get_name_by_oid(gensec_security, spnego.negTokenTarg.supportedMech), 
+                                gensec_get_name_by_oid(gensec_security, spnego_state->neg_oid)));
                        
                        talloc_free(spnego_state->sub_sec_security);
                        nt_status = gensec_subcontext_start(spnego_state,
@@ -1005,7 +1024,6 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        }
                        if (NT_STATUS_IS_OK(nt_status) && spnego.negTokenTarg.mechListMIC.length > 0) {
                                nt_status = gensec_check_packet(spnego_state->sub_sec_security,
-                                                               out_mem_ctx,
                                                                spnego_state->mech_types.data,
                                                                spnego_state->mech_types.length,
                                                                spnego_state->mech_types.data,
@@ -1024,7 +1042,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                                                  spnego.negTokenTarg.responseToken, 
                                                  &unwrapped_out);
 
-                       if (NT_STATUS_IS_OK(nt_status)) {
+                       if (NT_STATUS_IS_OK(nt_status)
+                           && spnego.negTokenTarg.negResult != SPNEGO_ACCEPT_COMPLETED) {
                                new_spnego = gensec_have_feature(spnego_state->sub_sec_security,
                                                                 GENSEC_FEATURE_NEW_SPNEGO);
                        }
@@ -1056,7 +1075,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return nt_status;
                }
 
-               if (unwrapped_out.length) {
+               if (unwrapped_out.length || mech_list_mic.length) {
                        /* compose reply */
                        spnego_out.type = SPNEGO_NEG_TOKEN_TARG;
                        spnego_out.negTokenTarg.negResult = SPNEGO_NONE_RESULT;