Merge commit 'release-4-0-0alpha15' into master4-tmp
[amitay/samba.git] / source3 / winbindd / winbindd_util.c
index 283eee09af4ae10a7fc078dff1e776cca2e736a4..7dff138fc137b0a1381da743e024d8ebc5e0dad1 100644 (file)
 
 #include "includes.h"
 #include "winbindd.h"
+#include "secrets.h"
+#include "../libcli/security/security.h"
+#include "../libcli/auth/pam_errors.h"
+#include "passdb/machine_sid.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_WINBIND
 
 extern struct winbindd_methods cache_methods;
-extern struct winbindd_methods builtin_passdb_methods;
-extern struct winbindd_methods sam_passdb_methods;
-
 
 /**
- * @file winbindd_util.c
+ * @file winbindd_util.cq
  *
  * Winbind daemon for NT domain authentication nss module.
  **/
@@ -58,7 +59,7 @@ struct winbindd_domain *domain_list(void)
 
 /* Free all entries in the trusted domain list */
 
-void free_domain_list(void)
+static void free_domain_list(void)
 {
        struct winbindd_domain *domain = _domain_list;
 
@@ -71,25 +72,19 @@ void free_domain_list(void)
        }
 }
 
-static bool is_internal_domain(const DOM_SID *sid)
+static bool is_internal_domain(const struct dom_sid *sid)
 {
        if (sid == NULL)
                return False;
 
-       if ( IS_DC )
-               return sid_check_is_builtin(sid);
-
        return (sid_check_is_domain(sid) || sid_check_is_builtin(sid));
 }
 
-static bool is_in_internal_domain(const DOM_SID *sid)
+static bool is_in_internal_domain(const struct dom_sid *sid)
 {
        if (sid == NULL)
                return False;
 
-       if ( IS_DC )
-               return sid_check_is_in_builtin(sid);
-
        return (sid_check_is_in_our_domain(sid) || sid_check_is_in_builtin(sid));
 }
 
@@ -97,7 +92,7 @@ static bool is_in_internal_domain(const DOM_SID *sid)
 /* Add a trusted domain to our list of domains */
 static struct winbindd_domain *add_trusted_domain(const char *domain_name, const char *alt_name,
                                                  struct winbindd_methods *methods,
-                                                 const DOM_SID *sid)
+                                                 const struct dom_sid *sid)
 {
        struct winbindd_domain *domain;
        const char *alternative_name = NULL;
@@ -143,19 +138,20 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
                                continue;
                        }
 
-                       if (sid_equal(sid, &domain->sid)) {
+                       if (dom_sid_equal(sid, &domain->sid)) {
                                break;
                        }
                }
        }
 
-       /* See if we found a match.  Check if we need to update the
-          SID. */
-
-       if ( domain && sid) {
-               if ( sid_equal( &domain->sid, &global_sid_NULL ) )
+       if (domain != NULL) {
+               /*
+                * We found a match. Possibly update the SID
+                */
+               if ((sid != NULL)
+                   && dom_sid_equal(&domain->sid, &global_sid_NULL)) {
                        sid_copy( &domain->sid, sid );
-
+               }
                return domain;
        }
 
@@ -168,6 +164,16 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
 
        ZERO_STRUCTP(domain);
 
+       domain->children = SMB_MALLOC_ARRAY(
+               struct winbindd_child, lp_winbind_max_domain_connections());
+       if (domain->children == NULL) {
+               SAFE_FREE(domain);
+               return NULL;
+       }
+       memset(domain->children, 0,
+              sizeof(struct winbindd_child)
+              * lp_winbind_max_domain_connections());
+
        fstrcpy(domain->name, domain_name);
        if (alternative_name) {
                fstrcpy(domain->alt_name, alternative_name);
@@ -229,71 +235,64 @@ done:
        return domain;
 }
 
+bool domain_is_forest_root(const struct winbindd_domain *domain)
+{
+       const uint32_t fr_flags =
+               (NETR_TRUST_FLAG_TREEROOT|NETR_TRUST_FLAG_IN_FOREST);
+
+       return ((domain->domain_flags & fr_flags) == fr_flags);
+}
+
 /********************************************************************
   rescan our domains looking for new trusted domains
 ********************************************************************/
 
 struct trustdom_state {
-       TALLOC_CTX *mem_ctx;
-       bool primary;
-       bool forest_root;
-       struct winbindd_response *response;
+       struct winbindd_domain *domain;
+       struct winbindd_request request;
 };
 
-static void trustdom_recv(void *private_data, bool success);
+static void trustdom_list_done(struct tevent_req *req);
 static void rescan_forest_root_trusts( void );
 static void rescan_forest_trusts( void );
 
 static void add_trusted_domains( struct winbindd_domain *domain )
 {
-       TALLOC_CTX *mem_ctx;
-       struct winbindd_request *request;
-       struct winbindd_response *response;
-       uint32 fr_flags = (NETR_TRUST_FLAG_TREEROOT|NETR_TRUST_FLAG_IN_FOREST);
-
        struct trustdom_state *state;
+       struct tevent_req *req;
 
-       mem_ctx = talloc_init("add_trusted_domains");
-       if (mem_ctx == NULL) {
-               DEBUG(0, ("talloc_init failed\n"));
+       state = talloc_zero(NULL, struct trustdom_state);
+       if (state == NULL) {
+               DEBUG(0, ("talloc failed\n"));
                return;
        }
+       state->domain = domain;
 
-       request = TALLOC_ZERO_P(mem_ctx, struct winbindd_request);
-       response = TALLOC_P(mem_ctx, struct winbindd_response);
-       state = TALLOC_P(mem_ctx, struct trustdom_state);
+       state->request.length = sizeof(state->request);
+       state->request.cmd = WINBINDD_LIST_TRUSTDOM;
 
-       if ((request == NULL) || (response == NULL) || (state == NULL)) {
-               DEBUG(0, ("talloc failed\n"));
-               talloc_destroy(mem_ctx);
+       req = wb_domain_request_send(state, winbind_event_context(),
+                                    domain, &state->request);
+       if (req == NULL) {
+               DEBUG(1, ("wb_domain_request_send failed\n"));
+               TALLOC_FREE(state);
                return;
        }
-
-       state->mem_ctx = mem_ctx;
-       state->response = response;
-
-       /* Flags used to know how to continue the forest trust search */
-
-       state->primary = domain->primary;
-       state->forest_root = ((domain->domain_flags & fr_flags) == fr_flags );
-
-       request->length = sizeof(*request);
-       request->cmd = WINBINDD_LIST_TRUSTDOM;
-
-       async_domain_request(mem_ctx, domain, request, response,
-                            trustdom_recv, state);
+       tevent_req_set_callback(req, trustdom_list_done, state);
 }
 
-static void trustdom_recv(void *private_data, bool success)
+static void trustdom_list_done(struct tevent_req *req)
 {
-       struct trustdom_state *state =
-               talloc_get_type_abort(private_data, struct trustdom_state);
-       struct winbindd_response *response = state->response;
+       struct trustdom_state *state = tevent_req_callback_data(
+               req, struct trustdom_state);
+       struct winbindd_response *response;
+       int res, err;
        char *p;
 
-       if ((!success) || (response->result != WINBINDD_OK)) {
+       res = wb_domain_request_recv(req, state, &response, &err);
+       if ((res == -1) || (response->result != WINBINDD_OK)) {
                DEBUG(1, ("Could not receive trustdoms\n"));
-               talloc_destroy(state->mem_ctx);
+               TALLOC_FREE(state);
                return;
        }
 
@@ -301,7 +300,7 @@ static void trustdom_recv(void *private_data, bool success)
 
        while ((p != NULL) && (*p != '\0')) {
                char *q, *sidstr, *alt_name;
-               DOM_SID sid;
+               struct dom_sid sid;
                struct winbindd_domain *domain;
                char *alternate_name = NULL;
 
@@ -328,13 +327,8 @@ static void trustdom_recv(void *private_data, bool success)
                        *q = '\0';
 
                if (!string_to_sid(&sid, sidstr)) {
-                       /* Allow NULL sid for sibling domains */
-                       if ( strcmp(sidstr,"S-0-0") == 0) {
-                               sid_copy( &sid, &global_sid_NULL);
-                       } else {
-                               DEBUG(0, ("Got invalid trustdom response\n"));
-                               break;
-                       }
+                       DEBUG(0, ("Got invalid trustdom response\n"));
+                       break;
                }
 
                /* use the real alt_name if we have one, else pass in NULL */
@@ -356,8 +350,7 @@ static void trustdom_recv(void *private_data, bool success)
                                                    &cache_methods,
                                                    &sid);
                        if (domain) {
-                               setup_domain_child(domain,
-                                                  &domain->child);
+                               setup_domain_child(domain);
                        }
                }
                p=q;
@@ -373,23 +366,23 @@ static void trustdom_recv(void *private_data, bool success)
               && !forest_root)
        */
 
-       if ( state->primary ) {
+       if (state->domain->primary) {
                /* If this is our primary domain and we are not in the
                   forest root, we have to scan the root trusts first */
 
-               if ( !state->forest_root )
+               if (!domain_is_forest_root(state->domain))
                        rescan_forest_root_trusts();
                else
                        rescan_forest_trusts();
 
-       } else if ( state->forest_root ) {
+       } else if (domain_is_forest_root(state->domain)) {
                /* Once we have done root forest trust search, we can
                   go on to search the trusted forests */
 
                rescan_forest_trusts();
        }
 
-       talloc_destroy(state->mem_ctx);
+       TALLOC_FREE(state);
 
        return;
 }
@@ -433,6 +426,9 @@ static void rescan_forest_root_trusts( void )
                                                dom_list[i].dns_name,
                                                &cache_methods,
                                                &dom_list[i].sid );
+                       if (d != NULL) {
+                               setup_domain_child(d);
+                       }
                }
 
                if (d == NULL) {
@@ -502,6 +498,9 @@ static void rescan_forest_trusts( void )
                                                        dom_list[i].dns_name,
                                                        &cache_methods,
                                                        &dom_list[i].sid );
+                               if (d != NULL) {
+                                       setup_domain_child(d);
+                               }
                        }
 
                        if (d == NULL) {
@@ -569,7 +568,11 @@ enum winbindd_result winbindd_dual_init_connection(struct winbindd_domain *domai
                fstrcpy(domain->dcname, state->request->data.init_conn.dcname);
        }
 
-       init_dc_connection(domain);
+       if (domain->internal) {
+               domain->initialized = true;
+       } else {
+               init_dc_connection(domain);
+       }
 
        if (!domain->initialized) {
                /* If we return error here we can't do any cached authentication,
@@ -606,29 +609,27 @@ bool init_domain_list(void)
 
        /* BUILTIN domain */
 
-       domain = add_trusted_domain("BUILTIN", NULL, &builtin_passdb_methods,
+       domain = add_trusted_domain("BUILTIN", NULL, &cache_methods,
                                    &global_sid_Builtin);
        if (domain) {
-               setup_domain_child(domain,
-                                  &domain->child);
+               setup_domain_child(domain);
        }
 
        /* Local SAM */
 
        domain = add_trusted_domain(get_global_sam_name(), NULL,
-                                   &sam_passdb_methods, get_global_sam_sid());
+                                   &cache_methods, get_global_sam_sid());
        if (domain) {
                if ( role != ROLE_DOMAIN_MEMBER ) {
                        domain->primary = True;
                }
-               setup_domain_child(domain,
-                                  &domain->child);
+               setup_domain_child(domain);
        }
 
        /* Add ourselves as the first entry. */
 
        if ( role == ROLE_DOMAIN_MEMBER ) {
-               DOM_SID our_sid;
+               struct dom_sid our_sid;
 
                if (!secrets_fetch_domain_sid(lp_workgroup(), &our_sid)) {
                        DEBUG(0, ("Could not fetch our SID - did we join?\n"));
@@ -639,8 +640,7 @@ bool init_domain_list(void)
                                             &cache_methods, &our_sid);
                if (domain) {
                        domain->primary = True;
-                       setup_domain_child(domain,
-                                          &domain->child);
+                       setup_domain_child(domain);
 
                        /* Even in the parent winbindd we'll need to
                           talk to the DC, so try and see if we can
@@ -655,50 +655,6 @@ bool init_domain_list(void)
        return True;
 }
 
-void check_domain_trusted( const char *name, const DOM_SID *user_sid )
-{
-       struct winbindd_domain *domain;
-       DOM_SID dom_sid;
-       uint32 rid;
-
-       /* Check if we even care */
-
-       if (!lp_allow_trusted_domains())
-               return;
-
-       domain = find_domain_from_name_noinit( name );
-       if ( domain )
-               return;
-
-       sid_copy( &dom_sid, user_sid );
-       if ( !sid_split_rid( &dom_sid, &rid ) )
-               return;
-
-       /* add the newly discovered trusted domain */
-
-       domain = add_trusted_domain( name, NULL, &cache_methods,
-                                    &dom_sid);
-
-       if ( !domain )
-               return;
-
-       /* assume this is a trust from a one-way transitive
-          forest trust */
-
-       domain->active_directory = True;
-       domain->domain_flags = NETR_TRUST_FLAG_OUTBOUND;
-       domain->domain_type  = NETR_TRUST_TYPE_UPLEVEL;
-       domain->internal = False;
-       domain->online = True;
-
-       setup_domain_child(domain,
-                          &domain->child);
-
-       wcache_tdc_add_domain( domain );
-
-       return;
-}
-
 /**
  * Given a domain name, return the struct winbindd domain info for it
  *
@@ -747,14 +703,14 @@ struct winbindd_domain *find_domain_from_name(const char *domain_name)
 
 /* Given a domain sid, return the struct winbindd domain info for it */
 
-struct winbindd_domain *find_domain_from_sid_noinit(const DOM_SID *sid)
+struct winbindd_domain *find_domain_from_sid_noinit(const struct dom_sid *sid)
 {
        struct winbindd_domain *domain;
 
        /* Search through list */
 
        for (domain = domain_list(); domain != NULL; domain = domain->next) {
-               if (sid_compare_domain(sid, &domain->sid) == 0)
+               if (dom_sid_compare_domain(sid, &domain->sid) == 0)
                        return domain;
        }
 
@@ -765,7 +721,7 @@ struct winbindd_domain *find_domain_from_sid_noinit(const DOM_SID *sid)
 
 /* Given a domain sid, return the struct winbindd domain info for it */
 
-struct winbindd_domain *find_domain_from_sid(const DOM_SID *sid)
+struct winbindd_domain *find_domain_from_sid(const struct dom_sid *sid)
 {
        struct winbindd_domain *domain;
 
@@ -799,23 +755,18 @@ struct winbindd_domain *find_root_domain(void)
 {
        struct winbindd_domain *ours = find_our_domain();
 
-       if ( !ours )
-               return NULL;
-
-       if ( strlen(ours->forest_name) == 0 )
+       if (ours->forest_name[0] == '\0') {
                return NULL;
+       }
 
        return find_domain_from_name( ours->forest_name );
 }
 
 struct winbindd_domain *find_builtin_domain(void)
 {
-       DOM_SID sid;
        struct winbindd_domain *domain;
 
-       string_to_sid(&sid, "S-1-5-32");
-       domain = find_domain_from_sid(&sid);
-
+       domain = find_domain_from_sid(&global_sid_Builtin);
        if (domain == NULL) {
                smb_panic("Could not find BUILTIN domain");
        }
@@ -825,7 +776,7 @@ struct winbindd_domain *find_builtin_domain(void)
 
 /* Find the appropriate domain to lookup a name or SID */
 
-struct winbindd_domain *find_lookup_domain_from_sid(const DOM_SID *sid)
+struct winbindd_domain *find_lookup_domain_from_sid(const struct dom_sid *sid)
 {
        /* SIDs in the S-1-22-{1,2} domain should be handled by our passdb */
 
@@ -860,6 +811,10 @@ struct winbindd_domain *find_lookup_domain_from_name(const char *domain_name)
        if ( strequal(domain_name, unix_users_domain_name() ) ||
             strequal(domain_name, unix_groups_domain_name() ) )
        {
+               /*
+                * The "Unix User" and "Unix Group" domain our handled by
+                * passdb
+                */
                return find_domain_from_name_noinit( get_global_sam_name() );
        }
 
@@ -867,95 +822,10 @@ struct winbindd_domain *find_lookup_domain_from_name(const char *domain_name)
            strequal(domain_name, get_global_sam_name()))
                return find_domain_from_name_noinit(domain_name);
 
-       /* The "Unix User" and "Unix Group" domain our handled by passdb */
 
        return find_our_domain();
 }
 
-/* Lookup a sid in a domain from a name */
-
-bool winbindd_lookup_sid_by_name(TALLOC_CTX *mem_ctx,
-                                enum winbindd_cmd orig_cmd,
-                                struct winbindd_domain *domain,
-                                const char *domain_name,
-                                const char *name, DOM_SID *sid,
-                                enum lsa_SidType *type)
-{
-       NTSTATUS result;
-
-       /* Lookup name */
-       result = domain->methods->name_to_sid(domain, mem_ctx, orig_cmd,
-                                             domain_name, name, sid, type);
-
-       /* Return sid and type if lookup successful */
-       if (!NT_STATUS_IS_OK(result)) {
-               *type = SID_NAME_UNKNOWN;
-       }
-
-       return NT_STATUS_IS_OK(result);
-}
-
-/**
- * @brief Lookup a name in a domain from a sid.
- *
- * @param sid Security ID you want to look up.
- * @param name On success, set to the name corresponding to @p sid.
- * @param dom_name On success, set to the 'domain name' corresponding to @p sid.
- * @param type On success, contains the type of name: alias, group or
- * user.
- * @retval True if the name exists, in which case @p name and @p type
- * are set, otherwise False.
- **/
-bool winbindd_lookup_name_by_sid(TALLOC_CTX *mem_ctx,
-                                struct winbindd_domain *domain,
-                                DOM_SID *sid,
-                                char **dom_name,
-                                char **name,
-                                enum lsa_SidType *type)
-{
-       NTSTATUS result;
-
-       *dom_name = NULL;
-       *name = NULL;
-
-       /* Lookup name */
-
-       result = domain->methods->sid_to_name(domain, mem_ctx, sid, dom_name, name, type);
-
-       /* Return name and type if successful */
-
-       if (NT_STATUS_IS_OK(result)) {
-               return True;
-       }
-
-       *type = SID_NAME_UNKNOWN;
-
-       return False;
-}
-
-/* Free state information held for {set,get,end}{pw,gr}ent() functions */
-
-void free_getent_state(struct getent_state *state)
-{
-       struct getent_state *temp;
-
-       /* Iterate over state list */
-
-       temp = state;
-
-       while(temp != NULL) {
-               struct getent_state *next = temp->next;
-
-               /* Free sam entries then list entry */
-
-               SAFE_FREE(state->sam_entries);
-               DLIST_REMOVE(state, state);
-
-               SAFE_FREE(temp);
-               temp = next;
-       }
-}
-
 /* Is this a domain which we may assume no DOMAIN\ prefix? */
 
 static bool assume_domain(const char *domain)
@@ -996,7 +866,8 @@ bool parse_domain_user(const char *domuser, fstring domain, fstring user)
                if ( assume_domain(lp_workgroup())) {
                        fstrcpy(domain, lp_workgroup());
                } else if ((p = strchr(domuser, '@')) != NULL) {
-                       fstrcpy(domain, "");
+                       fstrcpy(domain, p + 1);
+                       user[PTR_DIFF(p, domuser)] = 0;
                } else {
                        return False;
                }
@@ -1023,31 +894,6 @@ bool parse_domain_user_talloc(TALLOC_CTX *mem_ctx, const char *domuser,
        return ((*domain != NULL) && (*user != NULL));
 }
 
-/* add a domain user name to a buffer */
-void parse_add_domuser(void *buf, char *domuser, int *len)
-{
-       fstring domain;
-       char *p, *user;
-
-       user = domuser;
-       p = strchr(domuser, *lp_winbind_separator());
-
-       if (p) {
-
-               fstrcpy(domain, domuser);
-               domain[PTR_DIFF(p, domuser)] = 0;
-               p++;
-
-               if (assume_domain(domain)) {
-
-                       user = p;
-                       *len -= (PTR_DIFF(p, domuser));
-               }
-       }
-
-       safe_strcpy((char *)buf, user, *len);
-}
-
 /* Ensure an incoming username from NSS is fully qualified. Replace the
    incoming fstring with DOMAIN <separator> user. Returns the same
    values as parse_domain_user() but also replaces the incoming username.
@@ -1125,49 +971,6 @@ char *fill_domain_username_talloc(TALLOC_CTX *mem_ctx,
        return name;
 }
 
-/*
- * Winbindd socket accessor functions
- */
-
-const char *get_winbind_pipe_dir(void)
-{
-       return lp_parm_const_string(-1, "winbindd", "socket dir", WINBINDD_SOCKET_DIR);
-}
-
-char *get_winbind_priv_pipe_dir(void)
-{
-       return lock_path(WINBINDD_PRIV_SOCKET_SUBDIR);
-}
-
-/* Open the winbindd socket */
-
-static int _winbindd_socket = -1;
-static int _winbindd_priv_socket = -1;
-
-int open_winbindd_socket(void)
-{
-       if (_winbindd_socket == -1) {
-               _winbindd_socket = create_pipe_sock(
-                       get_winbind_pipe_dir(), WINBINDD_SOCKET_NAME, 0755);
-               DEBUG(10, ("open_winbindd_socket: opened socket fd %d\n",
-                          _winbindd_socket));
-       }
-
-       return _winbindd_socket;
-}
-
-int open_winbindd_priv_socket(void)
-{
-       if (_winbindd_priv_socket == -1) {
-               _winbindd_priv_socket = create_pipe_sock(
-                       get_winbind_priv_pipe_dir(), WINBINDD_SOCKET_NAME, 0750);
-               DEBUG(10, ("open_winbindd_priv_socket: opened socket fd %d\n",
-                          _winbindd_priv_socket));
-       }
-
-       return _winbindd_priv_socket;
-}
-
 /*
  * Client list accessor functions
  */
@@ -1198,23 +1001,6 @@ void winbindd_remove_client(struct winbindd_cli_state *cli)
        _num_clients--;
 }
 
-/* Close all open clients */
-
-void winbindd_kill_all_clients(void)
-{
-       struct winbindd_cli_state *cl = winbindd_client_list();
-
-       DEBUG(10, ("winbindd_kill_all_clients: going postal\n"));
-
-       while (cl) {
-               struct winbindd_cli_state *next;
-
-               next = cl->next;
-               winbindd_remove_client(cl);
-               cl = next;
-       }
-}
-
 /* Return number of open clients */
 
 int winbindd_num_clients(void)
@@ -1224,12 +1010,12 @@ int winbindd_num_clients(void)
 
 NTSTATUS lookup_usergroups_cached(struct winbindd_domain *domain,
                                  TALLOC_CTX *mem_ctx,
-                                 const DOM_SID *user_sid,
-                                 uint32 *p_num_groups, DOM_SID **user_sids)
+                                 const struct dom_sid *user_sid,
+                                 uint32_t *p_num_groups, struct dom_sid **user_sids)
 {
        struct netr_SamInfo3 *info3 = NULL;
        NTSTATUS status = NT_STATUS_NO_MEMORY;
-       size_t num_groups = 0;
+       uint32_t num_groups = 0;
 
        DEBUG(3,(": lookup_usergroups_cached\n"));
 
@@ -1274,7 +1060,7 @@ NTSTATUS lookup_usergroups_cached(struct winbindd_domain *domain,
 
 NTSTATUS normalize_name_map(TALLOC_CTX *mem_ctx,
                             struct winbindd_domain *domain,
-                            char *name,
+                            const char *name,
                             char **normalized)
 {
        NTSTATUS nt_status;
@@ -1548,3 +1334,50 @@ void set_auth_errors(struct winbindd_response *resp, NTSTATUS result)
                        get_friendly_nt_error_msg(result));
        resp->data.auth.pam_error = nt_status_to_pam(result);
 }
+
+bool is_domain_offline(const struct winbindd_domain *domain)
+{
+       if (!lp_winbind_offline_logon()) {
+               return false;
+       }
+       if (get_global_winbindd_state_offline()) {
+               return true;
+       }
+       return !domain->online;
+}
+
+bool is_domain_online(const struct winbindd_domain *domain)
+{
+       return !is_domain_offline(domain);
+}
+
+bool parse_sidlist(TALLOC_CTX *mem_ctx, const char *sidstr,
+                  struct dom_sid **sids, uint32_t *num_sids)
+{
+       const char *p;
+
+       p = sidstr;
+       if (p == NULL)
+               return False;
+
+       while (p[0] != '\0') {
+               struct dom_sid sid;
+               const char *q = NULL;
+
+               if (!dom_sid_parse_endp(p, &sid, &q)) {
+                       DEBUG(1, ("Could not parse sid %s\n", p));
+                       return false;
+               }
+               if ((q == NULL) || (q[0] != '\n')) {
+                       DEBUG(1, ("Got invalid sidstr: %s\n", p));
+                       return false;
+               }
+               if (!NT_STATUS_IS_OK(add_sid_to_array(mem_ctx, &sid, sids,
+                                                     num_sids)))
+               {
+                       return False;
+               }
+               p = q+1;
+       }
+       return True;
+}