s3:net: fix some i18n messages in net_registry_getsd_internal().
[amitay/samba.git] / source3 / utils / net_registry.c
index 26710b35800a200c1f6f247bf4704c81c4f78b3d..1006079a0332aa43d0542766a88034e227aca3d6 100644 (file)
@@ -91,14 +91,15 @@ static WERROR open_key(TALLOC_CTX *ctx, const char *path,
 
        werr = open_hive(tmp_ctx, path, desired_access, &hive, &subkey_name);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_hive failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_hive failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
        werr = reg_openkey(ctx, hive, subkey_name, desired_access, key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_openkey failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, _("reg_openkey failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
@@ -129,15 +130,18 @@ static int net_registry_enumerate(struct net_context *c, int argc,
        int ret = -1;
 
        if (argc != 1 || c->display_usage) {
-               d_printf("Usage:    net registry enumerate <path>\n");
-               d_printf("Example:  net registry enumerate "
-                        "'HKLM\\Software\\Samba'\n");
+               d_printf("%s\n%s",
+                        _("Usage:"),
+                        _("net registry enumerate <path>\n"));
+               d_printf("%s\n%s",
+                        _("Example:"),
+                        _("net registry enumerate 'HKLM\\Software\\Samba'\n"));
                goto done;
        }
 
        werr = open_key(ctx, argv[0], REG_KEY_READ, &key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_key failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_key failed: %s\n"), win_errstr(werr));
                goto done;
        }
 
@@ -181,38 +185,43 @@ static int net_registry_createkey(struct net_context *c, int argc,
        int ret = -1;
 
        if (argc != 1 || c->display_usage) {
-               d_printf("Usage:    net registry createkey <path>\n");
-               d_printf("Example:  net registry createkey "
-                        "'HKLM\\Software\\Samba\\smbconf.127.0.0.1'\n");
+               d_printf("%s\n%s",
+                        _("Usage:"),
+                        _("net registry createkey <path>\n"));
+               d_printf("%s\n%s",
+                        _("Example:"),
+                        _("net registry createkey "
+                          "'HKLM\\Software\\Samba\\smbconf.127.0.0.1'\n"));
                goto done;
        }
        if (strlen(argv[0]) == 0) {
-               d_fprintf(stderr, "error: zero length key name given\n");
+               d_fprintf(stderr, _("error: zero length key name given\n"));
                goto done;
        }
 
        werr = open_hive(ctx, argv[0], REG_KEY_WRITE, &hivekey, &subkeyname);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_hive failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_hive failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
        werr = reg_createkey(ctx, hivekey, subkeyname, REG_KEY_WRITE,
                             &subkey, &action);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_createkey failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, _("reg_createkey failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
        switch (action) {
                case REG_ACTION_NONE:
-                       d_printf("createkey did nothing -- huh?\n");
+                       d_printf(_("createkey did nothing -- huh?\n"));
                        break;
                case REG_CREATED_NEW_KEY:
-                       d_printf("createkey created %s\n", argv[0]);
+                       d_printf(_("createkey created %s\n"), argv[0]);
                        break;
                case REG_OPENED_EXISTING_KEY:
-                       d_printf("createkey opened existing %s\n", argv[0]);
+                       d_printf(_("createkey opened existing %s\n"), argv[0]);
                        break;
        }
 
@@ -233,26 +242,31 @@ static int net_registry_deletekey(struct net_context *c, int argc,
        int ret = -1;
 
        if (argc != 1 || c->display_usage) {
-               d_printf("Usage:    net registry deletekey <path>\n");
-               d_printf("Example:  net registry deletekey "
-                        "'HKLM\\Software\\Samba\\smbconf.127.0.0.1'\n");
+               d_printf("%s\n%s",
+                        _("Usage:"),
+                        _("net registry deletekey <path>\n"));
+               d_printf("%s\n%s",
+                        _("Example:"),
+                        _("net registry deletekey "
+                          "'HKLM\\Software\\Samba\\smbconf.127.0.0.1'\n"));
                goto done;
        }
        if (strlen(argv[0]) == 0) {
-               d_fprintf(stderr, "error: zero length key name given\n");
+               d_fprintf(stderr, _("error: zero length key name given\n"));
                goto done;
        }
 
        werr = open_hive(ctx, argv[0], REG_KEY_WRITE, &hivekey, &subkeyname);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_hive failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, "open_hive %s: %s\n", _("failed"),
+                         win_errstr(werr));
                goto done;
        }
 
        werr = reg_deletekey(hivekey, subkeyname);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_deletekey failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, "reg_deletekey %s: %s\n", _("failed"),
+                         win_errstr(werr));
                goto done;
        }
 
@@ -273,21 +287,22 @@ static int net_registry_getvalue_internal(struct net_context *c, int argc,
        TALLOC_CTX *ctx = talloc_stackframe();
 
        if (argc != 2 || c->display_usage) {
-               d_fprintf(stderr, "usage: net rpc registry getvalue <key> "
-                                 "<valuename>\n");
+               d_fprintf(stderr, "%s\n%s",
+                         _("Usage:"),
+                         _("net rpc registry getvalue <key> <valuename>\n"));
                goto done;
        }
 
        werr = open_key(ctx, argv[0], REG_KEY_READ, &key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_key failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_key failed: %s\n"), win_errstr(werr));
                goto done;
        }
 
        werr = reg_queryvalue(ctx, key, argv[1], &value);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_queryvalue failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, _("reg_queryvalue failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
@@ -322,13 +337,15 @@ static int net_registry_setvalue(struct net_context *c, int argc,
        TALLOC_CTX *ctx = talloc_stackframe();
 
        if (argc < 4 || c->display_usage) {
-               d_fprintf(stderr, "usage: net rpc registry setvalue <key> "
-                         "<valuename> <type> [<val>]+\n");
+               d_fprintf(stderr, "%s\n%s",
+                         _("Usage:"),
+                         _("net rpc registry setvalue <key> <valuename> "
+                           "<type> [<val>]+\n"));
                goto done;
        }
 
        if (!strequal(argv[2], "multi_sz") && (argc != 4)) {
-               d_fprintf(stderr, "Too many args for type %s\n", argv[2]);
+               d_fprintf(stderr, _("Too many args for type %s\n"), argv[2]);
                goto done;
        }
 
@@ -339,21 +356,25 @@ static int net_registry_setvalue(struct net_context *c, int argc,
                value.type = REG_SZ;
                value.v.sz.len = strlen(argv[3])+1;
                value.v.sz.str = CONST_DISCARD(char *, argv[3]);
+       } else if (strequal(argv[2], "multi_sz")) {
+               value.type = REG_MULTI_SZ;
+               value.v.multi_sz.num_strings = argc - 3;
+               value.v.multi_sz.strings = (char **)(argv + 3);
        } else {
-               d_fprintf(stderr, "type \"%s\" not implemented\n", argv[2]);
+               d_fprintf(stderr, _("type \"%s\" not implemented\n"), argv[2]);
                goto done;
        }
 
        werr = open_key(ctx, argv[0], REG_KEY_WRITE, &key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_key failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_key failed: %s\n"), win_errstr(werr));
                goto done;
        }
 
        werr = reg_setvalue(key, argv[1], &value);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_setvalue failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, _("reg_setvalue failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
@@ -373,21 +394,22 @@ static int net_registry_deletevalue(struct net_context *c, int argc,
        int ret = -1;
 
        if (argc != 2 || c->display_usage) {
-               d_fprintf(stderr, "usage: net rpc registry deletevalue <key> "
-                         "<valuename>\n");
+               d_fprintf(stderr, "%s\n%s",
+                         _("Usage:"),
+                         _("net rpc registry deletevalue <key> <valuename>\n"));
                goto done;
        }
 
        werr = open_key(ctx, argv[0], REG_KEY_WRITE, &key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_key failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, _("open_key failed: %s\n"), win_errstr(werr));
                goto done;
        }
 
        werr = reg_deletevalue(key, argv[1]);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_deletekey failed: %s\n",
-                         dos_errstr(werr));
+               d_fprintf(stderr, _("reg_deletekey failed: %s\n"),
+                         win_errstr(werr));
                goto done;
        }
 
@@ -398,45 +420,77 @@ done:
        return ret;
 }
 
-static int net_registry_getsd(struct net_context *c, int argc,
-                             const char **argv)
+static WERROR net_registry_getsd_internal(struct net_context *c,
+                                         TALLOC_CTX *mem_ctx,
+                                         const char *keyname,
+                                         struct security_descriptor **sd)
 {
        WERROR werr;
-       int ret = -1;
        struct registry_key *key = NULL;
-       struct security_descriptor *secdesc = NULL;
        TALLOC_CTX *ctx = talloc_stackframe();
        uint32_t access_mask = REG_KEY_READ |
-                              SEC_RIGHT_MAXIMUM_ALLOWED |
-                              SEC_RIGHT_SYSTEM_SECURITY;
+                              SEC_FLAG_MAXIMUM_ALLOWED |
+                              SEC_FLAG_SYSTEM_SECURITY;
 
        /*
-        * net_rpc_regsitry uses SEC_RIGHT_SYSTEM_SECURITY, but access
+        * net_rpc_regsitry uses SEC_FLAG_SYSTEM_SECURITY, but access
         * is denied with these perms right now...
         */
        access_mask = REG_KEY_READ;
 
-       if (argc != 1 || c->display_usage) {
-               d_printf("Usage:    net registry getsd <path>\n");
-               d_printf("Example:  net registry getsd "
-                        "'HKLM\\Software\\Samba'\n");
+       if (sd == NULL) {
+               d_fprintf(stderr, _("internal error: invalid argument\n"));
+               werr = WERR_INVALID_PARAM;
                goto done;
        }
-       if (strlen(argv[0]) == 0) {
-               d_fprintf(stderr, "error: zero length key name given\n");
+
+       if (strlen(keyname) == 0) {
+               d_fprintf(stderr, _("error: zero length key name given\n"));
+               werr = WERR_INVALID_PARAM;
                goto done;
        }
 
-       werr = open_key(ctx, argv[0], access_mask, &key);
+       werr = open_key(ctx, keyname, access_mask, &key);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "open_key failed: %s\n", dos_errstr(werr));
+               d_fprintf(stderr, "%s%s\n", _("open_key failed: "),
+                         win_errstr(werr));
                goto done;
        }
 
-       werr = reg_getkeysecurity(ctx, key, &secdesc);
+       werr = reg_getkeysecurity(mem_ctx, key, sd);
+       if (!W_ERROR_IS_OK(werr)) {
+               d_fprintf(stderr, "%s%s\n", _("reg_getkeysecurity failed: "),
+                         win_errstr(werr));
+               goto done;
+       }
+
+       werr = WERR_OK;
+
+done:
+       TALLOC_FREE(ctx);
+       return werr;
+}
+
+static int net_registry_getsd(struct net_context *c, int argc,
+                             const char **argv)
+{
+       WERROR werr;
+       int ret = -1;
+       struct security_descriptor *secdesc = NULL;
+       TALLOC_CTX *ctx = talloc_stackframe();
+
+       if (argc != 1 || c->display_usage) {
+               d_printf("%s\n%s",
+                        _("Usage:"),
+                        _("net registry getsd <path>\n"));
+               d_printf("%s\n%s",
+                        _("Example:"),
+                        _("net registry getsd 'HKLM\\Software\\Samba'\n"));
+               goto done;
+       }
+
+       werr = net_registry_getsd_internal(c, ctx, argv[0], &secdesc);
        if (!W_ERROR_IS_OK(werr)) {
-               d_fprintf(stderr, "reg_getkeysecurity failed: %s\n",
-                         dos_errstr(werr));
                goto done;
        }
 
@@ -449,6 +503,38 @@ done:
        return ret;
 }
 
+static int net_registry_getsd_sddl(struct net_context *c,
+                                  int argc, const char **argv)
+{
+       WERROR werr;
+       int ret = -1;
+       struct security_descriptor *secdesc = NULL;
+       TALLOC_CTX *ctx = talloc_stackframe();
+
+       if (argc != 1 || c->display_usage) {
+               d_printf("%s\n%s",
+                        _("Usage:"),
+                        _("net registry getsd_sddl <path>\n"));
+               d_printf("%s\n%s",
+                        _("Example:"),
+                        _("net registry getsd_sddl 'HKLM\\Software\\Samba'\n"));
+               goto done;
+       }
+
+       werr = net_registry_getsd_internal(c, ctx, argv[0], &secdesc);
+       if (!W_ERROR_IS_OK(werr)) {
+               goto done;
+       }
+
+       d_printf("%s\n", sddl_encode(ctx, secdesc, get_global_sam_sid()));
+
+       ret = 0;
+
+done:
+       TALLOC_FREE(ctx);
+       return ret;
+}
+
 int net_registry(struct net_context *c, int argc, const char **argv)
 {
        int ret = -1;
@@ -458,65 +544,73 @@ int net_registry(struct net_context *c, int argc, const char **argv)
                        "enumerate",
                        net_registry_enumerate,
                        NET_TRANSPORT_LOCAL,
-                       "Enumerate registry keys and values",
-                       "net registry enumerate\n"
-                       "    Enumerate registry keys and values"
+                       N_("Enumerate registry keys and values"),
+                       N_("net registry enumerate\n"
+                          "    Enumerate registry keys and values")
                },
                {
                        "createkey",
                        net_registry_createkey,
                        NET_TRANSPORT_LOCAL,
-                       "Create a new registry key",
-                       "net registry createkey\n"
-                       "    Create a new registry key"
+                       N_("Create a new registry key"),
+                       N_("net registry createkey\n"
+                          "    Create a new registry key")
                },
                {
                        "deletekey",
                        net_registry_deletekey,
                        NET_TRANSPORT_LOCAL,
-                       "Delete a registry key",
-                       "net registry deletekey\n"
-                       "    Delete a registry key"
+                       N_("Delete a registry key"),
+                       N_("net registry deletekey\n"
+                          "    Delete a registry key")
                },
                {
                        "getvalue",
                        net_registry_getvalue,
                        NET_TRANSPORT_LOCAL,
-                       "Print a registry value",
-                       "net registry getvalue\n"
-                       "    Print a registry value"
+                       N_("Print a registry value"),
+                       N_("net registry getvalue\n"
+                          "    Print a registry value")
                },
                {
                        "getvalueraw",
                        net_registry_getvalueraw,
                        NET_TRANSPORT_LOCAL,
-                       "Print a registry value (raw format)",
-                       "net registry getvalueraw\n"
-                       "    Print a registry value (raw format)"
+                       N_("Print a registry value (raw format)"),
+                       N_("net registry getvalueraw\n"
+                          "    Print a registry value (raw format)")
                },
                {
                        "setvalue",
                        net_registry_setvalue,
                        NET_TRANSPORT_LOCAL,
-                       "Set a new registry value",
-                       "net registry setvalue\n"
-                       "    Set a new registry value"
+                       N_("Set a new registry value"),
+                       N_("net registry setvalue\n"
+                          "    Set a new registry value")
                },
                {
                        "deletevalue",
                        net_registry_deletevalue,
                        NET_TRANSPORT_LOCAL,
-                       "Delete a registry value",
-                       "net registry deletevalue\n"
-                       "    Delete a registry value"
+                       N_("Delete a registry value"),
+                       N_("net registry deletevalue\n"
+                          "    Delete a registry value")
                },
                {
                        "getsd",
                        net_registry_getsd,
                        NET_TRANSPORT_LOCAL,
-                       "Get security descriptor",
-                       "net registry getsd\n"
-                       "    Get security descriptor"
+                       N_("Get security descriptor"),
+                       N_("net registry getsd\n"
+                          "    Get security descriptor")
+               },
+               {
+                       "getsd_sddl",
+                       net_registry_getsd_sddl,
+                       NET_TRANSPORT_LOCAL,
+                       N_("Get security descriptor in sddl format"),
+                       N_("net registry getsd_sddl\n"
+                          "    Get security descriptor in sddl format")
                },
        { NULL, NULL, 0, NULL, NULL }
        };