#include "includes.h"
#include "../librpc/gen_ndr/srv_winreg.h"
+#include "registry/reg_parse_prs.h"
#include "registry.h"
+#include "registry/reg_api.h"
+#include "registry/reg_api_regf.h"
#include "registry/reg_perfcount.h"
-#include "registry/reg_util_marshalling.h"
+#include "rpc_misc.h"
#undef DBGC_CLASS
#define DBGC_CLASS DBGC_RPC_SRV
Find a registry key handle and return a struct registry_key *
*****************************************************************/
-static struct registry_key *find_regkey_by_hnd(pipes_struct *p,
+static struct registry_key *find_regkey_by_hnd(struct pipes_struct *p,
struct policy_handle *hnd)
{
struct registry_key *regkey = NULL;
HK[LM|U]\<key>\<key>\...
*******************************************************************/
-static WERROR open_registry_key( pipes_struct *p, struct policy_handle *hnd,
- struct registry_key *parent,
- const char *subkeyname,
- uint32 access_desired )
+static WERROR open_registry_key(struct pipes_struct *p,
+ struct policy_handle *hnd,
+ struct registry_key *parent,
+ const char *subkeyname,
+ uint32_t access_desired)
{
WERROR result = WERR_OK;
struct registry_key *key;
Note that P should be valid & hnd should already have space
*******************************************************************/
-static bool close_registry_key(pipes_struct *p, struct policy_handle *hnd)
+static bool close_registry_key(struct pipes_struct *p,
+ struct policy_handle *hnd)
{
struct registry_key *regkey = find_regkey_by_hnd(p, hnd);
_winreg_CloseKey
********************************************************************/
-WERROR _winreg_CloseKey(pipes_struct *p, struct winreg_CloseKey *r)
+WERROR _winreg_CloseKey(struct pipes_struct *p,
+ struct winreg_CloseKey *r)
{
/* close the policy handle */
_winreg_OpenHKLM
********************************************************************/
-WERROR _winreg_OpenHKLM(pipes_struct *p, struct winreg_OpenHKLM *r)
+WERROR _winreg_OpenHKLM(struct pipes_struct *p,
+ struct winreg_OpenHKLM *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKLM, r->in.access_mask);
}
_winreg_OpenHKPD
********************************************************************/
-WERROR _winreg_OpenHKPD(pipes_struct *p, struct winreg_OpenHKPD *r)
+WERROR _winreg_OpenHKPD(struct pipes_struct *p,
+ struct winreg_OpenHKPD *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKPD, r->in.access_mask);
}
_winreg_OpenHKPT
********************************************************************/
-WERROR _winreg_OpenHKPT(pipes_struct *p, struct winreg_OpenHKPT *r)
+WERROR _winreg_OpenHKPT(struct pipes_struct *p,
+ struct winreg_OpenHKPT *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKPT, r->in.access_mask);
}
_winreg_OpenHKCR
********************************************************************/
-WERROR _winreg_OpenHKCR(pipes_struct *p, struct winreg_OpenHKCR *r)
+WERROR _winreg_OpenHKCR(struct pipes_struct *p,
+ struct winreg_OpenHKCR *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKCR, r->in.access_mask);
}
_winreg_OpenHKU
********************************************************************/
-WERROR _winreg_OpenHKU(pipes_struct *p, struct winreg_OpenHKU *r)
+WERROR _winreg_OpenHKU(struct pipes_struct *p,
+ struct winreg_OpenHKU *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKU, r->in.access_mask);
}
_winreg_OpenHKCU
********************************************************************/
-WERROR _winreg_OpenHKCU(pipes_struct *p, struct winreg_OpenHKCU *r)
+WERROR _winreg_OpenHKCU(struct pipes_struct *p,
+ struct winreg_OpenHKCU *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKCU, r->in.access_mask);
}
_winreg_OpenHKCC
********************************************************************/
-WERROR _winreg_OpenHKCC(pipes_struct *p, struct winreg_OpenHKCC *r)
+WERROR _winreg_OpenHKCC(struct pipes_struct *p,
+ struct winreg_OpenHKCC *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKCC, r->in.access_mask);
}
_winreg_OpenHKDD
********************************************************************/
-WERROR _winreg_OpenHKDD(pipes_struct *p, struct winreg_OpenHKDD *r)
+WERROR _winreg_OpenHKDD(struct pipes_struct *p,
+ struct winreg_OpenHKDD *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKDD, r->in.access_mask);
}
_winreg_OpenHKPN
********************************************************************/
-WERROR _winreg_OpenHKPN(pipes_struct *p, struct winreg_OpenHKPN *r)
+WERROR _winreg_OpenHKPN(struct pipes_struct *p,
+ struct winreg_OpenHKPN *r)
{
return open_registry_key(p, r->out.handle, NULL, KEY_HKPN, r->in.access_mask);
}
_winreg_OpenKey
********************************************************************/
-WERROR _winreg_OpenKey(pipes_struct *p, struct winreg_OpenKey *r)
+WERROR _winreg_OpenKey(struct pipes_struct *p,
+ struct winreg_OpenKey *r)
{
struct registry_key *parent = find_regkey_by_hnd(p, r->in.parent_handle );
_winreg_QueryValue
********************************************************************/
-WERROR _winreg_QueryValue(pipes_struct *p, struct winreg_QueryValue *r)
+WERROR _winreg_QueryValue(struct pipes_struct *p,
+ struct winreg_QueryValue *r)
{
WERROR status = WERR_BADFILE;
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
prs_struct prs_hkpd;
- uint8_t *outbuf;
- uint32_t outbuf_size;
+ uint8_t *outbuf = NULL;
+ uint32_t outbuf_size = 0;
- DATA_BLOB val_blob;
bool free_buf = False;
bool free_prs = False;
return status;
}
- status = registry_push_value(p->mem_ctx, val, &val_blob);
- if (!W_ERROR_IS_OK(status)) {
- return status;
- }
-
- outbuf = val_blob.data;
- outbuf_size = val_blob.length;
+ outbuf = val->data.data;
+ outbuf_size = val->data.length;
*r->out.type = val->type;
}
_winreg_QueryInfoKey
****************************************************************************/
-WERROR _winreg_QueryInfoKey(pipes_struct *p, struct winreg_QueryInfoKey *r)
+WERROR _winreg_QueryInfoKey(struct pipes_struct *p,
+ struct winreg_QueryInfoKey *r)
{
WERROR status = WERR_OK;
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
_winreg_GetVersion
****************************************************************************/
-WERROR _winreg_GetVersion(pipes_struct *p, struct winreg_GetVersion *r)
+WERROR _winreg_GetVersion(struct pipes_struct *p,
+ struct winreg_GetVersion *r)
{
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
_winreg_EnumKey
****************************************************************************/
-WERROR _winreg_EnumKey(pipes_struct *p, struct winreg_EnumKey *r)
+WERROR _winreg_EnumKey(struct pipes_struct *p,
+ struct winreg_EnumKey *r)
{
- WERROR err;
+ WERROR err = WERR_OK;
struct registry_key *key = find_regkey_by_hnd( p, r->in.handle );
if ( !key )
_winreg_EnumValue
****************************************************************************/
-WERROR _winreg_EnumValue(pipes_struct *p, struct winreg_EnumValue *r)
+WERROR _winreg_EnumValue(struct pipes_struct *p,
+ struct winreg_EnumValue *r)
{
- WERROR err;
+ WERROR err = WERR_OK;
struct registry_key *key = find_regkey_by_hnd( p, r->in.handle );
- char *valname;
- struct registry_value *val;
- DATA_BLOB value_blob;
+ char *valname = NULL;
+ struct registry_value *val = NULL;
if ( !key )
return WERR_BADFID;
return err;
}
- err = registry_push_value(p->mem_ctx, val, &value_blob);
- if (!W_ERROR_IS_OK(err)) {
- return err;
- }
-
if (r->out.name != NULL) {
r->out.name->name = valname;
}
return WERR_INVALID_PARAM;
}
- if (value_blob.length > *r->out.size) {
+ if (val->data.length > *r->out.size) {
return WERR_MORE_DATA;
}
- memcpy( r->out.value, value_blob.data, value_blob.length );
+ memcpy( r->out.value, val->data.data, val->data.length );
}
if (r->out.length != NULL) {
- *r->out.length = value_blob.length;
+ *r->out.length = val->data.length;
}
if (r->out.size != NULL) {
- *r->out.size = value_blob.length;
+ *r->out.size = val->data.length;
}
return WERR_OK;
_winreg_InitiateSystemShutdown
********************************************************************/
-WERROR _winreg_InitiateSystemShutdown(pipes_struct *p, struct winreg_InitiateSystemShutdown *r)
+WERROR _winreg_InitiateSystemShutdown(struct pipes_struct *p,
+ struct winreg_InitiateSystemShutdown *r)
{
struct winreg_InitiateSystemShutdownEx s;
#define SHUTDOWN_F_STRING "-f"
-WERROR _winreg_InitiateSystemShutdownEx(pipes_struct *p, struct winreg_InitiateSystemShutdownEx *r)
+WERROR _winreg_InitiateSystemShutdownEx(struct pipes_struct *p,
+ struct winreg_InitiateSystemShutdownEx *r)
{
char *shutdown_script = NULL;
char *msg = NULL;
fstring str_reason;
fstring do_reboot;
fstring f;
- int ret;
- bool can_shutdown;
+ int ret = -1;
+ bool can_shutdown = false;
shutdown_script = talloc_strdup(p->mem_ctx, lp_shutdown_script());
if (!shutdown_script) {
return WERR_NOMEM;
}
- can_shutdown = user_has_privileges( p->server_info->ptok,
- &se_remote_shutdown );
+ can_shutdown = security_token_has_privilege(p->server_info->ptok, SEC_PRIV_REMOTE_SHUTDOWN);
/* IF someone has privs, run the shutdown script as root. OTHERWISE run it as not root
Take the error return from the script and provide it as the Windows return code. */
_winreg_AbortSystemShutdown
********************************************************************/
-WERROR _winreg_AbortSystemShutdown(pipes_struct *p, struct winreg_AbortSystemShutdown *r)
+WERROR _winreg_AbortSystemShutdown(struct pipes_struct *p,
+ struct winreg_AbortSystemShutdown *r)
{
- const char *abort_shutdown_script;
- int ret;
- bool can_shutdown;
-
- abort_shutdown_script = lp_abort_shutdown_script();
+ const char *abort_shutdown_script = lp_abort_shutdown_script();
+ int ret = -1;
+ bool can_shutdown = false;
if (!*abort_shutdown_script)
return WERR_ACCESS_DENIED;
- can_shutdown = user_has_privileges( p->server_info->ptok,
- &se_remote_shutdown );
+ can_shutdown = security_token_has_privilege(p->server_info->ptok, SEC_PRIV_REMOTE_SHUTDOWN);
/********** BEGIN SeRemoteShutdownPrivilege BLOCK **********/
char *p = NULL;
int num_services = lp_numservices();
int snum = -1;
- const char *share_path;
+ const char *share_path = NULL;
char *fname = *pp_fname;
/* convert to a unix path, stripping the C:\ along the way */
_winreg_RestoreKey
********************************************************************/
-WERROR _winreg_RestoreKey(pipes_struct *p, struct winreg_RestoreKey *r)
+WERROR _winreg_RestoreKey(struct pipes_struct *p,
+ struct winreg_RestoreKey *r)
{
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
char *fname = NULL;
- int snum;
+ int snum = -1;
if ( !regkey )
return WERR_BADFID;
/* user must posses SeRestorePrivilege for this this proceed */
- if ( !user_has_privileges( p->server_info->ptok, &se_restore ) )
+ if ( !security_token_has_privilege(p->server_info->ptok, SEC_PRIV_RESTORE)) {
return WERR_ACCESS_DENIED;
+ }
DEBUG(2,("_winreg_RestoreKey: Restoring [%s] from %s in share %s\n",
regkey->key->name, fname, lp_servicename(snum) ));
_winreg_SaveKey
********************************************************************/
-WERROR _winreg_SaveKey(pipes_struct *p, struct winreg_SaveKey *r)
+WERROR _winreg_SaveKey(struct pipes_struct *p,
+ struct winreg_SaveKey *r)
{
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
char *fname = NULL;
_winreg_SaveKeyEx
********************************************************************/
-WERROR _winreg_SaveKeyEx(pipes_struct *p, struct winreg_SaveKeyEx *r)
+WERROR _winreg_SaveKeyEx(struct pipes_struct *p,
+ struct winreg_SaveKeyEx *r)
{
/* fill in your code here if you think this call should
do anything */
_winreg_CreateKey
********************************************************************/
-WERROR _winreg_CreateKey( pipes_struct *p, struct winreg_CreateKey *r)
+WERROR _winreg_CreateKey(struct pipes_struct *p,
+ struct winreg_CreateKey *r)
{
struct registry_key *parent = find_regkey_by_hnd(p, r->in.handle);
- struct registry_key *new_key;
- WERROR result;
+ struct registry_key *new_key = NULL;
+ WERROR result = WERR_OK;
if ( !parent )
return WERR_BADFID;
_winreg_SetValue
********************************************************************/
-WERROR _winreg_SetValue(pipes_struct *p, struct winreg_SetValue *r)
+WERROR _winreg_SetValue(struct pipes_struct *p,
+ struct winreg_SetValue *r)
{
struct registry_key *key = find_regkey_by_hnd(p, r->in.handle);
- struct registry_value *val;
- WERROR status;
+ struct registry_value *val = NULL;
if ( !key )
return WERR_BADFID;
DEBUG(8,("_winreg_SetValue: Setting value for [%s:%s]\n",
key->key->name, r->in.name.name));
- status = registry_pull_value(p->mem_ctx, &val, r->in.type, r->in.data,
- r->in.size, r->in.size);
- if (!W_ERROR_IS_OK(status)) {
- return status;
+ val = talloc_zero(p->mem_ctx, struct registry_value);
+ if (val == NULL) {
+ return WERR_NOMEM;
}
+ val->type = r->in.type;
+ val->data = data_blob_talloc(p->mem_ctx, r->in.data, r->in.size);
+
return reg_setvalue(key, r->in.name.name, val);
}
_winreg_DeleteKey
********************************************************************/
-WERROR _winreg_DeleteKey(pipes_struct *p, struct winreg_DeleteKey *r)
+WERROR _winreg_DeleteKey(struct pipes_struct *p,
+ struct winreg_DeleteKey *r)
{
struct registry_key *parent = find_regkey_by_hnd(p, r->in.handle);
_winreg_DeleteValue
********************************************************************/
-WERROR _winreg_DeleteValue(pipes_struct *p, struct winreg_DeleteValue *r)
+WERROR _winreg_DeleteValue(struct pipes_struct *p,
+ struct winreg_DeleteValue *r)
{
struct registry_key *key = find_regkey_by_hnd(p, r->in.handle);
_winreg_GetKeySecurity
********************************************************************/
-WERROR _winreg_GetKeySecurity(pipes_struct *p, struct winreg_GetKeySecurity *r)
+WERROR _winreg_GetKeySecurity(struct pipes_struct *p,
+ struct winreg_GetKeySecurity *r)
{
struct registry_key *key = find_regkey_by_hnd(p, r->in.handle);
- WERROR err;
- struct security_descriptor *secdesc;
- uint8 *data;
- size_t len;
+ WERROR err = WERR_OK;
+ struct security_descriptor *secdesc = NULL;
+ uint8 *data = NULL;
+ size_t len = 0;
if ( !key )
return WERR_BADFID;
_winreg_SetKeySecurity
********************************************************************/
-WERROR _winreg_SetKeySecurity(pipes_struct *p, struct winreg_SetKeySecurity *r)
+WERROR _winreg_SetKeySecurity(struct pipes_struct *p,
+ struct winreg_SetKeySecurity *r)
{
struct registry_key *key = find_regkey_by_hnd(p, r->in.handle);
- struct security_descriptor *secdesc;
- WERROR err;
+ struct security_descriptor *secdesc = NULL;
+ WERROR err = WERR_OK;
if ( !key )
return WERR_BADFID;
_winreg_FlushKey
********************************************************************/
-WERROR _winreg_FlushKey(pipes_struct *p, struct winreg_FlushKey *r)
+WERROR _winreg_FlushKey(struct pipes_struct *p,
+ struct winreg_FlushKey *r)
{
/* I'm just replying OK because there's not a lot
here I see to do i --jerry */
_winreg_UnLoadKey
********************************************************************/
-WERROR _winreg_UnLoadKey(pipes_struct *p, struct winreg_UnLoadKey *r)
+WERROR _winreg_UnLoadKey(struct pipes_struct *p,
+ struct winreg_UnLoadKey *r)
{
/* fill in your code here if you think this call should
do anything */
_winreg_ReplaceKey
********************************************************************/
-WERROR _winreg_ReplaceKey(pipes_struct *p, struct winreg_ReplaceKey *r)
+WERROR _winreg_ReplaceKey(struct pipes_struct *p,
+ struct winreg_ReplaceKey *r)
{
/* fill in your code here if you think this call should
do anything */
_winreg_LoadKey
********************************************************************/
-WERROR _winreg_LoadKey(pipes_struct *p, struct winreg_LoadKey *r)
+WERROR _winreg_LoadKey(struct pipes_struct *p,
+ struct winreg_LoadKey *r)
{
/* fill in your code here if you think this call should
do anything */
_winreg_NotifyChangeKeyValue
********************************************************************/
-WERROR _winreg_NotifyChangeKeyValue(pipes_struct *p, struct winreg_NotifyChangeKeyValue *r)
+WERROR _winreg_NotifyChangeKeyValue(struct pipes_struct *p,
+ struct winreg_NotifyChangeKeyValue *r)
{
return WERR_NOT_SUPPORTED;
}
_winreg_QueryMultipleValues
********************************************************************/
-WERROR _winreg_QueryMultipleValues(pipes_struct *p, struct winreg_QueryMultipleValues *r)
+WERROR _winreg_QueryMultipleValues(struct pipes_struct *p,
+ struct winreg_QueryMultipleValues *r)
{
- /* fill in your code here if you think this call should
- do anything */
-
- p->rng_fault_state = True;
- return WERR_NOT_SUPPORTED;
+ struct winreg_QueryMultipleValues2 r2;
+ uint32_t needed = 0;
+
+ r2.in.key_handle = r->in.key_handle;
+ r2.in.values_in = r->in.values_in;
+ r2.in.num_values = r->in.num_values;
+ r2.in.offered = r->in.buffer_size;
+ r2.in.buffer = r->in.buffer;
+ r2.out.values_out = r->out.values_out;
+ r2.out.needed = &needed;
+ r2.out.buffer = r->out.buffer;
+
+ return _winreg_QueryMultipleValues2(p, &r2);
}
/*******************************************************************
_winreg_QueryMultipleValues2
********************************************************************/
-WERROR _winreg_QueryMultipleValues2(pipes_struct *p,
+WERROR _winreg_QueryMultipleValues2(struct pipes_struct *p,
struct winreg_QueryMultipleValues2 *r)
{
struct registry_key *regkey = find_regkey_by_hnd(p, r->in.key_handle);
struct registry_value *vals = NULL;
const char **names = NULL;
uint32_t offset = 0, num_vals = 0;
- DATA_BLOB result;
- int i;
- WERROR err;
+ DATA_BLOB result = data_blob_null;
+ int i = 0;
+ WERROR err = WERR_OK;
if (!regkey) {
return WERR_BADFID;
for (i=0; i < r->in.num_values; i++) {
const char *valuename = NULL;
- DATA_BLOB blob = data_blob_null;
-
- if (vals[i].type != REG_NONE) {
- err = registry_push_value(p->mem_ctx, &vals[i], &blob);
- if (!W_ERROR_IS_OK(err)) {
- return err;
- }
+ if (vals[i].data.length > 0) {
if (!data_blob_append(p->mem_ctx, &result,
- blob.data, blob.length)) {
+ vals[i].data.data,
+ vals[i].data.length)) {
return WERR_NOMEM;
}
}
err = construct_multiple_entry(r->out.values_out,
valuename,
- blob.length,
+ vals[i].data.length,
offset,
vals[i].type,
&r->out.values_out[i]);
return err;
}
- offset += blob.length;
+ offset += vals[i].data.length;
}
*r->out.needed = result.length;
_winreg_DeleteKeyEx
********************************************************************/
-WERROR _winreg_DeleteKeyEx(pipes_struct *p, struct winreg_DeleteKeyEx *r)
+WERROR _winreg_DeleteKeyEx(struct pipes_struct *p,
+ struct winreg_DeleteKeyEx *r)
{
/* fill in your code here if you think this call should
do anything */