libndr: Avoid assigning duplicate versions to symbols
[amitay/samba.git] / source3 / printing / print_cups.c
index f96e8e17268c000dac4aee5e03fe43b721eea7c9..0bbd7c8eff38d3a44bb6b15bde5a56bf7f5ada23 100644 (file)
 #include "includes.h"
 #include "printing.h"
 #include "printing/pcap.h"
+#include "librpc/gen_ndr/ndr_printcap.h"
+#include "lib/util/sys_rw.h"
+#include "lib/util/string_wrappers.h"
 
 #ifdef HAVE_CUPS
 #include <cups/cups.h>
 #include <cups/language.h>
+#include <cups/http.h>
+
+/* CUPS prior to version 1.7 doesn't have HTTP_URI_STATUS_OK */
+#if (CUPS_VERSION_MAJOR == 1) && (CUPS_VERSION_MINOR < 7)
+#define HTTP_URI_STATUS_OK HTTP_URI_OK
+#endif
+
+#if (CUPS_VERSION_MAJOR > 1) || (CUPS_VERSION_MINOR > 5)
+#define HAVE_CUPS_1_6 1
+#endif
+
+#ifndef HAVE_CUPS_1_6
+#define ippGetGroupTag(attr)  attr->group_tag
+#define ippGetName(attr)      attr->name
+#define ippGetValueTag(attr)  attr->value_tag
+#define ippGetStatusCode(ipp) ipp->request.status.status_code
+#define ippGetInteger(attr, element) attr->values[element].integer
+#define ippGetString(attr, element, language) attr->values[element].string.text
+
+static ipp_attribute_t *
+ippFirstAttribute(ipp_t *ipp)
+{
+  if (!ipp)
+    return (NULL);
+  return (ipp->current = ipp->attrs);
+}
+
+static ipp_attribute_t *
+ippNextAttribute(ipp_t *ipp)
+{
+  if (!ipp || !ipp->current)
+    return (NULL);
+  return (ipp->current = ipp->current->next);
+}
+
+static int ippSetOperation(ipp_t *ipp, ipp_op_t op)
+{
+    ipp->request.op.operation_id = op;
+    return (1);
+}
+
+static int ippSetRequestId(ipp_t *ipp, int request_id)
+{
+    ipp->request.any.request_id = request_id;
+    return (1);
+}
+#endif
 
 static SIG_ATOMIC_T gotalarm;
 
@@ -59,14 +109,16 @@ cups_passwd_cb(const char *prompt) /* I - Prompt */
 
 static http_t *cups_connect(TALLOC_CTX *frame)
 {
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        http_t *http = NULL;
        char *server = NULL, *p = NULL;
        int port;
        int timeout = lp_cups_connection_timeout();
        size_t size;
 
-       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
-               if (!push_utf8_talloc(frame, &server, lp_cups_server(), &size)) {
+       if (lp_cups_server(talloc_tos(), lp_sub) != NULL && strlen(lp_cups_server(talloc_tos(), lp_sub)) > 0) {
+               if (!push_utf8_talloc(frame, &server, lp_cups_server(talloc_tos(), lp_sub), &size)) {
                        return NULL;
                }
        } else {
@@ -94,7 +146,18 @@ static http_t *cups_connect(TALLOC_CTX *frame)
                 alarm(timeout);
         }
 
-#ifdef HAVE_HTTPCONNECTENCRYPT
+#if defined(HAVE_HTTPCONNECT2)
+       http = httpConnect2(server,
+                           port,
+                           NULL,
+                           AF_UNSPEC,
+                           lp_cups_encrypt() ?
+                               HTTP_ENCRYPTION_ALWAYS :
+                               HTTP_ENCRYPTION_IF_REQUESTED,
+                           1, /* blocking */
+                           30 * 1000, /* timeout */
+                           NULL);
+#elif defined(HAVE_HTTPCONNECTENCRYPT)
        http = httpConnectEncrypt(server, port, lp_cups_encrypt());
 #else
        http = httpConnect(server, port);
@@ -105,67 +168,173 @@ static http_t *cups_connect(TALLOC_CTX *frame)
         alarm(0);
 
        if (http == NULL) {
-               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n",
+               DEBUG(3,("Unable to connect to CUPS server %s:%d - %s\n",
                         server, port, strerror(errno)));
        }
 
        return http;
 }
 
-static void send_pcap_info(const char *name, const char *info, void *pd)
+static bool send_pcap_blob(DATA_BLOB *pcap_blob, int fd)
 {
-       int fd = *(int *)pd;
-       size_t namelen = name ? strlen(name)+1 : 0;
-       size_t infolen = info ? strlen(info)+1 : 0;
-
-       DEBUG(11,("send_pcap_info: writing namelen %u\n", (unsigned int)namelen));
-       if (sys_write(fd, &namelen, sizeof(namelen)) != sizeof(namelen)) {
-               DEBUG(10,("send_pcap_info: namelen write failed %s\n",
-                       strerror(errno)));
-               return;
-       }
-       DEBUG(11,("send_pcap_info: writing infolen %u\n", (unsigned int)infolen));
-       if (sys_write(fd, &infolen, sizeof(infolen)) != sizeof(infolen)) {
-               DEBUG(10,("send_pcap_info: infolen write failed %s\n",
-                       strerror(errno)));
-               return;
-       }
-       if (namelen) {
-               DEBUG(11,("send_pcap_info: writing name %s\n", name));
-               if (sys_write(fd, name, namelen) != namelen) {
-                       DEBUG(10,("send_pcap_info: name write failed %s\n",
-                               strerror(errno)));
-                       return;
-               }
+       size_t ret;
+
+       ret = sys_write(fd, &pcap_blob->length, sizeof(pcap_blob->length));
+       if (ret != sizeof(pcap_blob->length)) {
+               return false;
+       }
+
+       ret = sys_write(fd, pcap_blob->data, pcap_blob->length);
+       if (ret != pcap_blob->length) {
+               return false;
+       }
+
+       DEBUG(10, ("successfully sent blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool recv_pcap_blob(TALLOC_CTX *mem_ctx, int fd, DATA_BLOB *pcap_blob)
+{
+       size_t blob_len;
+       size_t ret;
+
+       ret = sys_read(fd, &blob_len, sizeof(blob_len));
+       if (ret != sizeof(blob_len)) {
+               return false;
+       }
+
+       *pcap_blob = data_blob_talloc_named(mem_ctx, NULL, blob_len,
+                                          "cups pcap");
+       if (pcap_blob->length != blob_len) {
+               return false;
        }
-       if (infolen) {
-               DEBUG(11,("send_pcap_info: writing info %s\n", info));
-               if (sys_write(fd, info, infolen) != infolen) {
-                       DEBUG(10,("send_pcap_info: info write failed %s\n",
-                               strerror(errno)));
-                       return;
+       ret = sys_read(fd, pcap_blob->data, blob_len);
+       if (ret != blob_len) {
+               talloc_free(pcap_blob->data);
+               return false;
+       }
+
+       DEBUG(10, ("successfully recvd blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool process_cups_printers_response(TALLOC_CTX *mem_ctx,
+                                          ipp_t *response,
+                                          struct pcap_data *pcap_data)
+{
+       ipp_attribute_t *attr;
+       char *name;
+       char *info;
+       char *location = NULL;
+       struct pcap_printer *printer;
+       bool ret_ok = false;
+
+       for (attr = ippFirstAttribute(response); attr != NULL;) {
+              /*
+               * Skip leading attributes until we hit a printer...
+               */
+
+               while (attr != NULL && ippGetGroupTag(attr) != IPP_TAG_PRINTER)
+                       attr = ippNextAttribute(response);
+
+               if (attr == NULL)
+                       break;
+
+              /*
+               * Pull the needed attributes from this printer...
+               */
+
+               name       = NULL;
+               info       = NULL;
+
+               while (attr != NULL && ippGetGroupTag(attr) == IPP_TAG_PRINTER) {
+                       size_t size;
+                       if (strcmp(ippGetName(attr), "printer-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &name,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(ippGetName(attr), "printer-info") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &info,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(ippGetName(attr), "printer-location") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &location,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       attr = ippNextAttribute(response);
                }
+
+              /*
+               * See if we have everything needed...
+               */
+
+               if (name == NULL)
+                       break;
+
+               if (pcap_data->count == 0) {
+                       printer = talloc_array(mem_ctx, struct pcap_printer, 1);
+               } else {
+                       printer = talloc_realloc(mem_ctx, pcap_data->printers,
+                                                struct pcap_printer,
+                                                pcap_data->count + 1);
+               }
+               if (printer == NULL) {
+                       goto err_out;
+               }
+               pcap_data->printers = printer;
+               pcap_data->printers[pcap_data->count].name = name;
+               pcap_data->printers[pcap_data->count].info = info;
+               pcap_data->printers[pcap_data->count].location = location;
+               pcap_data->count++;
        }
+
+       ret_ok = true;
+err_out:
+       return ret_ok;
 }
 
+/*
+ * request printer list from cups, send result back to up parent via fd.
+ * returns true if the (possibly failed) result was successfully sent to parent.
+ */
 static bool cups_cache_reload_async(int fd)
 {
        TALLOC_CTX *frame = talloc_stackframe();
-       struct pcap_cache *tmp_pcap_cache = NULL;
+       struct pcap_data pcap_data;
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            *name,          /* printer-name attribute */
-                       *info;          /* printer-info attribute */
        static const char *requested[] =/* Requested attributes */
                        {
                          "printer-name",
-                         "printer-info"
+                         "printer-info",
+                         "printer-location"
                        };
        bool ret = False;
-       size_t size;
+       enum ndr_err_code ndr_ret;
+       DATA_BLOB pcap_blob;
+
+       ZERO_STRUCT(pcap_data);
+       pcap_data.status = NT_STATUS_UNSUCCESSFUL;
 
        DEBUG(5, ("reloading cups printcap cache\n"));
 
@@ -175,10 +344,6 @@ static bool cups_cache_reload_async(int fd)
 
         cupsSetPasswordCB(cups_passwd_cb);
 
-       /*
-       * Try to connect to the server...
-       */
-
        if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
@@ -194,8 +359,8 @@ static bool cups_cache_reload_async(int fd)
 
        request = ippNew();
 
-       request->request.op.operation_id = CUPS_GET_PRINTERS;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, CUPS_GET_PRINTERS);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -210,68 +375,16 @@ static bool cups_cache_reload_async(int fd)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-              /*
-               * Pull the needed attributes from this printer...
-               */
-
-               name       = NULL;
-               info       = NULL;
-
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME) {
-                               if (!pull_utf8_talloc(frame,
-                                               &name,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                       }
-
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT) {
-                               if (!pull_utf8_talloc(frame,
-                                               &info,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                       }
-
-                       attr = attr->next;
-               }
-
-              /*
-               * See if we have everything needed...
-               */
-
-               if (name == NULL)
-                       break;
-
-               if (!pcap_cache_add_specific(&tmp_pcap_cache, name, info)) {
-                       goto out;
-               }
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
        }
 
        ippDelete(response);
@@ -288,8 +401,8 @@ static bool cups_cache_reload_async(int fd)
 
        request = ippNew();
 
-       request->request.op.operation_id = CUPS_GET_CLASSES;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, CUPS_GET_CLASSES);
+       ippSetRequestId(request, 1);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
                      "attributes-charset", NULL, "utf-8");
@@ -302,72 +415,19 @@ static bool cups_cache_reload_async(int fd)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-              /*
-               * Pull the needed attributes from this printer...
-               */
-
-               name       = NULL;
-               info       = NULL;
-
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME) {
-                               if (!pull_utf8_talloc(frame,
-                                               &name,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                       }
-
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT) {
-                               if (!pull_utf8_talloc(frame,
-                                               &info,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                       }
-
-                       attr = attr->next;
-               }
-
-              /*
-               * See if we have everything needed...
-               */
-
-               if (name == NULL)
-                       break;
-
-               if (!pcap_cache_add_specific(&tmp_pcap_cache, name, info)) {
-                       goto out;
-               }
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
        }
 
-       ret = True;
-
+       pcap_data.status = NT_STATUS_OK;
  out:
        if (response)
                ippDelete(response);
@@ -378,20 +438,18 @@ static bool cups_cache_reload_async(int fd)
        if (http)
                httpClose(http);
 
-       /* Send all the entries up the pipe. */
-       if (tmp_pcap_cache) {
-               pcap_printer_fn_specific(tmp_pcap_cache,
-                               send_pcap_info,
-                               (void *)&fd);
-
-               pcap_cache_destroy_specific(&tmp_pcap_cache);
+       ret = false;
+       ndr_ret = ndr_push_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_push_flags_fn_t)ndr_push_pcap_data);
+       if (ndr_ret == NDR_ERR_SUCCESS) {
+               ret = send_pcap_blob(&pcap_blob, fd);
        }
+
        TALLOC_FREE(frame);
        return ret;
 }
 
-static struct pcap_cache *local_pcap_copy;
-struct fd_event *cache_fd_event;
+static struct tevent_fd *cache_fd_event;
 
 static bool cups_pcap_load_async(struct tevent_context *ev,
                                 struct messaging_context *msg_ctx,
@@ -415,7 +473,7 @@ static bool cups_pcap_load_async(struct tevent_context *ev,
                return false;
        }
 
-       pid = sys_fork();
+       pid = fork();
        if (pid == (pid_t)-1) {
                DEBUG(10,("cups_pcap_load_async: fork failed %s\n",
                        strerror(errno) ));
@@ -437,7 +495,7 @@ static bool cups_pcap_load_async(struct tevent_context *ev,
 
        close_all_print_db();
 
-       status = reinit_after_fork(msg_ctx, ev, procid_self(), true);
+       status = reinit_after_fork(msg_ctx, ev, true, NULL);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("cups_pcap_load_async: reinit_after_fork() failed\n"));
                smb_panic("cups_pcap_load_async: reinit_after_fork() failed");
@@ -446,166 +504,121 @@ static bool cups_pcap_load_async(struct tevent_context *ev,
        close(fds[0]);
        cups_cache_reload_async(fds[1]);
        close(fds[1]);
+       TALLOC_FREE(msg_ctx);
        _exit(0);
 }
 
-static void cups_async_callback(struct event_context *event_ctx,
-                               struct fd_event *event,
-                               uint16 flags,
+struct cups_async_cb_args {
+       int pipe_fd;
+       struct tevent_context *event_ctx;
+       struct messaging_context *msg_ctx;
+       void (*post_cache_fill_fn)(struct tevent_context *,
+                                  struct messaging_context *);
+};
+
+static void cups_async_callback(struct tevent_context *event_ctx,
+                               struct tevent_fd *event,
+                               uint16_t flags,
                                void *p)
 {
        TALLOC_CTX *frame = talloc_stackframe();
-       int fd = *(int *)p;
+       struct cups_async_cb_args *cb_args = (struct cups_async_cb_args *)p;
        struct pcap_cache *tmp_pcap_cache = NULL;
+       bool ret_ok;
+       struct pcap_data pcap_data;
+       DATA_BLOB pcap_blob;
+       enum ndr_err_code ndr_ret;
+       uint32_t i;
 
        DEBUG(5,("cups_async_callback: callback received for printer data. "
-               "fd = %d\n", fd));
-
-       while (1) {
-               char *name = NULL, *info = NULL;
-               size_t namelen = 0, infolen = 0;
-               ssize_t ret = -1;
-
-               ret = sys_read(fd, &namelen, sizeof(namelen));
-               if (ret == 0) {
-                       /* EOF */
-                       break;
-               }
-               if (ret != sizeof(namelen)) {
-                       DEBUG(10,("cups_async_callback: namelen read failed %d %s\n",
-                               errno, strerror(errno)));
-                       break;
-               }
+               "fd = %d\n", cb_args->pipe_fd));
 
-               DEBUG(11,("cups_async_callback: read namelen %u\n",
-                       (unsigned int)namelen));
+       ret_ok = recv_pcap_blob(frame, cb_args->pipe_fd, &pcap_blob);
+       if (!ret_ok) {
+               DEBUG(0,("failed to recv pcap blob\n"));
+               goto err_out;
+       }
 
-               ret = sys_read(fd, &infolen, sizeof(infolen));
-               if (ret == 0) {
-                       /* EOF */
-                       break;
-               }
-               if (ret != sizeof(infolen)) {
-                       DEBUG(10,("cups_async_callback: infolen read failed %s\n",
-                               strerror(errno)));
-                       break;
-               }
+       ndr_ret = ndr_pull_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_pull_flags_fn_t)ndr_pull_pcap_data);
+       if (ndr_ret != NDR_ERR_SUCCESS) {
+               goto err_out;
+       }
 
-               DEBUG(11,("cups_async_callback: read infolen %u\n",
-                       (unsigned int)infolen));
+       if (!NT_STATUS_IS_OK(pcap_data.status)) {
+               DEBUG(3,("failed to retrieve printer list: %s\n",
+                        nt_errstr(pcap_data.status)));
+               goto err_out;
+       }
 
-               if (namelen) {
-                       name = TALLOC_ARRAY(frame, char, namelen);
-                       if (!name) {
-                               break;
-                       }
-                       ret = sys_read(fd, name, namelen);
-                       if (ret == 0) {
-                               /* EOF */
-                               break;
-                       }
-                       if (ret != namelen) {
-                               DEBUG(10,("cups_async_callback: name read failed %s\n",
-                                       strerror(errno)));
-                               break;
-                       }
-                       DEBUG(11,("cups_async_callback: read name %s\n",
-                               name));
-               } else {
-                       name = NULL;
-               }
-               if (infolen) {
-                       info = TALLOC_ARRAY(frame, char, infolen);
-                       if (!info) {
-                               break;
-                       }
-                       ret = sys_read(fd, info, infolen);
-                       if (ret == 0) {
-                               /* EOF */
-                               break;
-                       }
-                       if (ret != infolen) {
-                               DEBUG(10,("cups_async_callback: info read failed %s\n",
-                                       strerror(errno)));
-                               break;
-                       }
-                       DEBUG(11,("cups_async_callback: read info %s\n",
-                               info));
-               } else {
-                       info = NULL;
+       for (i = 0; i < pcap_data.count; i++) {
+               ret_ok = pcap_cache_add_specific(&tmp_pcap_cache,
+                                                pcap_data.printers[i].name,
+                                                pcap_data.printers[i].info,
+                                                pcap_data.printers[i].location);
+               if (!ret_ok) {
+                       DEBUG(0, ("failed to add to tmp pcap cache\n"));
+                       goto err_out;
                }
-
-               /* Add to our local pcap cache. */
-               pcap_cache_add_specific(&tmp_pcap_cache, name, info);
-               TALLOC_FREE(name);
-               TALLOC_FREE(info);
        }
 
-       TALLOC_FREE(frame);
-       if (tmp_pcap_cache) {
-               /* We got a namelist, replace our local cache. */
-               pcap_cache_destroy_specific(&local_pcap_copy);
-               local_pcap_copy = tmp_pcap_cache;
-
-               /* And the systemwide pcap cache. */
-               pcap_cache_replace(local_pcap_copy);
-       } else {
-               DEBUG(2,("cups_async_callback: failed to read a new "
-                       "printer list\n"));
+       /* replace the system-wide pcap cache with a (possibly empty) new one */
+       ret_ok = pcap_cache_replace(tmp_pcap_cache);
+       if (!ret_ok) {
+               DEBUG(0, ("failed to replace pcap cache\n"));
+       } else if (cb_args->post_cache_fill_fn != NULL) {
+               /* Caller requested post cache fill callback */
+               cb_args->post_cache_fill_fn(cb_args->event_ctx,
+                                           cb_args->msg_ctx);
        }
-       close(fd);
-       TALLOC_FREE(p);
+err_out:
+       pcap_cache_destroy_specific(&tmp_pcap_cache);
+       TALLOC_FREE(frame);
        TALLOC_FREE(cache_fd_event);
+       close(cb_args->pipe_fd);
+       TALLOC_FREE(cb_args);
 }
 
 bool cups_cache_reload(struct tevent_context *ev,
-                      struct messaging_context *msg_ctx)
+                      struct messaging_context *msg_ctx,
+                      void (*post_cache_fill_fn)(struct tevent_context *,
+                                                 struct messaging_context *))
 {
-       int *p_pipe_fd = TALLOC_P(NULL, int);
+       struct cups_async_cb_args *cb_args;
+       int *p_pipe_fd;
 
-       if (!p_pipe_fd) {
+       cb_args = talloc(NULL, struct cups_async_cb_args);
+       if (cb_args == NULL) {
                return false;
        }
 
+       cb_args->post_cache_fill_fn = post_cache_fill_fn;
+       cb_args->event_ctx = ev;
+       cb_args->msg_ctx = msg_ctx;
+       p_pipe_fd = &cb_args->pipe_fd;
        *p_pipe_fd = -1;
 
        /* Set up an async refresh. */
        if (!cups_pcap_load_async(ev, msg_ctx, p_pipe_fd)) {
+               talloc_free(cb_args);
                return false;
        }
-       if (!local_pcap_copy) {
-               /* We have no local cache, wait directly for
-                * async refresh to complete.
-                */
-               DEBUG(10,("cups_cache_reload: sync read on fd %d\n",
-                       *p_pipe_fd ));
-
-               cups_async_callback(ev, NULL,
-                                       EVENT_FD_READ,
-                                       (void *)p_pipe_fd);
-               if (!local_pcap_copy) {
-                       return false;
-               }
-       } else {
-               /* Replace the system cache with our
-                * local copy. */
-               pcap_cache_replace(local_pcap_copy);
-
-               DEBUG(10,("cups_cache_reload: async read on fd %d\n",
-                       *p_pipe_fd ));
-
-               /* Trigger an event when the pipe can be read. */
-               cache_fd_event = event_add_fd(ev,
-                                       NULL, *p_pipe_fd,
-                                       EVENT_FD_READ,
-                                       cups_async_callback,
-                                       (void *)p_pipe_fd);
-               if (!cache_fd_event) {
-                       close(*p_pipe_fd);
-                       TALLOC_FREE(p_pipe_fd);
-                       return false;
-               }
+
+       DEBUG(10,("cups_cache_reload: async read on fd %d\n",
+               *p_pipe_fd ));
+
+       /* Trigger an event when the pipe can be read. */
+       cache_fd_event = tevent_add_fd(ev,
+                               NULL, *p_pipe_fd,
+                               TEVENT_FD_READ,
+                               cups_async_callback,
+                               (void *)cb_args);
+       if (!cache_fd_event) {
+               close(*p_pipe_fd);
+               TALLOC_FREE(cb_args);
+               return false;
        }
+
        return true;
 }
 
@@ -622,7 +635,8 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
        char *user = NULL;
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        size_t size;
 
        DEBUG(5,("cups_job_delete(%s, %p (%d))\n", sharename, pjob, pjob->sysjob));
@@ -653,8 +667,8 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_CANCEL_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_CANCEL_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -664,7 +678,18 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
@@ -680,7 +705,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -719,7 +744,8 @@ static int cups_job_pause(int snum, struct printjob *pjob)
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
        char *user = NULL;
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        size_t size;
 
        DEBUG(5,("cups_job_pause(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
@@ -750,8 +776,8 @@ static int cups_job_pause(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_HOLD_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_HOLD_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -761,7 +787,18 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
@@ -776,7 +813,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -815,7 +852,8 @@ static int cups_job_resume(int snum, struct printjob *pjob)
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
        char *user = NULL;
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        size_t size;
 
        DEBUG(5,("cups_job_resume(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
@@ -846,8 +884,8 @@ static int cups_job_resume(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_RELEASE_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_RELEASE_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -857,7 +895,18 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
@@ -872,7 +921,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -902,17 +951,21 @@ static int cups_job_resume(int snum, struct printjob *pjob)
  * 'cups_job_submit()' - Submit a job for printing.
  */
 
-static int cups_job_submit(int snum, struct printjob *pjob)
+static int cups_job_submit(int snum, struct printjob *pjob,
+                          enum printing_types printing_type,
+                          char *lpq_cmd)
 {
        TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        ipp_attribute_t *attr_job_id = NULL;    /* IPP Attribute "job-id" */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-       const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        char *new_jobname = NULL;
        int             num_options = 0;
        cups_option_t   *options = NULL;
@@ -922,8 +975,6 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        char *cupsoptions = NULL;
        char *filename = NULL;
        size_t size;
-       uint32_t jobid = (uint32_t)-1;
-       char addr[INET6_ADDRSTRLEN];
 
        DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
 
@@ -954,8 +1005,8 @@ static int cups_job_submit(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_PRINT_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_PRINT_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -965,12 +1016,23 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+       if (!push_utf8_talloc(frame, &printername,
+                             lp_printername(talloc_tos(), lp_sub, snum),
                              &size)) {
                goto out;
        }
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                printername);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
                     "printer-uri", NULL, uri);
@@ -981,30 +1043,16 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
                     NULL, user);
 
-       clientname = client_name(get_client_fd());
-       if (strcmp(clientname, "UNKNOWN") == 0) {
-               clientname = client_addr(get_client_fd(),addr,sizeof(addr));
-       }
-
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                     "job-originating-host-name", NULL,
-                     clientname);
-
-       /* Get the jobid from the filename. */
-       jobid = print_parse_jobid(pjob->filename);
-       if (jobid == (uint32_t)-1) {
-               DEBUG(0,("cups_job_submit: failed to parse jobid from name %s\n",
-                               pjob->filename ));
-               jobid = 0;
-       }
+                    pjob->clientmachine);
 
        if (!push_utf8_talloc(frame, &jobname, pjob->jobname, &size)) {
                goto out;
        }
        new_jobname = talloc_asprintf(frame,
                        "%s%.8u %s", PRINT_SPOOL_PREFIX,
-                       (unsigned int)jobid,
-                       jobname);
+                       pjob->jobid, jobname);
        if (new_jobname == NULL) {
                goto out;
        }
@@ -1016,7 +1064,8 @@ static int cups_job_submit(int snum, struct printjob *pjob)
         * add any options defined in smb.conf
         */
 
-       if (!push_utf8_talloc(frame, &cupsoptions, lp_cups_options(snum), &size)) {
+       if (!push_utf8_talloc(frame, &cupsoptions,
+                             lp_cups_options(talloc_tos(), lp_sub, snum), &size)) {
                goto out;
        }
        num_options = 0;
@@ -1030,21 +1079,32 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        * Do the request and get back a response...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "/printers/%s", printername);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        if (!push_utf8_talloc(frame, &filename, pjob->filename, &size)) {
                goto out;
        }
        if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to print file to %s - %s\n",
-                                lp_printername(snum),
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                 ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                        attr_job_id = ippFindAttribute(response, "job-id", IPP_TAG_INTEGER);
                        if(attr_job_id) {
-                               pjob->sysjob = attr_job_id->values[0].integer;
+                               pjob->sysjob = ippGetInteger(attr_job_id, 0);
                                DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
                        } else {
                                DEBUG(0,("Missing job-id attribute in IPP response"));
@@ -1052,7 +1112,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
                }
        } else {
                DEBUG(0,("Unable to print file to `%s' - %s\n",
-                        lp_printername(snum),
+                        lp_printername(talloc_tos(), lp_sub, snum),
                         ippErrorString(cupsLastError())));
        }
 
@@ -1092,7 +1152,8 @@ static int cups_queue_get(const char *sharename,
                        *response = NULL;       /* IPP Response */
        ipp_attribute_t *attr = NULL;           /* Current attribute */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        int             qcount = 0,             /* Number of active queue entries */
                        qalloc = 0;             /* Number of queue entries allocated */
        print_queue_struct *queue = NULL,       /* Queue entries */
@@ -1152,7 +1213,18 @@ static int cups_queue_get(const char *sharename,
         * Generate the printer URI...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", printername);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        /*
        * Build an IPP_GET_JOBS request, which requires the following
@@ -1166,8 +1238,8 @@ static int cups_queue_get(const char *sharename,
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_JOBS;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_GET_JOBS);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -1177,7 +1249,7 @@ static int cups_queue_get(const char *sharename,
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
 
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
                      "requested-attributes",
                      (sizeof(jattrs) / sizeof(jattrs[0])),
                      NULL, jattrs);
@@ -1195,9 +1267,9 @@ static int cups_queue_get(const char *sharename,
                goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+       if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
-                        ippErrorString(response->request.status.status_code)));
+                        ippErrorString(ippGetStatusCode(response))));
                goto out;
        }
 
@@ -1209,13 +1281,13 @@ static int cups_queue_get(const char *sharename,
        qalloc = 0;
        queue  = NULL;
 
-        for (attr = response->attrs; attr != NULL; attr = attr->next) {
+        for (attr = ippFirstAttribute(response); attr != NULL; attr = ippNextAttribute(response)) {
               /*
                * Skip leading attributes until we hit a job...
                */
 
-               while (attr != NULL && attr->group_tag != IPP_TAG_JOB)
-                       attr = attr->next;
+               while (attr != NULL && ippGetGroupTag(attr) != IPP_TAG_JOB)
+                       attr = ippNextAttribute(response);
 
                if (attr == NULL)
                        break;
@@ -1250,53 +1322,53 @@ static int cups_queue_get(const char *sharename,
                user_name    = NULL;
                job_name     = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_JOB) {
-                       if (attr->name == NULL) {
-                               attr = attr->next;
+               while (attr != NULL && ippGetGroupTag(attr) == IPP_TAG_JOB) {
+                       if (ippGetName(attr) == NULL) {
+                               attr = ippNextAttribute(response);
                                break;
                        }
 
-                       if (strcmp(attr->name, "job-id") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_id = attr->values[0].integer;
+                       if (strcmp(ippGetName(attr), "job-id") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_id = ippGetInteger(attr, 0);
 
-                       if (strcmp(attr->name, "job-k-octets") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_k_octets = attr->values[0].integer;
+                       if (strcmp(ippGetName(attr), "job-k-octets") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_k_octets = ippGetInteger(attr, 0);
 
-                       if (strcmp(attr->name, "job-priority") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_priority = attr->values[0].integer;
+                       if (strcmp(ippGetName(attr), "job-priority") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_priority = ippGetInteger(attr, 0);
 
-                       if (strcmp(attr->name, "job-state") == 0 &&
-                           attr->value_tag == IPP_TAG_ENUM)
-                               job_status = (ipp_jstate_t)(attr->values[0].integer);
+                       if (strcmp(ippGetName(attr), "job-state") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_ENUM)
+                               job_status = (ipp_jstate_t)ippGetInteger(attr, 0);
 
-                       if (strcmp(attr->name, "time-at-creation") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_time = attr->values[0].integer;
+                       if (strcmp(ippGetName(attr), "time-at-creation") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_time = ippGetInteger(attr, 0);
 
-                       if (strcmp(attr->name, "job-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME) {
+                       if (strcmp(ippGetName(attr), "job-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
                                if (!pull_utf8_talloc(frame,
                                                &job_name,
-                                               attr->values[0].string.text,
+                                               ippGetString(attr, 0, NULL),
                                                &size)) {
                                        goto out;
                                }
                        }
 
-                       if (strcmp(attr->name, "job-originating-user-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME) {
+                       if (strcmp(ippGetName(attr), "job-originating-user-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
                                if (!pull_utf8_talloc(frame,
                                                &user_name,
-                                               attr->values[0].string.text,
+                                               ippGetString(attr, 0, NULL),
                                                &size)) {
                                        goto out;
                                }
                        }
 
-                       attr = attr->next;
+                       attr = ippNextAttribute(response);
                }
 
               /*
@@ -1310,7 +1382,7 @@ static int cups_queue_get(const char *sharename,
                                continue;
                }
 
-               temp->job      = job_id;
+               temp->sysjob   = job_id;
                temp->size     = job_k_octets * 1024;
                temp->status   = job_status == IPP_JOB_PENDING ? LPQ_QUEUED :
                                 job_status == IPP_JOB_STOPPED ? LPQ_PAUSED :
@@ -1342,8 +1414,8 @@ static int cups_queue_get(const char *sharename,
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_GET_PRINTER_ATTRIBUTES);
+       ippSetRequestId(request, 1);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
                      "attributes-charset", NULL, "utf-8");
@@ -1369,9 +1441,9 @@ static int cups_queue_get(const char *sharename,
                goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+       if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
-                        ippErrorString(response->request.status.status_code)));
+                        ippErrorString(ippGetStatusCode(response))));
                goto out;
        }
 
@@ -1380,7 +1452,7 @@ static int cups_queue_get(const char *sharename,
        */
 
         if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL) {
-               if (attr->values[0].integer == IPP_PRINTER_STOPPED)
+               if (ippGetInteger(attr, 0) == IPP_PRINTER_STOPPED)
                        status->status = LPSTAT_STOPPED;
                else
                        status->status = LPSTAT_OK;
@@ -1390,7 +1462,7 @@ static int cups_queue_get(const char *sharename,
                                     IPP_TAG_TEXT)) != NULL) {
                char *msg = NULL;
                if (!pull_utf8_talloc(frame, &msg,
-                               attr->values[0].string.text,
+                               ippGetString(attr, 0, NULL),
                                &size)) {
                        SAFE_FREE(queue);
                        qcount = 0;
@@ -1428,6 +1500,8 @@ static int cups_queue_get(const char *sharename,
 static int cups_queue_pause(int snum)
 {
        TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
@@ -1435,7 +1509,8 @@ static int cups_queue_pause(int snum)
        cups_lang_t     *language = NULL;       /* Default language */
        char *printername = NULL;
        char *username = NULL;
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        size_t size;
 
        DEBUG(5,("cups_queue_pause(%d)\n", snum));
@@ -1466,8 +1541,8 @@ static int cups_queue_pause(int snum)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_PAUSE_PRINTER;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_PAUSE_PRINTER);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -1477,12 +1552,22 @@ static int cups_queue_pause(int snum)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
-                             &size)) {
+       if (!push_utf8_talloc(frame, &printername,
+                             lp_printername(talloc_tos(), lp_sub, snum), &size)) {
+               goto out;
+       }
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
                goto out;
        }
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
@@ -1497,16 +1582,16 @@ static int cups_queue_pause(int snum)
        */
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to pause printer %s - %s\n",
-                                lp_printername(snum),
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
                DEBUG(0,("Unable to pause printer %s - %s\n",
-                        lp_printername(snum),
+                        lp_printername(talloc_tos(), lp_sub, snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1532,6 +1617,8 @@ static int cups_queue_pause(int snum)
 static int cups_queue_resume(int snum)
 {
        TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
@@ -1539,7 +1626,8 @@ static int cups_queue_resume(int snum)
        cups_lang_t     *language = NULL;       /* Default language */
        char *printername = NULL;
        char *username = NULL;
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        size_t size;
 
        DEBUG(5,("cups_queue_resume(%d)\n", snum));
@@ -1570,8 +1658,8 @@ static int cups_queue_resume(int snum)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_RESUME_PRINTER;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_RESUME_PRINTER);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
@@ -1581,12 +1669,22 @@ static int cups_queue_resume(int snum)
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+       if (!push_utf8_talloc(frame, &printername, lp_printername(talloc_tos(), lp_sub, snum),
                              &size)) {
                goto out;
        }
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                printername);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
@@ -1601,16 +1699,16 @@ static int cups_queue_resume(int snum)
        */
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to resume printer %s - %s\n",
-                                lp_printername(snum),
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
                DEBUG(0,("Unable to resume printer %s - %s\n",
-                        lp_printername(snum),
+                        lp_printername(talloc_tos(), lp_sub, snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1644,178 +1742,6 @@ struct printif  cups_printif =
        cups_job_submit,
 };
 
-bool cups_pull_comment_location(TALLOC_CTX *mem_ctx,
-                               const char *printername,
-                               char **comment,
-                               char **location)
-{
-       TALLOC_CTX *frame = talloc_stackframe();
-       http_t          *http = NULL;           /* HTTP connection to server */
-       ipp_t           *request = NULL,        /* IPP Request */
-                       *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI];
-       char *server = NULL;
-       char *sharename = NULL;
-       char *name = NULL;
-       static const char *requested[] =/* Requested attributes */
-                       {
-                         "printer-name",
-                         "printer-info",
-                         "printer-location"
-                       };
-       bool ret = False;
-       size_t size;
-
-       DEBUG(5, ("pulling %s location\n", printername));
-
-       /*
-        * Make sure we don't ask for passwords...
-        */
-
-        cupsSetPasswordCB(cups_passwd_cb);
-
-       /*
-        * Try to connect to the server...
-        */
-
-       if ((http = cups_connect(frame)) == NULL) {
-               goto out;
-       }
-
-       request = ippNew();
-
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-       request->request.op.request_id   = 1;
-
-       language = cupsLangDefault();
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, "utf-8");
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
-                     "attributes-natural-language", NULL, language->language);
-
-       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
-               if (!push_utf8_talloc(frame, &server, lp_cups_server(), &size)) {
-                       goto out;
-               }
-       } else {
-               server = talloc_strdup(frame,cupsServer());
-       }
-       if (server) {
-               goto out;
-       }
-       if (!push_utf8_talloc(frame, &sharename, printername, &size)) {
-               goto out;
-       }
-       slprintf(uri, sizeof(uri) - 1, "ipp://%s/printers/%s",
-                server, sharename);
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
-
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                     "requested-attributes",
-                     (sizeof(requested) / sizeof(requested[0])),
-                     NULL, requested);
-
-       /*
-        * Do the request and get back a response...
-        */
-
-       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
-               DEBUG(0,("Unable to get printer attributes - %s\n",
-                        ippErrorString(cupsLastError())));
-               goto out;
-       }
-
-       for (attr = response->attrs; attr != NULL;) {
-               /*
-                * Skip leading attributes until we hit a printer...
-                */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-               /*
-                * Pull the needed attributes from this printer...
-                */
-
-               while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME) {
-                               if (!pull_utf8_talloc(frame,
-                                               &name,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                       }
-
-                       /* Grab the comment if we don't have one */
-                       if ( (strcmp(attr->name, "printer-info") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT))
-                       {
-                               if (!pull_utf8_talloc(mem_ctx,
-                                               comment,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                               DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
-                                        *comment));
-                       }
-
-                       /* Grab the location if we don't have one */
-                       if ( (strcmp(attr->name, "printer-location") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT))
-                       {
-                               if (!pull_utf8_talloc(mem_ctx,
-                                               location,
-                                               attr->values[0].string.text,
-                                               &size)) {
-                                       goto out;
-                               }
-                               DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
-                                        *location));
-                       }
-
-                       attr = attr->next;
-               }
-
-               /*
-                * We have everything needed...
-                */
-
-               if (name != NULL)
-                       break;
-       }
-
-       ret = True;
-
- out:
-       if (response)
-               ippDelete(response);
-
-       if (request) {
-               ippDelete(request);
-       }
-
-       if (language)
-               cupsLangFree(language);
-
-       if (http)
-               httpClose(http);
-
-       TALLOC_FREE(frame);
-       return ret;
-}
-
 #else
  /* this keeps fussy compilers happy */
  void print_cups_dummy(void);