libndr: Avoid assigning duplicate versions to symbols
[amitay/samba.git] / source3 / printing / print_cups.c
index 97584cbe058a5e350ab2d9c0861105faaf9377d9..0bbd7c8eff38d3a44bb6b15bde5a56bf7f5ada23 100644 (file)
@@ -2,6 +2,7 @@
  * Support code for the Common UNIX Printing System ("CUPS")
  *
  * Copyright 1999-2003 by Michael R Sweet.
+ * Copyright 2008 Jeremy Allison.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+/*
+ * JRA. Converted to utf8 pull/push.
+ */
+
 #include "includes.h"
 #include "printing.h"
+#include "printing/pcap.h"
+#include "librpc/gen_ndr/ndr_printcap.h"
+#include "lib/util/sys_rw.h"
+#include "lib/util/string_wrappers.h"
 
 #ifdef HAVE_CUPS
 #include <cups/cups.h>
 #include <cups/language.h>
+#include <cups/http.h>
+
+/* CUPS prior to version 1.7 doesn't have HTTP_URI_STATUS_OK */
+#if (CUPS_VERSION_MAJOR == 1) && (CUPS_VERSION_MINOR < 7)
+#define HTTP_URI_STATUS_OK HTTP_URI_OK
+#endif
+
+#if (CUPS_VERSION_MAJOR > 1) || (CUPS_VERSION_MINOR > 5)
+#define HAVE_CUPS_1_6 1
+#endif
+
+#ifndef HAVE_CUPS_1_6
+#define ippGetGroupTag(attr)  attr->group_tag
+#define ippGetName(attr)      attr->name
+#define ippGetValueTag(attr)  attr->value_tag
+#define ippGetStatusCode(ipp) ipp->request.status.status_code
+#define ippGetInteger(attr, element) attr->values[element].integer
+#define ippGetString(attr, element, language) attr->values[element].string.text
+
+static ipp_attribute_t *
+ippFirstAttribute(ipp_t *ipp)
+{
+  if (!ipp)
+    return (NULL);
+  return (ipp->current = ipp->attrs);
+}
+
+static ipp_attribute_t *
+ippNextAttribute(ipp_t *ipp)
+{
+  if (!ipp || !ipp->current)
+    return (NULL);
+  return (ipp->current = ipp->current->next);
+}
+
+static int ippSetOperation(ipp_t *ipp, ipp_op_t op)
+{
+    ipp->request.op.operation_id = op;
+    return (1);
+}
+
+static int ippSetRequestId(ipp_t *ipp, int request_id)
+{
+    ipp->request.any.request_id = request_id;
+    return (1);
+}
+#endif
 
 static SIG_ATOMIC_T gotalarm;
 
@@ -30,7 +86,7 @@ static SIG_ATOMIC_T gotalarm;
  Signal function to tell us we timed out.
 ****************************************************************/
 
-static void gotalarm_sig(void)
+static void gotalarm_sig(int signum)
 {
         gotalarm = 1;
 }
@@ -51,24 +107,25 @@ cups_passwd_cb(const char *prompt) /* I - Prompt */
        return (NULL);
 }
 
-static http_t *cups_connect(void)
+static http_t *cups_connect(TALLOC_CTX *frame)
 {
-       http_t *http;
-       char *server, *p;
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
+       http_t *http = NULL;
+       char *server = NULL, *p = NULL;
        int port;
        int timeout = lp_cups_connection_timeout();
+       size_t size;
 
-       gotalarm = 0;
-
-       if (timeout) {
-                CatchSignal(SIGALRM, SIGNAL_CAST gotalarm_sig);
-                alarm(timeout);
-        }
-
-       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
-               server = smb_xstrdup(lp_cups_server());
+       if (lp_cups_server(talloc_tos(), lp_sub) != NULL && strlen(lp_cups_server(talloc_tos(), lp_sub)) > 0) {
+               if (!push_utf8_talloc(frame, &server, lp_cups_server(talloc_tos(), lp_sub), &size)) {
+                       return NULL;
+               }
        } else {
-               server = smb_xstrdup(cupsServer());
+               server = talloc_strdup(frame,cupsServer());
+       }
+       if (!server) {
+               return NULL;
        }
 
        p = strchr(server, ':');
@@ -82,35 +139,202 @@ static http_t *cups_connect(void)
        DEBUG(10, ("connecting to cups server %s:%d\n",
                   server, port));
 
+       gotalarm = 0;
+
+       if (timeout) {
+                CatchSignal(SIGALRM, gotalarm_sig);
+                alarm(timeout);
+        }
+
+#if defined(HAVE_HTTPCONNECT2)
+       http = httpConnect2(server,
+                           port,
+                           NULL,
+                           AF_UNSPEC,
+                           lp_cups_encrypt() ?
+                               HTTP_ENCRYPTION_ALWAYS :
+                               HTTP_ENCRYPTION_IF_REQUESTED,
+                           1, /* blocking */
+                           30 * 1000, /* timeout */
+                           NULL);
+#elif defined(HAVE_HTTPCONNECTENCRYPT)
+       http = httpConnectEncrypt(server, port, lp_cups_encrypt());
+#else
        http = httpConnect(server, port);
+#endif
 
-       CatchSignal(SIGALRM, SIGNAL_CAST SIG_IGN);
+
+       CatchSignal(SIGALRM, SIG_IGN);
         alarm(0);
 
        if (http == NULL) {
-               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n",
+               DEBUG(3,("Unable to connect to CUPS server %s:%d - %s\n",
                         server, port, strerror(errno)));
        }
 
-       SAFE_FREE(server);
        return http;
 }
 
-bool cups_cache_reload(void)
+static bool send_pcap_blob(DATA_BLOB *pcap_blob, int fd)
+{
+       size_t ret;
+
+       ret = sys_write(fd, &pcap_blob->length, sizeof(pcap_blob->length));
+       if (ret != sizeof(pcap_blob->length)) {
+               return false;
+       }
+
+       ret = sys_write(fd, pcap_blob->data, pcap_blob->length);
+       if (ret != pcap_blob->length) {
+               return false;
+       }
+
+       DEBUG(10, ("successfully sent blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool recv_pcap_blob(TALLOC_CTX *mem_ctx, int fd, DATA_BLOB *pcap_blob)
 {
+       size_t blob_len;
+       size_t ret;
+
+       ret = sys_read(fd, &blob_len, sizeof(blob_len));
+       if (ret != sizeof(blob_len)) {
+               return false;
+       }
+
+       *pcap_blob = data_blob_talloc_named(mem_ctx, NULL, blob_len,
+                                          "cups pcap");
+       if (pcap_blob->length != blob_len) {
+               return false;
+       }
+       ret = sys_read(fd, pcap_blob->data, blob_len);
+       if (ret != blob_len) {
+               talloc_free(pcap_blob->data);
+               return false;
+       }
+
+       DEBUG(10, ("successfully recvd blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool process_cups_printers_response(TALLOC_CTX *mem_ctx,
+                                          ipp_t *response,
+                                          struct pcap_data *pcap_data)
+{
+       ipp_attribute_t *attr;
+       char *name;
+       char *info;
+       char *location = NULL;
+       struct pcap_printer *printer;
+       bool ret_ok = false;
+
+       for (attr = ippFirstAttribute(response); attr != NULL;) {
+              /*
+               * Skip leading attributes until we hit a printer...
+               */
+
+               while (attr != NULL && ippGetGroupTag(attr) != IPP_TAG_PRINTER)
+                       attr = ippNextAttribute(response);
+
+               if (attr == NULL)
+                       break;
+
+              /*
+               * Pull the needed attributes from this printer...
+               */
+
+               name       = NULL;
+               info       = NULL;
+
+               while (attr != NULL && ippGetGroupTag(attr) == IPP_TAG_PRINTER) {
+                       size_t size;
+                       if (strcmp(ippGetName(attr), "printer-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &name,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(ippGetName(attr), "printer-info") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &info,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(ippGetName(attr), "printer-location") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &location,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       attr = ippNextAttribute(response);
+               }
+
+              /*
+               * See if we have everything needed...
+               */
+
+               if (name == NULL)
+                       break;
+
+               if (pcap_data->count == 0) {
+                       printer = talloc_array(mem_ctx, struct pcap_printer, 1);
+               } else {
+                       printer = talloc_realloc(mem_ctx, pcap_data->printers,
+                                                struct pcap_printer,
+                                                pcap_data->count + 1);
+               }
+               if (printer == NULL) {
+                       goto err_out;
+               }
+               pcap_data->printers = printer;
+               pcap_data->printers[pcap_data->count].name = name;
+               pcap_data->printers[pcap_data->count].info = info;
+               pcap_data->printers[pcap_data->count].location = location;
+               pcap_data->count++;
+       }
+
+       ret_ok = true;
+err_out:
+       return ret_ok;
+}
+
+/*
+ * request printer list from cups, send result back to up parent via fd.
+ * returns true if the (possibly failed) result was successfully sent to parent.
+ */
+static bool cups_cache_reload_async(int fd)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct pcap_data pcap_data;
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            *name,          /* printer-name attribute */
-                       *info;          /* printer-info attribute */
        static const char *requested[] =/* Requested attributes */
                        {
                          "printer-name",
-                         "printer-info"
+                         "printer-info",
+                         "printer-location"
                        };
        bool ret = False;
+       enum ndr_err_code ndr_ret;
+       DATA_BLOB pcap_blob;
+
+       ZERO_STRUCT(pcap_data);
+       pcap_data.status = NT_STATUS_UNSUCCESSFUL;
 
        DEBUG(5, ("reloading cups printcap cache\n"));
 
@@ -120,11 +344,7 @@ bool cups_cache_reload(void)
 
         cupsSetPasswordCB(cups_passwd_cb);
 
-       /*
-       * Try to connect to the server...
-       */
-
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -139,13 +359,13 @@ bool cups_cache_reload(void)
 
        request = ippNew();
 
-       request->request.op.operation_id = CUPS_GET_PRINTERS;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, CUPS_GET_PRINTERS);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -155,56 +375,16 @@ bool cups_cache_reload(void)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-              /*
-               * Pull the needed attributes from this printer...
-               */
-
-               name       = NULL;
-               info       = NULL;
-
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               name = attr->values[0].string.text;
-
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               info = attr->values[0].string.text;
-
-                       attr = attr->next;
-               }
-
-              /*
-               * See if we have everything needed...
-               */
-
-               if (name == NULL)
-                       break;
-
-               if (!pcap_cache_add(name, info)) {
-                       goto out;
-               }
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
        }
 
        ippDelete(response);
@@ -221,11 +401,11 @@ bool cups_cache_reload(void)
 
        request = ippNew();
 
-       request->request.op.operation_id = CUPS_GET_CLASSES;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, CUPS_GET_CLASSES);
+       ippSetRequestId(request, 1);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -235,73 +415,212 @@ bool cups_cache_reload(void)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
+       }
 
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
+       pcap_data.status = NT_STATUS_OK;
+ out:
+       if (response)
+               ippDelete(response);
 
-               if (attr == NULL)
-                       break;
+       if (language)
+               cupsLangFree(language);
 
-              /*
-               * Pull the needed attributes from this printer...
-               */
+       if (http)
+               httpClose(http);
 
-               name       = NULL;
-               info       = NULL;
+       ret = false;
+       ndr_ret = ndr_push_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_push_flags_fn_t)ndr_push_pcap_data);
+       if (ndr_ret == NDR_ERR_SUCCESS) {
+               ret = send_pcap_blob(&pcap_blob, fd);
+       }
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               name = attr->values[0].string.text;
+       TALLOC_FREE(frame);
+       return ret;
+}
 
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               info = attr->values[0].string.text;
+static struct tevent_fd *cache_fd_event;
 
-                       attr = attr->next;
-               }
+static bool cups_pcap_load_async(struct tevent_context *ev,
+                                struct messaging_context *msg_ctx,
+                                int *pfd)
+{
+       int fds[2];
+       pid_t pid;
+       NTSTATUS status;
 
-              /*
-               * See if we have everything needed...
-               */
+       *pfd = -1;
 
-               if (name == NULL)
-                       break;
+       if (cache_fd_event) {
+               DEBUG(3,("cups_pcap_load_async: already waiting for "
+                       "a refresh event\n" ));
+               return false;
+       }
 
-               if (!pcap_cache_add(name, info)) {
-                       goto out;
-               }
+       DEBUG(5,("cups_pcap_load_async: asynchronously loading cups printers\n"));
+
+       if (pipe(fds) == -1) {
+               return false;
        }
 
-       ret = True;
+       pid = fork();
+       if (pid == (pid_t)-1) {
+               DEBUG(10,("cups_pcap_load_async: fork failed %s\n",
+                       strerror(errno) ));
+               close(fds[0]);
+               close(fds[1]);
+               return false;
+       }
 
- out:
-       if (response)
-               ippDelete(response);
+       if (pid) {
+               DEBUG(10,("cups_pcap_load_async: child pid = %u\n",
+                       (unsigned int)pid ));
+               /* Parent. */
+               close(fds[1]);
+               *pfd = fds[0];
+               return true;
+       }
 
-       if (language)
-               cupsLangFree(language);
+       /* Child. */
 
-       if (http)
-               httpClose(http);
+       close_all_print_db();
 
-       return ret;
+       status = reinit_after_fork(msg_ctx, ev, true, NULL);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,("cups_pcap_load_async: reinit_after_fork() failed\n"));
+               smb_panic("cups_pcap_load_async: reinit_after_fork() failed");
+       }
+
+       close(fds[0]);
+       cups_cache_reload_async(fds[1]);
+       close(fds[1]);
+       TALLOC_FREE(msg_ctx);
+       _exit(0);
 }
 
+struct cups_async_cb_args {
+       int pipe_fd;
+       struct tevent_context *event_ctx;
+       struct messaging_context *msg_ctx;
+       void (*post_cache_fill_fn)(struct tevent_context *,
+                                  struct messaging_context *);
+};
+
+static void cups_async_callback(struct tevent_context *event_ctx,
+                               struct tevent_fd *event,
+                               uint16_t flags,
+                               void *p)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct cups_async_cb_args *cb_args = (struct cups_async_cb_args *)p;
+       struct pcap_cache *tmp_pcap_cache = NULL;
+       bool ret_ok;
+       struct pcap_data pcap_data;
+       DATA_BLOB pcap_blob;
+       enum ndr_err_code ndr_ret;
+       uint32_t i;
+
+       DEBUG(5,("cups_async_callback: callback received for printer data. "
+               "fd = %d\n", cb_args->pipe_fd));
+
+       ret_ok = recv_pcap_blob(frame, cb_args->pipe_fd, &pcap_blob);
+       if (!ret_ok) {
+               DEBUG(0,("failed to recv pcap blob\n"));
+               goto err_out;
+       }
+
+       ndr_ret = ndr_pull_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_pull_flags_fn_t)ndr_pull_pcap_data);
+       if (ndr_ret != NDR_ERR_SUCCESS) {
+               goto err_out;
+       }
+
+       if (!NT_STATUS_IS_OK(pcap_data.status)) {
+               DEBUG(3,("failed to retrieve printer list: %s\n",
+                        nt_errstr(pcap_data.status)));
+               goto err_out;
+       }
+
+       for (i = 0; i < pcap_data.count; i++) {
+               ret_ok = pcap_cache_add_specific(&tmp_pcap_cache,
+                                                pcap_data.printers[i].name,
+                                                pcap_data.printers[i].info,
+                                                pcap_data.printers[i].location);
+               if (!ret_ok) {
+                       DEBUG(0, ("failed to add to tmp pcap cache\n"));
+                       goto err_out;
+               }
+       }
+
+       /* replace the system-wide pcap cache with a (possibly empty) new one */
+       ret_ok = pcap_cache_replace(tmp_pcap_cache);
+       if (!ret_ok) {
+               DEBUG(0, ("failed to replace pcap cache\n"));
+       } else if (cb_args->post_cache_fill_fn != NULL) {
+               /* Caller requested post cache fill callback */
+               cb_args->post_cache_fill_fn(cb_args->event_ctx,
+                                           cb_args->msg_ctx);
+       }
+err_out:
+       pcap_cache_destroy_specific(&tmp_pcap_cache);
+       TALLOC_FREE(frame);
+       TALLOC_FREE(cache_fd_event);
+       close(cb_args->pipe_fd);
+       TALLOC_FREE(cb_args);
+}
+
+bool cups_cache_reload(struct tevent_context *ev,
+                      struct messaging_context *msg_ctx,
+                      void (*post_cache_fill_fn)(struct tevent_context *,
+                                                 struct messaging_context *))
+{
+       struct cups_async_cb_args *cb_args;
+       int *p_pipe_fd;
+
+       cb_args = talloc(NULL, struct cups_async_cb_args);
+       if (cb_args == NULL) {
+               return false;
+       }
+
+       cb_args->post_cache_fill_fn = post_cache_fill_fn;
+       cb_args->event_ctx = ev;
+       cb_args->msg_ctx = msg_ctx;
+       p_pipe_fd = &cb_args->pipe_fd;
+       *p_pipe_fd = -1;
+
+       /* Set up an async refresh. */
+       if (!cups_pcap_load_async(ev, msg_ctx, p_pipe_fd)) {
+               talloc_free(cb_args);
+               return false;
+       }
+
+       DEBUG(10,("cups_cache_reload: async read on fd %d\n",
+               *p_pipe_fd ));
+
+       /* Trigger an event when the pipe can be read. */
+       cache_fd_event = tevent_add_fd(ev,
+                               NULL, *p_pipe_fd,
+                               TEVENT_FD_READ,
+                               cups_async_callback,
+                               (void *)cb_args);
+       if (!cache_fd_event) {
+               close(*p_pipe_fd);
+               TALLOC_FREE(cb_args);
+               return false;
+       }
+
+       return true;
+}
 
 /*
  * 'cups_job_delete()' - Delete a job.
@@ -309,13 +628,16 @@ bool cups_cache_reload(void)
 
 static int cups_job_delete(const char *sharename, const char *lprm_command, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       char *user = NULL;
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
+       size_t size;
 
        DEBUG(5,("cups_job_delete(%s, %p (%d))\n", sharename, pjob, pjob->sysjob));
 
@@ -329,7 +651,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -345,30 +667,45 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_CANCEL_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_CANCEL_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
+
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -389,6 +726,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -399,13 +737,16 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
 
 static int cups_job_pause(int snum, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       char *user = NULL;
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
+       size_t size;
 
        DEBUG(5,("cups_job_pause(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -419,7 +760,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -435,30 +776,44 @@ static int cups_job_pause(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_HOLD_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_HOLD_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -479,6 +834,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -489,13 +845,16 @@ static int cups_job_pause(int snum, struct printjob *pjob)
 
 static int cups_job_resume(int snum, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       char *user = NULL;
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
+       size_t size;
 
        DEBUG(5,("cups_job_resume(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -509,7 +868,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -525,30 +884,44 @@ static int cups_job_resume(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_RELEASE_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_RELEASE_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/jobs/%d", pjob->sysjob);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/jobs/%d",
+                                  pjob->sysjob);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
        if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
                                ippErrorString(cupsLastError())));
                } else {
@@ -569,6 +942,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -577,21 +951,32 @@ static int cups_job_resume(int snum, struct printjob *pjob)
  * 'cups_job_submit()' - Submit a job for printing.
  */
 
-static int cups_job_submit(int snum, struct printjob *pjob)
+static int cups_job_submit(int snum, struct printjob *pjob,
+                          enum printing_types printing_type,
+                          char *lpq_cmd)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr_job_id = NULL;    /* IPP Attribute "job-id" */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-       const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        char *new_jobname = NULL;
        int             num_options = 0;
        cups_option_t   *options = NULL;
-       char addr[INET6_ADDRSTRLEN];
+       char *printername = NULL;
+       char *user = NULL;
+       char *jobname = NULL;
+       char *cupsoptions = NULL;
+       char *filename = NULL;
+       size_t size;
 
-       DEBUG(5,("cups_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
+       DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
 
        /*
         * Make sure we don't ask for passwords...
@@ -603,7 +988,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -620,37 +1005,55 @@ static int cups_job_submit(int snum, struct printjob *pjob)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_PRINT_JOB;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_PRINT_JOB);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+       if (!push_utf8_talloc(frame, &printername,
+                             lp_printername(talloc_tos(), lp_sub, snum),
+                             &size)) {
+               goto out;
+       }
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
                     "printer-uri", NULL, uri);
 
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
-
-       clientname = client_name(get_client_fd());
-       if (strcmp(clientname, "UNKNOWN") == 0) {
-               clientname = client_addr(get_client_fd(),addr,sizeof(addr));
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
        }
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
+                    NULL, user);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                     "job-originating-host-name", NULL,
-                     clientname);
+                    pjob->clientmachine);
 
-       if (asprintf(&new_jobname,"%s%.8u %s", PRINT_SPOOL_PREFIX,
-                       (unsigned int)pjob->smbjob, pjob->jobname) < 0) {
+       if (!push_utf8_talloc(frame, &jobname, pjob->jobname, &size)) {
+               goto out;
+       }
+       new_jobname = talloc_asprintf(frame,
+                       "%s%.8u %s", PRINT_SPOOL_PREFIX,
+                       pjob->jobid, jobname);
+       if (new_jobname == NULL) {
                goto out;
        }
 
@@ -661,9 +1064,13 @@ static int cups_job_submit(int snum, struct printjob *pjob)
         * add any options defined in smb.conf
         */
 
+       if (!push_utf8_talloc(frame, &cupsoptions,
+                             lp_cups_options(talloc_tos(), lp_sub, snum), &size)) {
+               goto out;
+       }
        num_options = 0;
        options     = NULL;
-       num_options = cupsParseOptions(lp_cups_options(snum), num_options, &options);
+       num_options = cupsParseOptions(cupsoptions, num_options, &options);
 
        if ( num_options )
                cupsEncodeOptions(request, num_options, options);
@@ -672,17 +1079,40 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        * Do the request and get back a response...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "/printers/%s", PRINTERNAME(snum));
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
+       if (!push_utf8_talloc(frame, &filename, pjob->filename, &size)) {
+               goto out;
+       }
        if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to print file to %s - %s\n",
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                 ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
+                       attr_job_id = ippFindAttribute(response, "job-id", IPP_TAG_INTEGER);
+                       if(attr_job_id) {
+                               pjob->sysjob = ippGetInteger(attr_job_id, 0);
+                               DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
+                       } else {
+                               DEBUG(0,("Missing job-id attribute in IPP response"));
+                       }
                }
        } else {
-               DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to print file to `%s' - %s\n",
+                        lp_printername(talloc_tos(), lp_sub, snum),
                         ippErrorString(cupsLastError())));
        }
 
@@ -700,7 +1130,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
-       SAFE_FREE(new_jobname);
+       TALLOC_FREE(frame);
 
        return ret;
 }
@@ -715,24 +1145,27 @@ static int cups_queue_get(const char *sharename,
                print_queue_struct **q,
                print_status_struct *status)
 {
-       fstring         printername;
+       TALLOC_CTX *frame = talloc_stackframe();
+       char *printername = NULL;
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        ipp_attribute_t *attr = NULL;           /* Current attribute */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
        int             qcount = 0,             /* Number of active queue entries */
                        qalloc = 0;             /* Number of queue entries allocated */
        print_queue_struct *queue = NULL,       /* Queue entries */
                        *temp;          /* Temporary pointer for queue */
-       const char      *user_name,     /* job-originating-user-name attribute */
-                       *job_name;      /* job-name attribute */
+       char            *user_name = NULL,      /* job-originating-user-name attribute */
+                       *job_name = NULL;       /* job-name attribute */
        int             job_id;         /* job-id attribute */
        int             job_k_octets;   /* job-k-octets attribute */
        time_t          job_time;       /* time-at-creation attribute */
        ipp_jstate_t    job_status;     /* job-status attribute */
        int             job_priority;   /* job-priority attribute */
+       size_t size;
        static const char *jattrs[] =   /* Requested job attributes */
                        {
                          "job-id",
@@ -757,9 +1190,10 @@ static int cups_queue_get(const char *sharename,
           (which is basically what we do for non-cups printers ... using
           the lpq_command to get the queue listing). */
 
-       fstrcpy( printername, lpq_command );
-
-       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", printername, q, status));
+       if (!push_utf8_talloc(frame, &printername, lpq_command, &size)) {
+               goto out;
+       }
+       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", lpq_command, q, status));
 
        /*
         * Make sure we don't ask for passwords...
@@ -771,7 +1205,7 @@ static int cups_queue_get(const char *sharename,
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -779,7 +1213,18 @@ static int cups_queue_get(const char *sharename,
         * Generate the printer URI...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", printername);
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        /*
        * Build an IPP_GET_JOBS request, which requires the following
@@ -793,18 +1238,18 @@ static int cups_queue_get(const char *sharename,
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_JOBS;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_GET_JOBS);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
 
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_KEYWORD,
                      "requested-attributes",
                      (sizeof(jattrs) / sizeof(jattrs[0])),
                      NULL, jattrs);
@@ -822,9 +1267,9 @@ static int cups_queue_get(const char *sharename,
                goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+       if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
-                        ippErrorString(response->request.status.status_code)));
+                        ippErrorString(ippGetStatusCode(response))));
                goto out;
        }
 
@@ -836,13 +1281,13 @@ static int cups_queue_get(const char *sharename,
        qalloc = 0;
        queue  = NULL;
 
-        for (attr = response->attrs; attr != NULL; attr = attr->next) {
+        for (attr = ippFirstAttribute(response); attr != NULL; attr = ippNextAttribute(response)) {
               /*
                * Skip leading attributes until we hit a job...
                */
 
-               while (attr != NULL && attr->group_tag != IPP_TAG_JOB)
-                       attr = attr->next;
+               while (attr != NULL && ippGetGroupTag(attr) != IPP_TAG_JOB)
+                       attr = ippNextAttribute(response);
 
                if (attr == NULL)
                        break;
@@ -877,41 +1322,53 @@ static int cups_queue_get(const char *sharename,
                user_name    = NULL;
                job_name     = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_JOB) {
-                       if (attr->name == NULL) {
-                               attr = attr->next;
+               while (attr != NULL && ippGetGroupTag(attr) == IPP_TAG_JOB) {
+                       if (ippGetName(attr) == NULL) {
+                               attr = ippNextAttribute(response);
                                break;
                        }
 
-                       if (strcmp(attr->name, "job-id") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_id = attr->values[0].integer;
-
-                       if (strcmp(attr->name, "job-k-octets") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_k_octets = attr->values[0].integer;
-
-                       if (strcmp(attr->name, "job-priority") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_priority = attr->values[0].integer;
-
-                       if (strcmp(attr->name, "job-state") == 0 &&
-                           attr->value_tag == IPP_TAG_ENUM)
-                               job_status = (ipp_jstate_t)(attr->values[0].integer);
-
-                       if (strcmp(attr->name, "time-at-creation") == 0 &&
-                           attr->value_tag == IPP_TAG_INTEGER)
-                               job_time = attr->values[0].integer;
-
-                       if (strcmp(attr->name, "job-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               job_name = attr->values[0].string.text;
+                       if (strcmp(ippGetName(attr), "job-id") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_id = ippGetInteger(attr, 0);
+
+                       if (strcmp(ippGetName(attr), "job-k-octets") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_k_octets = ippGetInteger(attr, 0);
+
+                       if (strcmp(ippGetName(attr), "job-priority") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_priority = ippGetInteger(attr, 0);
+
+                       if (strcmp(ippGetName(attr), "job-state") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_ENUM)
+                               job_status = (ipp_jstate_t)ippGetInteger(attr, 0);
+
+                       if (strcmp(ippGetName(attr), "time-at-creation") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_INTEGER)
+                               job_time = ippGetInteger(attr, 0);
+
+                       if (strcmp(ippGetName(attr), "job-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &job_name,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
-                       if (strcmp(attr->name, "job-originating-user-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               user_name = attr->values[0].string.text;
+                       if (strcmp(ippGetName(attr), "job-originating-user-name") == 0 &&
+                           ippGetValueTag(attr) == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &user_name,
+                                               ippGetString(attr, 0, NULL),
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
-                       attr = attr->next;
+                       attr = ippNextAttribute(response);
                }
 
               /*
@@ -925,7 +1382,7 @@ static int cups_queue_get(const char *sharename,
                                continue;
                }
 
-               temp->job      = job_id;
+               temp->sysjob   = job_id;
                temp->size     = job_k_octets * 1024;
                temp->status   = job_status == IPP_JOB_PENDING ? LPQ_QUEUED :
                                 job_status == IPP_JOB_STOPPED ? LPQ_PAUSED :
@@ -933,8 +1390,8 @@ static int cups_queue_get(const char *sharename,
                                 LPQ_PRINTING;
                temp->priority = job_priority;
                temp->time     = job_time;
-               strncpy(temp->fs_user, user_name, sizeof(temp->fs_user) - 1);
-               strncpy(temp->fs_file, job_name, sizeof(temp->fs_file) - 1);
+               strlcpy(temp->fs_user, user_name, sizeof(temp->fs_user));
+               strlcpy(temp->fs_file, job_name, sizeof(temp->fs_file));
 
                qcount ++;
 
@@ -957,11 +1414,11 @@ static int cups_queue_get(const char *sharename,
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_GET_PRINTER_ATTRIBUTES);
+       ippSetRequestId(request, 1);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -981,14 +1438,12 @@ static int cups_queue_get(const char *sharename,
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(cupsLastError())));
-               *q = queue;
                goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+       if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
-                        ippErrorString(response->request.status.status_code)));
-               *q = queue;
+                        ippErrorString(ippGetStatusCode(response))));
                goto out;
        }
 
@@ -997,15 +1452,26 @@ static int cups_queue_get(const char *sharename,
        */
 
         if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL) {
-               if (attr->values[0].integer == IPP_PRINTER_STOPPED)
+               if (ippGetInteger(attr, 0) == IPP_PRINTER_STOPPED)
                        status->status = LPSTAT_STOPPED;
                else
                        status->status = LPSTAT_OK;
        }
 
         if ((attr = ippFindAttribute(response, "printer-state-message",
-                                    IPP_TAG_TEXT)) != NULL)
-               fstrcpy(status->message, attr->values[0].string.text);
+                                    IPP_TAG_TEXT)) != NULL) {
+               char *msg = NULL;
+               if (!pull_utf8_talloc(frame, &msg,
+                               ippGetString(attr, 0, NULL),
+                               &size)) {
+                       SAFE_FREE(queue);
+                       qcount = 0;
+                       goto out;
+               }
+               fstrcpy(status->message, msg);
+       }
+
+ out:
 
        /*
         * Return the job queue...
@@ -1013,7 +1479,6 @@ static int cups_queue_get(const char *sharename,
 
        *q = queue;
 
- out:
        if (response)
                ippDelete(response);
 
@@ -1023,6 +1488,7 @@ static int cups_queue_get(const char *sharename,
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return qcount;
 }
 
@@ -1033,13 +1499,19 @@ static int cups_queue_get(const char *sharename,
 
 static int cups_queue_pause(int snum)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       char *printername = NULL;
+       char *username = NULL;
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
+       size_t size;
 
        DEBUG(5,("cups_queue_pause(%d)\n", snum));
 
@@ -1053,7 +1525,7 @@ static int cups_queue_pause(int snum)
         * Try to connect to the server...
         */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -1069,38 +1541,57 @@ static int cups_queue_pause(int snum)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_PAUSE_PRINTER;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_PAUSE_PRINTER);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+       if (!push_utf8_talloc(frame, &printername,
+                             lp_printername(talloc_tos(), lp_sub, snum), &size)) {
+               goto out;
+       }
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, current_user_info.unix_name);
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
        */
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to pause printer %s - %s\n",
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
-               DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to pause printer %s - %s\n",
+                        lp_printername(talloc_tos(), lp_sub, snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1114,6 +1605,7 @@ static int cups_queue_pause(int snum)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -1124,13 +1616,19 @@ static int cups_queue_pause(int snum)
 
 static int cups_queue_resume(int snum)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
+       const struct loadparm_substitution *lp_sub =
+               loadparm_s3_global_substitution();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       char *printername = NULL;
+       char *username = NULL;
+       char            uri[HTTP_MAX_URI] = {0}; /* printer-uri attribute */
+       http_uri_status_t ustatus;
+       size_t size;
 
        DEBUG(5,("cups_queue_resume(%d)\n", snum));
 
@@ -1144,7 +1642,7 @@ static int cups_queue_resume(int snum)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -1160,38 +1658,57 @@ static int cups_queue_resume(int snum)
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_RESUME_PRINTER;
-       request->request.op.request_id   = 1;
+       ippSetOperation(request, IPP_RESUME_PRINTER);
+       ippSetRequestId(request, 1);
 
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+       if (!push_utf8_talloc(frame, &printername, lp_printername(talloc_tos(), lp_sub, snum),
+                             &size)) {
+               goto out;
+       }
+       ustatus = httpAssembleURIf(HTTP_URI_CODING_ALL,
+                                  uri,
+                                  sizeof(uri),
+                                  "ipp",
+                                  NULL, /* username */
+                                  "localhost",
+                                  ippPort(),
+                                  "/printers/%s",
+                                  printername);
+       if (ustatus != HTTP_URI_STATUS_OK) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, current_user_info.unix_name);
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
        */
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+               if (ippGetStatusCode(response) >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to resume printer %s - %s\n",
+                                lp_printername(talloc_tos(), lp_sub, snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
-               DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to resume printer %s - %s\n",
+                        lp_printername(talloc_tos(), lp_sub, snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1205,6 +1722,7 @@ static int cups_queue_resume(int snum)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -1224,144 +1742,6 @@ struct printif  cups_printif =
        cups_job_submit,
 };
 
-bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
-{
-       http_t          *http = NULL;           /* HTTP connection to server */
-       ipp_t           *request = NULL,        /* IPP Request */
-                       *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language = NULL;       /* Default language */
-       char            *name,          /* printer-name attribute */
-                       *info,          /* printer-info attribute */
-                       *location;      /* printer-location attribute */
-       char            uri[HTTP_MAX_URI];
-       static const char *requested[] =/* Requested attributes */
-                       {
-                         "printer-name",
-                         "printer-info",
-                         "printer-location"
-                       };
-       bool ret = False;
-
-       DEBUG(5, ("pulling %s location\n", printer->sharename));
-
-       /*
-        * Make sure we don't ask for passwords...
-        */
-
-        cupsSetPasswordCB(cups_passwd_cb);
-
-       /*
-        * Try to connect to the server...
-        */
-
-       if ((http = cups_connect()) == NULL) {
-               goto out;
-       }
-
-       request = ippNew();
-
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-       request->request.op.request_id   = 1;
-
-       language = cupsLangDefault();
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
-                     "attributes-natural-language", NULL, language->language);
-
-       slprintf(uri, sizeof(uri) - 1, "ipp://%s/printers/%s",
-                lp_cups_server(), printer->sharename);
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
-
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                     "requested-attributes",
-                     (sizeof(requested) / sizeof(requested[0])),
-                     NULL, requested);
-
-       /*
-        * Do the request and get back a response...
-        */
-
-       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
-               DEBUG(0,("Unable to get printer attributes - %s\n",
-                        ippErrorString(cupsLastError())));
-               goto out;
-       }
-
-       for (attr = response->attrs; attr != NULL;) {
-               /*
-                * Skip leading attributes until we hit a printer...
-                */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-               /*
-                * Pull the needed attributes from this printer...
-                */
-
-               name       = NULL;
-               info       = NULL;
-               location   = NULL;
-
-               while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
-                       /* Grab the comment if we don't have one */
-                       if ( (strcmp(attr->name, "printer-info") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT)
-                            && !strlen(printer->comment) )
-                       {
-                               DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
-                                        attr->values[0].string.text));
-                               strlcpy(printer->comment,
-                                               attr->values[0].string.text,
-                                               sizeof(printer->comment));
-                       }
-
-                       /* Grab the location if we don't have one */
-                       if ( (strcmp(attr->name, "printer-location") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT)
-                            && !strlen(printer->location) )
-                       {
-                               DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
-                                        attr->values[0].string.text));
-                               fstrcpy(printer->location,attr->values[0].string.text);
-                       }
-
-                       attr = attr->next;
-               }
-
-               /*
-                * See if we have everything needed...
-                */
-
-               if (name == NULL)
-                       break;
-
-       }
-
-       ret = True;
-
- out:
-       if (response)
-               ippDelete(response);
-
-       if (language)
-               cupsLangFree(language);
-
-       if (http)
-               httpClose(http);
-
-       return ret;
-}
-
 #else
  /* this keeps fussy compilers happy */
  void print_cups_dummy(void);