Make sure we claim that a DACL or SACL is present if the SD says so
[amitay/samba.git] / source3 / libsmb / clisecdesc.c
index 7dd2747ff6e08b4aae7f258a61c4ba00d9679bcb..04f661cc8207695dd3c4bfa2ee893ffb694604d8 100644 (file)
    Unix SMB/CIFS implementation.
    client security descriptor functions
    Copyright (C) Andrew Tridgell 2000
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
+#include "libsmb/libsmb.h"
+#include "../libcli/security/secdesc.h"
 
-/****************************************************************************
-  query the security descriptor for a open file
- ****************************************************************************/
-SEC_DESC *cli_query_secdesc(struct cli_state *cli, int fnum, 
-                           TALLOC_CTX *mem_ctx)
+NTSTATUS cli_query_secdesc(struct cli_state *cli, uint16_t fnum,
+                          TALLOC_CTX *mem_ctx, struct security_descriptor **sd)
 {
-       char param[8];
-       char *rparam=NULL, *rdata=NULL;
-       int rparam_count=0, rdata_count=0;
-       prs_struct pd;
-       SEC_DESC *psd = NULL;
+       uint8_t param[8];
+       uint8_t *rdata=NULL;
+       uint32_t rdata_count=0;
+       NTSTATUS status;
+       struct security_descriptor *lsd;
 
        SIVAL(param, 0, fnum);
-       SSVAL(param, 4, 0x7);
-
-       if (!cli_send_nt_trans(cli, 
-                              NT_TRANSACT_QUERY_SECURITY_DESC, 
-                              0, 
-                              NULL, 0, 0,
-                              param, 8, 4,
-                              NULL, 0, 0x10000)) {
-               DEBUG(1,("Failed to send NT_TRANSACT_QUERY_SECURITY_DESC\n"));
+       SIVAL(param, 4, 0x7);
+
+       status = cli_trans(talloc_tos(), cli, SMBnttrans,
+                          NULL, -1, /* name, fid */
+                          NT_TRANSACT_QUERY_SECURITY_DESC, 0, /* function, flags */
+                          NULL, 0, 0, /* setup, length, max */
+                          param, 8, 4, /* param, length, max */
+                          NULL, 0, 0x10000, /* data, length, max */
+                          NULL,             /* recv_flags2 */
+                          NULL, 0, NULL, /* rsetup, length */
+                          NULL, 0, NULL,
+                          &rdata, 0, &rdata_count);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1, ("NT_TRANSACT_QUERY_SECURITY_DESC failed: %s\n",
+                         nt_errstr(status)));
                goto cleanup;
        }
 
-
-       if (!cli_receive_nt_trans(cli, 
-                                 &rparam, &rparam_count,
-                                 &rdata, &rdata_count)) {
-               DEBUG(1,("Failed to recv NT_TRANSACT_QUERY_SECURITY_DESC\n"));
+       status = unmarshall_sec_desc(mem_ctx, (uint8 *)rdata, rdata_count,
+                                    &lsd);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("unmarshall_sec_desc failed: %s\n",
+                          nt_errstr(status)));
                goto cleanup;
        }
 
-       prs_init(&pd, rdata_count, mem_ctx, UNMARSHALL);
-       prs_append_data(&pd, rdata, rdata_count);
-       pd.data_offset = 0;
-
-       if (!sec_io_desc("sd data", &psd, &pd, 1)) {
-               DEBUG(1,("Failed to parse secdesc\n"));
-               goto cleanup;
+       if (sd != NULL) {
+               *sd = lsd;
+       } else {
+               TALLOC_FREE(lsd);
        }
 
  cleanup:
 
-       SAFE_FREE(rparam);
-       SAFE_FREE(rdata);
+       TALLOC_FREE(rdata);
 
-       prs_mem_free(&pd);
-       return psd;
+       return status;
 }
 
 /****************************************************************************
   set the security descriptor for a open file
  ****************************************************************************/
-BOOL cli_set_secdesc(struct cli_state *cli, int fnum, SEC_DESC *sd)
+NTSTATUS cli_set_secdesc(struct cli_state *cli, uint16_t fnum,
+                        const struct security_descriptor *sd)
 {
-       char param[8];
-       char *rparam=NULL, *rdata=NULL;
-       int rparam_count=0, rdata_count=0;
-       TALLOC_CTX *mem_ctx;
-       prs_struct pd;
-       BOOL ret = False;
-
-       if ((mem_ctx = talloc_init("cli_set_secdesc")) == NULL) {
-               DEBUG(0,("talloc_init failed.\n"));
-               goto cleanup;
-       }
-
-       prs_init(&pd, 0, mem_ctx, MARSHALL);
-       prs_give_memory(&pd, NULL, 0, True);
-
-       if (!sec_io_desc("sd data", &sd, &pd, 1)) {
-               DEBUG(1,("Failed to marshall secdesc\n"));
-               goto cleanup;
+       uint8_t param[8];
+       uint32 sec_info = 0;
+       uint8 *data;
+       size_t len;
+       NTSTATUS status;
+
+       status = marshall_sec_desc(talloc_tos(), sd, &data, &len);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("marshall_sec_desc failed: %s\n",
+                          nt_errstr(status)));
+               return status;
        }
 
        SIVAL(param, 0, fnum);
-       SSVAL(param, 4, 0x7);
-
-       if (!cli_send_nt_trans(cli, 
-                              NT_TRANSACT_SET_SECURITY_DESC, 
-                              0, 
-                              NULL, 0, 0,
-                              param, 8, 0,
-                              pd.data_p, pd.data_offset, 0)) {
-               DEBUG(1,("Failed to send NT_TRANSACT_SET_SECURITY_DESC\n"));
-               goto cleanup;
-       }
-
 
-       if (!cli_receive_nt_trans(cli, 
-                                 &rparam, &rparam_count,
-                                 &rdata, &rdata_count)) {
-               DEBUG(1,("NT_TRANSACT_SET_SECURITY_DESC failed\n"));
-               goto cleanup;
+       if (sd->dacl || (sd->type & SEC_DESC_DACL_PRESENT))
+               sec_info |= SECINFO_DACL;
+       if (sd->sacl || (sd->type & SEC_DESC_SACL_PRESENT))
+               sec_info |= SECINFO_SACL;
+       if (sd->owner_sid)
+               sec_info |= SECINFO_OWNER;
+       if (sd->group_sid)
+               sec_info |= SECINFO_GROUP;
+       SSVAL(param, 4, sec_info);
+
+       status = cli_trans(talloc_tos(), cli, SMBnttrans,
+                          NULL, -1, /* name, fid */
+                          NT_TRANSACT_SET_SECURITY_DESC, 0,
+                          NULL, 0, 0, /* setup */
+                          param, 8, 0, /* param */
+                          data, len, 0, /* data */
+                          NULL,         /* recv_flags2 */
+                          NULL, 0, NULL, /* rsetup */
+                          NULL, 0, NULL, /* rparam */
+                          NULL, 0, NULL); /* rdata */
+       TALLOC_FREE(data);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1, ("Failed to send NT_TRANSACT_SET_SECURITY_DESC: %s\n",
+                         nt_errstr(status)));
        }
-
-       ret = True;
-
-  cleanup:
-
-       SAFE_FREE(rparam);
-       SAFE_FREE(rdata);
-
-       talloc_destroy(mem_ctx);
-
-       prs_mem_free(&pd);
-       return ret;
+       return status;
 }