Replace sid_string_static by sid_string_dbg in DEBUGs
[amitay/samba.git] / source3 / lib / privileges.c
index 09a868fc277079ff95778b99c3bc7c4b893afffb..3e2c756849c085e3b292f1a09a7224abfa655967 100644 (file)
@@ -1,13 +1,14 @@
 /*
    Unix SMB/CIFS implementation.
    Privileges handling functions
-   Copyright (C) Jean François Micouleau       1998-2001
+   Copyright (C) Jean François Micouleau      1998-2001
    Copyright (C) Simo Sorce                    2002-2003
-   Copyright (C) Gerald (Jerry) Carter          2004
+   Copyright (C) Gerald (Jerry) Carter          2005
+   Copyright (C) Michael Adam                  2007
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -16,8 +17,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
  
 
 #define PRIVPREFIX              "PRIV_"
 
-#define ALLOC_CHECK(ptr, err, label, str) do { if ((ptr) == NULL) \
-       { DEBUG(0, ("%s: out of memory!\n", str)); err = NT_STATUS_NO_MEMORY; goto label; } } while(0)
-       
-PRIVS privs[] = {
-       {SE_NETWORK_LOGON,              "SeNetworkLogonRight",                  "Access this computer from the network"},
-       {SE_INTERACTIVE_LOGON,          "SeInteractiveLogonRight",              "Log on locally"},
-       {SE_BATCH_LOGON,                "SeBatchLogonRight",                    "Log on as a batch job"},
-       {SE_SERVICE_LOGON,              "SeServiceLogonRight",                  "Log on as a service"},
-
-       {SE_MACHINE_ACCOUNT,            "SeMachineAccountPrivilege",            "Add machines to domain"},
-       {SE_PRINT_OPERATOR,             "SePrintOperatorPrivilege",             "Printer Admin"},
-       {SE_ADD_USERS,                  "SeAddUsersPrivilege",                  "Add users and groups to the domain"},
-
-       {SE_END,                        "",                                     ""}
-};
-       
+typedef struct {
+       size_t count;
+       DOM_SID *list;
+} SID_LIST;
 
-#if 0  /* not needed currently */
-PRIVS privs[] = {
-       {SE_ASSIGN_PRIMARY_TOKEN,       "SeAssignPrimaryTokenPrivilege",        "Assign Primary Token"},
-       {SE_CREATE_TOKEN,               "SeCreateTokenPrivilege",               "Create Token"},
-       {SE_LOCK_MEMORY,                "SeLockMemoryPrivilege",                "Lock Memory"},
-       {SE_INCREASE_QUOTA,             "SeIncreaseQuotaPrivilege",             "Increase Quota"},
-       {SE_UNSOLICITED_INPUT,          "SeUnsolicitedInputPrivilege",          "Unsolicited Input"},
-       {SE_MACHINE_ACCOUNT,            "SeMachineAccountPrivilege",            "Can add Machine Accounts to the Domain"},
-       {SE_TCB,                        "SeTcbPrivilege",                       "Act as part of the operating system"},
-       {SE_SECURITY,                   "SeSecurityPrivilege",                  "Security Privilege"},
-       {SE_TAKE_OWNERSHIP,             "SeTakeOwnershipPrivilege",             "Take Ownership Privilege"},
-       {SE_LOAD_DRIVER,                "SeLocalDriverPrivilege",               "Local Driver Privilege"},
-       {SE_SYSTEM_PROFILE,             "SeSystemProfilePrivilege",             "System Profile Privilege"},
-       {SE_SYSTEM_TIME,                "SeSystemtimePrivilege",                "System Time"},
-       {SE_PROF_SINGLE_PROCESS,        "SeProfileSingleProcessPrivilege",      "Profile Single Process Privilege"},
-       {SE_INC_BASE_PRIORITY,          "SeIncreaseBasePriorityPrivilege",      "Increase Base Priority Privilege"},
-       {SE_CREATE_PAGEFILE,            "SeCreatePagefilePrivilege",            "Create Pagefile Privilege"},
-       {SE_CREATE_PERMANENT,           "SeCreatePermanentPrivilege",           "Create Permanent"},
-       {SE_BACKUP,                     "SeBackupPrivilege",                    "Backup Privilege"},
-       {SE_RESTORE,                    "SeRestorePrivilege",                   "Restore Privilege"},
-       {SE_SHUTDOWN,                   "SeShutdownPrivilege",                  "Shutdown Privilege"},
-       {SE_DEBUG,                      "SeDebugPrivilege",                     "Debug Privilege"},
-       {SE_AUDIT,                      "SeAuditPrivilege",                     "Audit"},
-       {SE_SYSTEM_ENVIRONMENT,         "SeSystemEnvironmentPrivilege",         "System Environment Privilege"},
-       {SE_CHANGE_NOTIFY,              "SeChangeNotifyPrivilege",              "Change Notify"},
-       {SE_REMOTE_SHUTDOWN,            "SeRemoteShutdownPrivilege",            "Remote Shutdown Privilege"},
-       {SE_UNDOCK,                     "SeUndockPrivilege",                    "Undock"},
-       {SE_SYNC_AGENT,                 "SeSynchronizationAgentPrivilege",      "Synchronization Agent"},
-       {SE_ENABLE_DELEGATION,          "SeEnableDelegationPrivilege",          "Enable Delegation"},
-       {SE_PRINT_OPERATOR,             "SePrintOperatorPrivilege",             "Printer Operator"},
-       {SE_ADD_USERS,                  "SeAddUsersPrivilege",                  "Add Users"},
-       {SE_ALL_PRIVS,                  "SeAllPrivileges",                      "All Privileges"}
-       {SE_END,                        "",                                     ""}
-};
-#endif
-
-typedef struct priv_sid_list {
-       uint32 se_priv;
+typedef struct {
+       TALLOC_CTX *mem_ctx;
+       SE_PRIV privilege;
        SID_LIST sids;
 } PRIV_SID_LIST;
 
-/***************************************************************************
- Retrieve the privilege mask (set) for a given SID
-****************************************************************************/
 
-static uint32 get_privileges( const DOM_SID *sid, uint32 *mask )
+static bool get_privileges( const DOM_SID *sid, SE_PRIV *mask )
 {
        TDB_CONTEXT *tdb = get_account_pol_tdb();
        fstring keystr;
-       uint32 priv_mask;
+       TDB_DATA data;
+
+       /* Fail if the admin has not enable privileges */
+       
+       if ( !lp_enable_privileges() ) {
+               return False;
+       }
        
        if ( !tdb )
                return False;
 
+       /* PRIV_<SID> (NULL terminated) as the key */
+       
        fstr_sprintf( keystr, "%s%s", PRIVPREFIX, sid_string_static(sid) );
 
-       if ( !tdb_fetch_uint32( tdb, keystr, &priv_mask ) ) {
-               DEBUG(3,("get_privileges: No privileges assigned to SID [%s]\n",
-                       sid_string_static(sid)));
+       data = tdb_fetch_bystring( tdb, keystr );
+       
+       if ( !data.dptr ) {
+               DEBUG(3, ("get_privileges: No privileges assigned to SID "
+                         "[%s]\n", sid_string_dbg(sid)));
                return False;
        }
        
-       *mask = priv_mask;
+       SMB_ASSERT( data.dsize == sizeof( SE_PRIV ) );
+       
+       se_priv_copy( mask, (SE_PRIV*)data.dptr );
+       SAFE_FREE(data.dptr);
+
        return True;
 }
 
@@ -112,146 +76,62 @@ static uint32 get_privileges( const DOM_SID *sid, uint32 *mask )
  Store the privilege mask (set) for a given SID
 ****************************************************************************/
 
-static BOOL set_privileges( const DOM_SID *sid, uint32 mask )
+static bool set_privileges( const DOM_SID *sid, SE_PRIV *mask )
 {
        TDB_CONTEXT *tdb = get_account_pol_tdb();
        fstring keystr;
+       TDB_DATA data;
        
-       if ( !tdb )
+       if ( !lp_enable_privileges() )
                return False;
 
-       fstr_sprintf( keystr, "%s%s", PRIVPREFIX, sid_string_static(sid) );
-
-       return tdb_store_uint32( tdb, keystr, mask );
-}
-
-/****************************************************************************
- check if the privilege is in the privilege list
-****************************************************************************/
-
-static BOOL check_priv_in_privilege(PRIVILEGE_SET *priv_set, LUID_ATTR set)
-{
-       int i;
-
-       if ( !priv_set )
+       if ( !tdb )
                return False;
 
-       for ( i = 0; i < priv_set->count; i++ ) {
-               LUID_ATTR *cur_set;
-
-               cur_set = &priv_set->set[i];
-
-               /* check only the low and high part. Checking the attr 
-                  field has no meaning */
-
-               if ( (cur_set->luid.low == set.luid.low) 
-                       && (cur_set->luid.high == set.luid.high) ) 
-               {
-                       return True;
-               }
+       if ( !sid || (sid->num_auths == 0) ) {
+               DEBUG(0,("set_privileges: Refusing to store empty SID!\n"));
+               return False;
        }
 
-       return False;
-}
-
-/****************************************************************************
- add a privilege to a privilege array
- ****************************************************************************/
-
-static NTSTATUS add_privilege(PRIVILEGE_SET *priv_set, LUID_ATTR set)
-{
-       NTSTATUS ret;
-       LUID_ATTR *new_set;
-
-       /* check if the privilege is not already in the list */
-
-       if ( check_priv_in_privilege(priv_set, set) )
-               return NT_STATUS_OK;
-
-       /* we can allocate memory to add the new privilege */
-
-       new_set = TALLOC_REALLOC_ARRAY(priv_set->mem_ctx, priv_set->set, LUID_ATTR, priv_set->count + 1);
-       ALLOC_CHECK(new_set, ret, done, "add_privilege");
-
-       new_set[priv_set->count].luid.high = set.luid.high;
-       new_set[priv_set->count].luid.low = set.luid.low;
-       new_set[priv_set->count].attr = set.attr;
-
-       priv_set->count++;
-       priv_set->set = new_set;
-
-       ret = NT_STATUS_OK;
-
-done:
-       return ret;
-}
-
-/*********************************************************************
- Generate the LUID_ATTR structure based on a bitmask
-*********************************************************************/
-
-static LUID_ATTR get_privilege_luid( uint32 mask )
-{
-       LUID_ATTR priv_luid;
-
-       priv_luid.attr = 0;
-       priv_luid.luid.high = 0;
-       priv_luid.luid.low = mask;
-
-       return priv_luid;
-}
-
-/*********************************************************************
- Convert a privilege mask to an LUID_ATTR[] and add the privileges to 
- the PRIVILEGE_SET
-*********************************************************************/
-
-static void add_privilege_set( PRIVILEGE_SET *privset, uint32 mask )
-{
-       LUID_ATTR luid;
-       int i;
+       /* PRIV_<SID> (NULL terminated) as the key */
        
-       for (i=0; privs[i].se_priv != SE_END; i++) {
-
-               /* skip if the privilege is not part of the mask */
-
-               if ( !(mask & privs[i].se_priv) ) 
-                       continue;
-
-               /* remove the bit from the mask */
-
-               mask &= ~privs[i].se_priv;      
-               
-               luid = get_privilege_luid( privs[i].se_priv );
-               
-               add_privilege( privset, luid );
-       }
+       fstr_sprintf( keystr, "%s%s", PRIVPREFIX, sid_string_static(sid) );
+       
+       /* no packing.  static size structure, just write it out */
+       
+       data.dptr  = (uint8 *)mask;
+       data.dsize = sizeof(SE_PRIV);
 
-       /* log an error if we have anything left at this point */
-       if ( mask )
-               DEBUG(0,("add_privilege_set: leftover bits! [0x%x]\n", mask ));
+       return ( tdb_store_bystring(tdb, keystr, data, TDB_REPLACE) != -1 );
 }
 
 /*********************************************************************
- get a list of all privleges for all sids the in list
+ get a list of all privileges for all sids in the list
 *********************************************************************/
 
-void get_privileges_for_sids(PRIVILEGE_SET *privset, DOM_SID *slist, int scount)
+bool get_privileges_for_sids(SE_PRIV *privileges, DOM_SID *slist, int scount)
 {
-       uint32 priv_mask;
+       SE_PRIV mask;
        int i;
+       bool found = False;
+
+       se_priv_copy( privileges, &se_priv_none );
        
        for ( i=0; i<scount; i++ ) {
                /* don't add unless we actually have a privilege assigned */
 
-               if ( !get_privileges( &slist[i], &priv_mask ) )
+               if ( !get_privileges( &slist[i], &mask ) )
                        continue;
 
-               DEBUG(5,("get_privileges_for_sids: sid = %s, privilege mask = 0x%x\n",
-                       sid_string_static(&slist[i]), priv_mask));
+               DEBUG(5,("get_privileges_for_sids: sid = %s\nPrivilege "
+                        "set:\n", sid_string_dbg(&slist[i])));
+               dump_se_priv( DBGC_ALL, 5, &mask );
                        
-               add_privilege_set( privset, priv_mask );
+               se_priv_add( privileges, &mask );
+               found = True;
        }
+
+       return found;
 }
 
 
@@ -261,29 +141,42 @@ void get_privileges_for_sids(PRIVILEGE_SET *privset, DOM_SID *slist, int scount)
 
 static int priv_traverse_fn(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void *state)
 {
-       PRIV_SID_LIST *priv = state;
+       PRIV_SID_LIST *priv = (PRIV_SID_LIST *)state;
        int  prefixlen = strlen(PRIVPREFIX);
        DOM_SID sid;
        fstring sid_string;
+       
+       /* easy check first */
+       
+       if ( data.dsize != sizeof(SE_PRIV) )
+               return 0;
 
        /* check we have a PRIV_+SID entry */
 
-       if ( strncmp(key.dptr, PRIVPREFIX, prefixlen) != 0)
+       if ( strncmp((const char *)key.dptr, PRIVPREFIX, prefixlen) != 0)
                return 0;
                
        /* check to see if we are looking for a particular privilege */
 
-       if ( priv->se_priv != SE_NONE ) {
-               uint32 mask = SVAL(data.dptr, 0);
+       if ( !se_priv_equal(&priv->privilege, &se_priv_none) ) {
+               SE_PRIV mask;
+               
+               se_priv_copy( &mask, (SE_PRIV*)data.dptr );
                
                /* if the SID does not have the specified privilege 
                   then just return */
                   
-               if ( !(mask & priv->se_priv) )
+               if ( !is_privilege_assigned( &mask, &priv->privilege) )
                        return 0;
        }
                
-       fstrcpy( sid_string, &key.dptr[strlen(PRIVPREFIX)] );
+       fstrcpy( sid_string, (const char *)&key.dptr[strlen(PRIVPREFIX)] );
+
+       /* this is a last ditch safety check to preventing returning
+          and invalid SID (i've somehow run into this on development branches) */
+
+       if ( strcmp( "S-0-0", sid_string ) == 0 )
+               return 0;
 
        if ( !string_to_sid(&sid, sid_string) ) {
                DEBUG(0,("travsersal_fn_enum__acct: Could not convert SID [%s]\n",
@@ -291,7 +184,10 @@ static int priv_traverse_fn(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void *s
                return 0;
        }
 
-       add_sid_to_array( &sid, &priv->sids.list, &priv->sids.count );
+       if (!add_sid_to_array( priv->mem_ctx, &sid, &priv->sids.list,
+                              &priv->sids.count )) {
+               return 0;
+       }
        
        return 0;
 }
@@ -305,8 +201,13 @@ NTSTATUS privilege_enumerate_accounts(DOM_SID **sids, int *num_sids)
        TDB_CONTEXT *tdb = get_account_pol_tdb();
        PRIV_SID_LIST priv;
        
+       if (!tdb) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
        ZERO_STRUCT(priv);
-       priv.se_priv = SE_NONE;
+
+       se_priv_copy( &priv.privilege, &se_priv_none );
 
        tdb_traverse( tdb, priv_traverse_fn, &priv);
 
@@ -318,23 +219,29 @@ NTSTATUS privilege_enumerate_accounts(DOM_SID **sids, int *num_sids)
        return NT_STATUS_OK;
 }
 
-/***************************************************************************
- Retrieve the SIDs assigned to a given privilege
-****************************************************************************/
+/*********************************************************************
+ Retrieve list of SIDs granted a particular privilege
+*********************************************************************/
 
-NTSTATUS priv_get_sids(const char *privname, DOM_SID **sids, int *num_sids)
+NTSTATUS privilege_enum_sids(const SE_PRIV *mask, TALLOC_CTX *mem_ctx,
+                            DOM_SID **sids, int *num_sids)
 {
        TDB_CONTEXT *tdb = get_account_pol_tdb();
        PRIV_SID_LIST priv;
-       
-       ZERO_STRUCT(priv);      
-       priv.se_priv = 
-       
+
+       if (!tdb) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       ZERO_STRUCT(priv);
+
+       se_priv_copy(&priv.privilege, mask);
+       priv.mem_ctx = mem_ctx;
 
        tdb_traverse( tdb, priv_traverse_fn, &priv);
 
        /* give the memory away; caller will free */
-       
+
        *sids      = priv.sids.list;
        *num_sids  = priv.sids.count;
 
@@ -345,78 +252,99 @@ NTSTATUS priv_get_sids(const char *privname, DOM_SID **sids, int *num_sids)
  Add privilege to sid
 ****************************************************************************/
 
-BOOL grant_privilege(const DOM_SID *sid, uint32 priv_mask)
+bool grant_privilege(const DOM_SID *sid, const SE_PRIV *priv_mask)
 {
-       uint32 old_mask, new_mask;
+       SE_PRIV old_mask, new_mask;
        
+       ZERO_STRUCT( old_mask );
+       ZERO_STRUCT( new_mask );
+
        if ( get_privileges( sid, &old_mask ) )
-               new_mask = old_mask | priv_mask;
+               se_priv_copy( &new_mask, &old_mask );
        else
-               new_mask = priv_mask;
+               se_priv_copy( &new_mask, &se_priv_none );
 
-       DEBUG(10,("grant_privilege: %s, orig priv set = 0x%x, new privilege set = 0x%x\n",
-               sid_string_static(sid), old_mask, new_mask ));
+       se_priv_add( &new_mask, priv_mask );
+
+       DEBUG(10,("grant_privilege: %s\n", sid_string_dbg(sid)));
+       
+       DEBUGADD( 10, ("original privilege mask:\n"));
+       dump_se_priv( DBGC_ALL, 10, &old_mask );
+       
+       DEBUGADD( 10, ("new privilege mask:\n"));
+       dump_se_priv( DBGC_ALL, 10, &new_mask );
        
-       return set_privileges( sid, new_mask );
+       return set_privileges( sid, &new_mask );
 }
 
 /*********************************************************************
  Add a privilege based on its name
 *********************************************************************/
 
-BOOL grant_privilege_by_name(DOM_SID *sid, const char *name)
+bool grant_privilege_by_name(DOM_SID *sid, const char *name)
 {
-       int i;
-
-       for ( i = 0; privs[i].se_priv != SE_END; i++ ) {
-               if ( strequal(privs[i].name, name) ) {
-                       return grant_privilege( sid, privs[i].se_priv );
-                }
-        }
+       SE_PRIV mask;
 
-        DEBUG(3, ("grant_privilege_by_name: No Such Privilege Found (%s)\n", name));
+       if (! se_priv_from_name(name, &mask)) {
+               DEBUG(3, ("grant_privilege_by_name: "
+                         "No Such Privilege Found (%s)\n", name));
+               return False;
+       }
 
-        return False;
+       return grant_privilege( sid, &mask );
 }
 
 /***************************************************************************
  Remove privilege from sid
 ****************************************************************************/
 
-BOOL revoke_privilege(const DOM_SID *sid, uint32 priv_mask)
+bool revoke_privilege(const DOM_SID *sid, const SE_PRIV *priv_mask)
 {
-       uint32 old_mask, new_mask;
+       SE_PRIV mask;
        
-       if ( get_privileges( sid, &old_mask ) )
-               new_mask = old_mask | priv_mask;
-       else
-               new_mask = priv_mask;
+       /* if the user has no privileges, then we can't revoke any */
+       
+       if ( !get_privileges( sid, &mask ) )
+               return True;
+       
+       DEBUG(10,("revoke_privilege: %s\n", sid_string_dbg(sid)));
        
-       new_mask = old_mask & ~priv_mask;
+       DEBUGADD( 10, ("original privilege mask:\n"));
+       dump_se_priv( DBGC_ALL, 10, &mask );
 
-        DEBUG(10,("revoke_privilege: %s, orig priv set = 0x%x, new priv set = 0x%x\n",
-                sid_string_static(sid), old_mask, new_mask ));
+       se_priv_remove( &mask, priv_mask );
        
-       return set_privileges( sid, new_mask );
+       DEBUGADD( 10, ("new privilege mask:\n"));
+       dump_se_priv( DBGC_ALL, 10, &mask );
+       
+       return set_privileges( sid, &mask );
+}
+
+/*********************************************************************
+ Revoke all privileges
+*********************************************************************/
+
+bool revoke_all_privileges( DOM_SID *sid )
+{
+       return revoke_privilege( sid, &se_priv_all );
 }
 
 /*********************************************************************
  Add a privilege based on its name
 *********************************************************************/
 
-BOOL revoke_privilege_by_name(DOM_SID *sid, const char *name)
+bool revoke_privilege_by_name(DOM_SID *sid, const char *name)
 {
-       int i;
+       SE_PRIV mask;
 
-       for ( i = 0; privs[i].se_priv != SE_END; i++ ) {
-               if ( strequal(privs[i].name, name) ) {
-                       return revoke_privilege( sid, privs[i].se_priv );
-                }
-        }
+       if (! se_priv_from_name(name, &mask)) {
+               DEBUG(3, ("revoke_privilege_by_name: "
+                         "No Such Privilege Found (%s)\n", name));
+               return False;
+       }
 
-        DEBUG(3, ("revoke_privilege_by_name: No Such Privilege Found (%s)\n", name));
+       return revoke_privilege(sid, &mask);
 
-        return False;
 }
 
 /***************************************************************************
@@ -425,28 +353,28 @@ BOOL revoke_privilege_by_name(DOM_SID *sid, const char *name)
 
 NTSTATUS privilege_create_account(const DOM_SID *sid )
 {
-       return ( grant_privilege( sid, SE_NONE ) ? NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL);
+       return ( grant_privilege(sid, &se_priv_none) ? NT_STATUS_OK : NT_STATUS_UNSUCCESSFUL);
 }
 
 /****************************************************************************
  initialise a privilege list and set the talloc context 
  ****************************************************************************/
 NTSTATUS privilege_set_init(PRIVILEGE_SET *priv_set)
 {
-       NTSTATUS ret;
        TALLOC_CTX *mem_ctx;
        
        ZERO_STRUCTP( priv_set );
 
        mem_ctx = talloc_init("privilege set");
-       ALLOC_CHECK(mem_ctx, ret, done, "init_privilege");
+       if ( !mem_ctx ) {
+               DEBUG(0,("privilege_set_init: failed to initialize talloc ctx!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
 
        priv_set->mem_ctx = mem_ctx;
 
-       ret = NT_STATUS_OK;
-
-done:
-       return ret;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -484,17 +412,20 @@ void privilege_set_free(PRIVILEGE_SET *priv_set)
 
 NTSTATUS dup_luid_attr(TALLOC_CTX *mem_ctx, LUID_ATTR **new_la, LUID_ATTR *old_la, int count)
 {
-       NTSTATUS ret;
        int i;
 
-       /* don't crash if the source pointer is NULL (since we don't
-          do priviledges now anyways) */
-
        if ( !old_la )
                return NT_STATUS_OK;
 
-       *new_la = TALLOC_ARRAY(mem_ctx, LUID_ATTR, count);
-       ALLOC_CHECK(new_la, ret, done, "dupalloc_luid_attr");
+       if (count) {
+               *new_la = TALLOC_ARRAY(mem_ctx, LUID_ATTR, count);
+               if ( !*new_la ) {
+                       DEBUG(0,("dup_luid_attr: failed to alloc new LUID_ATTR array [%d]\n", count));
+                       return NT_STATUS_NO_MEMORY;
+               }
+       } else {
+               *new_la = NULL;
+       }
 
        for (i=0; i<count; i++) {
                (*new_la)[i].luid.high = old_la[i].luid.high;
@@ -502,114 +433,29 @@ NTSTATUS dup_luid_attr(TALLOC_CTX *mem_ctx, LUID_ATTR **new_la, LUID_ATTR *old_l
                (*new_la)[i].attr = old_la[i].attr;
        }
        
-       ret = NT_STATUS_OK;
-
-done:
-       return ret;
-}
-
-/****************************************************************************
- Performa deep copy of a PRIVILEGE_SET structure.  Assumes an initialized 
- destination structure.
-*****************************************************************************/
-
-BOOL dup_privilege_set( PRIVILEGE_SET *dest, PRIVILEGE_SET *src )
-{
-       NTSTATUS result;
-       
-       if ( !dest || !src )
-               return False;
-
-       result = dup_luid_attr( dest->mem_ctx, &dest->set, src->set, src->count );
-       if ( !NT_STATUS_IS_OK(result) ) {
-               DEBUG(0,("dup_privilege_set: Failed to dup LUID_ATTR array [%s]\n", 
-                       nt_errstr(result) ));
-               return False;
-       }
-       
-       dest->control  = src->control;
-       dest->count    = src->count;
-
-       return True;
-}
-
-/****************************************************************************
- Does the user have the specified privilege ?  We only deal with one privilege
- at a time here.
-*****************************************************************************/
-
-BOOL user_has_privilege(NT_USER_TOKEN *token, uint32 privilege)
-{
-       return check_priv_in_privilege( &token->privileges, get_privilege_luid(privilege) );
-}
-
-/****************************************************************************
- Convert a LUID to a named string
-****************************************************************************/
-
-char* luid_to_privilege_name(const LUID *set)
-{
-       static fstring name;
-       int i = 0;
-
-       if (set->high != 0)
-               return NULL;
-
-       for ( i=0; privs[i].se_priv!=SE_END; i++ ) {
-               if (set->low == privs[i].se_priv) {
-                       fstrcpy(name, privs[i].name);
-                       return name;
-               }
-       }
-
-       return NULL;
-}
-
-/****************************************************************************
- Convert an LUID to a 32-bit mask
-****************************************************************************/
-
-uint32 luid_to_privilege_mask(const LUID *set)
-{
-       int i = 0;
-
-       if (set->high != 0)
-               return SE_END;
-
-       for ( i=0; privs[i].se_priv != SE_END; i++ ) {
-               if (set->low == privs[i].se_priv)
-                       return privs[i].se_priv;
-       }
-
-       return SE_END;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
- return the number of elements in the privlege array
 *******************************************************************/
 
-int count_all_privileges( void )
+bool is_privileged_sid( const DOM_SID *sid )
 {
-       static int count;
+       SE_PRIV mask;
        
-       if ( count )
-               return count;
-
-       /* loop over the array and count it */  
-       for ( count=0; privs[count].se_priv != SE_END; count++ ) ;
-
-       return count;
+       return get_privileges( sid, &mask );
 }
 
 /*******************************************************************
 *******************************************************************/
 
-BOOL is_privileged_sid( DOM_SID *sid ) 
+bool grant_all_privileges( const DOM_SID *sid )
 {
-       int mask;
-
-       /* check if the lookup succeeds */
+       SE_PRIV mask;
 
-       return get_privileges( sid, &mask );
+       if (!se_priv_put_all_privileges(&mask)) {
+               return False;
+       }
+       
+       return grant_privilege( sid, &mask );
 }
-