s3-auth Fix spelling
[amitay/samba.git] / source3 / auth / auth_util.c
index ea95f33a86af9cab8f460916b3f065358d148202..fe4f4a3861a7b636dea000e6f05ea84fc9b991f7 100644 (file)
@@ -2,10 +2,10 @@
    Unix SMB/CIFS implementation.
    Authentication utility functions
    Copyright (C) Andrew Tridgell 1992-1998
-   Copyright (C) Andrew Bartlett 2001
+   Copyright (C) Andrew Bartlett 2001-2011
    Copyright (C) Jeremy Allison 2000-2001
    Copyright (C) Rafal Szczesniak 2002
-   Copyright (C) Volker Lendecke 2006
+   Copyright (C) Volker Lendecke 2006-2008
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 */
 
 #include "includes.h"
-#include "smbd/globals.h"
+#include "auth.h"
 #include "../libcli/auth/libcli_auth.h"
 #include "../lib/crypto/arcfour.h"
+#include "rpc_client/init_lsa.h"
+#include "../libcli/security/security.h"
+#include "../lib/util/util_pw.h"
+#include "lib/winbind_util.h"
+#include "passdb.h"
+#include "../librpc/gen_ndr/ndr_auth.h"
+#include "../auth/auth_sam_reply.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH
 
-/****************************************************************************
- Ensure primary group SID is always at position 0 in a 
- auth_serversupplied_info struct.
-****************************************************************************/
-
-static void sort_sid_array_for_smbd(struct auth_serversupplied_info *result,
-                               const struct dom_sid *pgroup_sid)
-{
-       unsigned int i;
-
-       if (!result->sids) {
-               return;
-       }
-
-       if (sid_compare(&result->sids[0], pgroup_sid)==0) {
-               return;
-       }
-
-       for (i = 1; i < result->num_sids; i++) {
-               if (sid_compare(pgroup_sid,
-                               &result->sids[i]) == 0) {
-                       sid_copy(&result->sids[i], &result->sids[0]);
-                       sid_copy(&result->sids[0], pgroup_sid);
-                       return;
-               }
-       }
-}
-
 /****************************************************************************
  Create a UNIX user on demand.
 ****************************************************************************/
@@ -112,19 +91,23 @@ NTSTATUS make_user_info_map(struct auth_usersupplied_info **user_info,
                            const char *smb_name,
                            const char *client_domain,
                            const char *workstation_name,
+                           const struct tsocket_address *remote_address,
                            DATA_BLOB *lm_pwd,
                            DATA_BLOB *nt_pwd,
-                           DATA_BLOB *lm_interactive_pwd,
-                           DATA_BLOB *nt_interactive_pwd,
-                           DATA_BLOB *plaintext,
-                           bool encrypted)
+                           const struct samr_Password *lm_interactive_pwd,
+                           const struct samr_Password *nt_interactive_pwd,
+                           const char *plaintext,
+                           enum auth_password_state password_state)
 {
        const char *domain;
        NTSTATUS result;
        bool was_mapped;
-       fstring internal_username;
-       fstrcpy(internal_username, smb_name);
-       was_mapped = map_username(internal_username);
+       char *internal_username = NULL;
+
+       was_mapped = map_username(talloc_tos(), smb_name, &internal_username);
+       if (!internal_username) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        DEBUG(5, ("Mapping user [%s]\\[%s] from workstation [%s]\n",
                 client_domain, smb_name, workstation_name));
@@ -157,10 +140,13 @@ NTSTATUS make_user_info_map(struct auth_usersupplied_info **user_info,
 
        result = make_user_info(user_info, smb_name, internal_username,
                              client_domain, domain, workstation_name,
-                             lm_pwd, nt_pwd,
+                             remote_address, lm_pwd, nt_pwd,
                              lm_interactive_pwd, nt_interactive_pwd,
-                             plaintext, encrypted);
+                             plaintext, password_state);
        if (NT_STATUS_IS_OK(result)) {
+               /* We have tried mapping */
+               (*user_info)->mapped_state = True;
+               /* did we actually map the user to a different name? */
                (*user_info)->was_mapped = was_mapped;
        }
        return result;
@@ -175,6 +161,7 @@ bool make_user_info_netlogon_network(struct auth_usersupplied_info **user_info,
                                     const char *smb_name, 
                                     const char *client_domain, 
                                     const char *workstation_name,
+                                    const struct tsocket_address *remote_address,
                                     uint32 logon_parameters,
                                     const uchar *lm_network_pwd,
                                     int lm_pwd_len,
@@ -189,10 +176,11 @@ bool make_user_info_netlogon_network(struct auth_usersupplied_info **user_info,
        status = make_user_info_map(user_info,
                                    smb_name, client_domain, 
                                    workstation_name,
+                                   remote_address,
                                    lm_pwd_len ? &lm_blob : NULL, 
                                    nt_pwd_len ? &nt_blob : NULL,
                                    NULL, NULL, NULL,
-                                   True);
+                                   AUTH_PASSWORD_RESPONSE);
 
        if (NT_STATUS_IS_OK(status)) {
                (*user_info)->logon_parameters = logon_parameters;
@@ -213,14 +201,15 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
                                         const char *smb_name, 
                                         const char *client_domain, 
                                         const char *workstation_name,
+                                        const struct tsocket_address *remote_address,
                                         uint32 logon_parameters,
                                         const uchar chal[8], 
                                         const uchar lm_interactive_pwd[16], 
                                         const uchar nt_interactive_pwd[16], 
                                         const uchar *dc_sess_key)
 {
-       unsigned char lm_pwd[16];
-       unsigned char nt_pwd[16];
+       struct samr_Password lm_pwd;
+       struct samr_Password nt_pwd;
        unsigned char local_lm_response[24];
        unsigned char local_nt_response[24];
        unsigned char key[16];
@@ -228,42 +217,42 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
        memcpy(key, dc_sess_key, 16);
 
        if (lm_interactive_pwd)
-               memcpy(lm_pwd, lm_interactive_pwd, sizeof(lm_pwd));
+               memcpy(lm_pwd.hash, lm_interactive_pwd, sizeof(lm_pwd.hash));
 
        if (nt_interactive_pwd)
-               memcpy(nt_pwd, nt_interactive_pwd, sizeof(nt_pwd));
+               memcpy(nt_pwd.hash, nt_interactive_pwd, sizeof(nt_pwd.hash));
 
 #ifdef DEBUG_PASSWORD
        DEBUG(100,("key:"));
        dump_data(100, key, sizeof(key));
 
        DEBUG(100,("lm owf password:"));
-       dump_data(100, lm_pwd, sizeof(lm_pwd));
+       dump_data(100, lm_pwd.hash, sizeof(lm_pwd.hash));
 
        DEBUG(100,("nt owf password:"));
-       dump_data(100, nt_pwd, sizeof(nt_pwd));
+       dump_data(100, nt_pwd.hash, sizeof(nt_pwd.hash));
 #endif
 
        if (lm_interactive_pwd)
-               arcfour_crypt(lm_pwd, key, sizeof(lm_pwd));
+               arcfour_crypt(lm_pwd.hash, key, sizeof(lm_pwd.hash));
 
        if (nt_interactive_pwd)
-               arcfour_crypt(nt_pwd, key, sizeof(nt_pwd));
+               arcfour_crypt(nt_pwd.hash, key, sizeof(nt_pwd.hash));
 
 #ifdef DEBUG_PASSWORD
        DEBUG(100,("decrypt of lm owf password:"));
-       dump_data(100, lm_pwd, sizeof(lm_pwd));
+       dump_data(100, lm_pwd.hash, sizeof(lm_pwd));
 
        DEBUG(100,("decrypt of nt owf password:"));
-       dump_data(100, nt_pwd, sizeof(nt_pwd));
+       dump_data(100, nt_pwd.hash, sizeof(nt_pwd));
 #endif
 
        if (lm_interactive_pwd)
-               SMBOWFencrypt(lm_pwd, chal,
+               SMBOWFencrypt(lm_pwd.hash, chal,
                              local_lm_response);
 
        if (nt_interactive_pwd)
-               SMBOWFencrypt(nt_pwd, chal,
+               SMBOWFencrypt(nt_pwd.hash, chal,
                              local_nt_response);
 
        /* Password info paranoia */
@@ -275,33 +264,25 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
                DATA_BLOB local_lm_blob;
                DATA_BLOB local_nt_blob;
 
-               DATA_BLOB lm_interactive_blob;
-               DATA_BLOB nt_interactive_blob;
-
                if (lm_interactive_pwd) {
                        local_lm_blob = data_blob(local_lm_response,
                                                  sizeof(local_lm_response));
-                       lm_interactive_blob = data_blob(lm_pwd,
-                                                       sizeof(lm_pwd));
-                       ZERO_STRUCT(lm_pwd);
                }
 
                if (nt_interactive_pwd) {
                        local_nt_blob = data_blob(local_nt_response,
                                                  sizeof(local_nt_response));
-                       nt_interactive_blob = data_blob(nt_pwd,
-                                                       sizeof(nt_pwd));
-                       ZERO_STRUCT(nt_pwd);
                }
 
                nt_status = make_user_info_map(
                        user_info, 
                        smb_name, client_domain, workstation_name,
+                       remote_address,
                        lm_interactive_pwd ? &local_lm_blob : NULL,
                        nt_interactive_pwd ? &local_nt_blob : NULL,
-                       lm_interactive_pwd ? &lm_interactive_blob : NULL,
-                       nt_interactive_pwd ? &nt_interactive_blob : NULL,
-                       NULL, True);
+                       lm_interactive_pwd ? &lm_pwd : NULL,
+                       nt_interactive_pwd ? &nt_pwd : NULL,
+                       NULL, AUTH_PASSWORD_HASH);
 
                if (NT_STATUS_IS_OK(nt_status)) {
                        (*user_info)->logon_parameters = logon_parameters;
@@ -310,8 +291,6 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
                ret = NT_STATUS_IS_OK(nt_status) ? True : False;
                data_blob_free(&local_lm_blob);
                data_blob_free(&local_nt_blob);
-               data_blob_free(&lm_interactive_blob);
-               data_blob_free(&nt_interactive_blob);
                return ret;
        }
 }
@@ -324,6 +303,7 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
 bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
                              const char *smb_name, 
                              const char *client_domain,
+                             const struct tsocket_address *remote_address,
                              const uint8 chal[8],
                              DATA_BLOB plaintext_password)
 {
@@ -331,14 +311,13 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
        DATA_BLOB local_lm_blob;
        DATA_BLOB local_nt_blob;
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
-
+       char *plaintext_password_string;
        /*
         * Not encrypted - do so.
         */
 
        DEBUG(5,("make_user_info_for_reply: User passwords not in encrypted "
                 "format.\n"));
-
        if (plaintext_password.data && plaintext_password.length) {
                unsigned char local_lm_response[24];
 
@@ -361,14 +340,27 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
                local_nt_blob = data_blob_null; 
        }
 
+       plaintext_password_string = talloc_strndup(talloc_tos(),
+                                                  (const char *)plaintext_password.data,
+                                                  plaintext_password.length);
+       if (!plaintext_password_string) {
+               return False;
+       }
+
        ret = make_user_info_map(
                user_info, smb_name, client_domain, 
                get_remote_machine_name(),
+               remote_address,
                local_lm_blob.data ? &local_lm_blob : NULL,
                local_nt_blob.data ? &local_nt_blob : NULL,
                NULL, NULL,
-               plaintext_password.data && plaintext_password.length ? &plaintext_password : NULL, 
-               False);
+               plaintext_password_string,
+               AUTH_PASSWORD_PLAIN);
+
+       if (plaintext_password_string) {
+               memset(plaintext_password_string, '\0', strlen(plaintext_password_string));
+               talloc_free(plaintext_password_string);
+       }
 
        data_blob_free(&local_lm_blob);
        return NT_STATUS_IS_OK(ret) ? True : False;
@@ -380,23 +372,26 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
 
 NTSTATUS make_user_info_for_reply_enc(struct auth_usersupplied_info **user_info,
                                       const char *smb_name,
-                                      const char *client_domain, 
+                                      const char *client_domain,
+                                     const struct tsocket_address *remote_address,
                                       DATA_BLOB lm_resp, DATA_BLOB nt_resp)
 {
        return make_user_info_map(user_info, smb_name, 
                                  client_domain, 
-                                 get_remote_machine_name(), 
-                                 lm_resp.data ? &lm_resp : NULL, 
-                                 nt_resp.data ? &nt_resp : NULL, 
+                                 get_remote_machine_name(),
+                                 remote_address,
+                                 lm_resp.data && (lm_resp.length > 0) ? &lm_resp : NULL,
+                                 nt_resp.data && (nt_resp.length > 0) ? &nt_resp : NULL,
                                  NULL, NULL, NULL,
-                                 True);
+                                 AUTH_PASSWORD_RESPONSE);
 }
 
 /****************************************************************************
- Create a guest user_info blob, for anonymous authenticaion.
+ Create a guest user_info blob, for anonymous authentication.
 ****************************************************************************/
 
-bool make_user_info_guest(struct auth_usersupplied_info **user_info)
+bool make_user_info_guest(const struct tsocket_address *remote_address,
+                         struct auth_usersupplied_info **user_info)
 {
        NTSTATUS nt_status;
 
@@ -404,15 +399,16 @@ bool make_user_info_guest(struct auth_usersupplied_info **user_info)
                                   "","", 
                                   "","", 
                                   "", 
+                                  remote_address,
                                   NULL, NULL, 
                                   NULL, NULL, 
                                   NULL,
-                                  True);
+                                  AUTH_PASSWORD_RESPONSE);
 
        return NT_STATUS_IS_OK(nt_status) ? True : False;
 }
 
-static NTSTATUS log_nt_token(NT_USER_TOKEN *token)
+static NTSTATUS log_nt_token(struct security_token *token)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        char *command;
@@ -429,12 +425,12 @@ static NTSTATUS log_nt_token(NT_USER_TOKEN *token)
        for (i=1; i<token->num_sids; i++) {
                group_sidstr = talloc_asprintf(
                        frame, "%s %s", group_sidstr,
-                       sid_string_talloc(frame, &token->user_sids[i]));
+                       sid_string_talloc(frame, &token->sids[i]));
        }
 
        command = talloc_string_sub(
                frame, lp_log_nt_token_command(),
-               "%s", sid_string_talloc(frame, &token->user_sids[0]));
+               "%s", sid_string_talloc(frame, &token->sids[0]));
        command = talloc_string_sub(frame, command, "%t", group_sidstr);
 
        if (command == NULL) {
@@ -458,11 +454,105 @@ static NTSTATUS log_nt_token(NT_USER_TOKEN *token)
  * server_info->sids (the info3/sam groups). Find the unix gids.
  */
 
-NTSTATUS create_local_token(struct auth_serversupplied_info *server_info)
+NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
+                           const struct auth_serversupplied_info *server_info,
+                           DATA_BLOB *session_key,
+                           struct auth_session_info **session_info_out)
 {
+       struct security_token *t;
        NTSTATUS status;
        size_t i;
        struct dom_sid tmp_sid;
+       struct auth_session_info *session_info;
+       struct wbcUnixId *ids;
+
+       /* Ensure we can't possible take a code path leading to a
+        * null defref. */
+       if (!server_info) {
+               return NT_STATUS_LOGON_FAILURE;
+       }
+
+       session_info = talloc_zero(mem_ctx, struct auth_session_info);
+       if (!session_info) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       session_info->unix_token = talloc_zero(session_info, struct security_unix_token);
+       if (!session_info->unix_token) {
+               TALLOC_FREE(session_info);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       session_info->unix_token->uid = server_info->utok.uid;
+       session_info->unix_token->gid = server_info->utok.gid;
+
+       session_info->unix_info = talloc_zero(session_info, struct auth_user_info_unix);
+       if (!session_info->unix_info) {
+               TALLOC_FREE(session_info);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       session_info->unix_info->unix_name = talloc_strdup(session_info, server_info->unix_name);
+       if (!session_info->unix_info->unix_name) {
+               TALLOC_FREE(session_info);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       session_info->unix_info->sanitized_username = talloc_strdup(session_info, server_info->sanitized_username);
+       if (!session_info->unix_info->sanitized_username) {
+               TALLOC_FREE(session_info);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       session_info->unix_info->system = server_info->system;
+
+       if (session_key) {
+               data_blob_free(&session_info->session_key);
+               session_info->session_key = data_blob_talloc(session_info,
+                                                                 session_key->data,
+                                                                 session_key->length);
+               if (!session_info->session_key.data && session_key->length) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+       } else {
+               session_info->session_key = data_blob_talloc( session_info, server_info->session_key.data,
+                                                             server_info->session_key.length);
+       }
+
+       if (session_info->security_token) {
+               /* Just copy the token, it has already been finalised
+                * (nasty hack to support a cached guest session_info,
+                * and a possible strategy for auth_samba4 to pass in
+                * a finalised session) */
+
+               session_info->security_token = dup_nt_token(session_info, server_info->security_token);
+               if (!session_info->security_token) {
+                       TALLOC_FREE(session_info);
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               session_info->unix_token->ngroups = server_info->utok.ngroups;
+               if (server_info->utok.ngroups != 0) {
+                       session_info->unix_token->groups = (gid_t *)talloc_memdup(
+                               session_info->unix_token, server_info->utok.groups,
+                               sizeof(gid_t)*session_info->unix_token->ngroups);
+               } else {
+                       session_info->unix_token->groups = NULL;
+               }
+
+               *session_info_out = session_info;
+               return NT_STATUS_OK;
+       }
+
+       /* We need to populate session_info->info with the information found in server_info->info3 */
+       status = make_user_info_SamBaseInfo(session_info, "", &server_info->info3->base,
+                                           server_info->guest == false,
+                                           &session_info->info);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("conversion of info3 into auth_user_info failed!\n"));
+               TALLOC_FREE(session_info);
+               return status;
+       }
 
        /*
         * If winbind is not around, we can not make much use of the SIDs the
@@ -472,20 +562,20 @@ NTSTATUS create_local_token(struct auth_serversupplied_info *server_info)
 
        if (((lp_server_role() == ROLE_DOMAIN_MEMBER) && !winbind_ping()) ||
            (server_info->nss_token)) {
-               status = create_token_from_username(server_info,
+               status = create_token_from_username(session_info,
                                                    server_info->unix_name,
                                                    server_info->guest,
-                                                   &server_info->utok.uid,
-                                                   &server_info->utok.gid,
-                                                   &server_info->unix_name,
-                                                   &server_info->ptok);
+                                                   &session_info->unix_token->uid,
+                                                   &session_info->unix_token->gid,
+                                                   &session_info->unix_info->unix_name,
+                                                   &session_info->security_token);
 
        } else {
-               status = create_local_nt_token_from_info3(server_info,
+               status = create_local_nt_token_from_info3(session_info,
                                                          server_info->guest,
                                                          server_info->info3,
                                                          &server_info->extra,
-                                                         &server_info->ptok);
+                                                         &session_info->security_token);
        }
 
        if (!NT_STATUS_IS_OK(status)) {
@@ -494,23 +584,37 @@ NTSTATUS create_local_token(struct auth_serversupplied_info *server_info)
 
        /* Convert the SIDs to gids. */
 
-       server_info->utok.ngroups = 0;
-       server_info->utok.groups = NULL;
+       session_info->unix_token->ngroups = 0;
+       session_info->unix_token->groups = NULL;
+
+       t = session_info->security_token;
+
+       ids = talloc_array(talloc_tos(), struct wbcUnixId,
+                          t->num_sids);
+       if (ids == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       if (!sids_to_unix_ids(t->sids, t->num_sids, ids)) {
+               TALLOC_FREE(ids);
+               return NT_STATUS_NO_MEMORY;
+       }
 
        /* Start at index 1, where the groups start. */
 
-       for (i=1; i<server_info->ptok->num_sids; i++) {
-               gid_t gid;
-               struct dom_sid *sid = &server_info->ptok->user_sids[i];
+       for (i=1; i<t->num_sids; i++) {
 
-               if (!sid_to_gid(sid, &gid)) {
+               if (ids[i].type != WBC_ID_TYPE_GID) {
                        DEBUG(10, ("Could not convert SID %s to gid, "
-                                  "ignoring it\n", sid_string_dbg(sid)));
+                                  "ignoring it\n",
+                                  sid_string_dbg(&t->sids[i])));
                        continue;
                }
-               add_gid_to_array_unique(server_info, gid,
-                                       &server_info->utok.groups,
-                                       &server_info->utok.ngroups);
+               if (!add_gid_to_array_unique(session_info, ids[i].id.gid,
+                                            &session_info->unix_token->groups,
+                                            &session_info->unix_token->ngroups)) {
+                       return NT_STATUS_NO_MEMORY;
+               }
        }
 
        /*
@@ -526,34 +630,33 @@ NTSTATUS create_local_token(struct auth_serversupplied_info *server_info)
         * the nt token.
         */
 
-       if (!uid_to_unix_users_sid(server_info->utok.uid, &tmp_sid)) {
-               DEBUG(1,("create_local_token: Failed to create SID "
-                       "for uid %u!\n", (unsigned int)server_info->utok.uid));
-       }
-       add_sid_to_array_unique(server_info->ptok, &tmp_sid,
-                               &server_info->ptok->user_sids,
-                               &server_info->ptok->num_sids);
+       uid_to_unix_users_sid(session_info->unix_token->uid, &tmp_sid);
 
-       for ( i=0; i<server_info->utok.ngroups; i++ ) {
-               if (!gid_to_unix_groups_sid( server_info->utok.groups[i], &tmp_sid ) ) {
-                       DEBUG(1,("create_local_token: Failed to create SID "
-                               "for gid %u!\n", (unsigned int)server_info->utok.groups[i]));
-                       continue;
-               }
-               add_sid_to_array_unique(server_info->ptok, &tmp_sid,
-                                       &server_info->ptok->user_sids,
-                                       &server_info->ptok->num_sids);
+       add_sid_to_array_unique(session_info->security_token, &tmp_sid,
+                               &session_info->security_token->sids,
+                               &session_info->security_token->num_sids);
+
+       for ( i=0; i<session_info->unix_token->ngroups; i++ ) {
+               gid_to_unix_groups_sid(session_info->unix_token->groups[i], &tmp_sid);
+               add_sid_to_array_unique(session_info->security_token, &tmp_sid,
+                                       &session_info->security_token->sids,
+                                       &session_info->security_token->num_sids);
        }
 
-       debug_nt_user_token(DBGC_AUTH, 10, server_info->ptok);
+       security_token_debug(DBGC_AUTH, 10, session_info->security_token);
        debug_unix_user_token(DBGC_AUTH, 10,
-                             server_info->utok.uid,
-                             server_info->utok.gid,
-                             server_info->utok.ngroups,
-                             server_info->utok.groups);
+                             session_info->unix_token->uid,
+                             session_info->unix_token->gid,
+                             session_info->unix_token->ngroups,
+                             session_info->unix_token->groups);
 
-       status = log_nt_token(server_info->ptok);
-       return status;
+       status = log_nt_token(session_info->security_token);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       *session_info_out = session_info;
+       return NT_STATUS_OK;
 }
 
 /***************************************************************************
@@ -567,7 +670,6 @@ NTSTATUS make_server_info_pw(struct auth_serversupplied_info **server_info,
 {
        NTSTATUS status;
        struct samu *sampass = NULL;
-       gid_t *gids;
        char *qualified_name = NULL;
        TALLOC_CTX *mem_ctx = NULL;
        struct dom_sid u_sid;
@@ -636,23 +738,21 @@ NTSTATUS make_server_info_pw(struct auth_serversupplied_info **server_info,
                return NT_STATUS_NO_MEMORY;
        }
 
-       status = samu_to_SamInfo3(result, sampass, global_myname(),
+       status = samu_to_SamInfo3(result, sampass, lp_netbios_name(),
                                  &result->info3, &result->extra);
+       TALLOC_FREE(sampass);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("Failed to convert samu to info3: %s\n",
                           nt_errstr(status)));
-               TALLOC_FREE(sampass);
                TALLOC_FREE(result);
                return status;
        }
 
-
        result->unix_name = talloc_strdup(result, unix_username);
        result->sanitized_username = sanitize_username(result, unix_username);
 
        if ((result->unix_name == NULL)
            || (result->sanitized_username == NULL)) {
-               TALLOC_FREE(sampass);
                TALLOC_FREE(result);
                return NT_STATUS_NO_MEMORY;
        }
@@ -660,36 +760,58 @@ NTSTATUS make_server_info_pw(struct auth_serversupplied_info **server_info,
        result->utok.uid = pwd->pw_uid;
        result->utok.gid = pwd->pw_gid;
 
-       status = pdb_enum_group_memberships(result, sampass,
-                                           &result->sids, &gids,
-                                           &result->num_sids);
+       *server_info = result;
+
+       return NT_STATUS_OK;
+}
 
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("pdb_enum_group_memberships failed: %s\n",
-                          nt_errstr(status)));
-               TALLOC_FREE(sampass);
-               TALLOC_FREE(result);
-               return status;
+static NTSTATUS get_guest_info3(TALLOC_CTX *mem_ctx,
+                               struct netr_SamInfo3 *info3)
+{
+       const char *guest_account = lp_guestaccount();
+       struct dom_sid domain_sid;
+       struct passwd *pwd;
+       const char *tmp;
+
+       pwd = Get_Pwnam_alloc(mem_ctx, guest_account);
+       if (pwd == NULL) {
+               DEBUG(0,("SamInfo3_for_guest: Unable to locate guest "
+                        "account [%s]!\n", guest_account));
+               return NT_STATUS_NO_SUCH_USER;
        }
 
-       TALLOC_FREE(sampass);
+       /* Set account name */
+       tmp = talloc_strdup(mem_ctx, pwd->pw_name);
+       if (tmp == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       init_lsa_String(&info3->base.account_name, tmp);
 
-       /* FIXME: add to info3 too ? */
-       status = add_sid_to_array_unique(result, &u_sid,
-                                        &result->sids,
-                                        &result->num_sids);
-       if (!NT_STATUS_IS_OK(status)) {
-               TALLOC_FREE(result);
-               return status;
+       /* Set domain name */
+       tmp = talloc_strdup(mem_ctx, get_global_sam_name());
+       if (tmp == NULL) {
+               return NT_STATUS_NO_MEMORY;
        }
+       init_lsa_StringLarge(&info3->base.domain, tmp);
 
-       /* For now we throw away the gids and convert via sid_to_gid
-        * later. This needs fixing, but I'd like to get the code straight and
-        * simple first. */
-       TALLOC_FREE(gids);
+       /* Domain sid */
+       sid_copy(&domain_sid, get_global_sam_sid());
 
-       *server_info = result;
+       info3->base.domain_sid = dom_sid_dup(mem_ctx, &domain_sid);
+       if (info3->base.domain_sid == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* Guest rid */
+       info3->base.rid = DOMAIN_RID_GUEST;
+
+       /* Primary gid */
+       info3->base.primary_gid = BUILTIN_RID_GUESTS;
+
+       /* Set as guest */
+       info3->base.user_flags = NETLOGON_GUEST;
 
+       TALLOC_FREE(pwd);
        return NT_STATUS_OK;
 }
 
@@ -697,104 +819,131 @@ NTSTATUS make_server_info_pw(struct auth_serversupplied_info **server_info,
  Make (and fill) a user_info struct for a guest login.
  This *must* succeed for smbd to start. If there is no mapping entry for
  the guest gid, then create one.
+
+ The resulting structure is a 'session_info' because
+ create_local_token() has already been called on it.  This is quite
+ nasty, as the auth subsystem isn't expect this, but the behavior is
+ left as-is for now.
 ***************************************************************************/
 
-static NTSTATUS make_new_server_info_guest(struct auth_serversupplied_info **server_info)
+static NTSTATUS make_new_session_info_guest(struct auth_session_info **session_info, struct auth_serversupplied_info **server_info)
 {
+       static const char zeros[16] = {0};
+       const char *guest_account = lp_guestaccount();
+       const char *domain = lp_netbios_name();
+       struct netr_SamInfo3 info3;
+       TALLOC_CTX *tmp_ctx;
        NTSTATUS status;
-       struct samu *sampass = NULL;
-       struct dom_sid guest_sid;
-       bool ret;
-       static const char zeros[16] = {0, };
        fstring tmp;
 
-       if ( !(sampass = samu_new( NULL )) ) {
+       tmp_ctx = talloc_stackframe();
+       if (tmp_ctx == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       sid_compose(&guest_sid, get_global_sam_sid(), DOMAIN_RID_GUEST);
-
-       become_root();
-       ret = pdb_getsampwsid(sampass, &guest_sid);
-       unbecome_root();
+       ZERO_STRUCT(info3);
 
-       if (!ret) {
-               TALLOC_FREE(sampass);
-               return NT_STATUS_NO_SUCH_USER;
+       status = get_guest_info3(tmp_ctx, &info3);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("get_guest_info3 failed with %s\n",
+                         nt_errstr(status)));
+               goto done;
        }
 
-       status = make_server_info_sam(server_info, sampass);
+       status = make_server_info_info3(tmp_ctx,
+                                       guest_account,
+                                       domain,
+                                       server_info,
+                                       &info3);
        if (!NT_STATUS_IS_OK(status)) {
-               TALLOC_FREE(sampass);
-               return status;
+               DEBUG(0, ("make_server_info_info3 failed with %s\n",
+                         nt_errstr(status)));
+               goto done;
        }
 
-       TALLOC_FREE(sampass);
-
        (*server_info)->guest = True;
 
-       status = create_local_token(*server_info);
+       /* This should not be done here (we should produce a server
+        * info, and later construct a session info from it), but for
+        * now this does not change the previous behavior */
+       status = create_local_token(tmp_ctx, *server_info, NULL, session_info);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("create_local_token failed: %s\n",
-                          nt_errstr(status)));
-               return status;
+               DEBUG(0, ("create_local_token failed: %s\n",
+                         nt_errstr(status)));
+               goto done;
        }
+       talloc_steal(NULL, *session_info);
+       talloc_steal(NULL, *server_info);
 
        /* annoying, but the Guest really does have a session key, and it is
           all zeros! */
-       (*server_info)->user_session_key = data_blob(zeros, sizeof(zeros));
-       (*server_info)->lm_session_key = data_blob(zeros, sizeof(zeros));
+       (*session_info)->session_key = data_blob(zeros, sizeof(zeros));
 
        alpha_strcpy(tmp, (*server_info)->info3->base.account_name.string,
                     ". _-$", sizeof(tmp));
-       (*server_info)->sanitized_username = talloc_strdup(*server_info, tmp);
+       (*session_info)->unix_info->sanitized_username = talloc_strdup(*session_info, tmp);
 
-       return NT_STATUS_OK;
+       status = NT_STATUS_OK;
+done:
+       TALLOC_FREE(tmp_ctx);
+       return status;
 }
 
 /***************************************************************************
- Make (and fill) a user_info struct for a system user login.
+ Make (and fill) a auth_session_info struct for a system user login.
  This *must* succeed for smbd to start.
 ***************************************************************************/
 
-static NTSTATUS make_new_server_info_system(TALLOC_CTX *mem_ctx,
-                                           struct auth_serversupplied_info **server_info)
+static NTSTATUS make_new_session_info_system(TALLOC_CTX *mem_ctx,
+                                           struct auth_session_info **session_info)
 {
        struct passwd *pwd;
        NTSTATUS status;
 
        pwd = getpwuid_alloc(mem_ctx, sec_initial_uid());
        if (pwd == NULL) {
-               return NT_STATUS_NO_MEMORY;
+               return NT_STATUS_NO_SUCH_USER;
        }
 
-       status = make_serverinfo_from_username(mem_ctx,
-                                            pwd->pw_name,
-                                            false,
-                                            server_info);
+       status = make_session_info_from_username(mem_ctx,
+                                                pwd->pw_name,
+                                                false,
+                                                session_info);
+       TALLOC_FREE(pwd);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
 
-       (*server_info)->system = true;
+       (*session_info)->unix_info->system = true;
+
+       status = add_sid_to_array_unique((*session_info)->security_token->sids,
+                                        &global_sid_System,
+                                        &(*session_info)->security_token->sids,
+                                        &(*session_info)->security_token->num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
+               TALLOC_FREE((*session_info));
+               return status;
+       }
 
        return NT_STATUS_OK;
 }
 
 /****************************************************************************
-  Fake a auth_serversupplied_info just from a username
+  Fake a auth_session_info just from a username (as a
+  session_info structure, with create_local_token() already called on
+  it.
 ****************************************************************************/
 
-NTSTATUS make_serverinfo_from_username(TALLOC_CTX *mem_ctx,
-                                      const char *username,
-                                      bool is_guest,
-                                      struct auth_serversupplied_info **presult)
+NTSTATUS make_session_info_from_username(TALLOC_CTX *mem_ctx,
+                                        const char *username,
+                                        bool is_guest,
+                                        struct auth_session_info **session_info)
 {
        struct auth_serversupplied_info *result;
        struct passwd *pwd;
        NTSTATUS status;
 
-       pwd = getpwnam_alloc(talloc_tos(), username);
+       pwd = Get_Pwnam_alloc(talloc_tos(), username);
        if (pwd == NULL) {
                return NT_STATUS_NO_SUCH_USER;
        }
@@ -810,20 +959,28 @@ NTSTATUS make_serverinfo_from_username(TALLOC_CTX *mem_ctx,
        result->nss_token = true;
        result->guest = is_guest;
 
-       status = create_local_token(result);
-
-       if (!NT_STATUS_IS_OK(status)) {
-               TALLOC_FREE(result);
-               return status;
-       }
-
-       *presult = result;
-       return NT_STATUS_OK;
+       /* Now turn the server_info into a session_info with the full token etc */
+       status = create_local_token(mem_ctx, result, NULL, session_info);
+       talloc_free(result);
+       return status;
 }
 
-
-struct auth_serversupplied_info *copy_serverinfo(TALLOC_CTX *mem_ctx,
-                                                const struct auth_serversupplied_info *src)
+/* This function MUST only used to create the cached server_info for
+ * guest.
+ *
+ * This is a lossy conversion.  Variables known to be lost so far
+ * include:
+ *
+ * - nss_token (not needed because the only read doesn't happen
+ * for the GUEST user, as this routine populates ->security_token
+ *
+ * - extra (not needed because the guest account must have valid RIDs per the output of get_guest_info3())
+ *
+ * - The 'server_info' parameter allows the missing 'info3' to be copied across.
+ */
+static struct auth_serversupplied_info *copy_session_info_serverinfo_guest(TALLOC_CTX *mem_ctx,
+                                                                          const struct auth_session_info *src,
+                                                                          struct auth_serversupplied_info *server_info)
 {
        struct auth_serversupplied_info *dst;
 
@@ -832,48 +989,60 @@ struct auth_serversupplied_info *copy_serverinfo(TALLOC_CTX *mem_ctx,
                return NULL;
        }
 
-       dst->guest = src->guest;
-       dst->system = src->system;
-       dst->utok.uid = src->utok.uid;
-       dst->utok.gid = src->utok.gid;
-       dst->utok.ngroups = src->utok.ngroups;
-       if (src->utok.ngroups != 0) {
-               dst->utok.groups = (gid_t *)TALLOC_MEMDUP(
-                       dst, src->utok.groups,
+       /* This element must be provided to convert back to an auth_serversupplied_info */
+       SMB_ASSERT(src->unix_info);
+
+       dst->guest = true;
+       dst->system = false;
+
+       /* This element must be provided to convert back to an
+        * auth_serversupplied_info.  This needs to be from the
+        * auth_session_info because the group values in particular
+        * may change during create_local_token() processing */
+       SMB_ASSERT(src->unix_token);
+       dst->utok.uid = src->unix_token->uid;
+       dst->utok.gid = src->unix_token->gid;
+       dst->utok.ngroups = src->unix_token->ngroups;
+       if (src->unix_token->ngroups != 0) {
+               dst->utok.groups = (gid_t *)talloc_memdup(
+                       dst, src->unix_token->groups,
                        sizeof(gid_t)*dst->utok.ngroups);
        } else {
                dst->utok.groups = NULL;
        }
 
-       if (src->ptok) {
-               dst->ptok = dup_nt_token(dst, src->ptok);
-               if (!dst->ptok) {
-                       TALLOC_FREE(dst);
-                       return NULL;
-               }
+       /* We must have a security_token as otherwise the lossy
+        * conversion without nss_token would cause create_local_token
+        * to take the wrong path */
+       SMB_ASSERT(src->security_token);
+
+       dst->security_token = dup_nt_token(dst, src->security_token);
+       if (!dst->security_token) {
+               TALLOC_FREE(dst);
+               return NULL;
        }
 
-       dst->user_session_key = data_blob_talloc( dst, src->user_session_key.data,
-                                               src->user_session_key.length);
+       dst->session_key = data_blob_talloc( dst, src->session_key.data,
+                                               src->session_key.length);
 
-       dst->lm_session_key = data_blob_talloc(dst, src->lm_session_key.data,
-                                               src->lm_session_key.length);
+       /* This is OK because this functions is only used for the
+        * GUEST account, which has all-zero keys for both values */
+       dst->lm_session_key = data_blob_talloc(dst, src->session_key.data,
+                                               src->session_key.length);
 
-       dst->info3 = copy_netr_SamInfo3(dst, src->info3);
+       dst->info3 = copy_netr_SamInfo3(dst, server_info->info3);
        if (!dst->info3) {
                TALLOC_FREE(dst);
                return NULL;
        }
-       dst->extra = src->extra;
 
-       dst->pam_handle = NULL;
-       dst->unix_name = talloc_strdup(dst, src->unix_name);
+       dst->unix_name = talloc_strdup(dst, src->unix_info->unix_name);
        if (!dst->unix_name) {
                TALLOC_FREE(dst);
                return NULL;
        }
 
-       dst->sanitized_username = talloc_strdup(dst, src->sanitized_username);
+       dst->sanitized_username = talloc_strdup(dst, src->unix_info->sanitized_username);
        if (!dst->sanitized_username) {
                TALLOC_FREE(dst);
                return NULL;
@@ -882,61 +1051,117 @@ struct auth_serversupplied_info *copy_serverinfo(TALLOC_CTX *mem_ctx,
        return dst;
 }
 
+struct auth_session_info *copy_session_info(TALLOC_CTX *mem_ctx,
+                                            const struct auth_session_info *src)
+{
+       struct auth_session_info *dst;
+       DATA_BLOB blob;
+       enum ndr_err_code ndr_err;
+
+       ndr_err = ndr_push_struct_blob(
+               &blob, talloc_tos(), src,
+               (ndr_push_flags_fn_t)ndr_push_auth_session_info);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               DEBUG(0, ("copy_session_info(): ndr_push_auth_session_info failed: "
+                          "%s\n", ndr_errstr(ndr_err)));
+               return NULL;
+       }
+
+       dst = talloc(mem_ctx, struct auth_session_info);
+       if (dst == NULL) {
+               DEBUG(0, ("talloc failed\n"));
+               TALLOC_FREE(blob.data);
+               return NULL;
+       }
+
+       ndr_err = ndr_pull_struct_blob(
+               &blob, dst, dst,
+               (ndr_pull_flags_fn_t)ndr_pull_auth_session_info);
+       TALLOC_FREE(blob.data);
+
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               DEBUG(0, ("copy_session_info(): ndr_pull_auth_session_info failed: "
+                          "%s\n", ndr_errstr(ndr_err)));
+               TALLOC_FREE(dst);
+               return NULL;
+       }
+
+       return dst;
+}
+
 /*
  * Set a new session key. Used in the rpc server where we have to override the
  * SMB level session key with SystemLibraryDTC
  */
 
-bool server_info_set_session_key(struct auth_serversupplied_info *info,
+bool session_info_set_session_key(struct auth_session_info *info,
                                 DATA_BLOB session_key)
 {
-       TALLOC_FREE(info->user_session_key.data);
+       TALLOC_FREE(info->session_key.data);
 
-       info->user_session_key = data_blob_talloc(
+       info->session_key = data_blob_talloc(
                info, session_key.data, session_key.length);
 
-       return (info->user_session_key.data != NULL);
+       return (info->session_key.data != NULL);
 }
 
-static struct auth_serversupplied_info *guest_info = NULL;
+static struct auth_session_info *guest_info = NULL;
+
+static struct auth_serversupplied_info *guest_server_info = NULL;
 
 bool init_guest_info(void)
 {
        if (guest_info != NULL)
                return True;
 
-       return NT_STATUS_IS_OK(make_new_server_info_guest(&guest_info));
+       return NT_STATUS_IS_OK(make_new_session_info_guest(&guest_info, &guest_server_info));
 }
 
 NTSTATUS make_server_info_guest(TALLOC_CTX *mem_ctx,
                                struct auth_serversupplied_info **server_info)
 {
-       *server_info = copy_serverinfo(mem_ctx, guest_info);
+       /* This is trickier than it would appear to need to be because
+        * we are trying to avoid certain costly operations when the
+        * structure is converted to a 'auth_session_info' again in
+        * create_local_token() */
+       *server_info = copy_session_info_serverinfo_guest(mem_ctx, guest_info, guest_server_info);
        return (*server_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 }
 
-static struct auth_serversupplied_info *system_info = NULL;
+NTSTATUS make_session_info_guest(TALLOC_CTX *mem_ctx,
+                               struct auth_session_info **session_info)
+{
+       *session_info = copy_session_info(mem_ctx, guest_info);
+       return (*session_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
+}
+
+static struct auth_session_info *system_info = NULL;
 
-bool init_system_info(void)
+NTSTATUS init_system_info(void)
 {
        if (system_info != NULL)
-               return True;
+               return NT_STATUS_OK;
 
-       return NT_STATUS_IS_OK(make_new_server_info_system(talloc_autofree_context(), &system_info));
+       return make_new_session_info_system(NULL, &system_info);
 }
 
-NTSTATUS make_server_info_system(TALLOC_CTX *mem_ctx,
-                               struct auth_serversupplied_info **server_info)
+NTSTATUS make_session_info_system(TALLOC_CTX *mem_ctx,
+                               struct auth_session_info **session_info)
 {
        if (system_info == NULL) return NT_STATUS_UNSUCCESSFUL;
-       *server_info = copy_serverinfo(mem_ctx, system_info);
-       return (*server_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
+       *session_info = copy_session_info(mem_ctx, system_info);
+       return (*session_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
+}
+
+const struct auth_session_info *get_session_info_system(void)
+{
+    return system_info;
 }
 
 bool copy_current_user(struct current_user *dst, struct current_user *src)
 {
        gid_t *groups;
-       NT_USER_TOKEN *nt_token;
+       struct security_token *nt_token;
 
        groups = (gid_t *)memdup(src->ut.groups,
                                 sizeof(gid_t) * src->ut.ngroups);
@@ -966,34 +1191,51 @@ bool copy_current_user(struct current_user *dst, struct current_user *src)
 
 static NTSTATUS check_account(TALLOC_CTX *mem_ctx, const char *domain,
                              const char *username, char **found_username,
-                             uid_t *uid, gid_t *gid,
+                             struct passwd **pwd,
                              bool *username_was_mapped)
 {
-       fstring dom_user, lower_username;
-       fstring real_username;
+       char *orig_dom_user = NULL;
+       char *dom_user = NULL;
+       char *lower_username = NULL;
+       char *real_username = NULL;
        struct passwd *passwd;
 
-       fstrcpy( lower_username, username );
+       lower_username = talloc_strdup(mem_ctx, username);
+       if (!lower_username) {
+               return NT_STATUS_NO_MEMORY;
+       }
        strlower_m( lower_username );
 
-       fstr_sprintf(dom_user, "%s%c%s", domain, *lp_winbind_separator(), 
-               lower_username);
+       orig_dom_user = talloc_asprintf(mem_ctx,
+                               "%s%c%s",
+                               domain,
+                               *lp_winbind_separator(),
+                               lower_username);
+       if (!orig_dom_user) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        /* Get the passwd struct.  Try to create the account if necessary. */
 
-       *username_was_mapped = map_username(dom_user);
+       *username_was_mapped = map_username(mem_ctx, orig_dom_user, &dom_user);
+       if (!dom_user) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-       passwd = smb_getpwnam( NULL, dom_user, real_username, True );
+       passwd = smb_getpwnam(mem_ctx, dom_user, &real_username, True );
        if (!passwd) {
                DEBUG(3, ("Failed to find authenticated user %s via "
                          "getpwnam(), denying access.\n", dom_user));
                return NT_STATUS_NO_SUCH_USER;
        }
 
-       *uid = passwd->pw_uid;
-       *gid = passwd->pw_gid;
+       if (!real_username) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       *pwd = passwd;
 
-       /* This is pointless -- there is no suport for differing 
+       /* This is pointless -- there is no support for differing
           unix and windows names.  Make sure to always store the 
           one we actually looked up and succeeded. Have I mentioned
           why I hate the 'winbind use default domain' parameter?   
@@ -1001,8 +1243,6 @@ static NTSTATUS check_account(TALLOC_CTX *mem_ctx, const char *domain,
 
        *found_username = talloc_strdup( mem_ctx, real_username );
 
-       TALLOC_FREE(passwd);
-
        return NT_STATUS_OK;
 }
 
@@ -1012,32 +1252,32 @@ static NTSTATUS check_account(TALLOC_CTX *mem_ctx, const char *domain,
  the username if we fallback to the username only.
  ****************************************************************************/
 
-struct passwd *smb_getpwnam( TALLOC_CTX *mem_ctx, char *domuser,
-                            fstring save_username, bool create )
+struct passwd *smb_getpwnam( TALLOC_CTX *mem_ctx, const char *domuser,
+                            char **p_save_username, bool create )
 {
        struct passwd *pw = NULL;
-       char *p;
-       fstring username;
+       char *p = NULL;
+       char *username = NULL;
 
        /* we only save a copy of the username it has been mangled 
           by winbindd use default domain */
-
-       save_username[0] = '\0';
+       *p_save_username = NULL;
 
        /* don't call map_username() here since it has to be done higher 
           up the stack so we don't call it multiple times */
 
-       fstrcpy( username, domuser );
+       username = talloc_strdup(mem_ctx, domuser);
+       if (!username) {
+               return NULL;
+       }
 
        p = strchr_m( username, *lp_winbind_separator() );
 
        /* code for a DOMAIN\user string */
 
        if ( p ) {
-               fstring strip_username;
-
                pw = Get_Pwnam_alloc( mem_ctx, domuser );
-               if ( pw ) {     
+               if ( pw ) {
                        /* make sure we get the case of the username correct */
                        /* work around 'winbind use default domain = yes' */
 
@@ -1048,12 +1288,20 @@ struct passwd *smb_getpwnam( TALLOC_CTX *mem_ctx, char *domuser,
                                *p = '\0';
                                domain = username;
 
-                               fstr_sprintf(save_username, "%s%c%s", domain, *lp_winbind_separator(), pw->pw_name);
+                               *p_save_username = talloc_asprintf(mem_ctx,
+                                                               "%s%c%s",
+                                                               domain,
+                                                               *lp_winbind_separator(),
+                                                               pw->pw_name);
+                               if (!*p_save_username) {
+                                       TALLOC_FREE(pw);
+                                       return NULL;
+                               }
+                       } else {
+                               *p_save_username = talloc_strdup(mem_ctx, pw->pw_name);
                        }
-                       else
-                               fstrcpy( save_username, pw->pw_name );
 
-                       /* whew -- done! */             
+                       /* whew -- done! */
                        return pw;
                }
 
@@ -1061,8 +1309,10 @@ struct passwd *smb_getpwnam( TALLOC_CTX *mem_ctx, char *domuser,
                /* remember that p and username are overlapping memory */
 
                p++;
-               fstrcpy( strip_username, p );
-               fstrcpy( username, strip_username );
+               username = talloc_strdup(mem_ctx, p);
+               if (!username) {
+                       return NULL;
+               }
        }
 
        /* just lookup a plain username */
@@ -1085,9 +1335,9 @@ struct passwd *smb_getpwnam( TALLOC_CTX *mem_ctx, char *domuser,
 
        /* one last check for a valid passwd struct */
 
-       if ( pw )
-               fstrcpy( save_username, pw->pw_name );
-
+       if (pw) {
+               *p_save_username = talloc_strdup(mem_ctx, pw->pw_name);
+       }
        return pw;
 }
 
@@ -1107,14 +1357,11 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
        char *found_username = NULL;
        const char *nt_domain;
        const char *nt_username;
-       struct dom_sid user_sid;
-       struct dom_sid group_sid;
        bool username_was_mapped;
-
-       uid_t uid = (uid_t)-1;
-       gid_t gid = (gid_t)-1;
-
+       struct passwd *pwd;
        struct auth_serversupplied_info *result;
+       struct dom_sid *group_sid;
+       struct netr_SamInfo3 *i3;
 
        /* 
           Here is where we should check the list of
@@ -1122,15 +1369,6 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
           matches.
        */
 
-       if (!sid_compose(&user_sid, info3->base.domain_sid, info3->base.rid)) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
-       if (!sid_compose(&group_sid, info3->base.domain_sid,
-                        info3->base.primary_gid)) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
        nt_username = talloc_strdup(mem_ctx, info3->base.account_name.string);
        if (!nt_username) {
                /* If the server didn't give us one, just use the one we sent
@@ -1159,7 +1397,7 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
        /* this call will try to create the user if necessary */
 
        nt_status = check_account(mem_ctx, nt_domain, sent_nt_username,
-                                    &found_username, &uid, &gid,
+                                    &found_username, &pwd,
                                     &username_was_mapped);
 
        if (!NT_STATUS_IS_OK(nt_status)) {
@@ -1182,36 +1420,49 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
        }
 
        /* copy in the info3 */
-       result->info3 = copy_netr_SamInfo3(result, info3);
+       result->info3 = i3 = copy_netr_SamInfo3(result, info3);
+       if (result->info3 == NULL) {
+               TALLOC_FREE(result);
+               return NT_STATUS_NO_MEMORY;
+       }
 
        /* Fill in the unix info we found on the way */
+       result->utok.uid = pwd->pw_uid;
+       result->utok.gid = pwd->pw_gid;
 
-       result->utok.uid = uid;
-       result->utok.gid = gid;
-
-       /* Create a 'combined' list of all SIDs we might want in the SD */
-
-       result->num_sids = 0;
-       result->sids = NULL;
-
-       nt_status = sid_array_from_info3(result, info3,
-                                        &result->sids,
-                                        &result->num_sids,
-                                        false, false);
+       /* We can't just trust that the primary group sid sent us is something
+        * we can really use. Obtain the usable sid, and store the original
+        * one as an additional group if it had to be replaced */
+       nt_status = get_primary_group_sid(mem_ctx, found_username,
+                                         &pwd, &group_sid);
        if (!NT_STATUS_IS_OK(nt_status)) {
                TALLOC_FREE(result);
                return nt_status;
        }
 
-       /* Ensure the primary group sid is at position 0. */
-       sort_sid_array_for_smbd(result, &group_sid);
+       /* store and check if it is the same we got originally */
+       sid_peek_rid(group_sid, &i3->base.primary_gid);
+       if (i3->base.primary_gid != info3->base.primary_gid) {
+               uint32_t n = i3->base.groups.count;
+               /* not the same, store the original as an additional group */
+               i3->base.groups.rids =
+                       talloc_realloc(i3, i3->base.groups.rids,
+                                       struct samr_RidWithAttribute, n + 1);
+               if (i3->base.groups.rids == NULL) {
+                       TALLOC_FREE(result);
+                       return NT_STATUS_NO_MEMORY;
+               }
+               i3->base.groups.rids[n].rid = info3->base.primary_gid;
+               i3->base.groups.rids[n].attributes = SE_GROUP_ENABLED;
+               i3->base.groups.count = n + 1;
+       }
 
        /* ensure we are never given NULL session keys */
 
        if (memcmp(info3->base.key.key, zeros, sizeof(zeros)) == 0) {
-               result->user_session_key = data_blob_null;
+               result->session_key = data_blob_null;
        } else {
-               result->user_session_key = data_blob_talloc(
+               result->session_key = data_blob_talloc(
                        result, info3->base.key.key,
                        sizeof(info3->base.key.key));
        }
@@ -1226,6 +1477,8 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
 
        result->nss_token |= username_was_mapped;
 
+       result->guest = (info3->base.user_flags & NETLOGON_GUEST);
+
        *server_info = result;
 
        return NT_STATUS_OK;