libndr: Avoid assigning duplicate versions to symbols

[amitay/samba.git] / pidl / wscript

diff --git a/pidl/wscript b/pidl/wscript
index f3814eab01c49fd75a88d7aca634559acfb0a47f..50fe12c013dba020e8a50b729bcedfdc7ac5af2c 100644 (file)
--- a/pidl/wscript
+++ b/pidl/wscript
@@ -1,70 +1,64 @@
 #!/usr/bin/env python
 
-import os
+import os, string
+from samba_utils import MODE_755
+from waflib import Logs, Errors
 
-def set_options(opt):
-    opt.tool_options('perl')
+# This function checks if a perl module is installed on the system.
+def check_system_perl_module(conf, module, version=None):
+    module_check = module
 
-def configure(conf):
-    conf.check_tool('perl')
-    # we need a recent version of MakeMaker to get the right man page names
-    if conf.CHECK_PERL_MANPAGE():
-        conf.env.PERLMAN1EXT = conf.CHECK_PERL_MANPAGE(section='1')
-        conf.env.PERLMAN3EXT = conf.CHECK_PERL_MANPAGE(section='3')
-        conf.DEFINE('HAVE_PERL_MAKEMAKER', 1)
+    # Create module string with version
+    if version:
+        module_check = module + ' ' + str(version)
 
-    # yapp is used for building the parser
-    conf.find_program('yapp', var='YAPP')
-    conf.find_program('pod2man', var='POD2MAN')
+    # Check for system perl module
+    if conf.check_perl_module(module_check) is None:
+        return False
 
-def build(bld):
-    bld.INSTALL_FILES('${BINDIR}', 'pidl', chmod=0755)
+    return True
 
-    bld.RECURSE('lib')
+def options(opt):
+    return
 
-    if not bld.CONFIG_SET('HAVE_PERL_MAKEMAKER'):
-        return
+def configure(conf):
+    # Check if perl(Parse::Yapp::Driver) is available.
+    if not check_system_perl_module(conf,
+                                    "Parse::Yapp::Driver",
+                                    1.05):
+        raise Errors.WafError('perl module "Parse::Yapp::Driver" not found')
 
-    pidl_src = ['pidl']
-    pidl_src.extend(bld.path.ant_glob('lib/**/*.pm').split())
+    # yapp is used for building the parser
+    if not conf.find_program('yapp', var='YAPP'):
+        raise Errors.WafError('yapp not found')
 
-    pidl_manpages = {
-        'pidl': 'man1/pidl.${PERLMAN1EXT}',
-        'lib/Parse/Pidl/NDR.pm': 'man3/Parse::Pidl::NDR.${PERLMAN3EXT}',
-        'lib/Parse/Pidl/Wireshark/Conformance.pm': 'man3/Parse::Pidl::Wireshark::Conformance.${PERLMAN3EXT}',
-        'lib/Parse/Pidl/Dump.pm': 'man3/Parse::Pidl::Dump.${PERLMAN3EXT}',
-        'lib/Parse/Pidl/Util.pm': 'man3/Parse::Pidl::Util.${PERLMAN3EXT}',
-        'lib/Parse/Pidl/Wireshark/NDR.pm': 'man3/Parse::Pidl::Wireshark::NDR.${PERLMAN3EXT}'
-    }
+def build(bld):
 
-    for k, v in pidl_manpages.iteritems():
-        pidl_manpages[k] = bld.EXPAND_VARIABLES(v)
+    # we want to prefer the git version of the parsers if we can.
+    # Only if the source has changed do we want to re-run yapp
+    # But we force the developer to use the pidl standalone build
+    # to regenerate the files.
+    # TODO: only warn in developer mode and if 'git diff HEAD'
+    #       shows a difference
+    warn_about_grammar_changes = ('PIDL_BUILD_WARNINGS' in bld.env and (
+        bld.IS_NEWER('idl.yp', 'lib/Parse/Pidl/IDL.pm') or
+        bld.IS_NEWER('expr.yp', 'lib/Parse/Pidl/Expr.pm')))
 
-    # use perl to build the manpages
-    bld.env.pidl_srcdir = os.path.join(bld.srcnode.abspath(), 'pidl')
+    if warn_about_grammar_changes:
+        Logs.warn('''
+Pidl grammar files have changed. Please use the pidl standalone build
+to regenerate them with yapp.
 
-    blib_bld = os.path.join(bld.srcnode.abspath(bld.env), 'pidl/blib')
+$ cd ../pidl
+$ perl Makefile.PL
+$ make lib/Parse/Pidl/IDL.pm lib/Parse/Pidl/Expr.pm
+$ git add lib/Parse/Pidl/IDL.pm lib/Parse/Pidl/Expr.pm
+$ git commit
+$ cd -
 
-    link_command = 'rm -rf blib && ln -fs blib %s' % blib_bld
-    
-    bld.SET_BUILD_GROUP('main')
-    if 'POD2MAN' in bld.env and bld.env['POD2MAN'] != '':
-        for src, manpage in pidl_manpages.iteritems():
-            bld(rule='${PERL} ${POD2MAN} -c "Samba Documentation" ${SRC} ${TGT}',
-                shell=True,
-                source=src,
-                install_path=os.path.dirname(bld.EXPAND_VARIABLES('${MANDIR}/'+manpage)),
-                target=os.path.basename(manpage))
+If your 100% sure you haven't changed idl.yp and expr.yp
+try this to avoid this message:
 
-    # we want to prefer the git version of the parsers if we can. Only if the
-    # source has changed do we want to re-run yapp
-    need_yapp_build = ('YAPP' in bld.env and (
-        bld.IS_NEWER('idl.yp', 'lib/Parse/Pidl/IDL.pm') or
-        bld.IS_NEWER('expr.yp', 'lib/Parse/Pidl/Expr.pm')))
+$ touch ../pidl/lib/Parse/Pidl/IDL.pm ../pidl/lib/Parse/Pidl/Expr.pm
+''')
 
-    if need_yapp_build:
-        t = bld.SAMBA_GENERATOR('pidl_parser',
-                                source='idl.yp expr.yp',
-                                target='lib/Parse/Pidl/IDL.pm lib/Parse/Pidl/Expr.pm Makefile.PL',
-                                rule='cd ${pidl_srcdir} && ${LINK_COMMAND} && ${PERL} Makefile.PL && make lib/Parse/Pidl/IDL.pm lib/Parse/Pidl/Expr.pm && rm -f Makefile Makefile.old && rm -f blib')
-        t.env.LINK_COMMAND = link_command