Andrew Bartlett [Wed, 4 May 2011 03:59:57 +0000 (13:59 +1000)]
libcli/util Merge ntstatus_to_dos() ntstatus_to_werror() to the top level
This takes the Samba4 version, with the NT_STATUS_IS_DOS() check.
This will be used in smbd/error.c shortly.
Andrew Bartlett
Andrew Bartlett [Wed, 4 May 2011 06:51:23 +0000 (16:51 +1000)]
errors: Merge source3/ werror_to_ntstatus() code to source4/
Andrew Bartlett [Wed, 4 May 2011 03:47:26 +0000 (13:47 +1000)]
errors: Merge ntstatus -> DOS error table between Samba3 and Samba4.
They are now identical
Andrew Bartlett
Andrew Bartlett [Wed, 4 May 2011 01:39:21 +0000 (11:39 +1000)]
s3-lib Remove unused dos error codes from errmap_unix
This also makes unix_nt_errmap private to errmap_unix.c and errormap.c
so the tables themselves cannot be duplicate symbols until merged.
Andrew Bartlett
Andrew Bartlett [Wed, 4 May 2011 00:28:15 +0000 (10:28 +1000)]
lib/util Move source3 tdb_wrap_open() into the common code.
This #if _SAMBA_BUILD == 3 is very unfortunate, as it means that in
the top level build, these options are not available for these
databases. However, having two different tdb_wrap lists is a worse
fate, so this will do for now.
Andrew Bartlett
Volker Lendecke [Tue, 3 May 2011 19:28:37 +0000 (21:28 +0200)]
s3: Filter out duplicates in name_query()
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May 4 00:03:47 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 3 May 2011 14:28:44 +0000 (16:28 +0200)]
s3-includes: when MADVISE support was reverted back in 2009, someone forgot this hunk.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 3 22:06:20 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 3 May 2011 14:25:20 +0000 (16:25 +0200)]
s3-includes: move enum flush_reason_enum to smb.h
Guenther
Günther Deschner [Tue, 3 May 2011 14:16:50 +0000 (16:16 +0200)]
s3-includes: remove ipv6 related prototype which is already defined in ../lib/util/util_net.h.
Guenther
Günther Deschner [Tue, 3 May 2011 12:45:47 +0000 (14:45 +0200)]
s3-system: move LOCK_ defines to lib/system.c
Guenther
Volker Lendecke [Tue, 3 May 2011 15:04:06 +0000 (17:04 +0200)]
s3: Handle EINTR from sys_poll correctly
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 3 18:06:48 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 3 May 2011 10:05:47 +0000 (12:05 +0200)]
s3-proto: move remaining krb5 protos to krb5_protos.h
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 3 15:38:40 CEST 2011 on sn-devel-104
Andrew Bartlett [Tue, 3 May 2011 09:11:38 +0000 (19:11 +1000)]
s3-ctdb Fix duplicate function name due to packet -> ctdb_packet rename.
Signed-off-by: Günther Deschner <gd@samba.org>
Björn Jacke [Wed, 20 Apr 2011 22:11:21 +0000 (00:11 +0200)]
s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May 3 13:04:11 CEST 2011 on sn-devel-104
Björn Jacke [Wed, 20 Apr 2011 21:40:30 +0000 (23:40 +0200)]
ѕ3/configure: move out generic CPPFLAGS in the solaris case here
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Björn Jacke [Wed, 20 Apr 2011 21:32:12 +0000 (23:32 +0200)]
ѕ3/configure: move out generic LDFLAGS in the solaris case here
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 3 May 2011 05:35:18 +0000 (15:35 +1000)]
lib/util make string_wrappers.h a public header
This isn't a very good public header, but util.h includes it, so we
don't have much choice in the short term.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 3 08:37:22 CEST 2011 on sn-devel-104
Andrew Bartlett [Tue, 3 May 2011 03:24:10 +0000 (13:24 +1000)]
s4-param Rename secrets_init() -> randseed_init()
This only sets up the random number generator callback these days, so
use a different database for that.
(All secrets data in Samba4 is in secrets.ldb)
Andrew Bartlett
Andrew Bartlett [Tue, 3 May 2011 02:59:36 +0000 (12:59 +1000)]
lib/util Use lib/util/util_str.c in common, including strequal()
strequal() is now implemented in terms of strcasecmp_m() which is
tested in smbtorture and which does not talloc() for ASCII or
non-ASCII comparions, and has an ASCII fast-path.
Andrew Bartlett
Andrew Bartlett [Tue, 3 May 2011 05:23:19 +0000 (15:23 +1000)]
lib/util Use compiler-checked safe string macros in top level code.
This brings the 'safe' macros to the top level code, and removes
duplication of the safe_strcpy() and safe_strcat() functions.
Andrew Bartlett
Andrew Bartlett [Tue, 3 May 2011 05:33:31 +0000 (15:33 +1000)]
s4: fix arguments to safe_strcpy()
Found by the s3-derivied safe_strcpy() macro.
Andrew Bartlett
Andrew Tridgell [Mon, 2 May 2011 23:34:06 +0000 (09:34 +1000)]
s4-socket: rename allow_access() to socket_allow_access()
this prevents a symbol collision with s3
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 3 May 2011 02:29:12 +0000 (12:29 +1000)]
lib/util/charset Use push_string and talloc_strupper/strlower from common code
The only caller of push_string() (not to be confused with
push_string_check()) in the common code was encode_pw_buffer(), and it
didn't use the alignment or STR_UPPER flags.
The talloc_strupper() and talloc_strlower() functions are tested in
smbtorture, and are next_codepoint() based.
Andrew Bartlett
Andrew Bartlett [Tue, 3 May 2011 02:25:29 +0000 (12:25 +1000)]
s3-lib make push_ucs2() static
Andrew Bartlett [Tue, 3 May 2011 02:16:16 +0000 (12:16 +1000)]
Remove strlower_m() and strupper_m() from source4 and common code.
This function is problematic because a string may expand in size when
changed into upper or lower case. This will then push characters off
the end of the string in the s3 implementation, or panic in the former
s4 implementation.
Andrew Bartlett
Andrew Tridgell [Mon, 2 May 2011 02:05:13 +0000 (12:05 +1000)]
s4-param: use new roles.h
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 2 May 2011 02:05:02 +0000 (12:05 +1000)]
s3-include: use new roles.h
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 2 May 2011 02:04:32 +0000 (12:04 +1000)]
libds: added roles.h for server roles
this will allow us to move the server roles in common, which will
make it much easier to mix s3/s4 calls in the one C file
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 2 May 2011 01:34:57 +0000 (11:34 +1000)]
libcli/raw: use a different ifdef than s3 smb.h
this allows both headers to be included in 1 C file
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Tue, 3 May 2011 00:40:33 +0000 (10:40 +1000)]
s4-messaging Rename messaging -> imessaging
This avoid symbol and structure conflicts between Samba3 and Samba4,
and chooses a less generic name.
Andrew Bartlett
Andrew Bartlett [Mon, 2 May 2011 06:36:48 +0000 (16:36 +1000)]
s4-libcli Remove resolve_name() as it conflicts with Samba3.
This was just a wrapper around resolve_name_ex(), so just call that
instead.
Andrew Bartlett
Andrew Bartlett [Mon, 2 May 2011 06:36:21 +0000 (16:36 +1000)]
s4-torture Remove unused and uncompleated test
Andrew Bartlett [Mon, 2 May 2011 06:23:40 +0000 (16:23 +1000)]
lib/util Move set_socket_options() into common code.
Andrew Bartlett [Mon, 2 May 2011 06:15:50 +0000 (16:15 +1000)]
s4-lib/socket Merge updated set_socket_options from Samba3 -> Samba4
Andrew Bartlett [Mon, 2 May 2011 05:23:08 +0000 (15:23 +1000)]
lib/util Move more network utility functions from source3 into lib/util
This will help with the merge of the interfaces layer.
Andrew Bartlett
Andrew Bartlett [Mon, 2 May 2011 01:38:41 +0000 (11:38 +1000)]
s3-ctdb Rename packet file and files to ctdb_packet
This avoids a conflicts with the Samba4 packet.c, as these is only
used in CTDB
Andrew Bartlett
Andrew Bartlett [Mon, 2 May 2011 00:53:18 +0000 (10:53 +1000)]
s4-cluster Rename server_id.node -> vnn to match Samba3
Andrew Bartlett [Sun, 1 May 2011 10:53:21 +0000 (20:53 +1000)]
s4:Remove outdated doc on Samba4 upgrade
Andrew Bartlett [Sun, 1 May 2011 10:14:03 +0000 (20:14 +1000)]
selftest: Update README
Andrew Bartlett [Sun, 1 May 2011 09:54:59 +0000 (19:54 +1000)]
Remove reference to Samba4 LDAP backends
Andrew Bartlett [Mon, 2 May 2011 00:06:56 +0000 (10:06 +1000)]
s4-cluster: Remove const from cluster_id_string()
This allows the caller to talloc_free() this result.
Andrew Bartlett
Andrew Bartlett [Mon, 2 May 2011 00:05:46 +0000 (10:05 +1000)]
s4:cluster Rename .id to .pid in server_id
This also changes some DEBUG messages to use cluster_id_string()
rather than .id, to isolate them from this and other changes.
Andrew Bartlett
Volker Lendecke [Mon, 2 May 2011 21:35:06 +0000 (23:35 +0200)]
s3: Tune broadcast namequeries for unique names
If we get a unique name via a broadcast query, there's no point in waiting the
full timeout. A unique name is just what its name says: unique. No point in
waiting longer.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 3 00:57:24 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 2 May 2011 11:27:45 +0000 (13:27 +0200)]
s3-rpc_server: (re)move last globally included rpc_server prototypes.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 2 16:05:31 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 2 May 2011 11:25:19 +0000 (13:25 +0200)]
s3-spoolss: remove another unused header.
Guenther
Günther Deschner [Mon, 2 May 2011 11:21:53 +0000 (13:21 +0200)]
s3: include ntdomain.h before including generated srv_ headers.
Guenther
Günther Deschner [Mon, 2 May 2011 11:19:51 +0000 (13:19 +0200)]
s3-rpc_server: add pipes_struct forward declaration.
Guenther
Günther Deschner [Mon, 2 May 2011 11:18:39 +0000 (13:18 +0200)]
s3-winbindd: remove unused headers.
Guenther
Günther Deschner [Mon, 2 May 2011 10:36:55 +0000 (12:36 +0200)]
s3: remove various references to server side dcerpc structs (which are not needed).
Guenther
Günther Deschner [Mon, 2 May 2011 10:36:25 +0000 (12:36 +0200)]
s3: move pipe_auth_data to dcerpc.h
Guenther
Günther Deschner [Fri, 29 Apr 2011 22:40:28 +0000 (00:40 +0200)]
s3-printing: include ../librpc/ndr/libndr.h in ads printing.
Guenther
Günther Deschner [Fri, 29 Apr 2011 22:37:05 +0000 (00:37 +0200)]
s3-smbd: avoid using pipes_struct when only session_info is needed.
Guenther
Günther Deschner [Fri, 29 Apr 2011 22:09:09 +0000 (00:09 +0200)]
s3-printing: avoid using pipes_struct when only session_info is needed.
Guenther
Günther Deschner [Fri, 29 Apr 2011 21:58:18 +0000 (23:58 +0200)]
libcli/named_pipe_auth: add forward declaration in npa_tstream.h.
Guenther
Günther Deschner [Fri, 29 Apr 2011 21:57:49 +0000 (23:57 +0200)]
s3-proto: move remaining srvsvc protos to own header file.
Guenther
Günther Deschner [Fri, 29 Apr 2011 21:47:25 +0000 (23:47 +0200)]
s3-proto: move remaining spoolss protos to own header file.
Guenther
Günther Deschner [Fri, 29 Apr 2011 21:32:28 +0000 (23:32 +0200)]
s3-proto: move more rpc_server prototypes out of proto.h
Guenther
Günther Deschner [Fri, 29 Apr 2011 20:43:59 +0000 (22:43 +0200)]
s3-rpc_server: remove proto of nonexisting function
(rpc_pipe_register_commands).
Guenther
Günther Deschner [Fri, 29 Apr 2011 20:34:56 +0000 (22:34 +0200)]
s3-util: move valid_share_pathname() to lib/util.c
Guenther
Günther Deschner [Fri, 29 Apr 2011 20:32:12 +0000 (22:32 +0200)]
s3-proto: move rpc_srv_register protos and structs to town headerfile.
Guenther
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s4:libcli/util/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 2 15:02:56 CEST 2011 on sn-devel-104
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
s3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
metze
Stefan Metzmacher [Mon, 2 May 2011 10:41:46 +0000 (12:41 +0200)]
libcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE
metze
Stefan Metzmacher [Mon, 2 May 2011 11:50:52 +0000 (13:50 +0200)]
talloc: use TC_UNDEFINE_SHRINK_CHUNK() instead of TC_INVALIDATE_SHRINK_CHUNK() for realloc path
If we optimize on top of raw realloc() we need
TC_INVALIDATE_SHRINK_CHUNK together with TC_UNDEFINE_GROW_CHUNK
(with was missing and caused false positive valgrind warnings).
But that is really slow, as we do a lot of talloc_realloc calls in samba.
That's why we only to TC_UNDEFINE_SHRINK_CHUNK() for now.
metze
Volker Lendecke [Sat, 30 Apr 2011 17:23:55 +0000 (19:23 +0200)]
s3: Make name_resolve_bcast return sockaddr_storage
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 20:40:46 CEST 2011 on sn-devel-104
Volker Lendecke [Sat, 30 Apr 2011 15:10:35 +0000 (17:10 +0200)]
s3: Remove ip_sevice from get_ipc_connect_master_ip
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 18:16:28 CEST 2011 on sn-devel-104
Matthieu Patou [Fri, 29 Apr 2011 21:20:32 +0000 (01:20 +0400)]
provision: reorganize attributes so that we don't attribute with DN syntax that depends on non present object
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat Apr 30 14:51:16 CEST 2011 on sn-devel-104
Stefan Metzmacher [Sat, 30 Apr 2011 07:54:43 +0000 (09:54 +0200)]
script/autobuild.py: don't force usage of ccache and gcc
If someone wants to use it, CC="ccache gcc" script/autobuild.py will work.
It also makes it possible to use other compilers than gcc.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Apr 30 13:47:47 CEST 2011 on sn-devel-104
Stefan Metzmacher [Sat, 30 Apr 2011 07:35:56 +0000 (09:35 +0200)]
script/autobuild.py: make sure --with-selftest-prefix keeps working
metze
Stefan Metzmacher [Fri, 29 Apr 2011 19:12:53 +0000 (21:12 +0200)]
selftest: use env.SELFTEST_PREFIX instead of hardcoded "${srcdir}/st"
metze
Stefan Metzmacher [Sat, 30 Apr 2011 08:14:54 +0000 (10:14 +0200)]
s4:torture/nbt/winsreplication: ignore incoming broadcast messages
This will hopefully fix the flakey behavior of the
samba4.nbt.winsreplication.owned test.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Apr 30 12:45:01 CEST 2011 on sn-devel-104
Stefan Metzmacher [Sat, 30 Apr 2011 07:40:11 +0000 (09:40 +0200)]
s4:torture/nbt/winsreplication: assert the nbt name before the type
I hope that will make it easier to find problems
with the flakey samba4.nbt.winsreplication.owned test.
metze
Andrew Bartlett [Sat, 30 Apr 2011 08:10:17 +0000 (18:10 +1000)]
s3-build Add popt dep to fix build on FreeBSD
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Apr 30 11:42:20 CEST 2011 on sn-devel-104
Andrew Bartlett [Sat, 30 Apr 2011 03:10:18 +0000 (13:10 +1000)]
lib/util Rename conv_str_size() -> conv_str_size_error()
Stefan Metzmacher [Sat, 30 Apr 2011 07:29:16 +0000 (09:29 +0200)]
s4:torture/nbt/winsreplication: use torture macros in order report failures
This makes sure we can ignore this failures with the "knownfail"
file.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Apr 30 10:37:16 CEST 2011 on sn-devel-104
Andrew Bartlett [Sat, 30 Apr 2011 02:52:11 +0000 (12:52 +1000)]
s3-lib: Rely on uint64_t in conv_str_size()
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Apr 30 05:58:35 CEST 2011 on sn-devel-104
Andrew Bartlett [Sat, 30 Apr 2011 02:05:25 +0000 (12:05 +1000)]
kerberos: Only include gssapi/gssapi_krb5.h when available
Andrew Bartlett [Sat, 30 Apr 2011 00:50:50 +0000 (10:50 +1000)]
s3-waf: Add dependency on popt to fix build on FreeBSD
Jeremy Allison [Fri, 29 Apr 2011 23:18:14 +0000 (16:18 -0700)]
Add POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
Don't strip access bits from wire flags when opening a directory.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 02:21:24 CEST 2011 on sn-devel-104
Jeremy Allison [Fri, 29 Apr 2011 23:15:55 +0000 (16:15 -0700)]
Fix bug #8112 - POSIX extension opens of a directory are denied with EISDIR.
Ensure create_options are passed down to SMB_VFS_CREATE_FILE().
Correctly set create_options is SMB_O_DIRECTORY is set or pathname
is known to be a directory.
Jeremy.
Jeremy Allison [Fri, 29 Apr 2011 21:27:45 +0000 (14:27 -0700)]
torture test for bug #8111 - CIFS VFS: unexpected error on SMB posix open.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 00:33:40 CEST 2011 on sn-devel-104
Jeremy Allison [Fri, 29 Apr 2011 21:27:32 +0000 (14:27 -0700)]
Fix bug 8111 - CIFS VFS: unexpected error on SMB posix open
We are conflating the O_CREAT|O_EXCL with the O_TRUNC
processing, they need to be separate. We need to chose
using (O_CREAT|O_EXCL) first, then modify if O_TRUNC is
set. This needs two separate switch statements.
Jeremy
Günther Deschner [Fri, 29 Apr 2011 14:40:24 +0000 (16:40 +0200)]
s3-proto: move more headers to rpc_server/rpc_ncacn_np.h where they origin from.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 22:05:07 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 29 Apr 2011 14:20:27 +0000 (16:20 +0200)]
s3-proto: remove duplicate prototypes.
Guenther
Günther Deschner [Fri, 29 Apr 2011 14:19:54 +0000 (16:19 +0200)]
s3-rpc_server: remove some unneeded headers.
Guenther
Günther Deschner [Fri, 29 Apr 2011 13:22:29 +0000 (15:22 +0200)]
s3-proto: move rpc_server/rpc_handles.c protos to ntdomain.h
Guenther
Günther Deschner [Fri, 29 Apr 2011 13:13:55 +0000 (15:13 +0200)]
s3-proto: move more librpc prototypes to librpc/rpc/dcerpc.h
Guenther
Günther Deschner [Fri, 29 Apr 2011 13:02:49 +0000 (15:02 +0200)]
s3-proto: remove remaining nss_info prototypes to nss_info.h
Guenther
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:41:34 +0000 (19:41 +0200)]
ldb:tdb backend - cache - remove unused "last_attribute" structure member
Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Apr 29 20:07:27 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 18:47:18 +0000 (20:47 +0200)]
s4:"ldb_connect" calls - proof for "!= LDB_SUCCESS"
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 18:47:43 +0000 (20:47 +0200)]
s4:torture/rpc/testjoin.c - use a LDB result constant
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:35:22 +0000 (19:35 +0200)]
ldb:tools/cmdline.c + tools/ldbtest.c - make use of LDB result constants
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Wed, 13 Apr 2011 07:14:44 +0000 (09:14 +0200)]
s4:repl_meta_data LDB module - quiet a discard const ptr warning
Matthias Dieter Wallnöfer [Sun, 10 Apr 2011 17:24:16 +0000 (19:24 +0200)]
ldb:ldb_controls.c - fix comment indentation
Reviewed-by: abartlet
Matthias Dieter Wallnöfer [Fri, 29 Apr 2011 17:03:48 +0000 (19:03 +0200)]
s4:token_group.py python test - fix typos
Volker Lendecke [Fri, 29 Apr 2011 11:00:14 +0000 (13:00 +0200)]
s3: Avoid a potential 100% CPU loop in winbindd
In the clustering case if ctdb is unhappy, winbindd_reinit_after_fork fails.
This can lead to an endless loop depending on the scheduling of the parent vs
child. Parent forks, child is immediately scheduled and exits. Parent gets
SIGCHLD, parent is then scheduled before it sends the request out to the child.
Parent tries to fork again immediately.
The code before this patch did not really take into account that
reinit_after_fork can fail. The code now sends the result of
winbindd_reinit_after_fork to the parent and the parent only considers the
child alive when it got NT_STATUS_OK.
This was seen in 3.4 winbind. winbind has changed significantly since then, so
it might be possible that this does not happen anymore in exactly this way. But
passing up the status of reinit_after_fork and only consider the child alive
when that's ok is the correct thing to do anyway.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 29 17:58:19 CEST 2011 on sn-devel-104
Volker Lendecke [Fri, 29 Apr 2011 10:53:13 +0000 (12:53 +0200)]
s3: Make winbindd_reinit_after_fork return NTSTATUS
Volker Lendecke [Thu, 28 Apr 2011 11:26:57 +0000 (13:26 +0200)]
s3: In winbind, close parent/child sockets
This should further reduce fd load in winbind children
Günther Deschner [Thu, 28 Apr 2011 15:38:09 +0000 (17:38 +0200)]
s3-tevent: only include ../lib/util/tevent wrappers where needed.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
Günther Deschner [Thu, 28 Apr 2011 15:26:40 +0000 (17:26 +0200)]
s3-tsocket: only include ../lib/tsocket/tsocket.h where needed.
Guenther