From e7cf95c5417e07fb3544b8731cb6a33fbcf40eff Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Mon, 23 May 2011 09:22:07 +1000 Subject: [PATCH] selftest: Make knowfail/skip files consistent, always use ^prefix Except in one case (where we mark printing tests as knownfail), this has all our regular expressions start with ^, which ensures we don't accidentially mix up the samba3/samba4 prefix here. Because of the particular values in these files at the moment, this should not change the set of tests, but it will help to ensure that future edits follow the correct pattern. Andrew Bartlett --- source3/selftest/knownfail | 22 ++--- source3/selftest/skip | 46 +++++------ source4/selftest/knownfail | 160 ++++++++++++++++++------------------- 3 files changed, 114 insertions(+), 114 deletions(-) diff --git a/source3/selftest/knownfail b/source3/selftest/knownfail index 95f01f64dcf..b62ef3e667d 100644 --- a/source3/selftest/knownfail +++ b/source3/selftest/knownfail @@ -1,14 +1,14 @@ -samba3.blackbox.failure # this is designed to fail, for testing our test infrastructure +^samba3.blackbox.failure # this is designed to fail, for testing our test infrastructure .*printer.*print_test_extended # fails on some hosts due to timing issues ? .*printer.*print_test # fails on some hosts due to timing issues ? -samba3.posix_s3.rap.printing # fails sometimes on sn-devel -samba3.posix_s3.rpc.spoolss.*printserver.enum_printers_old # fails on some hosts due to timing issues ? -samba3.posix_s3.rpc.spoolss.printer.*addprinterex.print_test # another intermittent failure -samba3.posix_s3.smb2.lock.*.rw-exclusive # another intermittent failure +^samba3.posix_s3.rap.printing # fails sometimes on sn-devel +^samba3.posix_s3.rpc.spoolss.*printserver.enum_printers_old # fails on some hosts due to timing issues ? +^samba3.posix_s3.rpc.spoolss.printer.*addprinterex.print_test # another intermittent failure +^samba3.posix_s3.smb2.lock.*.rw-exclusive # another intermittent failure .*driver.add_driver_timestamps # we only can store dates, not timestamps -samba3.raw.mux.* #This test is flaky on the async lock time -samba3.smbtorture_s3.*OPLOCK4 # fails sometimes on sn-devel -samba3.posix_s3.nbt.dgram.*netlogon2 -samba3.*rap.sam.*.useradd # Not provided by Samba 3 -samba3.*rap.sam.*.userdelete # Not provided by Samba 3 -samba3.*rap.basic.*.netsessiongetinfo # Not provided by Samba 3 +^samba3.raw.mux.* #This test is flaky on the async lock time +^samba3.smbtorture_s3.*OPLOCK4 # fails sometimes on sn-devel +^samba3.posix_s3.nbt.dgram.*netlogon2 +^samba3.*rap.sam.*.useradd # Not provided by Samba 3 +^samba3.*rap.sam.*.userdelete # Not provided by Samba 3 +^samba3.*rap.basic.*.netsessiongetinfo # Not provided by Samba 3 diff --git a/source3/selftest/skip b/source3/selftest/skip index 02166a14578..4366ae68726 100644 --- a/source3/selftest/skip +++ b/source3/selftest/skip @@ -1,23 +1,23 @@ -samba3.smbtorture_s3.*.randomipc -samba3.smbtorture_s3.*.negnowait -samba3.smbtorture_s3.*.nbench -samba3.smbtorture_s3.*.errmapextract -samba3.smbtorture_s3.*.trans2scan -samba3.smbtorture_s3.*.nttransscan -samba3.smbtorture_s3.*.deny1 -samba3.smbtorture_s3.*.deny2 -samba3.smbtorture_s3.*.openattr -samba3.smbtorture_s3.*.casetable -samba3.smbtorture_s3.*.eatest -samba3.smbtorture_s3.*.mangle -samba3.smbtorture_s3.*.utable -samba3.smbtorture_s3.*.pipe_number -samba3.smbtorture_s3.*.CHAIN1 -samba3.*base.charset -samba3.*raw.acls -samba3.*raw.composite -samba3.*raw.context -samba3.*raw.ioctl -samba3.*raw.qfileinfo -samba3.*raw.qfsinfo -samba3.*raw.sfileinfo.base +^samba3.smbtorture_s3.*.randomipc +^samba3.smbtorture_s3.*.negnowait +^samba3.smbtorture_s3.*.nbench +^samba3.smbtorture_s3.*.errmapextract +^samba3.smbtorture_s3.*.trans2scan +^samba3.smbtorture_s3.*.nttransscan +^samba3.smbtorture_s3.*.deny1 +^samba3.smbtorture_s3.*.deny2 +^samba3.smbtorture_s3.*.openattr +^samba3.smbtorture_s3.*.casetable +^samba3.smbtorture_s3.*.eatest +^samba3.smbtorture_s3.*.mangle +^samba3.smbtorture_s3.*.utable +^samba3.smbtorture_s3.*.pipe_number +^samba3.smbtorture_s3.*.CHAIN1 +^samba3.*base.charset +^samba3.*raw.acls +^samba3.*raw.composite +^samba3.*raw.context +^samba3.*raw.ioctl +^samba3.*raw.qfileinfo +^samba3.*raw.qfsinfo +^samba3.*raw.sfileinfo.base diff --git a/source4/selftest/knownfail b/source4/selftest/knownfail index 52e56ea5949..d0d3aced92f 100644 --- a/source4/selftest/knownfail +++ b/source4/selftest/knownfail @@ -3,85 +3,85 @@ # # "make test" will not report failures for tests listed here and will consider # a successful run for any of these tests an error. -samba4.local.resolve.*.async -samba4.local.iconv.*.next_codepoint() -samba4..*base.delete.*.deltest17 -samba4..*base.delete.*.deltest20a -samba4..*base.delete.*.deltest20b -samba4.raw.rename.*.osxrename -samba4.raw.rename.*.directory rename -samba4.rpc.winreg.*security -samba4.local.registry.(dir|ldb).check hive security -samba4.local.registry.local.security -samba4.rpc.wkssvc -samba4.rpc.handles.*.lsarpc-shared -samba4.rpc.handles.*.mixed-shared -samba4.rpc.epmapper -samba4.rpc.drsuapi.* -samba4.rpc.lsalookup -samba4.rpc.cracknames -samba4.rpc.netlogon.*.LogonUasLogon -samba4.rpc.netlogon.*.LogonUasLogoff -samba4.rpc.netlogon.*.DatabaseSync -samba4.rpc.netlogon.*.DatabaseSync2 -samba4.rpc.netlogon.*.LogonControl -samba4.rpc.netlogon.*.LogonControl2 -samba4.rpc.netlogon.*.DsrEnumerateDomainTrusts -samba4.rpc.netlogon.*.NetrEnumerateTrustedDomains -samba4.rpc.netlogon.*.NetrEnumerateTrustedDomainsEx -samba4.rpc.netlogon.*.GetPassword -samba4.rpc.netlogon.*.GetTrustPasswords -samba4.rpc.netlogon.*.DatabaseRedo -samba4.rpc.netlogon.*.ServerGetTrustInfo -samba4.rpc.netlogon.*.GetForestTrustInformation -samba4.rpc.samr.passwords.badpwdcount # Not provided by Samba 4 yet -samba4.rpc.samr.passwords.lockout -samba4.base.charset.*.Testing partial surrogate +^samba4.local.resolve.*.async +^samba4.local.iconv.*.next_codepoint() +^samba4..*base.delete.*.deltest17 +^samba4..*base.delete.*.deltest20a +^samba4..*base.delete.*.deltest20b +^samba4.raw.rename.*.osxrename +^samba4.raw.rename.*.directory rename +^samba4.rpc.winreg.*security +^samba4.local.registry.(dir|ldb).check hive security +^samba4.local.registry.local.security +^samba4.rpc.wkssvc +^samba4.rpc.handles.*.lsarpc-shared +^samba4.rpc.handles.*.mixed-shared +^samba4.rpc.epmapper +^samba4.rpc.drsuapi.* +^samba4.rpc.lsalookup +^samba4.rpc.cracknames +^samba4.rpc.netlogon.*.LogonUasLogon +^samba4.rpc.netlogon.*.LogonUasLogoff +^samba4.rpc.netlogon.*.DatabaseSync +^samba4.rpc.netlogon.*.DatabaseSync2 +^samba4.rpc.netlogon.*.LogonControl +^samba4.rpc.netlogon.*.LogonControl2 +^samba4.rpc.netlogon.*.DsrEnumerateDomainTrusts +^samba4.rpc.netlogon.*.NetrEnumerateTrustedDomains +^samba4.rpc.netlogon.*.NetrEnumerateTrustedDomainsEx +^samba4.rpc.netlogon.*.GetPassword +^samba4.rpc.netlogon.*.GetTrustPasswords +^samba4.rpc.netlogon.*.DatabaseRedo +^samba4.rpc.netlogon.*.ServerGetTrustInfo +^samba4.rpc.netlogon.*.GetForestTrustInformation +^samba4.rpc.samr.passwords.badpwdcount # Not provided by Samba 4 yet +^samba4.rpc.samr.passwords.lockout +^samba4.base.charset.*.Testing partial surrogate .*net.api.delshare.* # DelShare isn't implemented yet -samba4.rap.*netservergetinfo -samba4.rap.*netsessionenum -samba4.rap.*netsessiongetinfo -samba4.rap.*netremotetod -samba4.smb2.persistent.handles1 -samba4.winbind.struct.*.show_sequence # Not yet working in winbind -samba4.winbind.struct.*.getpwent # Not yet working in winbind -samba4.winbind.struct.*.setpwent # Not yet working in winbind -samba4.winbind.struct.*.lookup_name_sid # Not yet working in winbind -samba4.winbind.struct.*.list_groups -samba4.*base.delaywrite.*update of write time and SMBwrite truncate$ -samba4.*base.delaywrite.*update of write time and SMBwrite truncate expand$ -samba4.*base.delaywrite.*delayed update of write time 3a$ -samba4.*base.delaywrite.*delayed update of write time 3c$ -samba4.*base.delaywrite.*update of write time using SET_END_OF_FILE$ -samba4.*base.delaywrite.*update of write time using SET_ALLOCATION_SIZE$ -samba4.ldap.python \(dc\).Test add_ldif\(\) with BASE64 security descriptor input using WRONG domain SID$ +^samba4.rap.*netservergetinfo +^samba4.rap.*netsessionenum +^samba4.rap.*netsessiongetinfo +^samba4.rap.*netremotetod +^samba4.smb2.persistent.handles1 +^samba4.winbind.struct.*.show_sequence # Not yet working in winbind +^samba4.winbind.struct.*.getpwent # Not yet working in winbind +^samba4.winbind.struct.*.setpwent # Not yet working in winbind +^samba4.winbind.struct.*.lookup_name_sid # Not yet working in winbind +^samba4.winbind.struct.*.list_groups +^samba4.*base.delaywrite.*update of write time and SMBwrite truncate$ +^samba4.*base.delaywrite.*update of write time and SMBwrite truncate expand$ +^samba4.*base.delaywrite.*delayed update of write time 3a$ +^samba4.*base.delaywrite.*delayed update of write time 3c$ +^samba4.*base.delaywrite.*update of write time using SET_END_OF_FILE$ +^samba4.*base.delaywrite.*update of write time using SET_ALLOCATION_SIZE$ +^samba4.ldap.python \(dc\).Test add_ldif\(\) with BASE64 security descriptor input using WRONG domain SID$ # some operations don't work over the CIFS NTVFS backend yet (eg. root_fid) -samba4.ntvfs.cifs.base.createx_access -samba4.ntvfs.cifs.base.createx_sharemodes_dir -samba4.ntvfs.cifs.base.maximum_allowed -samba4.base.createx_access # this test is broken for non-administrator users -samba4.smb2.oplock # oplocks in the s4 SMB2 server are a mess -samba4.raw.lock.*.async # bug 6960 -samba4.smb2.lock.*.multiple-unlock # bug 6959 -samba4.raw.sfileinfo.*.end-of-file # bug 6962 -samba4.raw.oplock.*.batch22 # bug 6963 -samba4.raw.oplock.*.brl4 # bug 7928 -samba4.raw.lock.*.zerobyteread # bug 6974 -samba4.smb2.lock.*.zerobyteread # bug 6974 -samba4.raw.streams.*.delete -samba4.raw.streams.*.createdisp -samba4.raw.streams.*.sumtab -samba4.raw.acls.*.create_dir -samba4.raw.acls.*.create_file -samba4.smb2.create.*.acldir -samba4.smb2.acls.*.generic -samba4.smb2.acls.*.inheritflags -samba4.smb2.acls.*.owner -samba4.smb2.compound.*.related1 -samba4.smb2.compound.*.related2 -samba4.smb2.compound.*.invalid2 -samba4.ldap.acl.*.search.* # ACL search behaviour not enabled by default -samba4.ldap.acl.*.ntSecurityDescriptor.* # ACL extended checks on search not enabled by default -samba4.nbt.winsreplication.owned # fails sometimes, timing related -samba4.ldap.dirsync.python.dc..__main__.ExtendedDirsyncTests.test_dirsync_deleted_items -#samba4.ldap.dirsync.python.dc..__main__.ExtendedDirsyncTests.* +^samba4.ntvfs.cifs.base.createx_access +^samba4.ntvfs.cifs.base.createx_sharemodes_dir +^samba4.ntvfs.cifs.base.maximum_allowed +^samba4.base.createx_access # this test is broken for non-administrator users +^samba4.smb2.oplock # oplocks in the s4 SMB2 server are a mess +^samba4.raw.lock.*.async # bug 6960 +^samba4.smb2.lock.*.multiple-unlock # bug 6959 +^samba4.raw.sfileinfo.*.end-of-file # bug 6962 +^samba4.raw.oplock.*.batch22 # bug 6963 +^samba4.raw.oplock.*.brl4 # bug 7928 +^samba4.raw.lock.*.zerobyteread # bug 6974 +^samba4.smb2.lock.*.zerobyteread # bug 6974 +^samba4.raw.streams.*.delete +^samba4.raw.streams.*.createdisp +^samba4.raw.streams.*.sumtab +^samba4.raw.acls.*.create_dir +^samba4.raw.acls.*.create_file +^samba4.smb2.create.*.acldir +^samba4.smb2.acls.*.generic +^samba4.smb2.acls.*.inheritflags +^samba4.smb2.acls.*.owner +^samba4.smb2.compound.*.related1 +^samba4.smb2.compound.*.related2 +^samba4.smb2.compound.*.invalid2 +^samba4.ldap.acl.*.search.* # ACL search behaviour not enabled by default +^samba4.ldap.acl.*.ntSecurityDescriptor.* # ACL extended checks on search not enabled by default +^samba4.nbt.winsreplication.owned # fails sometimes, timing related +^samba4.ldap.dirsync.python.dc..__main__.ExtendedDirsyncTests.test_dirsync_deleted_items +#^samba4.ldap.dirsync.python.dc..__main__.ExtendedDirsyncTests.* -- 2.34.1