From 9ecc68abe707506b7dc10ce580c7c2ef6b95a785 Mon Sep 17 00:00:00 2001 From: Jelmer Vernooij Date: Sat, 25 Feb 2012 17:50:14 +0100 Subject: [PATCH] 'samba-tool gpo': Properly close transaction. --- source4/scripting/python/samba/netcmd/gpo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source4/scripting/python/samba/netcmd/gpo.py b/source4/scripting/python/samba/netcmd/gpo.py index bd3480e053a..94c70c6af3b 100644 --- a/source4/scripting/python/samba/netcmd/gpo.py +++ b/source4/scripting/python/samba/netcmd/gpo.py @@ -916,11 +916,11 @@ class cmd_create(Command): # Set ACL conn.set_acl(sharepath, fs_sd) - - self.samdb.transaction_commit() - except Exception, e: + except: self.samdb.transaction_cancel() - raise RuntimeError("Error adding GPO to AD", e) + raise + else: + self.samdb.transaction_commit() self.outf.write("GPO '%s' created as %s\n" % (displayname, gpo)) -- 2.34.1