From 451907739cc14717c12875b88fbbe63a53e9cbec Mon Sep 17 00:00:00 2001 From: Garming Sam Date: Thu, 9 Jun 2016 03:52:38 +0200 Subject: [PATCH] tests/dns_forwarder: Fail out with an assertion instead OOB error Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett Autobuild-User(master): Garming Sam Autobuild-Date(master): Tue Sep 6 15:41:54 CEST 2016 on sn-devel-144 --- python/samba/tests/dns_forwarder.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/samba/tests/dns_forwarder.py b/python/samba/tests/dns_forwarder.py index bef21f6bdaf..51a86198b54 100644 --- a/python/samba/tests/dns_forwarder.py +++ b/python/samba/tests/dns_forwarder.py @@ -466,8 +466,9 @@ class TestDnsForwarding(DNSTest): try: data = ad.recv(0xffff + 2, 0) data = ndr.ndr_unpack(dns.name_packet, data) - self.assertEqual('forwarder1', data.answers[0].rdata) self.assert_dns_rcode_equals(data, dns.DNS_RCODE_OK) + self.assertEqual(len(data.answers), 1) + self.assertEqual('forwarder1', data.answers[0].rdata) except socket.timeout: self.fail("DNS server is too slow (timeout %s)" % timeout) -- 2.34.1