From 44937c55ff69f29d44cf6ef34a7e4050816b30a4 Mon Sep 17 00:00:00 2001 From: Tim Prouty Date: Sun, 11 Jan 2009 23:16:37 -0800 Subject: [PATCH] s3: Fix uninitialized variable in OneFS streams --- source3/modules/onefs_streams.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/source3/modules/onefs_streams.c b/source3/modules/onefs_streams.c index 55ce11ecf55..184fe4f0c99 100644 --- a/source3/modules/onefs_streams.c +++ b/source3/modules/onefs_streams.c @@ -132,7 +132,8 @@ int onefs_rename(vfs_handle_struct *handle, const char *oldname, { TALLOC_CTX *frame = NULL; int ret = -1; - int dir_fd, saved_errno; + int dir_fd = -1; + int saved_errno; bool old_is_stream; bool new_is_stream; char *obase = NULL; @@ -182,7 +183,9 @@ int onefs_rename(vfs_handle_struct *handle, const char *oldname, done: saved_errno = errno; - close(dir_fd); + if (dir_fd >= 0) { + close(dir_fd); + } errno = saved_errno; TALLOC_FREE(frame); return ret; -- 2.34.1