From 1f8b574adb10397ca4b9dc4a55281d3afaaeabfc Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 18 Jul 2012 15:07:27 +0930 Subject: [PATCH] talloc_stack: abort in developer me if no stackframe on talloc_tos() Don't tolerate leaks in developer mode. Signed-off-by: Rusty Russell --- lib/util/talloc_stack.c | 10 +++++++--- lib/util/talloc_stack.h | 3 ++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/util/talloc_stack.c b/lib/util/talloc_stack.c index be332af571b..9c72c801197 100644 --- a/lib/util/talloc_stack.c +++ b/lib/util/talloc_stack.c @@ -188,15 +188,19 @@ TALLOC_CTX *_talloc_stackframe_pool(const char *location, size_t poolsize) * Get us the current top of the talloc stack. */ -TALLOC_CTX *talloc_tos(void) +TALLOC_CTX *_talloc_tos(const char *location) { struct talloc_stackframe *ts = (struct talloc_stackframe *)SMB_THREAD_GET_TLS(global_ts); if (ts == NULL || ts->talloc_stacksize == 0) { - talloc_stackframe(); + _talloc_stackframe(location); ts = (struct talloc_stackframe *)SMB_THREAD_GET_TLS(global_ts); - DEBUG(0, ("no talloc stackframe around, leaking memory\n")); + DEBUG(0, ("no talloc stackframe at %s, leaking memory\n", + location)); +#ifdef DEVELOPER + smb_panic("No talloc stackframe"); +#endif } return ts->talloc_stack[ts->talloc_stacksize-1]; diff --git a/lib/util/talloc_stack.h b/lib/util/talloc_stack.h index 8e1644624ba..2f5dcab0a38 100644 --- a/lib/util/talloc_stack.h +++ b/lib/util/talloc_stack.h @@ -53,7 +53,8 @@ TALLOC_CTX *_talloc_stackframe_pool(const char *location, size_t poolsize); * Get us the current top of the talloc stack. */ -TALLOC_CTX *talloc_tos(void); +#define talloc_tos() _talloc_tos(__location__) +TALLOC_CTX *_talloc_tos(const char *location); /* * return true if a talloc stackframe exists -- 2.34.1