From 0dc30b9fe8243e9596e4016a20e1f7f19223ed1a Mon Sep 17 00:00:00 2001 From: Ricky Nance Date: Tue, 31 Dec 2013 10:58:16 -0600 Subject: [PATCH] samba_upgradedns: message the user if they need to change smb.conf Reviewed-by: Andrew Bartlett Reviewed-by: Kai Blin Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Jan 7 06:05:15 CET 2014 on sn-devel-104 --- source4/scripting/bin/samba_upgradedns | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/source4/scripting/bin/samba_upgradedns b/source4/scripting/bin/samba_upgradedns index d2c96cc1c27..c4f21449699 100755 --- a/source4/scripting/bin/samba_upgradedns +++ b/source4/scripting/bin/samba_upgradedns @@ -500,3 +500,19 @@ if __name__ == '__main__': logger.info("Failed to delete %s from sam.ldb" % dn) logger.info("Finished upgrading DNS") + + services = lp.get("server services") + for service in services: + if service == "dns": + if opts.dns_backend.startswith("BIND"): + logger.info("You have switched to using %s as your dns backend," + " but still have the internal dns starting. Please" + " make sure you add '-dns' to your server services" + " line in your smb.conf." % opts.dns_backend) + break + else: + if opts.dns_backend == "SAMBA_INTERNAL": + logger.info("You have switched to using %s as your dns backend," + " but you still have samba starting looking for a" + " BIND backend. Please remove the -dns from your" + " server services line." % opts.dns_backend) -- 2.34.1