Andrew Bartlett [Tue, 16 Oct 2012 04:08:30 +0000 (15:08 +1100)]
dns_server: Try and use the dns-SERVER account if we were configured with it
Rusty Russell [Sun, 14 Oct 2012 05:35:58 +0000 (16:05 +1030)]
ccan: check for all the used config.h defines
In particular, not checking for byteswap.h meant we defined duplicates:
https://bugzilla.samba.org/show_bug.cgi?id=9286
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Wed Oct 17 01:55:14 CEST 2012 on sn-devel-104
Kai Blin [Sat, 13 Oct 2012 00:09:57 +0000 (02:09 +0200)]
libcli/dns: Time out requests after a while
Time out UDP requests after DNS_REQUEST_TIMEOUT seconds. Currently set
to 2 seconds.
This should fix bug #8878.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 16 12:58:32 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 16 Oct 2012 06:34:35 +0000 (08:34 +0200)]
selftest/knownfail: add samba3.rpc.lsa.privileges.lsa.Privileges
This failed more than 20 times in the last few weeks, e.g.
https://git.samba.org/autobuild.flakey/2012-10-16-0629/samba3.stdout
https://git.samba.org/autobuild.flakey/2012-10-16-0829/samba3.stdout
[530/717 in 14m32s] samba3.rpc.lsa.privileges(s3dc)
Using seed
1350368974
Testing OpenPolicy
Testing OpenPolicy2
Testing CreateAccount
Testing Delete
Testing DeleteObject
Testing EnumAccounts
Testing LookupSids
Testing LookupNames with 7 names
LookupName of sharesec_user was unmapped
LookupName of Everyone failed to return a result
UNEXPECTED(failure): samba3.rpc.lsa.privileges.lsa.Privileges(s3dc)
REASON: _StringException: _StringException: ../source4/torture/rpc/lsa.c:319: r.out.result was STATUS_SOME_UNMAPPED, expected NT_STATUS_OK: LookupNames failed
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Oct 16 10:43:02 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 16 Oct 2012 06:30:17 +0000 (08:30 +0200)]
Revert "provision: Always create DNS user."
This reverts commit
c2d14747d608d406de6410556807d467cd0b85ef.
samba_upgradedns handles creates/removed the dns acount.
See
https://lists.samba.org/archive/samba-technical/2012-October/thread.html#87578
metze
Matthieu Patou [Sat, 13 Oct 2012 08:36:06 +0000 (01:36 -0700)]
s4-dns: Fix the comments about ignoring zones in internal server
Acked-By: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat Oct 13 12:37:53 CEST 2012 on sn-devel-104
Christian Ambach [Fri, 28 Sep 2012 05:09:23 +0000 (22:09 -0700)]
s3:smb2_getinfo ensure proper error for not yet present quota support
non-existing quota support needs to be signaled by NT_STATUS_NOT_SUPPORTED,
not NT_STATUS_INVALID_PARAMETER
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Fri Oct 12 13:37:37 CEST 2012 on sn-devel-104
Christian Ambach [Fri, 12 Oct 2012 09:47:04 +0000 (11:47 +0200)]
s3:vfs_gpfs re-indent run-away lines
some lines added by the acl_blob additions were longer than 80 chars
Christian Ambach [Fri, 12 Oct 2012 09:45:59 +0000 (11:45 +0200)]
s3:vfs_gpfs fix the build
make it compile again after the recent (untested) additions of the acl_blob functions
Christian Ambach [Fri, 12 Oct 2012 08:32:20 +0000 (10:32 +0200)]
s3:vfs_gpfs remove a trailing space
Christian Ambach [Fri, 12 Oct 2012 08:31:10 +0000 (10:31 +0200)]
s3:vfs_gpfs skip local flock when gpfs sharemodes are disabled
no sense in calling local flock when clustered sharemodes should be disabled
Jelmer Vernooij [Fri, 5 Oct 2012 09:51:37 +0000 (11:51 +0200)]
selftest: Move more tests to common list script.
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Fri Oct 12 02:06:42 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 11 Oct 2012 15:23:13 +0000 (17:23 +0200)]
samba.join: Fix multiple spaces.
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Thu Oct 11 20:30:43 CEST 2012 on sn-devel-104
Jelmer Vernooij [Fri, 5 Oct 2012 09:46:25 +0000 (11:46 +0200)]
selftest: Move some tests to common test script.
Jelmer Vernooij [Fri, 5 Oct 2012 09:39:34 +0000 (11:39 +0200)]
selftests.tests: Remove reference to Samba 4.
Jelmer Vernooij [Thu, 11 Oct 2012 15:11:44 +0000 (17:11 +0200)]
samba.provision.sambadns: Use == to compare strings, not 'is'.
Andreas Schneider [Thu, 11 Oct 2012 12:46:56 +0000 (14:46 +0200)]
s3fs-printing: Simplify the comment and location handling.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Oct 11 18:49:15 CEST 2012 on sn-devel-104
Andreas Schneider [Wed, 10 Oct 2012 09:30:15 +0000 (11:30 +0200)]
packaging: Add support for reloading systemd services.
Jelmer Vernooij [Thu, 11 Oct 2012 12:45:10 +0000 (14:45 +0200)]
provision: Always create DNS user.
The DNS user is currently only used by the bind9 plugin. This makes it
easier to later on switch between the builtin DNS server and bind
backend.
In addition, ideally the internal DNS server would use that (separate)
user too.
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Thu Oct 11 17:05:40 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 11 Oct 2012 12:39:50 +0000 (14:39 +0200)]
wafsamba: Ignore some more symbols when checking for dupes.
Andrew Bartlett [Thu, 11 Oct 2012 11:29:43 +0000 (22:29 +1100)]
smbd: Always free the talloc_stackframe() before leaving smbd_do_query_security_desc
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 11 15:20:54 CEST 2012 on sn-devel-104
Karolin Seeger [Wed, 10 Oct 2012 08:43:02 +0000 (10:43 +0200)]
docs: Add very basic samba manpage.
Please feel free to extend.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Thu Oct 11 11:40:37 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 11 Oct 2012 04:08:25 +0000 (15:08 +1100)]
rpc_server:srvsvc Remove psd variable that was no longer set by SMB_VFS_FGET_NT_ACL
This fixes up an error introduced by
c8ade07760ae0ccfdf2d875c9f3027926e62321b.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 11 07:53:36 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 10 Oct 2012 10:20:24 +0000 (21:20 +1100)]
build: Remove --disable-shared
This does not work, and has no known use cases. Remove it so we do
not waste time trying to support it.
This also removes it for ldb/tdb/ntdb/talloc, but as these are first
shared libraries, and then tools on top of those, rpath or (for
emergency tools) --nonshared-binary= seems more appropriate.
Andrew Bartlett
Andrew Bartlett [Thu, 11 Oct 2012 03:49:13 +0000 (14:49 +1100)]
vfs: Remove irixacl module (all the fucntions in it are unimplemented)
Andrew Bartlett [Thu, 11 Oct 2012 03:42:39 +0000 (14:42 +1100)]
vfs: Fix alternative posix and no-op sys acl implementations to take a mem_ctx
These were missed with the initial conversion to use a talloc context.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 23:47:17 +0000 (10:47 +1100)]
vfs: Improve formatting of vfs_fake_acls
This avoids this bad style being copied into new modules.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 11 05:10:16 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 10 Oct 2012 23:46:37 +0000 (10:46 +1100)]
vfs: Improve formatting of vfs_default
This avoids this bad style being copied into new modules.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 20:53:29 +0000 (07:53 +1100)]
examples: Re-indent and reformat skel VFS modules
This avoids some of the poor style here from propogating to new VFS modules.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 06:00:42 +0000 (17:00 +1100)]
vfs: Use a blocking function in vfs_zfsacl for system ACL blobs
This is so we do not query some other module for the ACL blob, as zfs
ACLs are not posix ACLs. We may add a linearisation later.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 05:59:53 +0000 (16:59 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_tru64acl for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:59:43 +0000 (16:59 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_solarisacl for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:59:35 +0000 (16:59 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_posixacl for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:59:25 +0000 (16:59 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_irix for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:59:18 +0000 (16:59 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_hpux for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:58:59 +0000 (16:58 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_gpfs for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:53:43 +0000 (16:53 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_fake_acls for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:53:22 +0000 (16:53 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_default for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:52:17 +0000 (16:52 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl2 for posix ACLs
Andrew Bartlett [Wed, 10 Oct 2012 05:52:02 +0000 (16:52 +1100)]
vfs: Use posix_sys_acl_blob_get_file in vfs_aixacl
Andrew Bartlett [Wed, 10 Oct 2012 05:45:44 +0000 (16:45 +1100)]
vfs: Use a blocking function in vfs_afsacl for system ACL blobs
This is important, as we need to avoid asking any lower module for a
possible libear ACL blob. We may implement a linearisation in the
future.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 05:49:59 +0000 (16:49 +1100)]
vfs: Implement a sys_acl_blob_get_{fd,file} for POSIX ACL backends
This simply linearlises the SMB_ACL_T (default and access acl for
directories) and the file owner, group and mode into a blob.
It will be useful for an improved vfs_acl_common.c that uses this sets
that, rather than the hash of the NT ACL, in the xattr
This will in turn insulate the stored hash from changes in the ACL
mapping.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 05:44:41 +0000 (16:44 +1100)]
vfs: Remove type parameter from sys_acl_blob_get_{fd,file}
This interface actually needs to match the get_nt_acl interface in
that the system ACL implmenetation may not be posix ACLs, and the blob
is not meant to be enforced to be of a particular system ACL
structure.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 00:50:27 +0000 (11:50 +1100)]
smbd: Add mem_ctx to {f,}get_nt_acl VFS call
This makes it clear which context the returned SD is allocated on, as
a number of callers do not want it on talloc_tos().
As the ACL transformation allocates and then no longer needs a great
deal of memory, a talloc_stackframe() call is used to contain the
memory that is not returned further up the stack.
Andrew Bartlett
Andrew Bartlett [Tue, 9 Oct 2012 23:18:32 +0000 (10:18 +1100)]
smbd: Add mem_ctx to sys_acl_init() and all callers
This changes from allocation on NULL to allocation on the supplied
memory context.
Currently that supplied context is talloc_tos() at the the final consumer of
the ACL.
Andrew Bartlett
Andrew Bartlett [Wed, 10 Oct 2012 01:44:14 +0000 (12:44 +1100)]
build: Add vfs_media_harmony to the waf build
Andrew Bartlett [Wed, 10 Oct 2012 05:42:38 +0000 (16:42 +1100)]
posixacls: Add IDL changes for vfs_acl_xattr using hash of the sys acl
This will isolate the hash of the ACL from any intermediate mapping that
the POSIX -> NT mapping subsystem might need to do, and which might
change if we need to correct that mapping.
Andrew Bartlett
David Disseldorp [Wed, 10 Oct 2012 08:47:20 +0000 (10:47 +0200)]
s3-rpc_server: fix build warning
enum dcerpc_transport_t is undeclared, include required headers.
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Oct 10 12:41:28 CEST 2012 on sn-devel-104
Jeremy Allison [Tue, 9 Oct 2012 19:46:57 +0000 (12:46 -0700)]
Make sure the returned sd is on the right context, and if not it's always freed.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 9 23:35:50 CEST 2012 on sn-devel-104
Jeremy Allison [Tue, 9 Oct 2012 19:45:30 +0000 (12:45 -0700)]
Move setting of psd->dacl->revision and protect against null SD's.
Karolin Seeger [Tue, 9 Oct 2012 09:56:19 +0000 (11:56 +0200)]
docs: Add '-V' to the list of options.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Tue Oct 9 18:53:12 CEST 2012 on sn-devel-104
Karolin Seeger [Tue, 9 Oct 2012 09:53:21 +0000 (11:53 +0200)]
samba-tool: Some more unifications...
in the usage message.
Karolin
Andreas Schneider [Tue, 9 Oct 2012 12:25:29 +0000 (14:25 +0200)]
packaging: Add config for systemd-tmpfiles.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Oct 9 17:10:53 CEST 2012 on sn-devel-104
Andrew Bartlett [Fri, 5 Oct 2012 00:19:17 +0000 (10:19 +1000)]
samba-tool: skip chown in sysvolreset when it would fail on a GID
This skips the chown of the files if (for example) the domain Admins group
were to own the file and not be able to because the group maps only to a GID.
This essentially papers over the problem, but may be enough to get us past
the Samba 4.0 release.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 9 15:24:44 CEST 2012 on sn-devel-104
Volker Lendecke [Tue, 9 Oct 2012 07:41:41 +0000 (09:41 +0200)]
s3: Pass down smb_filename to smbacl4_fill_ace4
A full fsp is a bit overkill here
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct 9 13:38:49 CEST 2012 on sn-devel-104
Amitay Isaacs [Tue, 2 Oct 2012 03:02:07 +0000 (13:02 +1000)]
s4-rpc: dnsserver: Ignore DNS zones that are not used by RPC dnsserver
..TrustAnchors zone is not interpreted by RPC dnsserver code.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Oct 9 03:21:07 CEST 2012 on sn-devel-104
Amitay Isaacs [Tue, 2 Oct 2012 03:00:50 +0000 (13:00 +1000)]
s4-dns: dlz_bind9: Ignore zones that are not used by BIND9 DLZ plugin
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Stefan Metzmacher [Mon, 8 Oct 2012 10:50:52 +0000 (12:50 +0200)]
s4:scripting/python: add '-V' as alias for '--version'
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Oct 8 17:52:52 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 8 Oct 2012 10:50:33 +0000 (12:50 +0200)]
s4:samba-tool: allow 'samba-tool --version'
metze
Stefan Metzmacher [Mon, 8 Oct 2012 10:47:47 +0000 (12:47 +0200)]
s4:samba-tool: use normal option parsing in SuperCommand
We use the epilog to print the subcommands.
metze
Stefan Metzmacher [Mon, 8 Oct 2012 10:45:20 +0000 (12:45 +0200)]
s4:samba-tool: add optional epilog to _create_parser()
metze
Andreas Schneider [Mon, 8 Oct 2012 10:32:49 +0000 (12:32 +0200)]
s3fs-printing: Fix RAW printing for normal users.
This fixes bug #8769.
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 8 16:11:51 CEST 2012 on sn-devel-104
Karolin Seeger [Mon, 8 Oct 2012 10:32:58 +0000 (12:32 +0200)]
samba-tool: Unify usage messages.
Karolin
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Oct 8 14:26:52 CEST 2012 on sn-devel-104
Karolin Seeger [Mon, 8 Oct 2012 09:57:40 +0000 (11:57 +0200)]
docs: Add man 8 samba-tool.
Addresses bug #8802 - Create missing manpages for new binaries.
Please note that it's a very basic version. Please feel free
to extend.
Karolin
Karolin Seeger [Mon, 8 Oct 2012 09:47:22 +0000 (11:47 +0200)]
samba-tool: Clarify usage of --help.
Karolin
Björn Baumbach [Mon, 8 Oct 2012 08:42:34 +0000 (10:42 +0200)]
docs: fix opening and ending tag mismatch: para
in forcedirectorysecuritymode.xml.
Björn Baumbach [Mon, 8 Oct 2012 08:42:34 +0000 (10:42 +0200)]
docs: fix opening and ending tag mismatch: para
in directorysecuritymask.xml.
Karolin Seeger [Mon, 8 Oct 2012 07:47:37 +0000 (09:47 +0200)]
samba-tool: Fix typo in usage.
Karolin
Matthieu Patou [Wed, 3 Oct 2012 07:37:34 +0000 (00:37 -0700)]
s4-dns: fix a warning
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Oct 8 10:45:41 CEST 2012 on sn-devel-104
Matthieu Patou [Tue, 2 Oct 2012 04:36:34 +0000 (21:36 -0700)]
s4-dns: Ignore zones that shouldn't be returned currently
RootDNSServers should never be returned (Windows DNS server don't)
..TrustAnchors should never be returned as is, (Windows returns
TrustAnchors) and for the moment we don't support DNSSEC so we'd better
not return this zone.
Matthieu Patou [Sat, 29 Sep 2012 17:15:05 +0000 (10:15 -0700)]
s4-join: factorize code, add info
Matthieu Patou [Mon, 8 Oct 2012 04:52:25 +0000 (21:52 -0700)]
s4-join: add some documentation
Matthieu Patou [Fri, 28 Sep 2012 01:38:29 +0000 (18:38 -0700)]
s4-repl: make dreplsrv_partition_find_for_nc return BAD_NC only
Matthieu Patou [Thu, 27 Sep 2012 22:22:00 +0000 (15:22 -0700)]
drsuapi: Validate the input parameters for the drsuapi_UpdateRefs function
Matthieu Patou [Thu, 27 Sep 2012 22:02:06 +0000 (15:02 -0700)]
drsuapi: check more carefully the validity of the NC
Check that both the GUID and DN are the GUID/DN of a NC if not return
WERR_DS_DRA_BAD_NC
Matthieu Patou [Thu, 27 Sep 2012 21:20:26 +0000 (14:20 -0700)]
drsuapi-idl: Fix the encoding of the source_dsa_dns
astring is not aligned and is not conformant
Matthieu Patou [Thu, 27 Sep 2012 08:27:50 +0000 (01:27 -0700)]
drs-replica-info: level_not_supported is wrong when we do support (partialy the level)
Matthieu Patou [Thu, 27 Sep 2012 08:22:57 +0000 (01:22 -0700)]
lib-addns: ensure that allocated buffer are pre set to 0
It avoid bugs when one of the buffer is supposed to contain a string
that is not null terminated (ie. label->label) and that we don't force
the last byte to 0.
Matthieu Patou [Thu, 27 Sep 2012 01:32:28 +0000 (18:32 -0700)]
ldap-server: sscanf result was never used to mistyped var
Matthieu Patou [Thu, 27 Sep 2012 01:31:39 +0000 (18:31 -0700)]
ldap-server: remove warning for the ret not being used
Matthieu Patou [Wed, 26 Sep 2012 18:49:07 +0000 (11:49 -0700)]
s4-drs: fix the logic to allow REPL_SECRET if the account has GET_ALL_CHANGES
Matthieu Patou [Wed, 26 Sep 2012 18:44:58 +0000 (11:44 -0700)]
s4-drs: EXOP_REPL_SECRETS can be called by RW DC as well
Matthieu Patou [Tue, 25 Sep 2012 21:02:55 +0000 (14:02 -0700)]
drs-getncchanges: do not set the highestUsn to 0
Paragraph 4.1.10.5 says that
if err = 0 then
msgOut.pNC := msgIn.pNC
msgOut.usnvecFrom := msgIn.usnvecFrom
so no need to set the highestUsn to 0
Matthieu Patou [Tue, 25 Sep 2012 20:27:04 +0000 (13:27 -0700)]
kcc: return invalid parameter if the taskId is not 0
Matthieu Patou [Tue, 25 Sep 2012 17:51:47 +0000 (10:51 -0700)]
drs-crackname: if there is no sid do not return the domain
Matthieu Patou [Tue, 25 Sep 2012 09:00:23 +0000 (02:00 -0700)]
devel-crackname: Print if count > 0
Matthieu Patou [Tue, 25 Sep 2012 04:34:02 +0000 (21:34 -0700)]
Implement the LIST_INFO_FOR_SERVER input format
Matthieu Patou [Tue, 25 Sep 2012 06:12:25 +0000 (23:12 -0700)]
getdcinfo: Check that the server object has a serverreference objects pointing to a DC object
The problem was found by the DRSR testsuite where server objects were
created in the Site container without serverrefrence attribute
triggering error in the testsuite.
Rusty Russell [Mon, 8 Oct 2012 00:56:43 +0000 (11:26 +1030)]
ntdb: remove unused local variable.
Reported-by: Matthieu Patou <mat@samba.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Mon Oct 8 04:43:37 CEST 2012 on sn-devel-104
Volker Lendecke [Tue, 2 Oct 2012 13:44:41 +0000 (15:44 +0200)]
s3: Add two tests a CLEAR_IF_FIRST crash
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Oct 6 17:16:39 CEST 2012 on sn-devel-104
Volker Lendecke [Tue, 2 Oct 2012 13:26:14 +0000 (15:26 +0200)]
tdb: Make tdb robust against improper CLEAR_IF_FIRST restart
When winbind is restarted, there is a potential crash in tdb. Following
situation: We are in a cluster with ctdb. A winbind child hangs
in a request to the DC. Cluster monitoring decides the node has a
problem. Cluster monitoring decides to kill ctdbd. winbind child
still hangs in a RPC request. winbind parent figures that ctdb is
dead and immediately commits suicide. winbind parent is restarted by
cluster management, overwriting gencache.tdb with CLEAR_IF_FIRST. The
CLEAR_IF_FIRST logic as implemented now will not see that a child still
has the tdb open, only the parent holds the ACTIVE_LOCK due to performance
reasons. During the CLEAR_IF_FIRST logic is done, there is a very small
window where we ftruncate(tfd, 0) the file and re-write a proper header
without a lock. When during this small window the winbind child comes
back, wanting to store something into gencache.tdb, that winbind child
will crash with a SIGBUS.
Sounds unlikely? See:
[2012/09/29 07:02:31.871607, 0] lib/util.c:1183(smb_panic)
PANIC (pid
1814517): internal error
[2012/09/29 07:02:31.877596, 0] lib/util.c:1287(log_stack_trace)
BACKTRACE: 35 stack frames:
#0 winbindd(log_stack_trace+0x1a) [0x7feb7d4ca18a]
#1 winbindd(smb_panic+0x2b) [0x7feb7d4ca25b]
#2 winbindd(+0x1a3cc4) [0x7feb7d4bacc4]
#3 /lib64/libc.so.6(+0x32900) [0x7feb7a929900]
#4 /lib64/libc.so.6(memcpy+0x35) [0x7feb7a97f355]
#5 /usr/lib64/libtdb.so.1(+0x6e76) [0x7feb7b0b0e76]
#6 /usr/lib64/libtdb.so.1(+0x3d37) [0x7feb7b0add37]
#7 /usr/lib64/libtdb.so.1(+0x863d) [0x7feb7b0b263d]
#8 /usr/lib64/libtdb.so.1(+0x8700) [0x7feb7b0b2700]
#9 /usr/lib64/libtdb.so.1(+0x2505) [0x7feb7b0ac505]
#10 /usr/lib64/libtdb.so.1(+0x25b7) [0x7feb7b0ac5b7]
#11 /usr/lib64/libtdb.so.1(tdb_fetch+0x13) [0x7feb7b0ac633]
#12 winbindd(gencache_set_data_blob+0x259) [0x7feb7d4d8449]
#13 winbindd(gencache_set+0x53) [0x7feb7d4d85b3]
#14 winbindd(gencache_del+0x5e) [0x7feb7d4d879e]
#15 winbindd(saf_delete+0x93) [0x7feb7d54b693]
#16 winbindd(+0xe507e) [0x7feb7d3fc07e]
#17 winbindd(+0xe85e5) [0x7feb7d3ff5e5]
#18 winbindd(+0xe65be) [0x7feb7d3fd5be]
#19 winbindd(+0xe7562) [0x7feb7d3fe562]
#20 winbindd(init_dc_connection+0x2e) [0x7feb7d3fe5be]
#21 winbindd(+0xe75d9) [0x7feb7d3fe5d9]
#22 winbindd(cm_connect_netlogon+0x58) [0x7feb7d3fe658]
#23 winbindd(_wbint_PingDc+0x61) [0x7feb7d410991]
#24 winbindd(+0x103175) [0x7feb7d41a175]
#25 winbindd(winbindd_dual_ndrcmd+0xb7) [0x7feb7d4107d7]
#26 winbindd(+0xf8609) [0x7feb7d40f609]
#27 winbindd(+0xf9075) [0x7feb7d410075]
#28 winbindd(tevent_common_loop_immediate+0xe8) [0x7feb7d4db198]
#29 winbindd(run_events_poll+0x3c) [0x7feb7d4d93fc]
#30 winbindd(+0x1c2b52) [0x7feb7d4d9b52]
#31 winbindd(_tevent_loop_once+0x90) [0x7feb7d4d9f60]
#32 winbindd(main+0x7b3) [0x7feb7d3e7aa3]
#33 /lib64/libc.so.6(__libc_start_main+0xfd) [0x7feb7a915cdd]
#34 winbindd(+0xce2a9) [0x7feb7d3e52a9]
This is in a winbind child, logfiles surrounding indicate the parent
was restarted.
This patch takes all chain locks around the CLEAR_IF_FIRST introduced
tdb_new_database.
Rusty Russell [Sat, 6 Oct 2012 11:23:05 +0000 (13:23 +0200)]
tdb: Make robust against shrinking tdbs
When probing for a size change (eg. just before tdb_expand, tdb_check,
tdb_rescue) we call tdb_oob(tdb, tdb->map_size, 1, 1). Unfortunately
this does nothing if the tdb has actually shrunk, which as Volker
demonstrated, can actually happen if a "longlived" parent crashes.
So move the map/update size/remap before the limit check.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Jeremy Allison [Fri, 5 Oct 2012 22:51:19 +0000 (15:51 -0700)]
We should never just assign an st_mode to an ace->perms field, theoretically
they are different so should go through a mapping function. Ensure this is so.
Practically this does not matter, as for user permissions the mapping
function is an identity, and the extra bits we may add are ignored
anyway, but this makes the intent clear.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Oct 6 03:04:14 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 5 Oct 2012 22:48:07 +0000 (15:48 -0700)]
Modify ensure_canon_entry_valid() into ensure_canon_entry_valid_on_set() - makes the logic clearer.
Jeremy Allison [Fri, 5 Oct 2012 22:09:06 +0000 (15:09 -0700)]
Simplify ensure_canon_entry_valid by splitting out the _get codepath.
Simo Sorce [Fri, 5 Oct 2012 14:32:32 +0000 (10:32 -0400)]
talloc: Convert error cecking macros into fns
This will avoid 'surprise returns' and makes the code cleare to readers.
These macros were complex enough to warrant a full function anyway not
just for readability but also for debuggability.
Thanks David for pointing out this issue.
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Fri Oct 5 23:24:17 CEST 2012 on sn-devel-104
Simo Sorce [Sat, 22 Sep 2012 20:35:21 +0000 (16:35 -0400)]
Add tests for talloc_memlimit
Autobuild-User(master): Simo Sorce <idra@samba.org>
Autobuild-Date(master): Fri Oct 5 07:36:38 CEST 2012 on sn-devel-104
Simo Sorce [Sat, 22 Sep 2012 20:15:47 +0000 (16:15 -0400)]
Add memory limiting capability to talloc
By calling talloc_set_memlimit() we can now set a max memory limit
for a whole talloc hierarchy.
ANy attempt to allocate memory beyond the max allowed for the whole
hierarchy wil cause an allocation failure.
Stealing memory correctly accounts for used memory in the old and the new
hierarchy but exceeding the memory limit in the new parent will not cause
a failure.
Jeremy Allison [Thu, 4 Oct 2012 20:50:51 +0000 (13:50 -0700)]
Ensure the masks don't conflict with the ACL checks.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Oct 5 00:36:40 CEST 2012 on sn-devel-104
Jeremy Allison [Thu, 4 Oct 2012 19:03:27 +0000 (12:03 -0700)]
Update WHATSNEW.txt with removed parameters.