Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:51:26 +0000 (20:51 +0100)]
ldb:ldbsearch tool - use "%u" for printing unsigned integers
Matthias Dieter Wallnöfer [Sat, 5 Feb 2011 12:19:56 +0000 (13:19 +0100)]
ldb:ldbedit tool - don't forget about the "do_edit" result code
Use it for computing the program exit code. The "result" has not to be
free'd explicitly since it's a child by "ldb" which itself is child by
"mem_ctx".
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:48:54 +0000 (12:48 +0100)]
ldb:ldbedit tool - fix bug #7914
"modify_record" returns "-1" when failing, otherwise the number of
modifies performed as an "unsigned int" converted to "int".
When we get "-1" we immediately need to stop (the error message has
already been generated by the function itself).
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:39:42 +0000 (12:39 +0100)]
ldb:ldbedit tool - use unsigned counters for consistency with other LDB tools
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:52:33 +0000 (20:52 +0100)]
ldb:ldbedit tool - use "%u" for printing out unsigned integers
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:39:04 +0000 (12:39 +0100)]
ldb:ldbedit tool - use LDB result constants where needed
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:38:10 +0000 (12:38 +0100)]
ldb:ldbrename tool - use LDB result constant where needed
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:37:32 +0000 (12:37 +0100)]
ldb:ldbmodify tool - use unsigned counters for consistency with other LDB tools
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:36:13 +0000 (12:36 +0100)]
ldb:ldbdel tool - use LDB result constants for consistency
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:37:58 +0000 (20:37 +0100)]
ldb:ldbadd tool - use LDB return codes where possible
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:34:47 +0000 (12:34 +0100)]
ldb:ldbadd tool - use "%u" for printing out unsigned integers
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:34:08 +0000 (12:34 +0100)]
ldb:ldbadd tool - use LDB result constants for consistency
Günther Deschner [Wed, 9 Feb 2011 16:56:45 +0000 (17:56 +0100)]
s3-waf: we check for attr in ../lib/util/script already, so we cannot set to EMPTY here.
Hopefully fixes the irix build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 9 18:58:15 CET 2011 on sn-devel-104
Günther Deschner [Wed, 9 Feb 2011 16:37:40 +0000 (17:37 +0100)]
s3-waf: as long as we dont have --with-featureX=yes|no|auto handling, avoid exiting.
Guenther
Günther Deschner [Wed, 9 Feb 2011 16:43:54 +0000 (17:43 +0100)]
s3-waf: check k5crypto in some more locations.
Guenther
Günther Deschner [Wed, 9 Feb 2011 16:43:30 +0000 (17:43 +0100)]
s3-waf: support non-default krb5-config and cups-config locations.
Guenther
Volker Lendecke [Wed, 9 Feb 2011 14:50:34 +0000 (15:50 +0100)]
tevent: Fix typos
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 18:13:18 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 9 Feb 2011 13:21:24 +0000 (14:21 +0100)]
s3-rpc_server: We need a messaging context for rpc.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Feb 9 17:26:00 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 9 Feb 2011 13:08:34 +0000 (14:08 +0100)]
s3-rpc_server: Fixed possible segfault with client_id.
Christian Ambach [Wed, 9 Feb 2011 14:35:24 +0000 (15:35 +0100)]
s3:utils enable sharesec for registry shares
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb 9 16:41:31 CET 2011 on sn-devel-104
Gregor Beck [Tue, 8 Feb 2011 23:04:48 +0000 (00:04 +0100)]
s3:net idmap: implement net idmap delete
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb 9 15:06:06 CET 2011 on sn-devel-104
Michael Adam [Wed, 9 Feb 2011 12:47:21 +0000 (13:47 +0100)]
s3:net idmap dump: report correct database file when failed to open idmap db.
Gregor Beck [Tue, 8 Feb 2011 11:40:23 +0000 (12:40 +0100)]
s3:net idmap dump: use net_idmap_dbfile
Michael Adam [Tue, 8 Feb 2011 22:24:57 +0000 (23:24 +0100)]
s3:net idmap restore: correctly abort operation if dbfile could not be determined
Michael Adam [Tue, 8 Feb 2011 22:16:31 +0000 (23:16 +0100)]
s3:net idmap: fix error reporting in net_idmap_dbfile()
The last case which results in dbfile == NULL is not an
out of memory case but means no --db has been specified
and the idmap backend is not supported for auto-determining
the idmap tdb file.
Gregor Beck [Tue, 8 Feb 2011 11:06:07 +0000 (12:06 +0100)]
s3:net factor out net_idmap_dbfile
Gregor Beck [Tue, 8 Feb 2011 11:03:08 +0000 (12:03 +0100)]
s3:net idmap restore: fix segfault on missing input file
Gregor Beck [Tue, 8 Feb 2011 11:01:34 +0000 (12:01 +0100)]
s3:net add option --db
Michael Adam [Wed, 9 Feb 2011 12:45:22 +0000 (13:45 +0100)]
s3:testparm: add "--option" to testparm
This way one can test the --option feature with testparm.
E.g.:
testparm -s -v --option="parameter=value" | grep parameter
should print "parameter = value"
Michael Adam [Wed, 9 Feb 2011 12:44:42 +0000 (13:44 +0100)]
s3:popt: add POPT_COMMON_OPTION to provide only the "--option" feature
Michael Adam [Wed, 9 Feb 2011 12:42:38 +0000 (13:42 +0100)]
s3:loadparm: skip leading spaces in parameter values from the command line
Jelmer Vernooij [Sun, 30 Jan 2011 09:59:41 +0000 (10:59 +0100)]
provision: Add missing dependency on pyldb-util.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb 9 13:55:10 CET 2011 on sn-devel-104
Jelmer Vernooij [Sun, 30 Jan 2011 09:59:14 +0000 (10:59 +0100)]
dlinklist: Change license to LGPLv3+ (checked with tridge).
Stefan Metzmacher [Wed, 9 Feb 2011 05:56:25 +0000 (06:56 +0100)]
s3:rpc_server: create binding_handle in rpc_pipe_open_external()
metze
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 12:30:50 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 9 Feb 2011 05:55:33 +0000 (06:55 +0100)]
s3:rpc_client: make rpccli_bh_create() non-static for now
metze
Kamen Mazdrashki [Wed, 9 Feb 2011 01:40:52 +0000 (03:40 +0200)]
s4/tests: Implement a blackbox test for 'samba-tool drs' command
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Feb 9 11:45:30 CET 2011 on sn-devel-104
Kamen Mazdrashki [Wed, 9 Feb 2011 01:40:17 +0000 (03:40 +0200)]
s4/tests: Move command line processing into separate method to be reused
Kamen Mazdrashki [Wed, 9 Feb 2011 01:01:16 +0000 (03:01 +0200)]
s4/tests: Implement BlackboxTestCase.check_output() method
I am going to need this to check if output is OK (kind of)
Kamen Mazdrashki [Wed, 9 Feb 2011 01:00:06 +0000 (03:00 +0200)]
s4/samba-tool/drs: Make use of Command.message() method instead of using 'print'
Kamen Mazdrashki [Mon, 7 Feb 2011 12:13:06 +0000 (14:13 +0200)]
s4/samba-tool/drs: Move get_dsServiceName function at module level to be re-used
Kamen Mazdrashki [Fri, 4 Feb 2011 02:14:13 +0000 (04:14 +0200)]
s4/samba-tool: 'drs options' command implementation
Current implementation handle only one flag change per call
Andrew Bartlett [Tue, 8 Feb 2011 23:59:18 +0000 (10:59 +1100)]
waf Remove debugging hacks left in the top level build
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb 9 01:55:15 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 8 Feb 2011 23:50:57 +0000 (10:50 +1100)]
s4-waf Remove source4 build system.
The top level build is the official build system now.
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 23:46:21 +0000 (10:46 +1100)]
s4-auth Fix setting of bad_password_count in auth_convert_user_info_dc_sambaseinfo()
Discovered during the convertion to auth_user_info.
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 09:38:05 +0000 (20:38 +1100)]
s4-selftest Fix valgrind and gdb options for top level build
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 05:53:13 +0000 (16:53 +1100)]
s4-auth Rework auth subsystem to remove struct auth_serversupplied_info
This changes auth_serversupplied_info into the IDL-defined struct
auth_user_info_dc. This then in turn contains a struct
auth_user_info, which is the only part of the structure that is
mainted into the struct session_info.
The idea here is to avoid keeping the incomplete results of the
authentication (such as session keys, lists of SID memberships etc) in
a namespace where it may be confused for the finalised results.
Andrew Barltett
Andrew Bartlett [Tue, 8 Feb 2011 05:39:34 +0000 (16:39 +1100)]
s4-auth Add auth.idl to encode auth subsystem structures in IDL
This is not only a useful way to encode stuff, it also allows python
to handle the structures, and natrually allows them to be NDR encoded.
Andrew Bartlett
Jeremy Allison [Tue, 8 Feb 2011 23:07:48 +0000 (15:07 -0800)]
Add fdopendir to the VFS. We will use this to reuse a directory fd already open by NtCreateX.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 9 00:55:22 CET 2011 on sn-devel-104
Jeremy Allison [Tue, 8 Feb 2011 23:05:00 +0000 (15:05 -0800)]
Pass fsp to dptr_CloseDir(). Cope with setting the fd if we're closing an fd that opendir knows about.
Jeremy Allison [Tue, 8 Feb 2011 23:04:47 +0000 (15:04 -0800)]
Add configure checks for fdopendir.
Jeremy Allison [Tue, 8 Feb 2011 22:43:07 +0000 (14:43 -0800)]
Add fdopendir().
Volker Lendecke [Tue, 8 Feb 2011 22:08:21 +0000 (23:08 +0100)]
s3: Fix some nonempty blank lines and some typos
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 00:01:45 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:56:32 +0000 (14:56 +0100)]
selftest: remove make oldtest.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 22:16:31 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:55:12 +0000 (14:55 +0100)]
s3-selftest: let valgrindtest use the new make test.
Guenther
Günther Deschner [Tue, 8 Feb 2011 19:44:55 +0000 (20:44 +0100)]
waf: bring back shared Makefile and configure (needed by s3-waf).
Guenther
Revert "build: removed unused build scripts"
This reverts commit
2e520ca91180920e4c8b71be4eaa7fabb56d2a12.
Günther Deschner [Tue, 8 Feb 2011 16:19:23 +0000 (17:19 +0100)]
s3-spoolss: Dont wipe out all drivers when only one should be deleted.
Great catch from Bjoern Baumbach <bb@sernet.de> !
Andreas, Simo, please check.
We now have a torture test (rpc.spoolss.driver.driver.multiple_drivers) for this.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 18:11:48 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 16:16:51 +0000 (17:16 +0100)]
s4-smbtorture: add torture test to check proper add and delete driver operations.
Thanks to Bjoern Baumbach <bb@sernet.de> for pushing us to test and verify this.
Guenther
Günther Deschner [Tue, 8 Feb 2011 14:16:44 +0000 (15:16 +0100)]
s3-selftest: mark the driver timestamp test as knownfail for now.
Guenther
Günther Deschner [Tue, 8 Feb 2011 14:16:20 +0000 (15:16 +0100)]
s4-smbtorture: also run the driver timestamp spoolss test against samba.
Guenther
Günther Deschner [Fri, 28 Jan 2011 13:02:55 +0000 (14:02 +0100)]
s4-waf: split out wscript_build for ndrdump binary.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 14:50:54 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:00:02 +0000 (14:00 +0100)]
lib/compression: add shared wscript_build.
Guenther
Günther Deschner [Tue, 8 Feb 2011 10:49:33 +0000 (11:49 +0100)]
libndr: apply some const and make is_valid_policy_hnd a callback to policy_handle_empty.
Guenther
Günther Deschner [Tue, 8 Feb 2011 09:45:39 +0000 (10:45 +0100)]
pam: share pam errors in a common location.
Guenther
Jelmer Vernooij [Sun, 30 Jan 2011 09:57:30 +0000 (10:57 +0100)]
pysecurity: Add missing dependency on pytalloc-util.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Feb 8 13:16:43 CET 2011 on sn-devel-104
Gregor Beck [Fri, 28 Jan 2011 09:58:03 +0000 (10:58 +0100)]
s3:net: remove unused net_idmap_help
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 8 11:50:37 CET 2011 on sn-devel-104
Andreas Schneider [Mon, 7 Feb 2011 17:06:40 +0000 (18:06 +0100)]
s3: Added file for clang complete support in vim.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb 8 10:40:42 CET 2011 on sn-devel-104
Andreas Schneider [Mon, 7 Feb 2011 17:06:04 +0000 (18:06 +0100)]
s3: Added missing files in .gitignore.
Günther Deschner [Mon, 7 Feb 2011 23:04:20 +0000 (00:04 +0100)]
libndr: share some uuid helpers.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 09:52:56 CET 2011 on sn-devel-104
Günther Deschner [Mon, 7 Feb 2011 22:27:57 +0000 (23:27 +0100)]
ndr: merge ndr_map_error2string and ndr_errstr.
Guenther
Günther Deschner [Mon, 7 Feb 2011 22:21:41 +0000 (23:21 +0100)]
ndr: move null_ndr_syntax_id to the common libndr location.
Guenther
Günther Deschner [Fri, 28 Jan 2011 22:38:21 +0000 (23:38 +0100)]
ndr: merge duplicate ndr_map_error2ntstatus() functions.
Guenther
Jeremy Allison [Tue, 8 Feb 2011 04:46:36 +0000 (20:46 -0800)]
If possible (O_DIRECTORY exists) open an fd for a directory open.
Start of the move towards handle-based code for directory access.
Currently makes fstat/fchown code work for directories rather than
falling back to pathnames.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 8 06:34:41 CET 2011 on sn-devel-104
Jeremy Allison [Tue, 8 Feb 2011 01:34:22 +0000 (17:34 -0800)]
Use corrcet function instead of cut-and-paste code.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 8 03:23:40 CET 2011 on sn-devel-104
Jeremy Allison [Tue, 8 Feb 2011 01:33:26 +0000 (17:33 -0800)]
Fix leak in error path.
Simo Sorce [Fri, 4 Feb 2011 01:51:45 +0000 (20:51 -0500)]
mit-samba: Allow nesting on the event context
This context is used in ldb, and ldb modules apparently abort if nesting is not
allowed.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Mon Feb 7 20:58:02 CET 2011 on sn-devel-104
Volker Lendecke [Thu, 3 Feb 2011 12:23:50 +0000 (05:23 -0700)]
libcli/security: Make add_sid_to_array_unique use a uin32_t counter
Logical consequence of the previous commit
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 7 19:24:19 CET 2011 on sn-devel-104
Volker Lendecke [Thu, 3 Feb 2011 12:22:36 +0000 (05:22 -0700)]
libcli/security: Make del_sid_from_array take a uint32_t
This aligns it with add_sid_to_array
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Mon, 7 Feb 2011 12:30:11 +0000 (13:30 +0100)]
s3:net conf: fix a comment typo
Stefan Metzmacher [Mon, 7 Feb 2011 12:48:08 +0000 (13:48 +0100)]
script/autobuild.py: git diff has a '--stat' option, no need to use 'diffstat'
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 7 14:55:10 CET 2011 on sn-devel-104
Günther Deschner [Mon, 7 Feb 2011 12:21:35 +0000 (13:21 +0100)]
s3-waf: add --with-automount option.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 7 14:11:03 CET 2011 on sn-devel-104
Günther Deschner [Mon, 7 Feb 2011 12:12:17 +0000 (13:12 +0100)]
waf: add clock_gettime clock ID checks to libreplace wscript.
Guenther
Günther Deschner [Mon, 7 Feb 2011 11:38:48 +0000 (12:38 +0100)]
s3-waf: fix wrong check for vfs_aio_fork dependencies.
Guenther
Günther Deschner [Thu, 3 Feb 2011 11:25:24 +0000 (12:25 +0100)]
s3-waf: fix the build after winreg and rpc services changes.
Andreas, please check.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 7 13:18:41 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 2 Feb 2011 10:47:37 +0000 (11:47 +0100)]
s3-perfcount: Create the directory on tdb open.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 14:33:02 +0000 (15:33 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_multi_sz.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 14:29:48 +0000 (15:29 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_query_dword.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 14:25:13 +0000 (15:25 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_X.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 14:11:05 +0000 (15:11 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_X.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 13:58:08 +0000 (14:58 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_dword.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 13:48:11 +0000 (14:48 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_set_sz..
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 13:28:39 +0000 (14:28 +0100)]
s3-rpc_server: Migrated spoolss to dcerpc_winreg_enum_keys.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 12:38:16 +0000 (13:38 +0100)]
s3-services: Remove obsolete services_db.c.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 10:50:10 +0000 (11:50 +0100)]
s3-smbd: Init the svcctl registry keys on service startup.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 31 Jan 2011 15:40:16 +0000 (16:40 +0100)]
s3-rpc_server: Added a winreg based svcctl registry init.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 1 Feb 2011 10:49:33 +0000 (11:49 +0100)]
s3-rpc_server: Added a svcctl shutdown function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 31 Jan 2011 15:40:33 +0000 (16:40 +0100)]
s3-services: Migrated svcctl registry functions to winreg.
This is a bigger commit. It moves the relevant function to
svc_winreg_glue. We need to use them in the same commit else we have
problems with prototypes in proto.h.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 28 Jan 2011 11:37:18 +0000 (12:37 +0100)]
s3-registry: Remove obsolete reg_eventlog.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 28 Jan 2011 11:33:20 +0000 (12:33 +0100)]
s3-smbd: Init the eventlog registry on service startup.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 27 Jan 2011 17:06:16 +0000 (18:06 +0100)]
s3-util: Moved eventlog_add_source to admin util.
This function is only used in the admin util.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 27 Jan 2011 18:22:02 +0000 (19:22 +0100)]
s3-rpc_server: Added a winreg based eventlog registry init.
This enumerates the keys first and only creates them if they don't exist
yet.
Signed-off-by: Günther Deschner <gd@samba.org>