Andrew Tridgell [Sat, 30 Oct 2004 11:07:28 +0000 (11:07 +0000)]
r3390: fixed schannel server side support. RPC-SCHANNEL now works against Samba4.
(This used to be commit
01f5c1c72d9fc8f21029adc586154b0c54f76c9e)
Andrew Tridgell [Sat, 30 Oct 2004 10:51:18 +0000 (10:51 +0000)]
r3389: fixed schannel client side code. RPC-SCHANNEL now works against w2k3
again. The problem was that the sig_size method didn't get added in
the gensec conversion.
(This used to be commit
a49b61173dbadbf4efb0fbcfaba67da393913639)
Andrew Tridgell [Sat, 30 Oct 2004 09:23:39 +0000 (09:23 +0000)]
r3388: when doing schannel use a anonymous session setup (as the machine acct
isn't allowed to login on a share)
(This used to be commit
8c0be60d8d59863f0bcdd17012dce923c139ce09)
Andrew Tridgell [Sat, 30 Oct 2004 05:53:56 +0000 (05:53 +0000)]
r3387: fixed pvfs to pass the NTDENY tests. The tricky bit was
SA_RIGHT_FILE_EXECUTE, which depends on a flags2 bit
(This used to be commit
c36851d230bcf552ed79322f8358060ab164ec09)
Andrew Tridgell [Sat, 30 Oct 2004 04:59:52 +0000 (04:59 +0000)]
r3386: - fixed --seed option in smbtorture
- added new tests BASE-NTDENY1 and BASE-NTDENY2. These are the
ntcreatex equivalents of the BASE-DENY1 and BASE-DENY2
tests. Unfortunately, with ntcreatex there are 4 million combination
and trying each one takes 1 second, so randomised testing is the
only choice. The BASE-DENY1 test can operate in parallel with
hundreds of connections, speeding things up a bit (as most time is
spent waiting 1 second for a sharing violation to come back)
(This used to be commit
b95493d3d16581b8dd8f4727cd10631c18e16748)
Andrew Tridgell [Sat, 30 Oct 2004 04:56:27 +0000 (04:56 +0000)]
r3385: when discarding a unmatched reply print the command type to help debugging
(This used to be commit
91139ed8d41a1d4b99379142b3e09c6d0a8ff159)
Andrew Tridgell [Sat, 30 Oct 2004 04:55:45 +0000 (04:55 +0000)]
r3384: added SA_RIGHT_FILE_WRITE_APPEND, which is a combination of write and append
(This used to be commit
d098636d7faacce7f024c74b945899edb824d740)
Andrew Tridgell [Sat, 30 Oct 2004 02:17:03 +0000 (02:17 +0000)]
r3383: avoid multi-part SMBtrans and SMBtrans2 replies until our client library can handle
them properly (they are difficult to do in an async fashion).
By choosing trans.in.max_data to fix in the negotiated buffer size a
server won't send us multi-part replies.
I notice that windows seems to avoid them too :)
(This used to be commit
e23edf762cace35f937959c9ffbef718431a79b9)
Andrew Tridgell [Sat, 30 Oct 2004 01:22:52 +0000 (01:22 +0000)]
r3380: - changed the default behaviour of server signing. We now have a default
setting of "server signing = auto", which means to offer signing
only if we have domain logons enabled (ie. we are a DC). This is a
better match for what windows clients want, as unfortunately windows
clients always use signing if it is offered, and when they use signing
they not only go slower because of the signing itself, they also
disable large readx/writex support, so they end up sending very small
IOs for.
- changed the default max xmit again, this time matching longhorn,
which uses 12288. That seems to be a fairly good compromise value.
(This used to be commit
e63edc81716fefd58a3be25deb3b25e45471f196)
Andrew Tridgell [Fri, 29 Oct 2004 21:55:06 +0000 (21:55 +0000)]
r3375: changed the default max xmit until I fix a problem with the SMBtrans multi-part code
A higher max xmit avoids multi-part trans requests
(This used to be commit
23f4ce3a7d207db0c2705295cbb8d46dc5290b1a)
Jelmer Vernooij [Fri, 29 Oct 2004 21:53:42 +0000 (21:53 +0000)]
r3374: Couple of bug fixes
(This used to be commit
f8e45e143087d333da4afc193b4fa1991ba04c63)
Andrew Tridgell [Fri, 29 Oct 2004 21:52:49 +0000 (21:52 +0000)]
r3373: added better error reporting in pvfs_open
(This used to be commit
22abdfca961a00e7c48ba4231e12f254781d315d)
Andrew Tridgell [Fri, 29 Oct 2004 21:51:36 +0000 (21:51 +0000)]
r3372: fixed the initial directory permissions for pvfs_mkdir()
(This used to be commit
72ddb38a7214a49548a27ef6e6b6e7b0944b01f0)
Andrew Tridgell [Fri, 29 Oct 2004 21:51:00 +0000 (21:51 +0000)]
r3371: fixed endpoint for browser.idl
(This used to be commit
b2ec1e75a203b8de5ab2ae8e91eca3ec43b98741)
Jelmer Vernooij [Fri, 29 Oct 2004 14:53:23 +0000 (14:53 +0000)]
r3370: Initial work on Add Key/Delete Key/Add Value/Mod Value/Del Value support in
gregedit
(This used to be commit
33f429c61f2859e3ad60fa38823174bbd331d91a)
Jelmer Vernooij [Fri, 29 Oct 2004 13:38:37 +0000 (13:38 +0000)]
r3369: More registry updates
We now pass the RPC-WINREG torture test.
Also, constructions like the following work now:
regtree <-> smbd <-> NTUSER.DAT
(This used to be commit
df952e95cd1cbbfb62b4620e9452993aaef44ad3)
Jelmer Vernooij [Fri, 29 Oct 2004 12:12:24 +0000 (12:12 +0000)]
r3368: Default to rpc backend with binding "ncalrpc:" if no backend was specified in the various registry tools.
Allow opening a remote registry to partly fail (I.e. if not all hives could be opened)
(This used to be commit
313034b10d7a70d079e2bec1af38cf2a7cd918c1)
Jelmer Vernooij [Fri, 29 Oct 2004 11:44:59 +0000 (11:44 +0000)]
r3367: More registry updates.
Add support flush_key and close_hive.
(This used to be commit
c526273df238c994c4de3c1704c6e95433f2331c)
Andrew Tridgell [Fri, 29 Oct 2004 11:39:08 +0000 (11:39 +0000)]
r3366: updates from the junkcode version of talloc.
The main change is to get rid of talloc_parent_chunk() from all
commonly used code paths, so talloc_free() is now O(1) again. It was
originally O(1), but the last round of changes broke that.
Also some documentation updates
(This used to be commit
d4fe21cdb982c8046b19f671d872b43cdd2efc72)
Andrew Bartlett [Fri, 29 Oct 2004 09:58:23 +0000 (09:58 +0000)]
r3365: Fill in the user and primary group SIDs into the 'server info' before
the session info.
Andrew Bartlett
(This used to be commit
5db5c30ebedca1fee8924a9416bcb94ed13af372)
Andrew Bartlett [Fri, 29 Oct 2004 09:57:31 +0000 (09:57 +0000)]
r3364: Add parameter to fix the compile.
Andrew Bartlett
(This used to be commit
effd10883b7b9d879a3e96801ef37992bc93bc97)
Andrew Tridgell [Fri, 29 Oct 2004 09:28:35 +0000 (09:28 +0000)]
r3363: added basic support for SA_RIGHT_FILE_EXECUTE, needed for opening .dll files
(This used to be commit
ba1bfd51e1b694cb69afe559f695addaf03b4d81)
Andrew Bartlett [Fri, 29 Oct 2004 09:19:54 +0000 (09:19 +0000)]
r3362: Change netlogon.idl so we can parse the 'info3' seperate from it's surroundings, and rename user_id -> rid, as it could be a user or group id.
Andrew Bartlett
Andrew Bartlett
(This used to be commit
18d0d70994ddb41b381b8fe42bc179cb9fdf0b11)
Andrew Bartlett [Fri, 29 Oct 2004 09:15:41 +0000 (09:15 +0000)]
r3361: Allow Samba4 (I'm interested in ntlm_auth in particular) to use
Samba3's winbind. This is also the start of domain membership code in
Samba4, as we now (partially) parse the info3, and use it like Samba3
does.
Andrew Bartlett
(This used to be commit
c1b7303c1c7d9fb815006c3bd2af20a0010d15a8)
Andrew Tridgell [Fri, 29 Oct 2004 08:38:59 +0000 (08:38 +0000)]
r3360: improved the deletion of tmp files. smbd now puts all tmp files in var/locks/smbd.tmp/
and deletes that dir on startup.
(This used to be commit
7e942e7f1bd2c293a0e6648df43a96f8b8a2a295)
Andrew Bartlett [Fri, 29 Oct 2004 08:32:59 +0000 (08:32 +0000)]
r3359: Add magic auto-initialisation hooks here, to match the rest of
secrets. (Which will, I am assured, go away).
Andrew Bartlett
(This used to be commit
415ba959271f6f97d6fe3b923e49a58611edf8bd)
Andrew Bartlett [Fri, 29 Oct 2004 08:31:27 +0000 (08:31 +0000)]
r3358: Try to put all the basic struct dom_sid manipulation functions in one
place. (I always have trouble finding one half or the other).
Andrew Bartlett
(This used to be commit
224b59edba7c00ad515b4c5e3e9a886700247ad4)
Andrew Tridgell [Fri, 29 Oct 2004 07:29:26 +0000 (07:29 +0000)]
r3357: removed the need to use TDB_CLEAR_IF_FIRST in Samba4.
We found a few months ago that TDB_CLEAR_IF_FIRST is extremely
inefficient for large numbers of connections, due to a fundamental
limitation in the way posix byte range locking is implemented. Rather
than the nasty workaround we had for Samba3, we now have a single
"cleanup tmp files" function that runs when smbd starts. That deletes
the tmp tdbs, so TDB_CLEAR_IF_FIRST is not needed at all.
(This used to be commit
ffa285bc783c775a2d53a58fb691ca339e6c76ae)
Andrew Tridgell [Fri, 29 Oct 2004 07:00:14 +0000 (07:00 +0000)]
r3356: in the standard process model we need to make sure we close all
listening sockets after the fork to prevent the child still listening
on incoming requests.
I have also added an optimisation where we use dup()/close() to lower
the file descriptor number of the new socket to the lowest possible
after closing our listening sockets. This keeps the max fd num passed
to select() low, which makes a difference to the speed of select().
(This used to be commit
f2a9bbc317ba86ebe87c3ca27a3a0192de91014d)
Andrew Tridgell [Fri, 29 Oct 2004 06:01:51 +0000 (06:01 +0000)]
r3355: fixed the old style search code in smb_server to correctly handle
searches that go beyond the negotiated max xmit size
(This used to be commit
84762a59763005f5d29106cd409867cb150d648f)
Andrew Tridgell [Fri, 29 Oct 2004 06:01:00 +0000 (06:01 +0000)]
r3354: honor "max xmit" and "max mux" from smb.conf in our client code. This
is important as it allows the test suite to exercise the multiple
reply logic in smbd for trans2 search replies.
(This used to be commit
865159016ab1e806465a55697444228fb3fa286e)
Andrew Tridgell [Fri, 29 Oct 2004 05:58:22 +0000 (05:58 +0000)]
r3353: don't reference dos.attrib unless its initialised
(This used to be commit
498799e4260b1c5e2bfc4fac4cba1080e8ec0a04)
Andrew Tridgell [Fri, 29 Oct 2004 05:31:35 +0000 (05:31 +0000)]
r3352: make smbcli_read() and smbcli_write() work with very small negotiated SMB buffer sizes
(This used to be commit
320ca0214d97dc6cebb00ddc98a1eb71e2b4c917)
Andrew Tridgell [Fri, 29 Oct 2004 04:43:28 +0000 (04:43 +0000)]
r3351: handle far more operations on open directory handles. pvfs was failing
with a wxp client because of qfileinfo operations on directories
failing with NT_STATUS_INVALID_HANDLE after the fstat() failed (as
pvfs sets f->fd to -1 for directories)
(This used to be commit
1993128cb1dbf49db6e3e0387996ecf2a14b8d76)
Andrew Tridgell [Fri, 29 Oct 2004 03:48:49 +0000 (03:48 +0000)]
r3350: fixed a bug with sending multiple replies for the one request, as
happens with trans2, trans and echo. Now that smbd is async we queue
the multiples replies all at once, and now need a way to ensure each
reply gets it own smbsrv_request buffer. I have added
req_setup_secondary() to cope with this.
(This used to be commit
2dbd2abc5f197ee21d7dceeda2922c7449c46d99)
Andrew Tridgell [Fri, 29 Oct 2004 01:22:47 +0000 (01:22 +0000)]
r3349: fixed more uninitialised variable problems with the nbench module
(This used to be commit
915faf49350b29a46f39354cbac746455d70c92c)
Jelmer Vernooij [Fri, 29 Oct 2004 01:10:40 +0000 (01:10 +0000)]
r3348: More registry fixes and additions. The following functions work right now against samba 4, at least with a ldb backend:
winreg_Open*
winreg_OpenKey
winreg_EnumKey
winreg_DeleteKey
winreg_CreateKey
(This used to be commit
a71d51dd3b136a1bcde1704fe9830985e06bb01b)
Andrew Tridgell [Fri, 29 Oct 2004 01:07:07 +0000 (01:07 +0000)]
r3347: fixed an uninitialised variable bug. Surprisingly hard to track down,
as valgrind got a corrupt stack when trying to debug it.
(This used to be commit
58cabaa7022e5521961551462d31fbd90e4183e4)
Andrew Tridgell [Fri, 29 Oct 2004 00:51:41 +0000 (00:51 +0000)]
r3346: - simplified vfs_nbench.c a bit, by using req->async_state->ntvfs inside
nbench_log() instead of declaring nprivates every time.
- added correct async_setup pass-thru in nbench
(This used to be commit
8d79bceeca4528ab31cff1adc7706faa075013ac)
Andrew Tridgell [Thu, 28 Oct 2004 23:09:40 +0000 (23:09 +0000)]
r3341: - don't zero the async structure (makes valgrind more useful)
- get rid of req->mid, as it isn't a safe value to use to match
requests in the server (it is safe in the client code, as we choose
the mid, but in the server we can't rely on other clients to choose
the mid carefully)
(This used to be commit
938fb44351e12a515073ea94cd306988d5ca7340)
Jelmer Vernooij [Thu, 28 Oct 2004 23:06:12 +0000 (23:06 +0000)]
r3340: Various fixes in the registry code. Implement the EnumKey call
in the server.
(This used to be commit
da65a248c292a90342e1394ee4132ef2c7afd3c8)
Jelmer Vernooij [Thu, 28 Oct 2004 22:38:27 +0000 (22:38 +0000)]
r3338: More work on the winreg RPC server. Opening hives is now supported, most other calls
return WERR_NOT_SUPPORTED for now.
Hive backends can be set like this:
registry:HKEY_LOCAL_MACHINE = ldb:tdb://registry.tdb
registry:HKEY_CURRENT_USER = gconf
registry:HKEY_USERS = dir:/tmp/registry
registry:HKEY_CLASSES_ROOT = nt4:/path/to/NTUSER.DAT
registry:HKEY_PERFORMANCE_DATA = w95:/path/to/USER.DAT
(This used to be commit
42844a4e3422bbbe891ba944c0e97861db7763ec)
Stefan Metzmacher [Thu, 28 Oct 2004 22:18:52 +0000 (22:18 +0000)]
r3337: remove debug code and reanable the reall logging:-)
metze
(This used to be commit
00b285e5a815e6d53ede7d102dee4e5b79d47f52)
Stefan Metzmacher [Thu, 28 Oct 2004 21:48:53 +0000 (21:48 +0000)]
r3336: use a struct ntvfs_async_state to be able to do async chaning of ntvfs modules
the idea is that a passthru module can use ntvfs_async_state_push() before
calling ntvfs_next_*() and in the _send function it calls
ntvfs_async_state_pop() and then call the upper layer send_fn itself
- ntvfs_nbench is now fully async
- the ntvfs_map_*() functions and the trans(2) mapping functions are not converted yet
metze
(This used to be commit
fde64c0dc142b53d128c8ba09af048dc58d8ef3a)
Andrew Tridgell [Thu, 28 Oct 2004 21:47:10 +0000 (21:47 +0000)]
r3335: better configure support for ipv6 - thanks to a quick tutorial from metze
(This used to be commit
76c4ba6d29a6ad1e21c2d7674e1f323e8d53d627)
Jelmer Vernooij [Thu, 28 Oct 2004 21:41:21 +0000 (21:41 +0000)]
r3334: Allow disabling IPv6 support using socket:noipv6
(This used to be commit
9c13f42c1fd489a6a663f614a41c59730c18a054)
Andrew Tridgell [Thu, 28 Oct 2004 21:36:27 +0000 (21:36 +0000)]
r3333: added configure tests for ipv6 support
(This used to be commit
9794570c6d0646cc34147bf8128802b181f658f0)
Jelmer Vernooij [Thu, 28 Oct 2004 21:24:29 +0000 (21:24 +0000)]
r3332: Check result codes in some more places...
(This used to be commit
87833cc75852bfe198c73ba1be67d1d36a43dc99)
Jelmer Vernooij [Thu, 28 Oct 2004 21:00:38 +0000 (21:00 +0000)]
r3331: Add string descriptions for a couple more WERROR's
(This used to be commit
1d374cdeb09b856449287cf12a77b23296c82a1d)
Jelmer Vernooij [Thu, 28 Oct 2004 19:14:26 +0000 (19:14 +0000)]
r3330: Use IPv6 for RPC client connections if we can
(This used to be commit
9426a655356f817f3d3174d25caa25224043d373)
Jelmer Vernooij [Thu, 28 Oct 2004 18:57:48 +0000 (18:57 +0000)]
r3329: Add support for IPv6
(This used to be commit
d8298901243ca4ce2ec420fa523c8e1407e72513)
Andrew Tridgell [Thu, 28 Oct 2004 13:51:41 +0000 (13:51 +0000)]
r3327: fixed another warning
we're now down the the last few warnings. Most are enum warnings
caused by unfinished code (unhandled enum levels). If you want to get
rid of those then work on finishing that code.
(This used to be commit
b62f7bb971c94be666ef816b24e93a14fd90f5e0)
Andrew Tridgell [Thu, 28 Oct 2004 13:41:35 +0000 (13:41 +0000)]
r3325: missed one of the torture changes ...
(This used to be commit
1629b593c6ad5a6c0a7dc0cd7588d979db887286)
Andrew Tridgell [Thu, 28 Oct 2004 13:40:50 +0000 (13:40 +0000)]
r3324: made the smbtorture code completely warning free
(This used to be commit
7067bb9b52223cafa28470f264f0b60646a07a01)
Andrew Tridgell [Thu, 28 Oct 2004 13:19:39 +0000 (13:19 +0000)]
r3323: more warning reductions
(This used to be commit
5921587ec26e4892efc678421277e4969417d7f5)
Andrew Tridgell [Thu, 28 Oct 2004 12:46:59 +0000 (12:46 +0000)]
r3322: fixed a bunch of warnings in the build, including one case where it was a real bug
(This used to be commit
02d5d0f685e44bd66aff4a007f0bf34c8f915574)
Andrew Tridgell [Thu, 28 Oct 2004 11:59:48 +0000 (11:59 +0000)]
r3321: make the test_echo.sh test suite test non-blocking on all rpc transports
this test now passes
(This used to be commit
3d270fd86caedd1023373160934d72d8cb065659)
Andrew Tridgell [Thu, 28 Oct 2004 11:59:03 +0000 (11:59 +0000)]
r3320: fixed bugs in the rpc_server code in handling partial packet receives and sends
it now passes the non-blocking test suite
(This used to be commit
6cdf485fb263c69d62ea2e98236d92ffbf6b7a3e)
Andrew Tridgell [Thu, 28 Oct 2004 11:58:09 +0000 (11:58 +0000)]
r3319: fixed a bug in the client library found by the new non-block testing code
(This used to be commit
1e62aa262aac1c8e3676caac7b65086d21b7a01e)
Andrew Tridgell [Thu, 28 Oct 2004 11:57:20 +0000 (11:57 +0000)]
r3318: generate random STATUS_MORE_ENTRIES errors (1 in 10 packets) as well
as randomly short recv/send when socket:testnonblock is enabled
(This used to be commit
718175a265d34bfdbcbf0cc6b55dbf6b389f3194)
Volker Lendecke [Thu, 28 Oct 2004 08:37:46 +0000 (08:37 +0000)]
r3317: Fix the build
(This used to be commit
5e8fd27d6ec7f44e6e802a2f29ec54e96fa78af0)
Andrew Tridgell [Thu, 28 Oct 2004 08:36:23 +0000 (08:36 +0000)]
r3316: give the LDAP server a chance of operating correctly non-blocking (it
didn't handle EINTR or EAGAIN)
(This used to be commit
c35a8f92c2df354e972ced9371d33657ce99988e)
Andrew Tridgell [Thu, 28 Oct 2004 08:15:12 +0000 (08:15 +0000)]
r3315: converted the libcli/raw/ code to use the generic socket library. This
allows me to test with the socket:testnonblock option. It passes.
(This used to be commit
7cb4bf8662825d507d8246647ffb10aa08bad794)
Andrew Tridgell [Thu, 28 Oct 2004 07:55:33 +0000 (07:55 +0000)]
r3314: added a option "socket:testnonblock" to the generic socket code. If
you set this option (either on the command line using --option or in
smb.conf) then every socket recv or send will return short by random
amounts. This allows you to test that the non-blocking socket logic in
your code works correctly.
I also removed the flags argument to socket_accept(), and instead made
the new socket inherit the flags of the old socket, which makes more
sense to me.
(This used to be commit
406d356e698da01c84e8aa5b7894752b4403f63c)
Andrew Tridgell [Thu, 28 Oct 2004 07:34:11 +0000 (07:34 +0000)]
r3313: in socket_accept() make the new socket non-blocking unless SOCKET_FLAG_BLOCK is set.
(This used to be commit
a2d92aa431e0e9752387eebe741d9e6f376f74d7)
Andrew Tridgell [Thu, 28 Oct 2004 06:45:28 +0000 (06:45 +0000)]
r3312: in the brlock code, we prevent lock stampedes by attempting to not
wakeup all pending locks at once. This change means that we only
trigger this anti-stampede code for write locks, as for pending read
locks the correct behaviour is to stampede (as they will all succeed)
(This used to be commit
8021d1d74207db1204139309592b9d2f80f2bd0e)
Tim Potter [Thu, 28 Oct 2004 06:17:38 +0000 (06:17 +0000)]
r3311: Consistency updates for form name members.
Add tests for EnumForms, GetForm, AddForm, DeleteForm.
(This used to be commit
6c49ce976a5c6982fa83de4ea723cef5597c29ef)
Tim Potter [Thu, 28 Oct 2004 06:16:32 +0000 (06:16 +0000)]
r3310: Update dependencies for swig wrappers.
(This used to be commit
5dcb300fca592cc62d325c47c857b046c90e7b42)
Tim Potter [Thu, 28 Oct 2004 06:14:10 +0000 (06:14 +0000)]
r3309: Add wrapper for dcerpc_server_name() function.
(This used to be commit
2d60a04f21da9dbe32c85b11afa98df74f5fd763)
Tim Potter [Thu, 28 Oct 2004 06:13:42 +0000 (06:13 +0000)]
r3308: Handle servers that don't have samr_Connect5.
(This used to be commit
52af866ffb427427d21daf11a4ca9a8b9881f1d5)
Andrew Tridgell [Thu, 28 Oct 2004 05:09:42 +0000 (05:09 +0000)]
r3307: fixed the send side of the smb_server code to be non-blocking. This
means the whole of the SMB handling code is now non-blocking.
(This used to be commit
30acedb943f0170d30e7b08925280d0dffc7873e)
Andrew Tridgell [Thu, 28 Oct 2004 04:36:12 +0000 (04:36 +0000)]
r3306: the main smb server code now handles non-blocking socket receives. I
haven't marked the socket non-blocking yet as I haven't checked that
the send path is OK for non-blocking.
(This used to be commit
bda978cc2a921a888534054135b9325427425dd2)
Andrew Tridgell [Thu, 28 Oct 2004 04:01:45 +0000 (04:01 +0000)]
r3305: added ncalrpc to the list of rpc transports tested by test_echo.sh, so
it gets regularly tested when I make changes.
(This used to be commit
e4216da824c8186df956d05742d96da05393c719)
Andrew Tridgell [Thu, 28 Oct 2004 04:00:43 +0000 (04:00 +0000)]
r3304: changed the API to lib/socket/ a little.
The main change is to make socket_recv() take a pre-allocated buffer,
rather than allocating one itself. This allows non-blocking users of
this API to avoid a memcpy(). As a result our messaging code is now
about 10% faster, and the ncacn_ip_tcp and ncalrpc code is also
faster.
The second change was to remove the unused mem_ctx argument from
socket_send(). Having it there implied that memory could be allocated,
which meant the caller had to worry about freeing that memory (if for
example it is sending in a tight loop using the same memory
context). Removing that unused argument keeps life simpler for users.
(This used to be commit
a16e4756cd68ca8aab4ffc59d4d9db0b6e44dbd1)
Tim Potter [Thu, 28 Oct 2004 03:58:17 +0000 (03:58 +0000)]
r3303: Call pull function for correct type instead of spoolss_PrinterInfo when
unmarshalling arrays.
(This used to be commit
ee535b6801e553d0a180f18cc2c4b4438ee23de1)
Tim Potter [Thu, 28 Oct 2004 03:40:35 +0000 (03:40 +0000)]
r3302: The security descriptors in spoolss_PrinterInfo2 and spoolss_PrinterInfo3
need to be marked as subcontext(0).
GetPrinter tests now work for all info levels!
(This used to be commit
53bd02960e17f7517e0d6c4f489d27b8bdcc7582)
Jelmer Vernooij [Wed, 27 Oct 2004 22:41:14 +0000 (22:41 +0000)]
r3301: Simplify code
(This used to be commit
dcdc6666d55c1ad006a5a4e58b337874478a66a4)
Andrew Tridgell [Wed, 27 Oct 2004 21:29:55 +0000 (21:29 +0000)]
r3300: initialise *sendlen on failure, to allow for callers to check only for
NT_STATUS_IS_ERR()
(This used to be commit
80a109de8458420ac0b40c563f4b3bc51424d759)
Jeremy Allison [Wed, 27 Oct 2004 17:40:41 +0000 (17:40 +0000)]
r3295: Fix for SMB signing with 56-bit DES session keys. From Nalin Dahyabhai <nalin@redhat.com>.
Jeremy.
(This used to be commit
afed78f359a15809b2d9b7566e16ade294944fa9)
Stefan Metzmacher [Wed, 27 Oct 2004 15:40:19 +0000 (15:40 +0000)]
r3291: fix the build, thx to pipitas for finding this
metze
(This used to be commit
d331a83f08b492ea463fb8781b4c46a71f80bf42)
Stefan Metzmacher [Wed, 27 Oct 2004 13:38:30 +0000 (13:38 +0000)]
r3290: allow SID_ANONYMOUS ( "S-1-5-7" ) to be the users sid
metze
(This used to be commit
177afd4855c66f46c82899b46f030803be63d52a)
Stefan Metzmacher [Wed, 27 Oct 2004 12:59:41 +0000 (12:59 +0000)]
r3289: Mr. L. and Mr. B.!
can we decide to not break WinXP clients:-)
metze
(This used to be commit
5eb0ff78d5e68f488a439545fdaec90c28ef877a)
Andrew Tridgell [Wed, 27 Oct 2004 08:36:51 +0000 (08:36 +0000)]
r3288: - updated the path processing in pvfs to pass the RAW-CHKPATH test. This
rather extensive test reveals some really bizarre error code
handling in w2k3.
- extended and simplified the RAW-CHKPATH test, making it easier to
read (note that Samba3 fails the new tests - jra may wish to look)
- marked RAW-CHKPATH as pass for pvfs
(This used to be commit
32dccf91cfa5b57f84dd6307720b3f45faa10ae0)
Tim Potter [Wed, 27 Oct 2004 07:45:52 +0000 (07:45 +0000)]
r3287: The devicename and formname fields in a device mode are fixed length
strings. Not sure how to write this as idl which maps to a char * but
at least devicemodes can be pulled off the wire sucessfully.
(This used to be commit
dd20730a09935b0783b020a020ed9283ca1e4608)
Andrew Tridgell [Wed, 27 Oct 2004 05:30:29 +0000 (05:30 +0000)]
r3286: filled in more missing SV_TYPE_* defines
(This used to be commit
891d87a71203fcee504875976a4ee61b84579c83)
Andrew Tridgell [Wed, 27 Oct 2004 05:22:10 +0000 (05:22 +0000)]
r3285: fixed another IDL typo
(This used to be commit
4545ac9bfabf4af4b44cb72f30ed93273d9cdc37)
Andrew Tridgell [Wed, 27 Oct 2004 05:20:00 +0000 (05:20 +0000)]
r3284: - don't use a enum for bit-fields. It isn't legal C (as C is limited to
signed integer values for enum), and it is also very confusing to read.
Also, please align defines nicely. The value of SV_TYPE_DOMAIN_ENUM
was defined incorrectly, which became obvious when you align the
defines, but wasn't at all obvious in the original code.
- removed redundent defines in smb.h
(This used to be commit
fe042b8e5ca15dfd986bc0c05d464214a51cc0cf)
Andrew Tridgell [Wed, 27 Oct 2004 04:48:41 +0000 (04:48 +0000)]
r3283: converted to quoted uuid() defines in all our IDL. This should help
the build on systems like solaris with the SunPRO compiler
(This used to be commit
fe913ad11bf1c5e9fe04ed769a93b0ea16aa0a34)
Andrew Tridgell [Wed, 27 Oct 2004 04:43:01 +0000 (04:43 +0000)]
r3282: some C pre-processors don't like expressions like
uuid(
1ff70682-0a51-30e8-076d-
740be8cee98b) so we now accept
uuid("
1ff70682-0a51-30e8-076d-
740be8cee98b") in pidl, and
automagically add quotes only if needed
(This used to be commit
4aab2cb210eb9678bb72aebb33dcf6fd499206c1)
Andrew Tridgell [Wed, 27 Oct 2004 04:33:36 +0000 (04:33 +0000)]
r3281: some compilers can't handle empty structures, so for empty IDL
structures generate a single _empty_ element in the header
(This used to be commit
00ff1ca1d284bb698e98c773b18a29695e927605)
Andrew Tridgell [Wed, 27 Oct 2004 03:50:52 +0000 (03:50 +0000)]
r3280: fixed byte order of rhs IP
(This used to be commit
29fab12d0b1649046ab2abb08b51f9845c8f8116)
Andrew Tridgell [Wed, 27 Oct 2004 03:45:35 +0000 (03:45 +0000)]
r3279: Removed MSG_DONTWAIT flags as many platform don't have it.
If a socket is non-blocking then adding MSG_DONTWAIT is pointless (it
does nothing), so all we lose is the ability to set non-blocking on a
packet-by-packet basis, which is not a very useful thing to have
anyway
if the socket is blocking then the code already adds MSG_WAITALL, so
MSG_DONTWAIT is also not needed in that case.
(This used to be commit
b8a2afae67691a609b4a7a577fee3f9518adc9d2)
Andrew Tridgell [Wed, 27 Oct 2004 03:15:42 +0000 (03:15 +0000)]
r3278: - rewrote the client side rpc connection code to use lib/socket/
rather than doing everything itself. This greatly simplifies the
code, although I really don't like the socket_recv() interface (it
always allocates memory for you, which means an extra memcpy in this
code)
- fixed several bugs in the socket_ipv4.c code, in particular client
side code used a non-blocking connect but didn't handle EINPROGRESS,
so it had no chance of working. Also fixed the error codes, using
map_nt_error_from_unix()
- cleaned up and expanded map_nt_error_from_unix()
- changed interpret_addr2() to not take a mem_ctx. It makes absolutely
no sense to allocate a fixed size 4 byte structure like this. Dozens
of places in the code were also using interpret_addr2() incorrectly
(precisely because the allocation made no sense)
(This used to be commit
7f2c771b0e0e98c5c9e5cf662592d64d34ff1205)
Andrew Tridgell [Wed, 27 Oct 2004 01:30:59 +0000 (01:30 +0000)]
r3277: don't use the non-portable getaddrinfo() function, instead use
interpret_addr() and if someone wants to add support to that function
for ipv6 then they are welcome to.
(This used to be commit
50377db11bb727b407744e0c50805c8f90810c16)
Andrew Tridgell [Wed, 27 Oct 2004 01:11:44 +0000 (01:11 +0000)]
r3276: - allow for more than 256 open old style searches (limit currently set at an arbitrary 5000)
- auto-cleanup old searches that the client forgot to close (common with old searches)
- expanded the RAW-SEARCH test to test more than 256 old searches, and
old search rewind (w2k3 fails this - it appears to not support rewind
on old style searches)
(This used to be commit
bc83d823b2140a10007490bf0101843a886f99a6)
Andrew Tridgell [Tue, 26 Oct 2004 22:45:33 +0000 (22:45 +0000)]
r3271: use "struct messaging_context *" instead of "void *" in messaging API
(This used to be commit
cc93813e4a09c538ad485dc2b3cb4c9be34f3d18)
Andrew Tridgell [Tue, 26 Oct 2004 22:44:28 +0000 (22:44 +0000)]
r3270: - added another unlink test
- removed BASE-TRANS2 from the list of tests to be worked on (its
already in the "passes" list)
(This used to be commit
8ba10229c3860b955de698c3e2660cf6d18e2f22)
Andrew Tridgell [Tue, 26 Oct 2004 22:42:43 +0000 (22:42 +0000)]
r3269: fixed return value
(This used to be commit
bc392d88b1fa34edfc922f43e190da003160a7d2)
Andrew Tridgell [Tue, 26 Oct 2004 22:25:34 +0000 (22:25 +0000)]
r3268: - fixed wildcard handling in new dirlist code
- ensure that d_name from readdir is not used after closedir
(This used to be commit
5352613342c58192ae00618977041b98cd0ff7b6)
Andrew Tridgell [Tue, 26 Oct 2004 21:43:34 +0000 (21:43 +0000)]
r3267: make LIBTDB depend on LIBREPLACE. This is needed for building the tdb tools on Solaris.
(This used to be commit
c5d338d06137fe7464849df02671d8ab833e3b4e)