Lars Roland [Fri, 31 Dec 2004 14:14:44 +0000 (14:14 -0000)]
Fix from Luis Ontanon:
Bring tap-h225counter.c in sync with newest revision of the h225 dissector
svn path=/trunk/; revision=12901
Guy Harris [Fri, 31 Dec 2004 03:18:13 +0000 (03:18 -0000)]
Use "proto_tree_add_item()" to add a chunk of bytes to the protocol
tree.
svn path=/trunk/; revision=12900
Guy Harris [Fri, 31 Dec 2004 03:17:00 +0000 (03:17 -0000)]
Don't assign const pointers to non-const pointers, especially if the
object pointed to by the non-const pointer won't be modified.
svn path=/trunk/; revision=12899
Guy Harris [Fri, 31 Dec 2004 03:14:18 +0000 (03:14 -0000)]
"string_to_hex()" doesn't modify its first argument, so make it a
"const" pointer, and don't cast away the constness of "tvb_get_ptr()"s
result when passing it to "string_to_hex()".
svn path=/trunk/; revision=12898
Guy Harris [Fri, 31 Dec 2004 03:12:51 +0000 (03:12 -0000)]
Don't cast away the constness of pointers passed to "ip_to_str()" -
"ip_to_str()" takes a "const guint8 *" argument.
svn path=/trunk/; revision=12897
Guy Harris [Fri, 31 Dec 2004 03:10:11 +0000 (03:10 -0000)]
There are no guarantees that "strncasecmp()" works with
non-null-terminated strings, so be safe and fetch the metatag string
with "tvb_get_string()".
svn path=/trunk/; revision=12896
Guy Harris [Fri, 31 Dec 2004 02:48:53 +0000 (02:48 -0000)]
Use "tvb_memeql()" to check whether specified bytes in a packet have a
specified value.
Make a constant array "const".
svn path=/trunk/; revision=12895
Guy Harris [Fri, 31 Dec 2004 02:16:05 +0000 (02:16 -0000)]
Don't cast away the constness of argument pointers.
Don't supply our own definition of AF_INET or our own declaration of
"inet_pton()" - use the system ones if they're available.
"mkipv4_address()" doesn't modify the string passed to it - make it a
const pointer.
svn path=/trunk/; revision=12894
Guy Harris [Fri, 31 Dec 2004 02:13:42 +0000 (02:13 -0000)]
Don't roll our own code to display IPv4 or IPv6 addresses, use
"ip_to_str()" and "ip6_to_str()".
Check the length of items for IPv4 and IPv6 addresses before displaying
them as such.
svn path=/trunk/; revision=12893
Guy Harris [Fri, 31 Dec 2004 02:11:13 +0000 (02:11 -0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.
Now that "col_set_str()" takes a "const char *" as the second argument,
we don't have to cast away the constness of strings passed to it.
svn path=/trunk/; revision=12892
Guy Harris [Fri, 31 Dec 2004 02:09:48 +0000 (02:09 -0000)]
Don't assign a const pointer argument to a non-const pointer variable.
svn path=/trunk/; revision=12891
Guy Harris [Fri, 31 Dec 2004 02:08:01 +0000 (02:08 -0000)]
Don't assign the const pointers passed to hash routines to non-const
pointers.
svn path=/trunk/; revision=12890
Guy Harris [Fri, 31 Dec 2004 02:03:16 +0000 (02:03 -0000)]
Properly cast the pointer assigned to col_info->col_data.
svn path=/trunk/; revision=12889
Guy Harris [Fri, 31 Dec 2004 02:02:19 +0000 (02:02 -0000)]
"proto_registrar_get_byname()" doesn't modify its argument, so make it
"const char *".
svn path=/trunk/; revision=12888
Guy Harris [Fri, 31 Dec 2004 02:01:03 +0000 (02:01 -0000)]
Make arguments "const *" if the routine doesn't modify the object to
which they point.
svn path=/trunk/; revision=12887
Jörg Mayer [Fri, 31 Dec 2004 01:56:22 +0000 (01:56 -0000)]
Make sure print_buff is \0-terminated
svn path=/trunk/; revision=12886
Jörg Mayer [Fri, 31 Dec 2004 01:37:54 +0000 (01:37 -0000)]
As pointed out by Guy: We should be able to filter on the original SSID,
so use a copy of the existing one for printing.
svn path=/trunk/; revision=12885
Guy Harris [Fri, 31 Dec 2004 00:33:54 +0000 (00:33 -0000)]
In column sort routines, make the row pointers "const" pointers, as the
arguments passed in corresponding to those pointers are gconstpointers.
svn path=/trunk/; revision=12884
Guy Harris [Fri, 31 Dec 2004 00:32:00 +0000 (00:32 -0000)]
As "get_persconffile_path()" doesn't return a "const char *", neither
does "get_plugins_pers_dir()" - and "get_plugins_global_dir()" doesn't
return one either. Both of them return mallocated data, and making them
return a "const char *" just causes compiler whining when you try to
free them.
svn path=/trunk/; revision=12883
Guy Harris [Fri, 31 Dec 2004 00:29:09 +0000 (00:29 -0000)]
"get_persconffile_path()" doesn't return a "const char *", it just
returns a "char *", so don't assign its return value to a "const char *".
svn path=/trunk/; revision=12882
Guy Harris [Fri, 31 Dec 2004 00:26:36 +0000 (00:26 -0000)]
"gtk_entry_get_text()" returns a "const char *" - assign the result to
one.
"get_basename()" doesn't modify its argument, and its callers don't
modify the substring pointed to by the result, so make it take a "const
char *" as an argument and return a "const char *".
"find_last_pathname_separator()" doesn't modify its argument, so make it
a "const char *" - but some of its callers pass a non-"const" "char *"
and modify the result, so don't make its return value a "const char *".
And, as none of its callers are outside "filesystem.c", make it static.
In "about_folders_page_new()", have separate variables for pathnames
returned as "const char *" (which are cached by the routine that returns
them, so you can't modify them - and can't free them, so get rid of the
commented-out "g_free()" calls for them) and pathnames returned as "char
*" (which are allocated anew for each call, and can be modified, but
have to be freed).
Clean up white space.
svn path=/trunk/; revision=12881
Guy Harris [Fri, 31 Dec 2004 00:12:25 +0000 (00:12 -0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
svn path=/trunk/; revision=12880
Guy Harris [Fri, 31 Dec 2004 00:05:22 +0000 (00:05 -0000)]
Add a "tvb_bytes_to_str_punct()" routine, which wraps
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.
Also, export "bytes_to_str_punct()".
svn path=/trunk/; revision=12879
Guy Harris [Thu, 30 Dec 2004 23:57:29 +0000 (23:57 -0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
svn path=/trunk/; revision=12878
Guy Harris [Thu, 30 Dec 2004 23:56:12 +0000 (23:56 -0000)]
The first argument to "adler32_bytes()" is only passed on to
"update_adler32()", and the corresponding argument is a "const unsigned
char *", so that argument can be a "const unsigned char *".
svn path=/trunk/; revision=12877
Guy Harris [Thu, 30 Dec 2004 23:47:52 +0000 (23:47 -0000)]
Add a "tvb_bytes_to_str_punct()" routine, which wraps
"bytes_to_str_punct()", and use it instead of extracting the bytes and
formatting them by hand.
svn path=/trunk/; revision=12876
Guy Harris [Thu, 30 Dec 2004 23:42:02 +0000 (23:42 -0000)]
Make the "col_data" field in a "column_info" structure a pointer to an
array of "const char *" rather than to an array of "char *", and make
the second argument of "col_set_str()" a "const char *" - there's no
guarantee that "col_data" points to something you're allowed to modify.
svn path=/trunk/; revision=12875
Guy Harris [Thu, 30 Dec 2004 23:19:17 +0000 (23:19 -0000)]
We now require gint64/guint64 support to build Ethereal, so get rid of
the #ifdefs.
Don't use "%ll[doux]" - not all platforms use "ll" as the length
specifier for 64-bit integers in formats. Use PRI[doux]64 instead, to
handle platforms where some other length specifier is used.
svn path=/trunk/; revision=12874
Anders Broman [Thu, 30 Dec 2004 22:40:21 +0000 (22:40 -0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
svn path=/trunk/; revision=12873
Anders Broman [Thu, 30 Dec 2004 22:39:28 +0000 (22:39 -0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
svn path=/trunk/; revision=12872
Anders Broman [Thu, 30 Dec 2004 22:38:59 +0000 (22:38 -0000)]
Change a function name in preparation for genereating H.245 and H.225 dissectors with asn2etrh
svn path=/trunk/; revision=12871
Guy Harris [Thu, 30 Dec 2004 18:34:11 +0000 (18:34 -0000)]
Regenerate.
svn path=/trunk/; revision=12870
Guy Harris [Thu, 30 Dec 2004 18:33:14 +0000 (18:33 -0000)]
Fix the declaration of "tap_queue_packet()" to match its new signature.
svn path=/trunk/; revision=12869
Gerald Combs [Thu, 30 Dec 2004 16:45:37 +0000 (16:45 -0000)]
From Vincent Jardin: Fix the dissection of relayed messages.
svn path=/trunk/; revision=12868
Guy Harris [Thu, 30 Dec 2004 03:32:38 +0000 (03:32 -0000)]
Add "get_addr_name()" to the list of items exported by libethereal.
svn path=/trunk/; revision=12867
Guy Harris [Thu, 30 Dec 2004 02:28:50 +0000 (02:28 -0000)]
Fix some cut-and-pasteos.
svn path=/trunk/; revision=12866
Guy Harris [Thu, 30 Dec 2004 02:27:00 +0000 (02:27 -0000)]
In the "capture_null()" routine, handle IPv6.
svn path=/trunk/; revision=12865
Guy Harris [Thu, 30 Dec 2004 02:21:33 +0000 (02:21 -0000)]
Update a URL.
svn path=/trunk/; revision=12864
Guy Harris [Thu, 30 Dec 2004 02:10:24 +0000 (02:10 -0000)]
Add a "get_addr_name()" routine that takes an "address *" and attempts
to resolve it to a name.
Fix up some const-pointer-to-non-const-pointer, and
function-pointer-to-void-*, conversions.
Fix some comments.
svn path=/trunk/; revision=12863
Guy Harris [Wed, 29 Dec 2004 22:31:56 +0000 (22:31 -0000)]
From Albert Chin: not all compilers support a comma after the last value
in an enum.
svn path=/trunk/; revision=12862
Guy Harris [Wed, 29 Dec 2004 22:17:04 +0000 (22:17 -0000)]
From Albert Chin: get rid of C99/GCCisms (initializing automatic
structures with non-constant values).
svn path=/trunk/; revision=12861
Guy Harris [Wed, 29 Dec 2004 21:31:18 +0000 (21:31 -0000)]
From Albert Chin: "config.h" should always be included first first when
using AC_SYS_LARGEFILE.
svn path=/trunk/; revision=12860
Guy Harris [Wed, 29 Dec 2004 21:29:53 +0000 (21:29 -0000)]
Pass "capture_opts" to "capture_loop_dispatch()", as
"capture_loop_dispatch()" uses it.
svn path=/trunk/; revision=12859
Guy Harris [Wed, 29 Dec 2004 21:20:42 +0000 (21:20 -0000)]
Fix it to compile on systems without "pcap_datalink_val_to_name()" (or
with "pcap_datalink_val_to_name()" but without a declaration of it in
"pcap.h" *cough* Software Update *cough*).
svn path=/trunk/; revision=12858
Gerald Combs [Wed, 29 Dec 2004 16:25:06 +0000 (16:25 -0000)]
Remove some unneeded backslashes.
svn path=/trunk/; revision=12857
Gerald Combs [Wed, 29 Dec 2004 15:54:55 +0000 (15:54 -0000)]
If we can't find the "svn" executable in the current path, look in
"c:/cygwin/lib/subversion/bin/", which is the current default location
for Subversion 1.1.1 under Cygwin. If we still can't find "svn", simply
return instead of exiting.
svn path=/trunk/; revision=12856
Ulf Lamping [Wed, 29 Dec 2004 12:37:06 +0000 (12:37 -0000)]
move global capture_child flag into capture_options
svn path=/trunk/; revision=12855
Tomas Kukosa [Wed, 29 Dec 2004 12:28:16 +0000 (12:28 -0000)]
- new optional parameter ETH_VAR for #.EXPORTS directive
- few fixes for last changes
Summary of changes during last three revisions
- NULL can be used in #.PDU or #.REGISTER directive
- fix in cyclic dependency handling
- keep <proto>-exp.cnf file regardless of '-k' option
- handling of negative values in SingleValue or ValueRange constraints
- handling of all SEQUONCE/SET (OF) types including SIZE constraint
- rename ber_sequence->ber_sequence_t and ber_choice->ber_choice_t
- rename dissect_ber_integer_new()->dissect_ber_integer()
- fix number of parameters for dissect_per_GeneralString()
svn path=/trunk/; revision=12854
Ulf Lamping [Wed, 29 Dec 2004 09:09:35 +0000 (09:09 -0000)]
Don't use a global capture_opts in the capturing engine (this isn't a good idea). Do some more "housekeeping" in the capturing part.
Hopefully the unspecified forward declaration of capture_options_t in main.h is portable, but buildbot will tell me. This way I need the internals of that struct only at the places I really use it.
svn path=/trunk/; revision=12853
Guy Harris [Wed, 29 Dec 2004 01:08:20 +0000 (01:08 -0000)]
Make the tone of the error messages a bit less formal, by using
contractions. (Safari does, at least when you're trying to open a file
to which you don't have read access.)
svn path=/trunk/; revision=12852
Guy Harris [Wed, 29 Dec 2004 00:51:29 +0000 (00:51 -0000)]
Use the "errmsg_len" argument to "capture_loop_open_output()" -
"sizeof(errmsg)', when "errmsg" is a "char *", doesn't give the size of
the string to which "errmsg" points, it gives the size of the pointer
itself, which is too small.
svn path=/trunk/; revision=12851
Guy Harris [Wed, 29 Dec 2004 00:44:45 +0000 (00:44 -0000)]
Add Ethernet type for DEC Local Area Systems Transport.
svn path=/trunk/; revision=12850
Gerald Combs [Tue, 28 Dec 2004 19:59:50 +0000 (19:59 -0000)]
Remove some macros that were making the "splint" utility throw a fit.
svn path=/trunk/; revision=12849
Ulf Lamping [Tue, 28 Dec 2004 00:36:06 +0000 (00:36 -0000)]
some code cleanup (comments changed)
svn path=/trunk/; revision=12848
Ulf Lamping [Tue, 28 Dec 2004 00:10:04 +0000 (00:10 -0000)]
add a more detailed description, how to add a new dissector file
svn path=/trunk/; revision=12847
Ulf Lamping [Mon, 27 Dec 2004 22:04:49 +0000 (22:04 -0000)]
a lot of code cleanup/refactoring
svn path=/trunk/; revision=12846
Ulf Lamping [Mon, 27 Dec 2004 21:35:09 +0000 (21:35 -0000)]
fix a freebsd buildbot compile error, caused by myself :-(
svn path=/trunk/; revision=12845
Ulf Lamping [Mon, 27 Dec 2004 16:11:08 +0000 (16:11 -0000)]
fix a solaris buildbot compile error
svn path=/trunk/; revision=12844
Ulf Lamping [Mon, 27 Dec 2004 14:27:27 +0000 (14:27 -0000)]
location of cygwin's docbook xml changed
svn path=/trunk/; revision=12843
Ulf Lamping [Mon, 27 Dec 2004 13:17:20 +0000 (13:17 -0000)]
Again, some warnings removed.
svn path=/trunk/; revision=12842
Ulf Lamping [Mon, 27 Dec 2004 10:11:28 +0000 (10:11 -0000)]
Again, another warning (hopefully) removed.
svn path=/trunk/; revision=12841
Guy Harris [Sun, 26 Dec 2004 22:52:16 +0000 (22:52 -0000)]
From Jouni Malinen: use a length field from the packet to determine how
much data is available, rather than using "tvb_length_remaining()".
svn path=/trunk/; revision=12840
Guy Harris [Sun, 26 Dec 2004 22:26:02 +0000 (22:26 -0000)]
From Yaniv Kaul: add Ethernet address-to-name (or, at least, address-to-
vendor-name-and-next-three-bytes-in-hex) resolution for Ethernet/802.x
hardware addresses.
Move the ARP hardware types into a header file, for use by dissectors
other than the ARP dissector.
svn path=/trunk/; revision=12839
Gerald Combs [Sun, 26 Dec 2004 18:58:52 +0000 (18:58 -0000)]
From Vincent Jardin:
- support for new DHCPv6 options
- fix for the support of OPTION_RELAY_MSG
svn path=/trunk/; revision=12838
Ulf Lamping [Sun, 26 Dec 2004 10:11:42 +0000 (10:11 -0000)]
Again, some warnings removed.
svn path=/trunk/; revision=12837
Guy Harris [Sun, 26 Dec 2004 00:28:47 +0000 (00:28 -0000)]
From Jouni Malinen: dissect TLS extensions (RFC 3546) for ClientHello
and ServerHello.
svn path=/trunk/; revision=12836
Guy Harris [Sun, 26 Dec 2004 00:22:16 +0000 (00:22 -0000)]
From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS.
svn path=/trunk/; revision=12835
Ulf Lamping [Sat, 25 Dec 2004 18:35:21 +0000 (18:35 -0000)]
Again, some warnings removed.
svn path=/trunk/; revision=12834
Ulf Lamping [Sat, 25 Dec 2004 14:46:40 +0000 (14:46 -0000)]
Fix a core dump causing the buildbot test menagerie to fail. It was caused by incorrectly trying to proto_tree_add_item() with a very huge length. However, someone with more SQL knowledge than me should have a qualified look at that place and do a better fix.
svn path=/trunk/; revision=12833
Ulf Lamping [Sat, 25 Dec 2004 13:49:30 +0000 (13:49 -0000)]
a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros
svn path=/trunk/; revision=12832
Ulf Lamping [Sat, 25 Dec 2004 10:30:58 +0000 (10:30 -0000)]
Again, some warnings removed.
svn path=/trunk/; revision=12831
Ulf Lamping [Fri, 24 Dec 2004 23:17:38 +0000 (23:17 -0000)]
use GLib's pointer to int conversion macros to prevent compiler warnings
svn path=/trunk/; revision=12830
Guy Harris [Fri, 24 Dec 2004 22:21:23 +0000 (22:21 -0000)]
Note the RFC that describes VJ compression.
svn path=/trunk/; revision=12829
Ronnie Sahlberg [Fri, 24 Dec 2004 12:39:21 +0000 (12:39 -0000)]
New protocol RFC2510 PKIXCMP Certificate Management Protocol
svn path=/trunk/; revision=12828
Ronnie Sahlberg [Fri, 24 Dec 2004 12:22:52 +0000 (12:22 -0000)]
export ResonFlags from pkix1implicit
svn path=/trunk/; revision=12827
Ronnie Sahlberg [Fri, 24 Dec 2004 12:16:27 +0000 (12:16 -0000)]
export Certificate and CertificateList from pkix1explicit
svn path=/trunk/; revision=12826
Ronnie Sahlberg [Fri, 24 Dec 2004 11:32:13 +0000 (11:32 -0000)]
New "protocol" the support functions from RFC2511 Certificate Request Message Format CRMF
svn path=/trunk/; revision=12825
Ronnie Sahlberg [Fri, 24 Dec 2004 11:24:35 +0000 (11:24 -0000)]
export EnvelopedData
svn path=/trunk/; revision=12824
Ronnie Sahlberg [Thu, 23 Dec 2004 19:56:29 +0000 (19:56 -0000)]
RST segmetns are never WindowFull segments.
svn path=/trunk/; revision=12823
Ronnie Sahlberg [Thu, 23 Dec 2004 19:53:24 +0000 (19:53 -0000)]
add another error code to dcerpc
svn path=/trunk/; revision=12822
Ulf Lamping [Thu, 23 Dec 2004 13:34:02 +0000 (13:34 -0000)]
show a simple_dialog, if we use glib 1.x and trying to open a webbrowser (not implemented). This will prevent another compiler warning.
svn path=/trunk/; revision=12821
Lars Roland [Thu, 23 Dec 2004 08:27:30 +0000 (08:27 -0000)]
Fixes for Mate from Luis Ontanon:
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks
(I had to rename two GMemChunks to make MSVC happy)
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- fixed few things at reinit:
- reset last_id
- remove the nodes in the items hash tables
svn path=/trunk/; revision=12820
Ulf Lamping [Thu, 23 Dec 2004 00:27:20 +0000 (00:27 -0000)]
Again, some warnings removed.
svn path=/trunk/; revision=12819
Richard Sharpe [Wed, 22 Dec 2004 19:44:42 +0000 (19:44 -0000)]
Clean up one more instance of 8-byte timestamps in SMB. Have to work on
the 4-byte ones soon.
svn path=/trunk/; revision=12818
Guy Harris [Wed, 22 Dec 2004 19:27:09 +0000 (19:27 -0000)]
RFC 2868 says that the length of a "tagged string" field must be at
least 3 - 2 for type+length and 1 for the tag - so treat a "tagged
string" field as bad if there isn't at least one byte of data. (It's a
bit odd that the RFC says that the tag must be in the range 0x01-0x1F -
that sounds suspiciously as if they're saying "printable characters
aren't valid tags", to allow untagged strings, which might suggest that
a field with a length of 2 should be interpreted as an empty string.)
svn path=/trunk/; revision=12817
Guy Harris [Wed, 22 Dec 2004 10:44:20 +0000 (10:44 -0000)]
Check for all bogus ACE lengths, i.e. all lengths < 4.
Clean up indentation.
Add a comment asking whether the revision in an ACL is *really* 2 bytes
and the ACE count is *really* 4 bytes.
svn path=/trunk/; revision=12816
Guy Harris [Wed, 22 Dec 2004 09:58:28 +0000 (09:58 -0000)]
Add only one protocol tree item for the "weak IV" flag - add it as a
non-hidden Boolean, and use "proto_tree_add_boolean_format()" to add it
to include the key byte.
svn path=/trunk/; revision=12815
Guy Harris [Wed, 22 Dec 2004 09:46:14 +0000 (09:46 -0000)]
Change the RCS ID - it's not getting expanded when it's "$Id $".
Fix a comment in conversations_wlan.c.
Refer to "WLAN" in hostlist_wlan.c, just as we do in
conversations_wlan.c.
svn path=/trunk/; revision=12814
Guy Harris [Wed, 22 Dec 2004 09:19:01 +0000 (09:19 -0000)]
From Brett Kuskie: recalculate the ranges every time an export dialog is
opened, not just the first time, so that if the packet counts change
up-to-date values are displayed.
svn path=/trunk/; revision=12813
Richard Sharpe [Wed, 22 Dec 2004 02:40:33 +0000 (02:40 -0000)]
Add a dissection for the GET_NETWORK_FILE_OPEN_INFO and make some stuff that
we do in several places into a subroutine. We need to do it also with the
4-byte time stamps that are dissected all over the place.
I had thought that that last unknown in the returned structure might be
a count of the number of clients that have the file open, but a simple test
suggests that that is not the case.
svn path=/trunk/; revision=12812
Guy Harris [Wed, 22 Dec 2004 01:51:00 +0000 (01:51 -0000)]
In the "rdconvertXXXtostr()" routines, check that the length passed in
is >= 0 (if it's not, that's a bug), and make the buffer index and total
length variables int as well, to match the length.
svn path=/trunk/; revision=12811
Guy Harris [Wed, 22 Dec 2004 01:42:54 +0000 (01:42 -0000)]
Move the RADIUS_TIMESTAMP, RADIUS_INTEGER4_TAGGED, and RADIUS_UNKNOWN
case branches up, so the case branches are in the same order as the
elements of the enum are, and add length checks to RADIUS_TIMESTAMP and
RADIUS_INTEGER4_TAGGED.
svn path=/trunk/; revision=12810
Guy Harris [Wed, 22 Dec 2004 00:30:39 +0000 (00:30 -0000)]
Properly declare a variable as volatile, as the longjmp done by the
exception mechanism might clobber it otherwise.
svn path=/trunk/; revision=12809
Guy Harris [Wed, 22 Dec 2004 00:23:55 +0000 (00:23 -0000)]
Add some checks to make sure the AVP length is large enough for the item
we're fetching from the AVP.
In the case of a tagged string, if the length is 2 (meaning the data
length is 0), assume there's no tag.
svn path=/trunk/; revision=12808
Guy Harris [Tue, 21 Dec 2004 23:26:01 +0000 (23:26 -0000)]
Fix one comment, and put in another one giving a note about where you
can get the protocol specs.
svn path=/trunk/; revision=12807
Olivier Biot [Tue, 21 Dec 2004 21:17:44 +0000 (21:17 -0000)]
From Victor Stratan: GSM SMS fixes:
- Corrected incorrect Timezone output due to byte overflow.
- Added descriptions for address string decoding.
svn path=/trunk/; revision=12806
Guy Harris [Tue, 21 Dec 2004 20:36:50 +0000 (20:36 -0000)]
Use "format_text()" on strings, to better handle non-printable
characters.
svn path=/trunk/; revision=12805
Guy Harris [Tue, 21 Dec 2004 20:03:47 +0000 (20:03 -0000)]
Put the strings for the X-Mms-Previously-Sent-By header under the MMSE
tree rather than at the top level.
svn path=/trunk/; revision=12804
Guy Harris [Tue, 21 Dec 2004 19:28:48 +0000 (19:28 -0000)]
Make the array for the "setup method" for RTP, RTCP, and T.38
conversations large enough to hold the maximum setup method size plus a
trailing '\0'. Make the maximum setup method size 7, so that when the
trailing '\0' is included the total array length is a power of 2. (The
longest string currently used is "Skinny", which fits in 7 characters).
This fixes problems in the RTP and RTCP dissectors similar to the one
found in the T.38 dissector.
Undo the previous change to packet-t38.c, as it's now safe to store in
method[MAX_T38_SETUP_METHOD_SIZE], because the array now has
MAX_T38_SETUP_METHOD_SIZE+1 characters.
(Should we use "strlcpy()", and supply our own "strlcpy()" if the system
and/or C library doesn't supply it? Its semantics are a bit cleaner
than those of the "strncpy()"/null-terminate idiom, perhaps making it
less likely that mistakes of this sort will be made.)
svn path=/trunk/; revision=12803
Ronnie Sahlberg [Tue, 21 Dec 2004 17:05:14 +0000 (17:05 -0000)]
from metze
make ethereal handle gss-api encrypted ldap blobs
svn path=/trunk/; revision=12802