Richard Sharpe [Sat, 3 Jan 2004 18:40:08 +0000 (18:40 -0000)]
Apply the patches from Tadaaki Nagao for a global version of disabled
protocols ...
svn path=/trunk/; revision=9538
Richard Sharpe [Sat, 3 Jan 2004 18:05:57 +0000 (18:05 -0000)]
Make Analyze/Statistics have an accelerator of Alt+A S and move
Analyze/Summary to Alt+A Y.
svn path=/trunk/; revision=9537
Jörg Mayer [Sat, 3 Jan 2004 14:08:57 +0000 (14:08 -0000)]
Warning fix: Mark a parameter as unused
svn path=/trunk/; revision=9536
Michael Tüxen [Sat, 3 Jan 2004 13:03:02 +0000 (13:03 -0000)]
Make XConvertCase static to avoid a warning at link time.
svn path=/trunk/; revision=9535
Olivier Biot [Sat, 3 Jan 2004 12:43:51 +0000 (12:43 -0000)]
Fix an incorrect filterable field name.
svn path=/trunk/; revision=9534
Guy Harris [Sat, 3 Jan 2004 05:14:08 +0000 (05:14 -0000)]
At least with some versions of GCC, the __attribute__((unused)) stuff
has to come *after* the variable.
svn path=/trunk/; revision=9533
Guy Harris [Sat, 3 Jan 2004 05:13:12 +0000 (05:13 -0000)]
Mark arguments as unused.
Clean up indentation.
svn path=/trunk/; revision=9532
Guy Harris [Sat, 3 Jan 2004 03:51:27 +0000 (03:51 -0000)]
Have "dissect_xdlc_control()" take a pointer to a structure containing
pointers to hf_ values, so the subfields of the control field are put
into the protocol tree as filterable items. Change the protocols that
use it appropriately.
Export "dissect_xdlc_control()" to plugins.
svn path=/trunk/; revision=9531
Guy Harris [Sat, 3 Jan 2004 03:43:20 +0000 (03:43 -0000)]
Process all the data in the packet, regardless of whether it's captured
or not.
svn path=/trunk/; revision=9530
Guy Harris [Sat, 3 Jan 2004 03:37:26 +0000 (03:37 -0000)]
Deal with some weird ISMP packets that have 0x42 0x42 0x03 in front of
the payload (are they some kind of weird 802.2 header? 0x42 is the SAP
for IEEE 802.1d Spanning Tree BPDUs).
svn path=/trunk/; revision=9529
Guy Harris [Fri, 2 Jan 2004 23:44:20 +0000 (23:44 -0000)]
Fix a comment.
svn path=/trunk/; revision=9528
Ulf Lamping [Fri, 2 Jan 2004 21:48:24 +0000 (21:48 -0000)]
hide save dialog, while saving
svn path=/trunk/; revision=9527
Ulf Lamping [Fri, 2 Jan 2004 21:47:06 +0000 (21:47 -0000)]
bugfix: init progbar to NULL at the right place
svn path=/trunk/; revision=9526
Ulf Lamping [Fri, 2 Jan 2004 21:01:40 +0000 (21:01 -0000)]
added a progressbar, when saving a large capture file
svn path=/trunk/; revision=9525
Ulf Lamping [Fri, 2 Jan 2004 17:27:00 +0000 (17:27 -0000)]
recent files: make submenu insensitive if empty and
add a menu item to clear the list
svn path=/trunk/; revision=9524
Ulf Lamping [Fri, 2 Jan 2004 13:38:22 +0000 (13:38 -0000)]
From Didier: don't update the progress bar more often than every 100ms
svn path=/trunk/; revision=9523
Ulf Lamping [Fri, 2 Jan 2004 13:27:00 +0000 (13:27 -0000)]
From Didier: don't update the progress bar more often than every 100ms
svn path=/trunk/; revision=9522
Olivier Biot [Fri, 2 Jan 2004 12:57:26 +0000 (12:57 -0000)]
From Michael Shuldman: enhanced X11 support.
svn path=/trunk/; revision=9521
Olivier Biot [Fri, 2 Jan 2004 12:52:45 +0000 (12:52 -0000)]
From Michael Shuldman:
Add support for parsing some X11 replies and events (and
the framework for handling X11 errors it looks like) to the
existing X11 code, which parses X11 requests.
It parses what is the most difficult part of the replies/events,
they Keycode stuff by parsing the Keyboardmapping replies and etc,
and then KeyPress, KeyRelease events and some related stuff (used
for a specific project).
Adding support for parsing the rest of the event/replies should not
be difficult, I think it will mostly consist of going through every
event/reply and add the missing calls for each dataitem i.e. register
the data, the remaining the eventcodes/replies are pretty
straightforward if I remember correctly.
All events and replies are reported, it's the "detailed" (-V option)
that's missing for most.
The replies, events and errors are listed in the Info column,
and are summarized in the protocol summary line.
Bogus if (tree) { } constructs have also been fixed.
List over other misc. stuff added:
- handle multiple outstanding requests.
- add AllocNamedColor to list of requests expecting a reply.
- body for parsing error replies.
- each packet can be sent to us multiple times, try to handle that.
- change request_length display to be what the client actually sends
for x11_request, not what it means (don't multiply by four).
- add some more opcodes expecting a reply (gone through all listed
in the ref. now, so should be complete).
- use hashtable and sequencenumber for matching reply to request.
svn path=/trunk/; revision=9520
Richard Sharpe [Fri, 2 Jan 2004 06:35:45 +0000 (06:35 -0000)]
Revert a small change I made a day or so ago because Guy has captures that
show that the short name can be in ASCII if flags 2 says ASCII.
svn path=/trunk/; revision=9519
Guy Harris [Fri, 2 Jan 2004 02:03:39 +0000 (02:03 -0000)]
From Steven Lass: put the request and status lines into the protocol
tree as filterable fields.
svn path=/trunk/; revision=9518
Richard Sharpe [Fri, 2 Jan 2004 00:19:59 +0000 (00:19 -0000)]
Tweak the name of the Coloring Rules dialog box to be more consistent ...
svn path=/trunk/; revision=9517
Guy Harris [Thu, 1 Jan 2004 23:36:50 +0000 (23:36 -0000)]
Make the RTSP packet handling more like the HTTP packet handling.
svn path=/trunk/; revision=9516
Guy Harris [Thu, 1 Jan 2004 23:34:06 +0000 (23:34 -0000)]
Clean up the blank line handling a bit.
svn path=/trunk/; revision=9515
Guy Harris [Thu, 1 Jan 2004 21:47:18 +0000 (21:47 -0000)]
Don't show empty media formats.
svn path=/trunk/; revision=9514
Guy Harris [Thu, 1 Jan 2004 21:35:49 +0000 (21:35 -0000)]
From Chris Waters: fix a typo.
svn path=/trunk/; revision=9513
Olivier Biot [Thu, 1 Jan 2004 17:02:56 +0000 (17:02 -0000)]
Add support of contains operator in slices.
svn path=/trunk/; revision=9512
Olivier Biot [Thu, 1 Jan 2004 16:59:20 +0000 (16:59 -0000)]
Add support of contains and matches operators on slices.
svn path=/trunk/; revision=9511
Ulf Lamping [Thu, 1 Jan 2004 13:41:09 +0000 (13:41 -0000)]
label texts changed (tip from Richard)
svn path=/trunk/; revision=9510
Ulf Lamping [Thu, 1 Jan 2004 13:29:16 +0000 (13:29 -0000)]
rearranged prefs topics
svn path=/trunk/; revision=9509
Ulf Lamping [Thu, 1 Jan 2004 13:16:40 +0000 (13:16 -0000)]
moved recent files pref, as it splits corresponding dir entries
svn path=/trunk/; revision=9508
Ulf Lamping [Thu, 1 Jan 2004 13:10:45 +0000 (13:10 -0000)]
comment fixed
svn path=/trunk/; revision=9507
Guy Harris [Wed, 31 Dec 2003 22:17:28 +0000 (22:17 -0000)]
ethereal.com/distribution/win32/development/ has GLib 2.2.3
packages, and a gtk+-1.3.0-
20030717.zip package; update the version
numbers accordingly.
svn path=/trunk/; revision=9506
Guy Harris [Wed, 31 Dec 2003 09:58:56 +0000 (09:58 -0000)]
Remove redundant protocol names from preference values.
svn path=/trunk/; revision=9505
Guy Harris [Wed, 31 Dec 2003 09:47:01 +0000 (09:47 -0000)]
Make the tvbuff for SDP lines have the line length as its length and
reported length, so we show the right error if we go past the end of the
tvbuff.
svn path=/trunk/; revision=9504
Guy Harris [Wed, 31 Dec 2003 01:17:21 +0000 (01:17 -0000)]
If a packet has a packet number of 0, it's not a fragment if the status
is "last buffer".
svn path=/trunk/; revision=9503
Guy Harris [Wed, 31 Dec 2003 01:07:09 +0000 (01:07 -0000)]
For WTAP_ENCAP_ETHERNET, you have to fill in the "eth.fcs_len" member of
the pseudo-header; these captures don't appear to have an FCS in them,
so set that member to 0.
svn path=/trunk/; revision=9502
Guy Harris [Tue, 30 Dec 2003 23:13:32 +0000 (23:13 -0000)]
In "get_field_data()", check to make sure the field doesn't run past the
end of the tvbuff.
svn path=/trunk/; revision=9501
Guy Harris [Tue, 30 Dec 2003 22:48:14 +0000 (22:48 -0000)]
Include <string.h> to declare various string manipulation functions.
svn path=/trunk/; revision=9500
Ulf Lamping [Tue, 30 Dec 2003 22:18:03 +0000 (22:18 -0000)]
removed compilation of packet-slsk
svn path=/trunk/; revision=9499
Ulf Lamping [Tue, 30 Dec 2003 21:55:19 +0000 (21:55 -0000)]
added dick gooris to the list of contributors
svn path=/trunk/; revision=9498
Jörg Mayer [Tue, 30 Dec 2003 19:11:30 +0000 (19:11 -0000)]
Remove unused variable firmware_rev
svn path=/trunk/; revision=9497
Jörg Mayer [Tue, 30 Dec 2003 17:14:15 +0000 (17:14 -0000)]
New protocol: Enterasys Interswitch Message Protocol (ismp) and
edp (Enterasys Discovery Protocol)
svn path=/trunk/; revision=9496
Olivier Biot [Tue, 30 Dec 2003 15:49:12 +0000 (15:49 -0000)]
Header files proto-ABBREV.h must not exist if there are no functions
to export to other dissectors.
Describe the "if (tree)" construct and its sense by introducing 2 operation
modes of Ethereal:
(a) operational dissection (tree == NULL)
and
(b) detailed dissection (tree != NULL).
Fix some typos.
svn path=/trunk/; revision=9495
Richard Sharpe [Tue, 30 Dec 2003 04:38:20 +0000 (04:38 -0000)]
A small fix from Andrew Bartlett. The Short File Name is always in UNICODE.
svn path=/trunk/; revision=9494
Guy Harris [Tue, 30 Dec 2003 01:58:17 +0000 (01:58 -0000)]
Clean up the handling of the code that handles the payload a bit; this
also fixes a case where we'd put the same string into the Info column
twice.
Put the packet sequence number into the Info column for segmented invoke
and result PDUs, even if we don't try to reassemble them.
Don't put an entry into the protocol tree for the payload if there isn't
any payload.
svn path=/trunk/; revision=9493
Ulf Lamping [Tue, 30 Dec 2003 01:19:02 +0000 (01:19 -0000)]
minor changes and a small bugfix
svn path=/trunk/; revision=9492
Guy Harris [Tue, 30 Dec 2003 00:22:38 +0000 (00:22 -0000)]
Update another URL and other stuff in that comment.
svn path=/trunk/; revision=9491
Guy Harris [Tue, 30 Dec 2003 00:19:18 +0000 (00:19 -0000)]
Update a URL.
svn path=/trunk/; revision=9490
Guy Harris [Tue, 30 Dec 2003 00:03:48 +0000 (00:03 -0000)]
Export a "dissect_tcp_payload()" routine from the TCP dissector, for use
by pass-through proxying dissectors such as the SOCKS dissector; it does
the work of processing a TCP segment, including desegmentation. Export
the "next sequence number" value to subdissectors, so they can use it
when calling "dissect_tcp_payload()".
Use that in the SOCKS dissector.
svn path=/trunk/; revision=9489
Guy Harris [Mon, 29 Dec 2003 22:44:50 +0000 (22:44 -0000)]
Add a "saved_can_desegment" field to the "packet_info" structure, so
that dissectors for pass-through proxying protocols such as SOCKS can
allow the subdissectors they call to ask that desegmentation be done.
svn path=/trunk/; revision=9488
Guy Harris [Mon, 29 Dec 2003 22:43:33 +0000 (22:43 -0000)]
Nothing in "range.c" is GTK+-specific, so move it to the top-level
directory.
svn path=/trunk/; revision=9487
Guy Harris [Mon, 29 Dec 2003 22:33:18 +0000 (22:33 -0000)]
From RFC 2616: "Field names are case-insensitive." Use
"tvb_strncaseeql()", not "tvb_strneql()", to check for
"Content-Length:".
svn path=/trunk/; revision=9486
Jörg Mayer [Mon, 29 Dec 2003 21:39:10 +0000 (21:39 -0000)]
Delete the generated files only during maintainerclean
svn path=/trunk/; revision=9485
Jörg Mayer [Mon, 29 Dec 2003 21:18:12 +0000 (21:18 -0000)]
range.h moved from gtk to .
svn path=/trunk/; revision=9484
Ulf Lamping [Mon, 29 Dec 2003 21:04:47 +0000 (21:04 -0000)]
removed a GTK2 warning
svn path=/trunk/; revision=9483
Ulf Lamping [Mon, 29 Dec 2003 20:53:39 +0000 (20:53 -0000)]
removed a GTK2 warning
svn path=/trunk/; revision=9482
Guy Harris [Mon, 29 Dec 2003 20:46:12 +0000 (20:46 -0000)]
Give it an RCS ID and copyright notice.
svn path=/trunk/; revision=9481
Guy Harris [Mon, 29 Dec 2003 20:41:37 +0000 (20:41 -0000)]
Get rid of an unused variable.
svn path=/trunk/; revision=9480
Guy Harris [Mon, 29 Dec 2003 20:40:44 +0000 (20:40 -0000)]
Give it an RCS ID.
svn path=/trunk/; revision=9479
Guy Harris [Mon, 29 Dec 2003 20:40:02 +0000 (20:40 -0000)]
Add an RCS ID.
Include <ctype.h> to declare "isdigit()".
svn path=/trunk/; revision=9478
Gilbert Ramirez [Mon, 29 Dec 2003 20:11:42 +0000 (20:11 -0000)]
Add a missing backslash for the EXTRA_DIST files.
svn path=/trunk/; revision=9477
Ulf Lamping [Mon, 29 Dec 2003 20:05:59 +0000 (20:05 -0000)]
From Dick Gooris (and me :-)
more ways to choose which packets can be saved,
in the save(as) dialog box
svn path=/trunk/; revision=9476
Guy Harris [Mon, 29 Dec 2003 19:59:05 +0000 (19:59 -0000)]
Make the "max count of recently-visited files" preference unsigned.
Get rid of an unused variable.
Fix up whitespace.
svn path=/trunk/; revision=9475
Guy Harris [Mon, 29 Dec 2003 19:53:52 +0000 (19:53 -0000)]
"hex_str_to_bytes()" modifies the GByteArray supplied to it, so don't
mark it as "const".
svn path=/trunk/; revision=9474
Guy Harris [Mon, 29 Dec 2003 19:05:40 +0000 (19:05 -0000)]
Make sure the "we're in the middle of dissecting SOCKS" flag gets
cleared even if we throw an exception when dissecting the payload.
svn path=/trunk/; revision=9473
Guy Harris [Mon, 29 Dec 2003 19:04:05 +0000 (19:04 -0000)]
Add support for NetWare's serialization protocol.
svn path=/trunk/; revision=9472
Gerald Combs [Mon, 29 Dec 2003 04:07:06 +0000 (04:07 -0000)]
Pull most of bytes_from_unparsed() into a new routine,
hex_str_to_bytes(). Use the new routine to initialize any WEP keys we
have defined. This has the side effect of fixing an overflow if the user
entered a long WEP key.
svn path=/trunk/; revision=9471
Richard Sharpe [Mon, 29 Dec 2003 00:48:56 +0000 (00:48 -0000)]
OK, now I have added the preference for recent_files_count_max, and we can
set the value and so on. We put the value in the text field before it is
displayed, and so on ...
svn path=/trunk/; revision=9470
Guy Harris [Mon, 29 Dec 2003 00:41:07 +0000 (00:41 -0000)]
From Niels Koot: support TCAP over SUA.
svn path=/trunk/; revision=9469
Guy Harris [Mon, 29 Dec 2003 00:36:12 +0000 (00:36 -0000)]
From Neils Koot:
add the ability to read Ethernet captures;
add the ability to read hex-only dumps.
svn path=/trunk/; revision=9468
Guy Harris [Mon, 29 Dec 2003 00:25:39 +0000 (00:25 -0000)]
Make all the byte arrays for writing out stuff "guint8" rather than
"gint8" - there's no reason for them to be signed, and making them
signed can cause compiler warnings if a value won't fit in 8 bits if
sign-extended.
svn path=/trunk/; revision=9467
Guy Harris [Mon, 29 Dec 2003 00:19:00 +0000 (00:19 -0000)]
At least as I read the Teredo draft, the nonce value is just an opaque
8-byte value.
svn path=/trunk/; revision=9466
Guy Harris [Sun, 28 Dec 2003 23:50:31 +0000 (23:50 -0000)]
In calls to "dcerpc_init_uuid()" only the *major* version number of the
interface is supplied; by virtue of 1.1 being truncated to 1, and by
virtue of the putative major and minor version numbers in 1.1 both being
1, a version number initialized to 1.1 presumably happened to work for
RPRIV and RS_REPADM, but we might as well do it right.
svn path=/trunk/; revision=9465
Richard Sharpe [Sun, 28 Dec 2003 23:20:08 +0000 (23:20 -0000)]
Add more code to handle the recent_files_count_max as a preference ...
Here we can read and write it from and to the preferences file. I only have
to add code to allow it to be set in the Edit->Preferences area,
svn path=/trunk/; revision=9464
Richard Sharpe [Sun, 28 Dec 2003 21:10:26 +0000 (21:10 -0000)]
Connect the recent_file_count_max variable to the prefs.gui_recent_file_count_max variable entry, and fix a small spelling/grammar mistake.
Now all we need is some enterprising individual to write the small amount of
preferences code to actually allow it to be changed etc, but I have to go to
Costco, so, later...
svn path=/trunk/; revision=9463
Richard Sharpe [Sun, 28 Dec 2003 20:36:59 +0000 (20:36 -0000)]
Add a preferences item for the recent file count max so we can tie it to
the edit preferences dialog box and then use it in the code that handles
recent files.
svn path=/trunk/; revision=9462
Ulf Lamping [Sun, 28 Dec 2003 18:31:14 +0000 (18:31 -0000)]
all libs now relative to a base dir, use compiler warning level 2
svn path=/trunk/; revision=9461
Ulf Lamping [Sun, 28 Dec 2003 12:50:42 +0000 (12:50 -0000)]
removed some MSVC warnings (warning level 2)
svn path=/trunk/; revision=9460
Ulf Lamping [Sun, 28 Dec 2003 12:43:40 +0000 (12:43 -0000)]
removed some MSVC warnings (warning level 2)
svn path=/trunk/; revision=9459
Guy Harris [Sun, 28 Dec 2003 08:39:10 +0000 (08:39 -0000)]
If we've seen an HTTP request or response or header line, and the line
we're looking at looks as if it could be the beginning of a header line
but stops at the end of the tvbuff before we see the colon for the
header line, throw an exception rather than treating it as "not HTTP".
svn path=/trunk/; revision=9458
Guy Harris [Sat, 27 Dec 2003 18:45:48 +0000 (18:45 -0000)]
Properly handle 1xx, 204, and 304 responses, which don't contain a
message body.
svn path=/trunk/; revision=9457
Ulf Lamping [Sat, 27 Dec 2003 13:19:06 +0000 (13:19 -0000)]
added/changed some comments
svn path=/trunk/; revision=9456
Guy Harris [Sat, 27 Dec 2003 08:35:08 +0000 (08:35 -0000)]
Fix some comments.
svn path=/trunk/; revision=9455
Guy Harris [Sat, 27 Dec 2003 04:01:17 +0000 (04:01 -0000)]
Don't create a protocol tree entry for the body of an NDMP request or
reply if there isn't a body, just a header, so that we don't throw an
exception and mark the frame as malformed if the request or reply isn't
supposed to have a body.
svn path=/trunk/; revision=9454
Guy Harris [Sat, 27 Dec 2003 03:45:45 +0000 (03:45 -0000)]
There might not be any AFS payload in an AFS reply; for fields in the
reply that don't come from the packet, use an offset and length of 0, so
that we don't throw an exception if the purported data at that offset
with that length doesn't exist.
svn path=/trunk/; revision=9453
Guy Harris [Sat, 27 Dec 2003 02:17:22 +0000 (02:17 -0000)]
Don't defragment packets that aren't fragmented.
Note that we've seen weird sequence numbers for login packets.
svn path=/trunk/; revision=9452
Guy Harris [Sat, 27 Dec 2003 02:01:13 +0000 (02:01 -0000)]
Note that this is another client for reassembly using connection
sequence numbers.
svn path=/trunk/; revision=9451
Guy Harris [Sat, 27 Dec 2003 01:42:56 +0000 (01:42 -0000)]
When testing the first line of HTTP data, process what data we have -
don't give up if we don't have the full line.
svn path=/trunk/; revision=9450
Guy Harris [Fri, 26 Dec 2003 23:33:25 +0000 (23:33 -0000)]
Check that the length of an AVP is >= 6, not just that it's non-zero.
svn path=/trunk/; revision=9449
Ulf Lamping [Fri, 26 Dec 2003 12:27:47 +0000 (12:27 -0000)]
conditionally use modern UI for NSIS installer
svn path=/trunk/; revision=9448
Ulf Lamping [Fri, 26 Dec 2003 11:37:58 +0000 (11:37 -0000)]
conditionally use modern UI for NSIS installer
svn path=/trunk/; revision=9447
Ulf Lamping [Fri, 26 Dec 2003 11:36:43 +0000 (11:36 -0000)]
bugfix: uninstall also the help textfiles
svn path=/trunk/; revision=9446
Guy Harris [Wed, 24 Dec 2003 23:37:28 +0000 (23:37 -0000)]
In "alloc_field_info()", handle the case where the offset is past the
byte past the end of the tvbuff.
svn path=/trunk/; revision=9445
Guy Harris [Wed, 24 Dec 2003 23:28:17 +0000 (23:28 -0000)]
In "tvb_ensure_bytes_remaining()", throw ReportedBoundsError, not
BoundsError, if the offset is just past the end of the reported data
(because we're ensuring that there actually *is* a byte there, and,
even according to the reported length, it isn't).
svn path=/trunk/; revision=9444
Jörg Mayer [Wed, 24 Dec 2003 14:45:48 +0000 (14:45 -0000)]
Add -pedantic to --with-extra-gcc-checks
svn path=/trunk/; revision=9443
Jörg Mayer [Wed, 24 Dec 2003 14:06:36 +0000 (14:06 -0000)]
Add -pedantic to --with-extra-gcc-checks
svn path=/trunk/; revision=9442
Olivier Biot [Wed, 24 Dec 2003 12:46:57 +0000 (12:46 -0000)]
Fix highlighting of Image record (forgot one fixed header byte).
Add comments on computation of fixed header.
svn path=/trunk/; revision=9441
Guy Harris [Wed, 24 Dec 2003 11:07:03 +0000 (11:07 -0000)]
Let FT_PROTOCOL fields, if the length specified is -1, have a length of
0 - now that "tvb_ensure_length_remaining()" ensures that there's at
least one byte of data, we should use "tvb_length_remaining()" for
FT_PROTOCOL fields.
svn path=/trunk/; revision=9440
Guy Harris [Wed, 24 Dec 2003 10:48:13 +0000 (10:48 -0000)]
Don't display TFTP data if there isn't any to display.
svn path=/trunk/; revision=9439